Amine Bouabdallaoui AmineB
0 Followers · 0 Following
Repositories
18
 Projects Packages Public Activity Starred Repositories
AmineB deleted branch delete_sources_safe from davidoskky/ReaderForSelfoss-multiplatform 2025-03-09 13:49:35 +00:00
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2025-03-09 13:49:34 +00:00
a1c0241a58 Show a confirmation dialog before deleting sources (#185)
AmineB merged pull request Louvorg/ReaderForSelfoss-multiplatform#185 2025-03-09 13:49:33 +00:00
Show a confirmation dialog before deleting sources
AmineB pushed to fix-invalid-url at Louvorg/ReaderForSelfoss-multiplatform 2025-03-09 13:48:49 +00:00
4a093fd969 chore: we don't need to check if the url is valid in upsert screen.
AmineB commented on issue Louvorg/ReaderForSelfoss-multiplatform#184 2025-03-09 13:43:40 +00:00
Can not add sources if url does not end with a slash

Thanks for the details. I fixed the issue.

AmineB created pull request Louvorg/ReaderForSelfoss-multiplatform#186 2025-03-09 13:43:14 +00:00
fix: Url validation was not failing login. Added tests.
AmineB created branch fix-invalid-url in Louvorg/ReaderForSelfoss-multiplatform 2025-03-09 13:42:42 +00:00
AmineB pushed to fix-invalid-url at Louvorg/ReaderForSelfoss-multiplatform 2025-03-09 13:42:42 +00:00
03ea12000c fix: Url validation was not failing login. Added tests.
AmineB deleted branch fix-invalid-url from davidoskky/ReaderForSelfoss-multiplatform 2025-03-09 13:42:29 +00:00
AmineB created branch fix-invalid-url in davidoskky/ReaderForSelfoss-multiplatform 2025-03-09 13:42:14 +00:00
AmineB pushed to fix-invalid-url at davidoskky/ReaderForSelfoss-multiplatform 2025-03-09 13:42:14 +00:00
03ea12000c fix: Url validation was not failing login. Added tests.
AmineB pushed to delete_sources_safe at davidoskky/ReaderForSelfoss-multiplatform 2025-03-09 12:57:06 +00:00
cdf4ece99c chore: translations.
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#185 2025-03-09 12:55:56 +00:00
Show a confirmation dialog before deleting sources

Hi, thanks for the lint fixes. I fixed the translation issues.

AmineB closed issue Louvorg/ReaderForSelfoss-multiplatform#184 2025-03-06 21:08:09 +00:00
Can not add sources if url does not end with a slash
AmineB commented on issue Louvorg/ReaderForSelfoss-multiplatform#184 2025-03-06 21:08:08 +00:00
Can not add sources if url does not end with a slash

I'll close for now. Please reopen if you have more details.

AmineB commented on issue Louvorg/ReaderForSelfoss-multiplatform#184 2025-03-06 21:07:34 +00:00
Can not add sources if url does not end with a slash

The isBaseUrlInvalid is called on the login screen, so the result should be the same on the sources screen too.

This isn't an issue with the url.

AmineB commented on issue Louvorg/ReaderForSelfoss-multiplatform#184 2025-03-03 21:20:23 +00:00
Can not add sources if url does not end with a slash

this.toHttpUrlOrNull() returns the url with a slash.

Can you provide a screengrab of the error, please?

AmineB commented on issue Louvorg/ReaderForSelfoss-multiplatform#184 2025-03-02 12:26:25 +00:00
Can not add sources if url does not end with a slash

I couldn't reproduce. Are you sure the issue isn't with the selfoss api ?

AmineB pushed to release at Louvorg/ReaderForSelfoss-multiplatform 2025-02-27 21:00:40 +00:00
a90ccec707 fix: url can be empty ?
2564b19726 Changelog for v125020471
Compare 2 commits »
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2025-02-27 20:41:32 +00:00
a90ccec707 fix: url can be empty ?