Amine Bouabdallaoui AmineB
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-18 19:59:14 +00:00
network

repository.offlineOverride should only refreshed on app reload or swipe to refresh.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-18 19:59:14 +00:00
network

There should be a message emited on network available too.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-18 19:59:14 +00:00
network

This should be reverted to the old network status check, because the network availability watcher should be stopped when the app is in the background.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-18 19:59:14 +00:00
network

This should only be done if the network is available as it was before.

AmineB suggested changes for Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-18 19:59:14 +00:00
network
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-18 17:06:18 +00:00
network

That´s why, in the background service, I asked to keep the network check as it was.

The background service should check, when executed, the network status.

Having things like so, let you…

AmineB opened issue Louvorg/ReaderForSelfoss-multiplatform#31 2022-08-17 21:25:06 +00:00
Mercury API not up ?
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-17 21:24:34 +00:00
network

This is mercury. It parses the page and fetch it´s content.

I'll look into why it does not work.

AmineB pushed to chore/sonarqube-fixes at Louvorg/ReaderForSelfoss-multiplatform 2022-08-17 20:53:10 +00:00
b33e811066 Push everywhere ?
AmineB pushed to chore/sonarqube-fixes at Louvorg/ReaderForSelfoss-multiplatform 2022-08-17 20:27:58 +00:00
e39bc896d2 Added build cache.
AmineB merged pull request Louvorg/ReaderForSelfoss-multiplatform#30 2022-08-17 19:10:48 +00:00
Fixing some sonarqube issues.
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-08-17 19:10:48 +00:00
1392e2a571 Merge pull request 'Fixing some sonarqube issues.' (#30) from chore/sonarqube-fixes into master
e9cb3d2f37 Fixing some sonarqube issues.
Compare 2 commits »
AmineB created pull request Louvorg/ReaderForSelfoss-multiplatform#30 2022-08-17 19:10:36 +00:00
Fixing some sonarqube issues.
AmineB created branch chore/sonarqube-fixes in Louvorg/ReaderForSelfoss-multiplatform 2022-08-17 19:01:00 +00:00
AmineB pushed to chore/sonarqube-fixes at Louvorg/ReaderForSelfoss-multiplatform 2022-08-17 19:01:00 +00:00
e9cb3d2f37 Fixing some sonarqube issues.
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-17 18:35:26 +00:00
network

The else block would have the BD fetching that'll assign the DB items to fetchedItems.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-17 18:34:19 +00:00
network

I think that this should be the only place where the connectivity check should stay like this.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-17 18:34:19 +00:00
network

Same here.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-17 18:34:19 +00:00
network

Same here. We are fetching data from an api, and we there is no need to do try anything if there is no network available.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-17 18:34:19 +00:00
network

It's weird to have this here. offlineOverride shouldn't be overridden from inside the repository.