From 7211fdb1a3a272410b10b01079d4b27488bb17f9 Mon Sep 17 00:00:00 2001 From: davidoskky Date: Thu, 29 Sep 2022 18:58:00 +0200 Subject: [PATCH] Fix update remote tests --- .../repository/RepositoryImpl.kt | 2 +- .../repository/RepositoryTest.kt | 18 ++++++++++++++++-- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt index fdba511..26f4ebb 100644 --- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt +++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt @@ -352,7 +352,7 @@ class Repository(private val api: SelfossApi, private val appSettingsService: Ap suspend fun updateRemote(): Boolean { return if (isNetworkAvailable()) { - api.update().equals("finished") + api.update().data.equals("finished") } else { false } diff --git a/shared/src/commonTest/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryTest.kt b/shared/src/commonTest/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryTest.kt index 46fbc06..3a9a27e 100644 --- a/shared/src/commonTest/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryTest.kt +++ b/shared/src/commonTest/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryTest.kt @@ -718,12 +718,26 @@ class RepositoryTest() { } coVerify(exactly = 1) { api.update() } - assertSame(true, response) + assertTrue(response) } @Test fun `update remote but response fails`() { - coEvery { api.update()} returns SelfossModel.StatusAndData(success = false, data = "undocumented...") + coEvery { api.update()} returns SelfossModel.StatusAndData(success = false, data = "unallowed access") + + val repository = Repository(api, appSettingsService, connectivityStatus, db) + var response = false + runBlocking { + response = repository.updateRemote() + } + + coVerify(exactly = 1) { api.update() } + assertSame(false, response) + } + + @Test + fun `update remote with unallowed access`() { + coEvery { api.update()} returns SelfossModel.StatusAndData(success = true, data = "unallowed access") val repository = Repository(api, appSettingsService, connectivityStatus, db) var response = false