fix: images could be null.

fix: Check if color is not empty before parsing it.
chore: Removed unused log.
2023-05-27 21:06:56 +02:00 · 2023-05-27 21:02:25 +02:00 · 2023-05-27 21:01:54 +02:00
3 changed files with 18 additions and 17 deletions
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/ReaderActivity.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/ReaderActivity.kt
@ -74,7 +74,6 @@ class ReaderActivity : AppCompatActivity(), DIAware {
        try {
            readItem(allItems[currentItem])
        } catch (e: IndexOutOfBoundsException) {
-            e.sendSilentlyWithAcraWithName("out of bound > size = ${allItems.size} currentItem = $currentItem")
            finish()
        }

--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/ArticleFragment.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/ArticleFragment.kt
@ -553,8 +553,8 @@ class ArticleFragment : Fragment(), DIAware {
    }

    fun performClick(): Boolean {
-        if (binding.webcontent.hitTestResult.type == WebView.HitTestResult.IMAGE_TYPE ||
-            binding.webcontent.hitTestResult.type == WebView.HitTestResult.SRC_IMAGE_ANCHOR_TYPE
+        if (allImages != null && (binding.webcontent.hitTestResult.type == WebView.HitTestResult.IMAGE_TYPE ||
+            binding.webcontent.hitTestResult.type == WebView.HitTestResult.SRC_IMAGE_ANCHOR_TYPE)
        ) {

            val position: Int = allImages.indexOf(binding.webcontent.hitTestResult.extra)
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/FilterSheetFragment.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/FilterSheetFragment.kt
@ -149,6 +149,7 @@ class FilterSheetFragment : BottomSheetDialogFragment(), DIAware {
            c.ellipsize = TextUtils.TruncateAt.END
            c.text = tag.tag

+            if (tag.color.isNotEmpty()) {
                try {
                    val gd = GradientDrawable()
                    val gdColor = try {
@ -165,6 +166,7 @@ class FilterSheetFragment : BottomSheetDialogFragment(), DIAware {
                } catch (e: Exception) {
                    e.sendSilentlyWithAcraWithName("tags > GradientDrawable")
                }
+            }

            c.setOnCloseIconClickListener {
                (it as Chip).isCloseIconVisible = false
Author	SHA1	Message	Date
aminecmi	7f96798f13	fix: images could be null. All checks were successful continuous-integration/drone/push Build is passing Details continuous-integration/drone Build is passing Details	2023-05-27 21:06:56 +02:00
aminecmi	6e5704a45b	fix: Check if color is not empty before parsing it.	2023-05-27 21:02:25 +02:00
aminecmi	495591159f	chore: Removed unused log.	2023-05-27 21:01:54 +02:00