ci: Instrumentation tests coverage in ci.

.gitea/workflows/common_coverage.yml

@@ -45,7 +45,7 @@ jobs:
       - name: Change url until I find a better way to do it
         if: steps.check-android-changes.outputs.any_modified == 'true'
         run: |
-          sed -i "s/val defaultUrl = \"http:\/\/10\.0\.2\.2\:8888\"/val defaultUrl = \"http:\/\/172\.17\.0\.1\:8888\"/g" ./androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/CommonTests.kt
+          sed -i "s/const DEFAULT_URL = \"http:\/\/10\.0\.2\.2\:8888\"/const DEFAULT_URL = \"http:\/\/172\.17\.0\.1\:8888\"/g" ./androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/CommonTests.kt
       - name: Tests
         if: steps.check-android-changes.outputs.any_modified == 'true'
         uses: reactivecircus/android-emulator-runner@v2

androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/CommonTests.kt

@@ -35,13 +35,13 @@ import java.io.IOException
 import java.util.Locale
 
 // For now, do not move this as it is modified by the integration tests
-val defaultUrl = "http://10.0.2.2:8888"
+const val DEFAULT_URL = "http://10.0.2.2:8888"
 
 fun performLogin(someUrl: String? = null) {
-    Log.i("AUTOMATION", "The url used will be ${if (!someUrl.isNullOrEmpty()) someUrl else defaultUrl}")
+    Log.i("AUTOMATION", "The url used will be ${if (!someUrl.isNullOrEmpty()) someUrl else DEFAULT_URL}")
     onView(withId(R.id.urlView)).perform(click()).perform(
         typeTextIntoFocusedView(
-            if (!someUrl.isNullOrEmpty()) someUrl else defaultUrl,
+            if (!someUrl.isNullOrEmpty()) someUrl else DEFAULT_URL,
         ),
     )
     onView(withId(R.id.signInButton)).perform(click())
@@ -160,7 +160,7 @@ open class WithANRException {
                     "default root matcher, it may be picking a root that never takes focus. " +
                     "Root:",
             )
-        private val otherException = "System Ul isn't responding"
+        private const val OTHER_EXCEPTION = "System Ul isn't responding"
 
         private fun handleAnrDialogue() {
             val device = UiDevice.getInstance(getInstrumentation())
@@ -175,7 +175,7 @@ open class WithANRException {
             Espresso.setFailureHandler { error, viewMatcher ->
 
                 takeScreenshot()
-                if (error.message!!.contains(otherException)) {
+                if (error.message!!.contains(OTHER_EXCEPTION)) {
                     handleAnrDialogue()
                 } else if (error.message!!.contains(rootViewWithoutFocusExceptionMsg) &&
                     anrCount < 20
@@ -192,6 +192,7 @@ open class WithANRException {
     }
 }
 
+@Suppress("detekt:NestedBlockDepth")
 fun takeScreenshot() {
     try {
         val bitmap = getInstrumentation().uiAutomation.takeScreenshot()

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/LoginActivity.kt

@@ -132,6 +132,7 @@ class LoginActivity :
         showProgress(false)
     }
 
+    @Suppress("detekt:LongMethod")
     private fun attemptLogin() {
         // Reset errors.
         binding.urlView.error = null