ci: Instrumentation tests coverage in ci.

.gitea/workflows/on_called_build.yml

@@ -11,7 +11,7 @@ jobs:
           fetch-depth: 0
       - name: "Check android app changes"
         id: check-android-changes
-        uses: tj-actions/changed-files@v46
+        uses: tj-actions/changed-files@v45
         with:
           files: |
             androidApp/src/**

.gitea/workflows/on_pr.yml

@@ -31,9 +31,8 @@ jobs:
           fetch-depth: 0
       - name: "Check translations changes"
         id: check-translations-changes
-        uses: tj-actions/changed-files@v46
+        uses: tj-actions/changed-files@v45
         with:
-          base_sha: ${{ github.event.pull_request.base.sha }}
           files: |
             androidApp/src/main/res/values/strings.xml
       - name: upload translation sources
@@ -87,4 +86,4 @@ jobs:
           branch: ${{ github.head_ref || github.ref_name }}
   build:
     needs: Lint
-    uses: ./.gitea/workflows/on_called_build.yml
+    uses: ./.gitea/workflows/common_build.yml

.gitea/workflows/on_ready_to_test.yml

@@ -1,37 +1,55 @@
-name: PR test
 on:
-  pull_request:
+  workflow_run:
-    branches:
+    workflows: [ Master, PR ]
-      - master
+    types: [ completed ]
 
 jobs:
   integrationTests:
     runs-on: ubuntu-latest
+    if: ${{ github.event.workflow_run.conclusion == 'success' }}
     steps:
       - name: Check out repository code
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - name: Fetch tags
+      - name: "Check android app changes"
-        run: git fetch --tags -p
+        id: check-android-changes
-      - uses: KengoTODA/actions-setup-docker-compose@v1
+        uses: tj-actions/changed-files@v45
         with:
-          version: "2.23.3"
+          files: |
-      - name: run selfoss
+            androidApp/src/**
-        run: |
+            shared/src/commonMain/**
-          docker compose -f .gitea/workflows/assets/docker-compose.yml up -d
+            shared/src/androidMain/**
+            shared/src/commonTest/**
+      - name: Fetch tags
+        if: steps.check-android-changes.outputs.any_modified == 'true'
+        run: git fetch --tags -p
       - uses: actions/setup-java@v4
+        if: steps.check-android-changes.outputs.any_modified == 'true'
         with:
           distribution: 'temurin'
           java-version: '17'
       - uses: gradle/actions/setup-gradle@v3
+        if: steps.check-android-changes.outputs.any_modified == 'true'
       - uses: android-actions/setup-android@v3
+        if: steps.check-android-changes.outputs.any_modified == 'true'
       - name: Configure gradle...
+        if: steps.check-android-changes.outputs.any_modified == 'true'
         run: mkdir -p ~/.gradle && echo "org.gradle.daemon=false\nignoreGitVersion=true" >> ~/.gradle/gradle.properties
       - name: Change url until I find a better way to do it
+        if: steps.check-android-changes.outputs.any_modified == 'true'
         run: |
-          sed -i "s/const val DEFAULT_URL = \"http:\/\/10\.0\.2\.2\:8888\"/const val DEFAULT_URL = \"http:\/\/172\.17\.0\.1\:8888\"/g" ./androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/CommonTests.kt
+          sed -i "s/const DEFAULT_URL = \"http:\/\/10\.0\.2\.2\:8888\"/const DEFAULT_URL = \"http:\/\/172\.17\.0\.1\:8888\"/g" ./androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/CommonTests.kt
+      - uses: KengoTODA/actions-setup-docker-compose@v1
+        if: steps.check-android-changes.outputs.any_modified == 'true'
+        with:
+          version: "2.23.3"
+      - name: run selfoss
+        if: steps.check-android-changes.outputs.any_modified == 'true'
+        run: |
+          docker compose -f .gitea/workflows/assets/docker-compose.yml up -d
       - name: Tests
+        if: steps.check-android-changes.outputs.any_modified == 'true'
         uses: reactivecircus/android-emulator-runner@v2
         with:
           api-level: 29
@@ -42,6 +60,7 @@ jobs:
             adb logcat -G 16M
             ./gradlew JacocoDebugCodeCoverage || (./gradlew androidApp:fetchScreenshots && adb logcat 'InputReader:S' 'chatty:S' 'audio_hw_generic:S' 'LogApiCalls:D' '*:I' -d > ./androidApp/build/reports/androidTests/connected/screenshots/logs.txt)
       - uses: actions/upload-artifact@v3
+        if: steps.check-android-changes.outputs.any_modified == 'true'
         with:
           name: screenshot-espresso
           path: androidApp/build/reports/androidTests/connected/screenshots
@@ -49,12 +68,14 @@ jobs:
           overwrite: true
           include-hidden-files: true
       - uses: actions/upload-artifact@v3
+        if: steps.check-android-changes.outputs.any_modified == 'true'
         with:
           path: androidApp/build/reports/androidTests/connected/debug/flavors/githubConfig
           retention-days: 1
           overwrite: true
           include-hidden-files: true
       - uses: actions/upload-artifact@v3
+        if: steps.check-android-changes.outputs.any_modified == 'true'
         with:
           name: coverage-espresso
           path: androidApp/build/reports/jacoco/JacocoDebugCodeCoverage
@@ -62,6 +83,11 @@ jobs:
           overwrite: true
           include-hidden-files: true
       - name: Clean
-        if: always()
+        if: steps.check-android-changes.outputs.any_modified == 'true' || failure()
         run: |
           docker compose -f .gitea/workflows/assets/docker-compose.yml stop
+  nothingToDo:
+    runs-on: ubuntu-latest
+    if: ${{ github.event.workflow_run.conclusion == 'failure' }}
+    steps:
+      - run: echo 'The triggering workflow failed'

CHANGELOG.md

@@ -1,30 +1,3 @@
-**v125040991
-
-- fix: Connectivity toast message was causing issues.
-- Changelog for v125030901
-
---------------------------------------------------------------------
-
-**v125030901
-
-- Merge pull request 'fix-reload' (#195) from fix-reload into master
-- fix: Infinite scroll needs loading stats.
-- fix: do not reload items on resume.
-- Merge pull request 'tests' (#193) from tests into master
-- ci: Instrumentation tests coverage in ci.
-- ci: Instrumentation tests coverage in ci.
-- ci: Instrumentation tests coverage in ci.
-- chore: better handling of coroutine dispatchers.
-- ci: Instrumentation tests coverage in ci.
-- chore: comment robolectric tests for now.
-- fix: Fixed source deletion test.
-- Merge pull request 'Fix alignment changes resetting reader article position' (#190) from davidoskky/ReaderForSelfoss-multiplatform:alignment into master
-- Refactor star icon handling
-- Don't restart activity changing alignment
-- Changelog for v125030711
-
---------------------------------------------------------------------
-
 **v125030711
 
 - Merge pull request 'fix: initial status loading issues.' (#192) from connectivity into master

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/HomeActivity.kt

@@ -120,7 +120,6 @@ class HomeActivity :
         binding.swipeRefreshLayout.setOnRefreshListener {
             repository.offlineOverride = false
             lastFetchDone = false
-            items.clear()
             getElementsAccordingToTab()
             binding.swipeRefreshLayout.isRefreshing = false
         }
@@ -459,28 +458,23 @@ class HomeActivity :
         appendResults: Boolean,
         itemType: ItemType,
     ) {
-        @Suppress("detekt:ComplexCondition")
+        CountingIdlingResourceSingleton.increment()
-        if ((appendResults && items.size > 0) || (!appendResults && items.size == 0)) {
+        binding.swipeRefreshLayout.isRefreshing = true
-            CountingIdlingResourceSingleton.increment()
+        CoroutineScope(Dispatchers.IO).launch {
-            binding.swipeRefreshLayout.isRefreshing = true
+            repository.displayedItems = itemType
-            CoroutineScope(Dispatchers.IO).launch {
+            items =
-                repository.displayedItems = itemType
+                if (appendResults) {
-                items =
+                    repository.getOlderItems()
-                    if (appendResults) {
+                } else {
-                        repository.getOlderItems()
+                    repository.getNewerItems()
-                    } else {
-                        repository.getNewerItems()
-                    }
-                CountingIdlingResourceSingleton.increment()
-                launch(Dispatchers.Main) {
-                    binding.swipeRefreshLayout.isRefreshing = false
-                    handleListResult()
-                    CountingIdlingResourceSingleton.decrement()
                 }
+            CountingIdlingResourceSingleton.increment()
+            launch(Dispatchers.Main) {
+                binding.swipeRefreshLayout.isRefreshing = false
+                handleListResult()
                 CountingIdlingResourceSingleton.decrement()
             }
-        } else {
+            CountingIdlingResourceSingleton.decrement()
-            handleListResult()
         }
     }
 
@@ -540,10 +534,7 @@ class HomeActivity :
     }
 
     private fun reloadBadges() {
-        if (appSettingsService.isInfiniteLoadingEnabled() ||
+        if (appSettingsService.isDisplayUnreadCountEnabled() || appSettingsService.isDisplayAllCountEnabled()) {
-            appSettingsService.isDisplayUnreadCountEnabled() ||
-            appSettingsService.isDisplayAllCountEnabled()
-        ) {
             CountingIdlingResourceSingleton.increment()
             CoroutineScope(Dispatchers.IO).launch {
                 repository.reloadBadges()

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/MyApp.kt

@@ -82,14 +82,13 @@ class MyApp :
                         } else {
                             R.string.network_connectivity_lost
                         }
-                    launch(Dispatchers.Main) {
+
-                        Toast
+                    Toast
-                            .makeText(
+                        .makeText(
-                                applicationContext,
+                            applicationContext,
-                                toastMessage,
+                            toastMessage,
-                                Toast.LENGTH_SHORT,
+                            Toast.LENGTH_SHORT,
-                            ).show()
+                        ).show()
-                    }
                 }
             }
         }

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemCardAdapter.kt

@@ -30,7 +30,7 @@ import org.kodein.di.instance
 
 class ItemCardAdapter(
     override val app: Activity,
-    override var items: ArrayList<SelfossModel.Item>,
+    override val items: ArrayList<SelfossModel.Item>,
     override val updateHomeItems: (ArrayList<SelfossModel.Item>) -> Unit,
 ) : ItemsAdapter<ItemCardAdapter.ViewHolder>() {
     override lateinit var binding: CardItemBinding

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemListAdapter.kt

@@ -21,7 +21,7 @@ import org.kodein.di.instance
 
 class ItemListAdapter(
     override val app: Activity,
-    override var items: ArrayList<SelfossModel.Item>,
+    override val items: ArrayList<SelfossModel.Item>,
     override val updateHomeItems: (ArrayList<SelfossModel.Item>) -> Unit,
 ) : ItemsAdapter<ItemListAdapter.ViewHolder>() {
     override lateinit var binding: ListItemBinding

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemsAdapter.kt

@@ -21,7 +21,7 @@ import org.kodein.di.DIAware
 abstract class ItemsAdapter<VH : RecyclerView.ViewHolder?> :
     RecyclerView.Adapter<VH>(),
     DIAware {
-    abstract var items: ArrayList<SelfossModel.Item>
+    abstract val items: ArrayList<SelfossModel.Item>
     abstract val repository: Repository
     abstract val binding: ViewBinding
     abstract val appSettingsService: AppSettingsService
@@ -31,7 +31,8 @@ abstract class ItemsAdapter<VH : RecyclerView.ViewHolder?> :
     protected val c: Context get() = app.baseContext
 
     fun updateAllItems(items: ArrayList<SelfossModel.Item>) {
-        this.items = items
+        this.items.clear()
+        this.items.addAll(items)
         updateHomeItems(items)
         notifyDataSetChanged()
     }

fastlane/metadata/android/en-US/changelogs/v125030901.txt

@@ -1,17 +0,0 @@
-**v125030901**
-
-- Merge pull request 'fix-reload' (#195) from fix-reload into master
-- fix: Infinite scroll needs loading stats.
-- fix: do not reload items on resume.
-- Merge pull request 'tests' (#193) from tests into master
-- ci: Instrumentation tests coverage in ci.
-- ci: Instrumentation tests coverage in ci.
-- ci: Instrumentation tests coverage in ci.
-- chore: better handling of coroutine dispatchers.
-- ci: Instrumentation tests coverage in ci.
-- chore: comment robolectric tests for now.
-- fix: Fixed source deletion test.
-- Merge pull request 'Fix alignment changes resetting reader article position' (#190) from davidoskky/ReaderForSelfoss-multiplatform:alignment into master
-- Refactor star icon handling
-- Don't restart activity changing alignment
-- Changelog for v125030711

fastlane/metadata/android/en-US/changelogs/v125040991.txt

@@ -1,4 +0,0 @@
-**v125040991**
-
-- fix: Connectivity toast message was causing issues.
-- Changelog for v125030901