chore: we don't need to check if the url is valid in upsert screen.

androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/LoginActivityTest.kt

@@ -60,9 +60,23 @@ class LoginActivityTest {
     fun urlError() {
         performLogin("10.0.2.2:8888")
         onView(withId(R.id.urlView)).perform(click())
+        onView(withId(R.id.urlView)).check(matches(withError(R.string.login_url_problem)))
+    }
+
+    @Test
+    fun connectError() {
+        performLogin("http://10.0.2.2:8889")
+        onView(withId(R.id.urlView)).perform(click())
         onView(withId(R.id.urlView)).check(matches(withError(R.string.wrong_infos)))
     }
 
+    @Test
+    fun urlSlashError() {
+        performLogin("https://google.fr/toto")
+        onView(withId(R.id.urlView)).perform(click())
+        onView(withId(R.id.urlView)).check(matches(withError(R.string.login_url_problem)))
+    }
+
     @Test
     fun multiError() {
         onView(withId(R.id.signInButton)).perform(click())

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/LoginActivity.kt

@@ -149,9 +149,10 @@ class LoginActivity :
                 .toString()
                 .trim()
 
-        failInvalidUrl(url)
+        val cancelUrl = failInvalidUrl(url)
-        failLoginDetails(password, login)
+        if (cancelUrl) return
-
+        val cancelDetails = failLoginDetails(password, login)
+        if (cancelDetails) return
         showProgress(true)
 
         appSettingsService.updateSelfSigned(binding.selfSigned.isChecked)
@@ -193,7 +194,7 @@ class LoginActivity :
     private fun failLoginDetails(
         password: String,
         login: String,
-    ) {
+    ): Boolean {
         var lastFocusedView: View? = null
         var cancel = false
         if (isWithLogin) {
@@ -210,9 +211,10 @@ class LoginActivity :
             }
         }
         maybeCancelAndFocusView(cancel, lastFocusedView)
+        return cancel
     }
 
-    private fun failInvalidUrl(url: String) {
+    private fun failInvalidUrl(url: String): Boolean {
         val focusView = binding.urlView
         var cancel = false
         if (url.isBaseUrlInvalid()) {
@@ -232,6 +234,7 @@ class LoginActivity :
             }
         }
         maybeCancelAndFocusView(cancel, focusView)
+        return cancel
     }
 
     private fun maybeCancelAndFocusView(

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/UpsertSourceActivity.kt

@@ -9,7 +9,6 @@ import android.widget.TextView
 import android.widget.Toast
 import androidx.appcompat.app.AppCompatActivity
 import bou.amine.apps.readerforselfossv2.android.databinding.ActivityUpsertSourceBinding
-import bou.amine.apps.readerforselfossv2.android.utils.isBaseUrlInvalid
 import bou.amine.apps.readerforselfossv2.model.NetworkUnavailableException
 import bou.amine.apps.readerforselfossv2.model.SelfossModel
 import bou.amine.apps.readerforselfossv2.repository.Repository
@@ -76,13 +75,7 @@ class UpsertSourceActivity :
 
     override fun onResume() {
         super.onResume()
-
+        handleSpoutsSpinner()
-        val baseUrl = appSettingsService.getBaseUrl()
-        if (baseUrl.isEmpty() || baseUrl.isBaseUrlInvalid()) {
-            mustLoginToAddSource()
-        } else {
-            handleSpoutsSpinner()
-        }
     }
 
     @Suppress("detekt:SwallowedException")