.editorconfig

@@ -1,36 +0,0 @@
-root = true
-
-[*]
-insert_final_newline = true
-
-[.editorconfig]
-insert_final_newline = false
-ij_kotlin_line_break_after_multiline_when_entry = false
-
-[*.{kt,kts}]
-#  Disable wildcard imports entirely
-ij_kotlin_name_count_to_use_star_import = 2147483647
-ij_kotlin_name_count_to_use_star_import_for_members = 2147483647
-end_of_line = lf
-ij_kotlin_allow_trailing_comma = true
-ij_kotlin_allow_trailing_comma_on_call_site = true
-ij_kotlin_imports_layout = *, java.**, javax.**, kotlin.**, ^
-ij_kotlin_indent_before_arrow_on_new_line = false
-ij_kotlin_line_break_after_multiline_when_entry = true
-ij_kotlin_packages_to_use_import_on_demand = unset
-indent_size = 4
-indent_style = space
-ktlint_argument_list_wrapping_ignore_when_parameter_count_greater_or_equal_than = unset
-ktlint_chain_method_rule_force_multiline_when_chain_operator_count_greater_or_equal_than = 4
-ktlint_class_signature_rule_force_multiline_when_parameter_count_greater_or_equal_than = 1
-ktlint_code_style = ktlint_official
-ktlint_enum_entry_name_casing = upper_or_camel_cases
-ktlint_function_naming_ignore_when_annotated_with = unset
-ktlint_function_signature_body_expression_wrapping = multiline
-ktlint_function_signature_rule_force_multiline_when_parameter_count_greater_or_equal_than = 2
-ktlint_ignore_back_ticked_identifier = false
-ktlint_property_naming_constant_naming = screaming_snake_case
-max_line_length = 140
-
-[**/build]
-ktlint = disabled

.gitea/workflows/on_pr.yml

@@ -16,13 +16,13 @@ jobs:
           java-version: '17'
           cache: gradle
       - name: Install klint
-        run: curl -sSLO https://github.com/pinterest/ktlint/releases/download/1.5.0/ktlint && chmod a+x ktlint && mv ktlint /usr/local/bin/
+        run: curl -sSLO https://github.com/pinterest/ktlint/releases/download/1.0.0/ktlint && chmod a+x ktlint && mv ktlint /usr/local/bin/
       - name: Install detekt
-        run: curl -sSLO https://github.com/detekt/detekt/releases/download/v1.23.7/detekt-cli-1.23.7.zip && unzip detekt-cli-1.23.7.zip
+        run: curl -sSLO https://github.com/detekt/detekt/releases/download/v1.23.1/detekt-cli-1.23.1.zip && unzip detekt-cli-1.23.1.zip
       - name: Linting...
-        run: ktlint 'shared/**/*.kt' 'androidApp/**/*.kt' '!shared/build'
+        run: ktlint 'shared/**/*.kt' 'androidApp/**/*.kt' '!shared/build' || true
       - name: Detecting...
-        run: ./detekt-cli-1.23.7/bin/detekt-cli -c detekt.yml --excludes '**/shared/build/**/*.kt'
+        run: ./detekt-cli-1.23.1/bin/detekt-cli --all-rules --excludes '**/shared/build/**/*.kt' || true
   build:
     needs: Lint
-    uses: ./.gitea/workflows/common_build.yml
+    uses: ./.gitea/workflows/common_build.yml

CHANGELOG.md

@@ -1,35 +1,3 @@
-**v125010131
-
-- fix: reload the adapter when it's needed. Fixes #128. (#176)
-- feat: basic auth and images loading. Fixes #172. (#175)
-- Changelog for v125010111
-
---------------------------------------------------------------------
-
-**v125010111
-
-- Debug trying to fix context issues. (#174)
-- Changelog for v125010031
-
---------------------------------------------------------------------
-
-**v125010031
-
-- Merge pull request 'Bump dependencies' (#173) from upgarde into master
-- chore: "faster" action.
-- fastlane: icon change.
-- chore: ignoring a pixel issue.
-- test: fixed an ui test issue.
-- fix: center the loading thing.
-- test: items displaying.
-- bump: sqldelight.
-- bump: material, desugar jdk, jsoup, kodein, settings, napier, mock.
-- bump: androix and coroutines.
-- bump: ktor. Closes #67.
-- Changelog for v124123651
-
---------------------------------------------------------------------
-
 **v124123651
 
 - Merge pull request 'Bugfixes' (#171) from bugfixes into master

androidApp/build.gradle.kts

@@ -156,7 +156,7 @@ dependencies {
     implementation("com.github.bumptech.glide:okhttp3-integration:4.16.0")
 
     // Themes
-    implementation("com.leinardi.android:speed-dial:3.3.0")
+    implementation("com.github.rubensousa:floatingtoolbar:1.5.1")
 
     // Pager
     implementation("me.relex:circleindicator:2.1.6")

androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/CommonTests.kt

@@ -20,72 +20,65 @@ import org.hamcrest.Matchers.hasToString
 fun performLogin(someUrl: String? = null) {
     onView(withId(R.id.urlView)).perform(click()).perform(
         typeTextIntoFocusedView(
-            if (!someUrl.isNullOrEmpty()) someUrl else "http://10.0.2.2:8888",
+            if (!someUrl.isNullOrEmpty()) someUrl else "http://10.0.2.2:8888"
-        ),
+        )
     )
     onView(withId(R.id.signInButton)).perform(click())
 }
 
 fun loginAndInitHome() {
+
     performLogin()
     onView(withText(R.string.gdpr_dialog_title)).check(matches(isDisplayed()))
     onView(withText("OK")).perform(click())
 }
 
-fun changeAndCancelSetting(
+fun changeAndCancelSetting(oldValue: String, newValue: String, openSettingItem: () -> Unit) {
-    oldValue: String,
-    newValue: String,
-    openSettingItem: () -> Unit,
-) {
     openSettingItem()
     onView(
-        withId(android.R.id.edit),
+        withId(android.R.id.edit)
     ).perform(replaceText(newValue))
     onView(
-        withId(android.R.id.button2),
+        withId(android.R.id.button2)
     ).perform(click())
     openSettingItem()
     onView(
-        withId(android.R.id.edit),
+        withId(android.R.id.edit)
     ).check(matches(withText(oldValue)))
     onView(
-        withText(newValue),
+        withText(newValue)
     ).check(doesNotExist())
     onView(
-        withId(android.R.id.button2),
+        withId(android.R.id.button2)
     ).perform(click())
 }
 
-fun changeAndSaveSetting(
+fun changeAndSaveSetting(oldValue: String, newValue: String, openSettingItem: () -> Unit) {
-    oldValue: String,
-    newValue: String,
-    openSettingItem: () -> Unit,
-) {
     openSettingItem()
     onView(
-        withId(android.R.id.edit),
+        withId(android.R.id.edit)
     ).perform(replaceText(newValue))
     onView(
-        withId(android.R.id.button1),
+        withId(android.R.id.button1)
     ).perform(click())
     openSettingItem()
     onView(
-        withId(android.R.id.edit),
+        withId(android.R.id.edit)
     ).check(matches(withText(newValue)))
     if (oldValue.isNotEmpty()) {
         onView(
-            withText(oldValue),
+            withText(oldValue)
         ).check(doesNotExist())
     }
     onView(
-        withId(android.R.id.button2),
+        withId(android.R.id.button2)
     ).perform(click())
 }
 
 fun testPreferencesFromArray(
     context: Context,
     @ArrayRes arrayRes: Int,
-    openSettingItem: () -> Unit,
+    openSettingItem: () -> Unit
 ) {
     openSettingItem()
     context.resources.getStringArray(arrayRes).forEach { res ->
@@ -97,25 +90,20 @@ fun testPreferencesFromArray(
     }
 }
 
-fun testAddSourceWithUrl(
+fun testAddSourceWithUrl(url: String, sourceName: String) {
-    url: String,
-    sourceName: String,
-) {
     onView(withId(R.id.fab))
         .perform(click())
     onView(withId(R.id.nameInput))
-        .perform(click())
+        .perform(click()).perform(typeTextIntoFocusedView(sourceName))
-        .perform(typeTextIntoFocusedView(sourceName))
     onView(withId(R.id.sourceUri))
         .perform(click())
         .perform(typeTextIntoFocusedView(url))
     onView(withId(R.id.tags))
-        .perform(click())
+        .perform(click()).perform(typeTextIntoFocusedView("tag1,tag2,tag3"))
-        .perform(typeTextIntoFocusedView("tag1,tag2,tag3"))
     onView(withId(R.id.spoutsSpinner))
         .perform(click())
     onData(hasToString("RSS Feed")).perform(click())
     onView(withId(R.id.saveBtn))
         .perform(click())
     onView(withText(sourceName)).check(matches(isDisplayed()))
-}
+}

androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/HomeActivityTest.kt

@@ -23,6 +23,7 @@ import org.junit.runner.RunWith
 @RunWith(AndroidJUnit4::class)
 @LargeTest
 class HomeActivityTest {
+
     @get:Rule
     val activityRule = ActivityScenarioRule(LoginActivity::class.java)
 
@@ -35,13 +36,13 @@ class HomeActivityTest {
     fun testMenu() {
         onView(withId(R.id.action_search)).check(matches(isDisplayed())).check(
             matches(
-                isClickable(),
+                isClickable()
-            ),
+            )
         )
         onView(withId(R.id.action_filter)).check(matches(isDisplayed())).check(
             matches(
-                isClickable(),
+                isClickable()
-            ),
+            )
         )
         openMenu()
         onView(withText(R.string.readAll)).check(matches(isDisplayed()))
@@ -56,19 +57,19 @@ class HomeActivityTest {
     fun testMenuActions() {
         onView(withId(R.id.action_search)).perform(click())
         onView(
-            withId(R.id.search_src_text),
+            withId(R.id.search_src_text)
         ).check(matches(isFocused()))
         onView(isRoot()).perform(ViewActions.pressBack())
 
         onView(withId(R.id.action_filter)).perform(click())
         onView(
-            withText(R.string.filter_item_sources),
+            withText(R.string.filter_item_sources)
         ).check(matches(isDisplayed()))
         onView(
-            withText(R.string.filter_item_tags),
+            withText(R.string.filter_item_tags)
         ).check(matches(isDisplayed()))
         onView(
-            withId(R.id.floatingActionButton2),
+            withId(R.id.floatingActionButton2)
         ).check(matches(isDisplayed()))
         onView(isRoot()).perform(ViewActions.pressBack())
 
@@ -106,13 +107,14 @@ class HomeActivityTest {
     fun testEmptyView() {
         onView(withId(R.id.emptyText)).check(matches(isDisplayed()))
         onView(
-            hasBottombarItemText(R.string.tab_new),
+            hasBottombarItemText(R.string.tab_new)
         ).check(matches(isDisplayed())).check(matches(isSelected()))
         onView(
-            hasBottombarItemText(R.string.tab_read),
+            hasBottombarItemText(R.string.tab_read)
         ).check(matches(isDisplayed())).check(matches(not(isSelected())))
         onView(
-            hasBottombarItemText(R.string.tab_favs),
+            hasBottombarItemText(R.string.tab_favs)
         ).check(matches(isDisplayed())).check(matches(not(isSelected())))
     }
-}
+
+}

androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/LoginActivityTest.kt

@@ -1,5 +1,6 @@
 package bou.amine.apps.readerforselfossv2.android
 
+import android.app.Activity
 import androidx.test.espresso.Espresso.onView
 import androidx.test.espresso.IdlingRegistry
 import androidx.test.espresso.action.ViewActions.click
@@ -22,37 +23,40 @@ import org.junit.runner.RunWith
 @RunWith(AndroidJUnit4::class)
 @LargeTest
 class LoginActivityTest {
+
     @get:Rule
     val activityRule = ActivityScenarioRule(LoginActivity::class.java)
 
+    private fun getActivity(): Activity? {
+        var activity: Activity? = null
+        activityRule.scenario.onActivity {
+            activity = it
+        }
+        return activity
+    }
+
     @Before
     fun registerIdlingResource() {
-        IdlingRegistry
+        IdlingRegistry.getInstance()
-            .getInstance()
             .register(CountingIdlingResourceSingleton.countingIdlingResource)
     }
 
     @After
     fun unregisterIdlingResource() {
-        IdlingRegistry
+        IdlingRegistry.getInstance()
-            .getInstance()
             .unregister(CountingIdlingResourceSingleton.countingIdlingResource)
     }
 
     @Test
     fun viewIsInitialized() {
         onView(withId(R.id.urlView)).check(matches(isDisplayed()))
-        onView(withId(R.id.selfSigned))
+        onView(withId(R.id.selfSigned)).check(matches(isDisplayed())).check(matches(isNotChecked()))
-            .check(matches(isDisplayed()))
-            .check(matches(isNotChecked()))
             .check(
-                matches(isClickable()),
+                matches(isClickable())
             )
-        onView(withId(R.id.withLogin))
+        onView(withId(R.id.withLogin)).check(matches(isDisplayed()))
-            .check(matches(isDisplayed()))
+            .check(matches(isNotChecked())).check(
-            .check(matches(isNotChecked()))
+                matches(isClickable())
-            .check(
-                matches(isClickable()),
             )
     }
 
@@ -76,4 +80,4 @@ class LoginActivityTest {
         performLogin()
         onView(withText(R.string.gdpr_dialog_title)).check(matches(isDisplayed()))
     }
-}
+}

androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/SettingsActivityGeneralTest.kt

@@ -26,9 +26,11 @@ import org.junit.Rule
 import org.junit.Test
 import org.junit.runner.RunWith
 
+
 @RunWith(AndroidJUnit4::class)
 @LargeTest
 class SettingsActivityGeneralTest {
+
     @get:Rule
     val activityRule = ActivityScenarioRule(LoginActivity::class.java)
 
@@ -36,77 +38,81 @@ class SettingsActivityGeneralTest {
     fun init() {
         loginAndInitHome()
         openActionBarOverflowOrOptionsMenu(
-            ApplicationProvider.getApplicationContext(),
+            ApplicationProvider.getApplicationContext()
         )
         onView(withText(R.string.title_activity_settings)).perform(click())
         onView(withText(R.string.pref_header_general)).perform(click())
     }
 
-    @Suppress("detekt:LongMethod")
     @Test
     fun testGeneral() {
         onView(withText(R.string.pref_api_items_number_title)).check(matches(isDisplayed()))
         onView(
-            withSettingsCheckboxWidget(R.string.pref_general_infinite_loading_title),
+            withSettingsCheckboxWidget(R.string.pref_general_infinite_loading_title)
         ).check(
             matches(
                 allOf(
-                    isDisplayed(),
+                    isDisplayed(), not(isChecked())
-                    not(isChecked()),
+                )
-                ),
+            )
-            ),
         )
         onView(withText(R.string.pref_general_category_links)).check(matches(isDisplayed()))
         onView(withSettingsCheckboxWidget(R.string.pref_article_viewer_title)).check(
             matches(
                 allOf(
-                    isDisplayed(),
+                    isDisplayed(), isChecked()
-                    isChecked(),
+                )
-                ),
+            )
-            ),
+        )
+        onView(withSettingsCheckboxWidget(R.string.reader_static_bar_title)).check(
+            matches(
+                allOf(
+                    isDisplayed(), not(isChecked())
+                )
+            )
+        )
+        onView(withSettingsCheckboxFrame(R.string.reader_static_bar_title)).check(
+            matches(
+                isEnabled()
+            )
         )
         onView(withText(R.string.pref_general_category_displaying)).check(matches(isDisplayed()))
         onView(withSettingsCheckboxWidget(R.string.pref_switch_card_view_title)).check(
             matches(
                 allOf(
-                    isDisplayed(),
+                    isDisplayed(), not(isChecked())
-                    not(isChecked()),
+                )
-                ),
+            )
-            ),
         )
         onView(withSettingsCheckboxWidget(R.string.card_height_title)).check(
             matches(
                 allOf(
-                    isDisplayed(),
+                    isDisplayed(), not(isChecked())
-                    not(isChecked()),
+                )
-                ),
+            )
-            ),
         )
         onView(withSettingsCheckboxFrame(R.string.card_height_title)).check(
             matches(
-                not(isEnabled()),
+                not(isEnabled())
-            ),
+            )
         )
         onView(withSettingsCheckboxWidget(R.string.switch_unread_count_title)).check(
             matches(
                 allOf(
-                    isDisplayed(),
+                    isDisplayed(), isChecked()
-                    isChecked(),
+                )
-                ),
+            )
-            ),
         )
         onView(withId(R.id.settings)).perform(swipeUp())
         onView(withSettingsCheckboxWidget(R.string.display_all_counts_title)).check(
             matches(
                 allOf(
-                    isDisplayed(),
+                    isDisplayed(), not(isChecked())
-                    not(isChecked()),
+                )
-                ),
+            )
-            ),
         )
     }
 
-    @Suppress("detekt:ForbiddenComment")
     @Test
     fun testGeneralActionsNumberItems() {
         onView(withText(R.string.pref_api_items_number_title)).perform(click())
@@ -114,25 +120,25 @@ class SettingsActivityGeneralTest {
 
         // Value check
         onView(
-            withId(android.R.id.edit),
+            withId(android.R.id.edit)
         ).perform(replaceText("AVC"))
             .check(matches(withText("")))
         // TODO: should check message error. Not working for api level 30+
         onView(
-            withId(android.R.id.edit),
+            withId(android.R.id.edit)
         ).perform(replaceText("-1"))
             .check(matches(withText("")))
         // TODO: should check message error. Not working for api level 30+
         onView(
-            withId(android.R.id.edit),
+            withId(android.R.id.edit)
         ).perform(replaceText("300"))
             .check(matches(withText("")))
         onView(
-            withId(android.R.id.edit),
+            withId(android.R.id.edit)
         ).perform(typeTextIntoFocusedView("300"))
             .check(matches(withText("30")))
         onView(
-            withId(android.R.id.edit),
+            withId(android.R.id.edit)
         ).perform(replaceText("10"))
             .check(matches(withText("10")))
         onView(isRoot()).perform(ViewActions.pressBack())
@@ -148,8 +154,21 @@ class SettingsActivityGeneralTest {
 
     @Test
     fun testGeneralActionsCheckboxes() {
+        // article viewer settings
+        onView(withSettingsCheckboxFrame(R.string.reader_static_bar_title)).check(
+            matches(
+                isEnabled()
+            )
+        )
+        onView(withSettingsCheckboxWidget(R.string.pref_article_viewer_title)).perform(click())
+        onView(withSettingsCheckboxFrame(R.string.reader_static_bar_title)).check(
+            matches(
+                not(isEnabled())
+            )
+        )
+
         onView(withSettingsCheckboxFrame(R.string.card_height_title)).check(matches(not(isEnabled())))
         onView(withSettingsCheckboxWidget(R.string.pref_switch_card_view_title)).perform(click())
         onView(withSettingsCheckboxFrame(R.string.card_height_title)).check(matches(isEnabled()))
     }
-}
+}

androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/SettingsActivityOfflineTest.kt

@@ -21,9 +21,11 @@ import org.junit.Rule
 import org.junit.Test
 import org.junit.runner.RunWith
 
+
 @RunWith(AndroidJUnit4::class)
 @LargeTest
 class SettingsActivityOfflineTest {
+
     @get:Rule
     val activityRule = ActivityScenarioRule(LoginActivity::class.java)
 
@@ -36,79 +38,72 @@ class SettingsActivityOfflineTest {
         }
         loginAndInitHome()
         openActionBarOverflowOrOptionsMenu(
-            ApplicationProvider.getApplicationContext(),
+            ApplicationProvider.getApplicationContext()
         )
         onView(withText(R.string.title_activity_settings)).perform(click())
         onView(withText(R.string.pref_header_offline)).perform(click())
     }
 
-    @Suppress("detekt:LongMethod")
     @Test
     fun testOffline() {
         onView(withSettingsCheckboxWidget(R.string.pref_switch_periodic_refresh)).check(
             matches(
                 allOf(
-                    isDisplayed(),
+                    isDisplayed(), not(isChecked())
-                    not(isChecked()),
+                )
-                ),
+            )
-            ),
         )
         onView(withSettingsCheckboxWidget(R.string.pref_switch_items_caching)).check(
             matches(
                 allOf(
-                    isDisplayed(),
+                    isDisplayed(), not(isChecked())
-                    not(isChecked()),
+                )
-                ),
+            )
-            ),
         )
         onView(withSettingsCheckboxFrame(R.string.pref_switch_items_caching)).check(
             matches(
-                isEnabled(),
+                isEnabled()
-            ),
+            )
         )
         onView(withText(R.string.pref_periodic_refresh_minutes_title)).check(
             matches(
-                allOf(isNotEnabled(), isDisplayed()),
+                allOf(isNotEnabled(), isDisplayed())
-            ),
+            )
         )
 
         onView(withSettingsCheckboxWidget(R.string.pref_switch_refresh_when_charging)).check(
             matches(
                 allOf(
-                    isDisplayed(),
+                    isDisplayed(), not(isChecked())
-                    not(isChecked()),
+                )
-                ),
+            )
-            ),
         )
         onView(withSettingsCheckboxFrame(R.string.pref_switch_refresh_when_charging)).check(
             matches(
-                isNotEnabled(),
+                isNotEnabled()
-            ),
+            )
         )
         onView(withSettingsCheckboxWidget(R.string.pref_switch_notify_new_items)).check(
             matches(
                 allOf(
-                    isDisplayed(),
+                    isDisplayed(), not(isChecked())
-                    not(isChecked()),
+                )
-                ),
+            )
-            ),
         )
         onView(withSettingsCheckboxFrame(R.string.pref_switch_notify_new_items)).check(
             matches(
-                isNotEnabled(),
+                isNotEnabled()
-            ),
+            )
         )
         onView(withSettingsCheckboxWidget(R.string.pref_switch_update_sources)).check(
             matches(
                 allOf(
-                    isDisplayed(),
+                    isDisplayed(), isChecked()
-                    isChecked(),
+                )
-                ),
+            )
-            ),
         )
     }
 
-    @Suppress("detekt:LongMethod")
     @Test
     fun testOfflineActions() {
         onView(withText(R.string.pref_switch_items_caching_off)).check(matches(isDisplayed()))
@@ -116,50 +111,50 @@ class SettingsActivityOfflineTest {
         onView(withText(R.string.pref_switch_items_caching_on)).check(matches(isDisplayed()))
         onView(withSettingsCheckboxFrame(R.string.pref_switch_items_caching)).check(
             matches(
-                isEnabled(),
+                isEnabled()
-            ),
+            )
         )
         onView(withText(R.string.pref_periodic_refresh_minutes_title)).check(
             matches(
-                isNotEnabled(),
+                isNotEnabled()
-            ),
+            )
         )
         onView(withSettingsCheckboxFrame(R.string.pref_switch_refresh_when_charging)).check(
             matches(
-                isNotEnabled(),
+                isNotEnabled()
-            ),
+            )
         )
         onView(withSettingsCheckboxFrame(R.string.pref_switch_notify_new_items)).check(
             matches(
-                isNotEnabled(),
+                isNotEnabled()
-            ),
+            )
         )
 
         onView(withText(R.string.pref_switch_periodic_refresh_off)).check(
             matches(
-                isDisplayed(),
+                isDisplayed()
-            ),
+            )
         )
         onView(withSettingsCheckboxWidget(R.string.pref_switch_periodic_refresh)).perform(click())
         onView(withText(R.string.pref_switch_periodic_refresh_on)).check(
             matches(
-                isDisplayed(),
+                isDisplayed()
-            ),
+            )
         )
         onView(withSettingsCheckboxFrame(R.string.pref_periodic_refresh_minutes_title)).check(
             matches(
-                isEnabled(),
+                isEnabled()
-            ),
+            )
         )
         onView(withSettingsCheckboxFrame(R.string.pref_switch_refresh_when_charging)).check(
             matches(
-                isEnabled(),
+                isEnabled()
-            ),
+            )
         )
         onView(withSettingsCheckboxFrame(R.string.pref_switch_notify_new_items)).check(
             matches(
-                isEnabled(),
+                isEnabled()
-            ),
+            )
         )
         changeAndCancelSetting("360", "123") {
             onView(withText(R.string.pref_periodic_refresh_minutes_title)).perform(click())
@@ -171,4 +166,4 @@ class SettingsActivityOfflineTest {
         onView(withSettingsCheckboxFrame(R.string.pref_switch_notify_new_items)).perform(click())
         onView(withSettingsCheckboxWidget(R.string.pref_switch_update_sources)).perform(click())
     }
-}
+}

androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/SettingsActivityReaderTest.kt

@@ -19,9 +19,11 @@ import org.junit.Rule
 import org.junit.Test
 import org.junit.runner.RunWith
 
+
 @RunWith(AndroidJUnit4::class)
 @LargeTest
 class SettingsActivityReaderTest {
+
     @get:Rule
     val activityRule = ActivityScenarioRule(LoginActivity::class.java)
 
@@ -34,7 +36,7 @@ class SettingsActivityReaderTest {
         }
         loginAndInitHome()
         openActionBarOverflowOrOptionsMenu(
-            ApplicationProvider.getApplicationContext(),
+            ApplicationProvider.getApplicationContext()
         )
         onView(withText(R.string.title_activity_settings)).perform(click())
         onView(withText(R.string.pref_header_viewer)).perform(click())
@@ -45,12 +47,11 @@ class SettingsActivityReaderTest {
         onView(withSettingsCheckboxFrame(R.string.pref_switch_actions_pager_scroll)).check(
             matches(
                 allOf(
-                    isDisplayed(),
+                    isDisplayed(), not(
-                    not(
+                        isChecked()
-                        isChecked(),
+                    )
-                    ),
+                )
-                ),
+            )
-            ),
         )
         onView(withText(R.string.pref_content_reader_font_size)).check(matches(isDisplayed()))
         onView(withText(R.string.settings_reader_font)).check(matches(isDisplayed()))
@@ -60,14 +61,14 @@ class SettingsActivityReaderTest {
     fun testReaderActions() {
         onView(withText(R.string.pref_switch_actions_pager_scroll_off)).check(
             matches(
-                isDisplayed(),
+                isDisplayed()
-            ),
+            )
         )
         onView(withSettingsCheckboxFrame(R.string.pref_switch_actions_pager_scroll)).perform(click())
         onView(withText(R.string.pref_switch_actions_pager_scroll_on)).check(
             matches(
-                isDisplayed(),
+                isDisplayed()
-            ),
+            )
         )
 
         onView(withText(R.string.pref_content_reader_font_size)).perform(click())
@@ -82,4 +83,4 @@ class SettingsActivityReaderTest {
             onView(withText(R.string.settings_reader_font)).perform(click())
         }
     }
-}
+}

androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/SettingsActivityTest.kt

@@ -20,6 +20,7 @@ import org.junit.runner.RunWith
 @RunWith(AndroidJUnit4::class)
 @LargeTest
 class SettingsActivityTest {
+
     @get:Rule
     val activityRule = ActivityScenarioRule(LoginActivity::class.java)
     lateinit var context: Context
@@ -34,8 +35,10 @@ class SettingsActivityTest {
         onView(withText(R.string.title_activity_settings)).perform(click())
     }
 
+
     @Test
     fun testAllSettings() {
+
         onView(withText(R.string.pref_header_general)).check(matches(isDisplayed()))
         onView(withText(R.string.pref_header_viewer)).check(matches(isDisplayed()))
         onView(withText(R.string.pref_header_offline)).check(matches(isDisplayed()))
@@ -45,13 +48,14 @@ class SettingsActivityTest {
             matches(
                 allOf(
                     isDisplayed(),
-                    not(isSelected()),
+                    not(isSelected())
-                ),
+                )
-            ),
+            )
         )
         onView(withText(R.string.action_about)).check(matches(isDisplayed()))
     }
 
+
     @Test
     fun testThemes() {
         testPreferencesFromArray(context, R.array.ModeTitles) {
@@ -59,6 +63,7 @@ class SettingsActivityTest {
         }
     }
 
+
     @Test
     fun testExperimentail() {
         onView(withText(R.string.pref_header_experimental)).perform(click())
@@ -70,11 +75,13 @@ class SettingsActivityTest {
         }
     }
 
+
     @Test
     fun testBugReports() {
         onView(withText(R.string.pref_switch_disable_acra)).perform(click())
     }
 
+
     @Test
     fun testLinks() {
         onView(withText(R.string.pref_header_links)).perform(click())
@@ -84,9 +91,10 @@ class SettingsActivityTest {
         onView(withText(R.string.translation)).check(matches(isDisplayed()))
     }
 
+
     @Test
     fun testAbout() {
         onView(withText(R.string.action_about)).perform(click())
         onView(withText("ACRA")).check(matches(isDisplayed()))
     }
-}
+}

androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/SourcesActivityTest.kt

@@ -41,11 +41,11 @@ class SourcesActivityTest {
     fun addSource() {
         testAddSourceWithUrl(
             "https://lorem-rss.herokuapp.com/feed?unit=year&interval=1&length=10",
-            sourceName,
+            sourceName
         )
     }
 
-    @Suppress("detekt:SwallowedException")
+
     @Test
     fun addSourceCheckContent() {
         testAddSourceWithUrl("https://news.google.com/rss?hl=en-US&gl=US&ceid=US:en", sourceName)
@@ -54,7 +54,7 @@ class SourcesActivityTest {
         onView(withText(R.string.menu_home_refresh)).perform(click())
         onView(withText(R.string.refresh_dialog_message)).check(matches(isDisplayed()))
         onView(
-            withId(android.R.id.button1),
+            withId(android.R.id.button1)
         ).perform(click())
         Thread.sleep(10000)
         onView(withId(R.id.swipeRefreshLayout)).perform(swipeDown())
@@ -74,9 +74,10 @@ class SourcesActivityTest {
         onView(withText(sourceName)).check(doesNotExist())
     }
 
+
     private fun goToSources() {
         openMenu()
         onView(withText(R.string.menu_home_sources))
             .perform(click())
     }
-}
+}

androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/helpers.kt

@@ -25,35 +25,38 @@ import org.hamcrest.Matcher
 import org.hamcrest.Matchers
 import org.hamcrest.TypeSafeMatcher
 
-fun withError(
+
-    @StringRes id: Int,
+fun withError(@StringRes id: Int): TypeSafeMatcher<View?> {
-): TypeSafeMatcher<View?> {
     return object : TypeSafeMatcher<View?>() {
         override fun matchesSafely(view: View?): Boolean {
-            if (view != null && (view !is EditText || view.error == null)) {
+            if (view == null) {
+                return false
+            }
+            val context = view.context
+            if (view !is EditText) {
+                return false
+            }
+            if (view.error == null) {
                 return false
             }
-            val context = view!!.context
 
-            return (view as EditText).error.toString() == context.getString(id)
+            return view.error.toString() == context.getString(id)
         }
 
         override fun describeTo(description: Description?) {
-            // Nothing
         }
     }
 }
 
-fun isPopupWindow(): Matcher<Root> = isPlatformPopup()
+fun isPopupWindow(): Matcher<Root> {
+    return isPlatformPopup()
+}
 
-fun withDrawable(
+fun withDrawable(@DrawableRes id: Int) = object : TypeSafeMatcher<View>() {
-    @DrawableRes id: Int,
-) = object : TypeSafeMatcher<View>() {
     override fun describeTo(description: Description) {
         description.appendText("ImageView with drawable same as drawable with id $id")
     }
 
-    @Suppress("detekt:SwallowedException")
     override fun matchesSafely(view: View): Boolean {
         val context = view.context
         val expectedBitmap = context.getDrawable(id)!!.toBitmap()
@@ -65,46 +68,43 @@ fun withDrawable(
     }
 }
 
-fun hasBottombarItemText(
+fun hasBottombarItemText(@StringRes id: Int): Matcher<View>? {
-    @StringRes id: Int,
+    return allOf(
-): Matcher<View>? =
-    allOf(
         withResourceName("fixed_bottom_navigation_icon"),
         withParent(
             allOf(
                 withResourceName("fixed_bottom_navigation_icon_container"),
-                hasSibling(withText(id)),
+                hasSibling(withText(id))
-            ),
+            )
-        ),
+        )
     )
+}
 
-fun withSettingsCheckboxWidget(
+fun withSettingsCheckboxWidget(@StringRes id: Int): Matcher<View>? {
-    @StringRes id: Int,
+    return allOf(
-): Matcher<View>? =
-    allOf(
         withId(android.R.id.switch_widget),
         withParent(
-            withSettingsCheckboxFrame(id),
+            withSettingsCheckboxFrame(id)
-        ),
+        )
     )
+}
 
-fun withSettingsCheckboxFrame(
+fun withSettingsCheckboxFrame(@StringRes id: Int): Matcher<View>? {
-    @StringRes id: Int,
+    return allOf(
-): Matcher<View>? =
-    allOf(
         withId(android.R.id.widget_frame),
         hasSibling(
             allOf(
                 withClassName(Matchers.equalTo(RelativeLayout::class.java.name)),
                 withChild(
-                    withText(id),
+                    withText(id)
-                ),
+                )
-            ),
+            )
-        ),
+        )
     )
+}
 
 fun openMenu() {
     openActionBarOverflowOrOptionsMenu(
-        ApplicationProvider.getApplicationContext<Context>(),
+        ApplicationProvider.getApplicationContext<Context>()
     )
-}
+}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/HomeActivity.kt

@@ -49,12 +49,7 @@ import org.kodein.di.instance
 import java.security.MessageDigest
 import java.util.concurrent.TimeUnit
 
-private const val MIN_WIDTH_CARD_DP = 300
+class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener, DIAware {
-
-class HomeActivity :
-    AppCompatActivity(),
-    SearchView.OnQueryTextListener,
-    DIAware {
     private var items: ArrayList<SelfossModel.Item> = ArrayList()
 
     private var elementsShown: ItemType = ItemType.UNREAD
@@ -176,12 +171,11 @@ class HomeActivity :
                             getElementsAccordingToTab()
                         }
                     } else {
-                        Toast
+                        Toast.makeText(
-                            .makeText(
+                            this@HomeActivity,
-                                this@HomeActivity,
+                            "Found null when swiping at positon $position.",
-                                "Found null when swiping at positon $position.",
+                            Toast.LENGTH_LONG,
-                                Toast.LENGTH_LONG,
+                        ).show()
-                            ).show()
                     }
                 }
             }
@@ -202,23 +196,19 @@ class HomeActivity :
         }
     }
 
-    @Suppress("detekt:LongMethod")
     private fun handleBottomBar() {
         tabNewBadge =
             TextBadgeItem()
                 .setText("")
-                .setHideOnSelect(false)
+                .setHideOnSelect(false).hide(false)
-                .hide(false)
         tabArchiveBadge =
             TextBadgeItem()
                 .setText("")
-                .setHideOnSelect(false)
+                .setHideOnSelect(false).hide(false)
-                .hide(false)
         tabStarredBadge =
             TextBadgeItem()
                 .setText("")
-                .setHideOnSelect(false)
+                .setHideOnSelect(false).hide(false)
-                .hide(false)
 
         if (appSettingsService.isDisplayUnreadCountEnabled()) {
             lifecycleScope.launch {
@@ -246,12 +236,14 @@ class HomeActivity :
             BottomNavigationItem(
                 R.drawable.ic_tab_fiber_new_black_24dp,
                 getString(R.string.tab_new),
-            ).setBadgeItem(tabNewBadge)
+            )
+                .setBadgeItem(tabNewBadge)
         val tabArchive =
             BottomNavigationItem(
                 R.drawable.ic_tab_archive_black_24dp,
                 getString(R.string.tab_read),
-            ).setBadgeItem(tabArchiveBadge)
+            )
+                .setBadgeItem(tabArchiveBadge)
         val tabStarred =
             BottomNavigationItem(
                 R.drawable.ic_tab_favorite_black_24dp,
@@ -285,7 +277,7 @@ class HomeActivity :
 
         handleBottomBarActions()
 
-        handleGdprDialog(appSettingsService.settings.getBoolean("GDPR_shown", false))
+        handleGDPRDialog(appSettingsService.settings.getBoolean("GDPR_shown", false))
 
         handleRecurringTask()
         CountingIdlingResourceSingleton.increment()
@@ -297,10 +289,10 @@ class HomeActivity :
         getElementsAccordingToTab()
     }
 
-    private fun handleGdprDialog(gdprShown: Boolean) {
+    private fun handleGDPRDialog(GDPRShown: Boolean) {
         val messageDigest: MessageDigest = MessageDigest.getInstance("SHA-256")
         messageDigest.update(appSettingsService.getBaseUrl().toByteArray())
-        if (!gdprShown) {
+        if (!GDPRShown) {
             val alertDialog = AlertDialog.Builder(this).create()
             alertDialog.setTitle(getString(R.string.gdpr_dialog_title))
             alertDialog.setMessage(getString(R.string.gdpr_dialog_message))
@@ -317,44 +309,50 @@ class HomeActivity :
 
     private fun reloadLayoutManager() {
         val currentManager = binding.recyclerView.layoutManager
+        val layoutManager: RecyclerView.LayoutManager
 
-        fun gridLayoutManager() {
+        // This will only update the layout manager if settings changed
-            val layoutManager =
-                GridLayoutManager(
-                    this,
-                    calculateNoOfColumns(),
-                )
-            binding.recyclerView.layoutManager = layoutManager
-        }
-
-        fun staggererdGridLayoutManager() {
-            var layoutManager =
-                StaggeredGridLayoutManager(
-                    calculateNoOfColumns(),
-                    StaggeredGridLayoutManager.VERTICAL,
-                )
-            layoutManager.gapStrategy =
-                StaggeredGridLayoutManager.GAP_HANDLING_MOVE_ITEMS_BETWEEN_SPANS
-            binding.recyclerView.layoutManager = layoutManager
-        }
-
         when (currentManager) {
             is StaggeredGridLayoutManager ->
                 if (!appSettingsService.isCardViewEnabled()) {
-                    gridLayoutManager()
+                    layoutManager =
+                        GridLayoutManager(
+                            this,
+                            calculateNoOfColumns(),
+                        )
+                    binding.recyclerView.layoutManager = layoutManager
                 }
 
             is GridLayoutManager ->
                 if (appSettingsService.isCardViewEnabled()) {
-                    staggererdGridLayoutManager()
+                    layoutManager =
+                        StaggeredGridLayoutManager(
+                            calculateNoOfColumns(),
+                            StaggeredGridLayoutManager.VERTICAL,
+                        )
+                    layoutManager.gapStrategy =
+                        StaggeredGridLayoutManager.GAP_HANDLING_MOVE_ITEMS_BETWEEN_SPANS
+                    binding.recyclerView.layoutManager = layoutManager
                 }
 
             else ->
                 if (currentManager == null) {
                     if (!appSettingsService.isCardViewEnabled()) {
-                        gridLayoutManager()
+                        layoutManager =
+                            GridLayoutManager(
+                                this,
+                                calculateNoOfColumns(),
+                            )
+                        binding.recyclerView.layoutManager = layoutManager
                     } else {
-                        staggererdGridLayoutManager()
+                        layoutManager =
+                            StaggeredGridLayoutManager(
+                                calculateNoOfColumns(),
+                                StaggeredGridLayoutManager.VERTICAL,
+                            )
+                        layoutManager.gapStrategy =
+                            StaggeredGridLayoutManager.GAP_HANDLING_MOVE_ITEMS_BETWEEN_SPANS
+                        binding.recyclerView.layoutManager = layoutManager
                     }
                 }
         }
@@ -427,17 +425,17 @@ class HomeActivity :
         binding.recyclerView.addOnScrollListener(recyclerViewScrollListener)
     }
 
-    private fun getLastVisibleItem(): Int =
+    private fun getLastVisibleItem(): Int {
-        when (val manager = binding.recyclerView.layoutManager) {
+        return when (val manager = binding.recyclerView.layoutManager) {
             is StaggeredGridLayoutManager ->
-                manager
+                manager.findLastCompletelyVisibleItemPositions(
-                    .findLastCompletelyVisibleItemPositions(
+                    null,
-                        null,
+                ).last()
-                    ).last()
 
             is GridLayoutManager -> manager.findLastCompletelyVisibleItemPosition()
             else -> 0
         }
+    }
 
     private fun mayBeEmpty() =
         if (items.isEmpty()) {
@@ -479,8 +477,8 @@ class HomeActivity :
     }
 
     private fun handleListResult(appendResults: Boolean = false) {
-        val oldManager = binding.recyclerView.layoutManager
         if (appendResults) {
+            val oldManager = binding.recyclerView.layoutManager
             firstVisible =
                 when (oldManager) {
                     is StaggeredGridLayoutManager ->
@@ -493,13 +491,7 @@ class HomeActivity :
                 }
         }
 
-        @Suppress("detekt:ComplexCondition")
+        if (recyclerAdapter == null) {
-        if (recyclerAdapter == null ||
-            (
-                (recyclerAdapter is ItemListAdapter && appSettingsService.isCardViewEnabled()) ||
-                    (recyclerAdapter is ItemCardAdapter && !appSettingsService.isCardViewEnabled())
-            )
-        ) {
             if (appSettingsService.isCardViewEnabled()) {
                 recyclerAdapter =
                     ItemCardAdapter(
@@ -546,7 +538,7 @@ class HomeActivity :
     private fun calculateNoOfColumns(): Int {
         val displayMetrics = resources.displayMetrics
         val dpWidth = displayMetrics.widthPixels / displayMetrics.density
-        return (dpWidth / MIN_WIDTH_CARD_DP).toInt()
+        return (dpWidth / 300).toInt()
     }
 
     override fun onQueryTextChange(p0: String?): Boolean {
@@ -585,8 +577,7 @@ class HomeActivity :
         messageRes: Int,
         doFn: () -> Unit,
     ) {
-        AlertDialog
+        AlertDialog.Builder(this@HomeActivity)
-            .Builder(this@HomeActivity)
             .setMessage(messageRes)
             .setTitle(titleRes)
             .setPositiveButton(android.R.string.ok) { _, _ -> doFn() }
@@ -595,11 +586,10 @@ class HomeActivity :
             .show()
     }
 
-    @Suppress("detekt:ReturnCount", "detekt:LongMethod")
     override fun onOptionsItemSelected(item: MenuItem): Boolean {
         when (item.itemId) {
             R.id.issue_tracker -> {
-                baseContext.openUrlInBrowser(AppSettingsService.BUG_URL)
+                baseContext.openUrlInBrowser(AppSettingsService.trackerUrl)
                 return true
             }
 
@@ -616,19 +606,18 @@ class HomeActivity :
                     CoroutineScope(Dispatchers.Main).launch {
                         val updatedRemote = repository.updateRemote()
                         if (updatedRemote) {
-                            Toast
+                            Toast.makeText(
-                                .makeText(
+                                this@HomeActivity,
-                                    this@HomeActivity,
+                                R.string.refresh_success_response,
-                                    R.string.refresh_success_response,
+                                Toast.LENGTH_LONG,
-                                    Toast.LENGTH_LONG,
+                            )
-                                ).show()
+                                .show()
                         } else {
-                            Toast
+                            Toast.makeText(
-                                .makeText(
+                                this@HomeActivity,
-                                    this@HomeActivity,
+                                R.string.refresh_failer_message,
-                                    R.string.refresh_failer_message,
+                                Toast.LENGTH_SHORT,
-                                    Toast.LENGTH_SHORT,
+                            ).show()
-                                ).show()
                         }
                         CountingIdlingResourceSingleton.decrement()
                     }
@@ -644,26 +633,25 @@ class HomeActivity :
                         CoroutineScope(Dispatchers.Main).launch {
                             val success = repository.markAllAsRead(items)
                             if (success) {
-                                Toast
+                                Toast.makeText(
-                                    .makeText(
+                                    this@HomeActivity,
-                                        this@HomeActivity,
+                                    R.string.all_posts_read,
-                                        R.string.all_posts_read,
+                                    Toast.LENGTH_SHORT,
-                                        Toast.LENGTH_SHORT,
+                                ).show()
-                                    ).show()
                                 tabNewBadge.removeBadge()
 
                                 getElementsAccordingToTab()
                             } else {
-                                Toast
+                                Toast.makeText(
-                                    .makeText(
+                                    this@HomeActivity,
-                                        this@HomeActivity,
+                                    R.string.all_posts_not_read,
-                                        R.string.all_posts_not_read,
+                                    Toast.LENGTH_SHORT,
-                                        Toast.LENGTH_SHORT,
+                                ).show()
-                                    ).show()
                             }
                             handleListResult()
                             binding.swipeRefreshLayout.isRefreshing = false
                             CountingIdlingResourceSingleton.decrement()
+
                         }
                     }
                 }
@@ -673,7 +661,7 @@ class HomeActivity :
             R.id.action_disconnect -> {
                 needsConfirmation(
                     R.string.confirm_disconnect_title,
-                    R.string.confirm_disconnect_description,
+                    R.string.confirm_disconnect_description
                 ) {
                     runBlocking {
                         repository.logout()
@@ -714,8 +702,7 @@ class HomeActivity :
     private fun handleRecurringTask() {
         if (appSettingsService.isPeriodicRefreshEnabled()) {
             val myConstraints =
-                Constraints
+                Constraints.Builder()
-                    .Builder()
                     .setRequiresBatteryNotLow(true)
                     .setRequiresCharging(appSettingsService.isRefreshWhenChargingOnlyEnabled())
                     .setRequiresStorageNotLow(true)
@@ -724,19 +711,19 @@ class HomeActivity :
             val backgroundWork =
                 PeriodicWorkRequestBuilder<LoadingWorker>(
                     appSettingsService.getRefreshMinutes(),
-                    TimeUnit.MINUTES,
+                    TimeUnit.MINUTES
-                ).setConstraints(myConstraints)
+                )
+                    .setConstraints(myConstraints)
                     .addTag("selfoss-loading")
                     .build()
 
-            WorkManager
+            WorkManager.getInstance(
-                .getInstance(
+                baseContext,
-                    baseContext,
+            ).enqueueUniquePeriodicWork(
-                ).enqueueUniquePeriodicWork(
+                "selfoss-loading",
-                    "selfoss-loading",
+                ExistingPeriodicWorkPolicy.KEEP,
-                    ExistingPeriodicWorkPolicy.KEEP,
+                backgroundWork
-                    backgroundWork,
+            )
-                )
         }
     }
-}
+}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/ImageActivity.kt

@@ -84,9 +84,7 @@ class ImageActivity : AppCompatActivity() {
         return super.onOptionsItemSelected(item)
     }
 
-    private inner class ScreenSlidePagerAdapter(
+    private inner class ScreenSlidePagerAdapter(fa: FragmentActivity) : FragmentStateAdapter(fa) {
-        fa: FragmentActivity,
-    ) : FragmentStateAdapter(fa) {
         override fun getItemCount(): Int = allImages.size
 
         override fun createFragment(position: Int): Fragment = ImageFragment.newInstance(allImages[position])

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/LoginActivity.kt

@@ -30,11 +30,7 @@ import org.kodein.di.DIAware
 import org.kodein.di.android.closestDI
 import org.kodein.di.instance
 
-private const val MAX_INVALID_LOGIN_BEFORE_ALERT_DISPLAYED = 3
+class LoginActivity : AppCompatActivity(), DIAware {
-
-class LoginActivity :
-    AppCompatActivity(),
-    DIAware {
     private var inValidCount: Int = 0
     private var isWithLogin = false
 
@@ -112,7 +108,7 @@ class LoginActivity :
             repository.updateApiInformation()
             ACRA.errorReporter.putCustomData(
                 "SELFOSS_API_VERSION",
-                appSettingsService.getApiVersion().toString(),
+                appSettingsService.getApiVersion().toString()
             )
             CountingIdlingResourceSingleton.decrement()
         }
@@ -136,18 +132,9 @@ class LoginActivity :
         binding.passwordView.error = null
 
         // Store values at the time of the login attempt.
-        val url =
+        val url = binding.urlView.text.toString().trim()
-            binding.urlView.text
+        val login = binding.loginView.text.toString().trim()
-                .toString()
+        val password = binding.passwordView.text.toString().trim()
-                .trim()
-        val login =
-            binding.loginView.text
-                .toString()
-                .trim()
-        val password =
-            binding.passwordView.text
-                .toString()
-                .trim()
 
         failInvalidUrl(url)
         failLoginDetails(password, login)
@@ -164,12 +151,11 @@ class LoginActivity :
                 repository.updateApiInformation()
             } catch (e: Exception) {
                 if (e.message?.startsWith("No transformation found") == true) {
-                    Toast
+                    Toast.makeText(
-                        .makeText(
+                        applicationContext,
-                            applicationContext,
+                        R.string.application_selfoss_only,
-                            R.string.application_selfoss_only,
+                        Toast.LENGTH_LONG,
-                            Toast.LENGTH_LONG,
+                    ).show()
-                        ).show()
                     preferenceError()
                     showProgress(false)
                 }
@@ -219,7 +205,7 @@ class LoginActivity :
             cancel = true
             binding.urlView.error = getString(R.string.login_url_problem)
             inValidCount++
-            if (inValidCount == MAX_INVALID_LOGIN_BEFORE_ALERT_DISPLAYED) {
+            if (inValidCount == 3) {
                 val alertDialog = AlertDialog.Builder(this).create()
                 alertDialog.setTitle(getString(R.string.warning_wrong_url))
                 alertDialog.setMessage(getString(R.string.text_wrong_url))
@@ -284,7 +270,7 @@ class LoginActivity :
         return when (item.itemId) {
             R.id.issue_tracker -> {
                 val browserIntent =
-                    Intent(Intent.ACTION_VIEW, Uri.parse(AppSettingsService.BUG_URL))
+                    Intent(Intent.ACTION_VIEW, Uri.parse(AppSettingsService.trackerUrl))
                 startActivity(browserIntent)
                 return true
             }
@@ -294,9 +280,9 @@ class LoginActivity :
                     .withAboutIconShown(true)
                     .withAboutVersionShown(true)
                     .withAboutSpecial2("Bug reports")
-                    .withAboutSpecial2Description(AppSettingsService.BUG_URL)
+                    .withAboutSpecial2Description(AppSettingsService.trackerUrl)
                     .withAboutSpecial1("Project Page")
-                    .withAboutSpecial1Description(AppSettingsService.SOURCE_URL)
+                    .withAboutSpecial1Description(AppSettingsService.sourceUrl)
                     .start(this)
                 true
             }
@@ -304,4 +290,4 @@ class LoginActivity :
             else -> super.onOptionsItemSelected(item)
         }
     }
-}
+}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/MyApp.kt

@@ -9,11 +9,11 @@ import androidx.lifecycle.DefaultLifecycleObserver
 import androidx.lifecycle.LifecycleOwner
 import androidx.lifecycle.ProcessLifecycleOwner
 import androidx.multidex.MultiDexApplication
+import bou.amine.apps.readerforselfossv2.DI.networkModule
 import bou.amine.apps.readerforselfossv2.android.testing.TestingHelper
 import bou.amine.apps.readerforselfossv2.android.viewmodel.AppViewModel
 import bou.amine.apps.readerforselfossv2.dao.DriverFactory
 import bou.amine.apps.readerforselfossv2.dao.ReaderForSelfossDB
-import bou.amine.apps.readerforselfossv2.di.networkModule
 import bou.amine.apps.readerforselfossv2.repository.Repository
 import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 import com.github.ln_12.library.ConnectivityStatus
@@ -36,23 +36,21 @@ import org.kodein.di.bind
 import org.kodein.di.instance
 import org.kodein.di.singleton
 
-class MyApp :
+class MyApp : MultiDexApplication(), DIAware {
-    MultiDexApplication(),
-    DIAware {
     override val di by DI.lazy {
         bind<AppSettingsService>() with singleton { AppSettingsService(ACRA.isACRASenderServiceProcess() || TestingHelper().isUnitTest()) }
         import(networkModule)
         bind<DriverFactory>() with singleton { DriverFactory(applicationContext) }
         bind<ReaderForSelfossDB>() with singleton { ReaderForSelfossDB(driverFactory.createDriver()) }
         bind<Repository>() with
-            singleton {
+                singleton {
-                Repository(
+                    Repository(
-                    instance(),
+                        instance(),
-                    instance(),
+                        instance(),
-                    isConnectionAvailable,
+                        isConnectionAvailable,
-                    instance(),
+                        instance(),
-                )
+                    )
-            }
+                }
         bind<ConnectivityStatus>() with singleton { ConnectivityStatus(applicationContext) }
         bind<AppViewModel>() with singleton { AppViewModel(repository = instance()) }
     }
@@ -62,7 +60,6 @@ class MyApp :
     private val connectivityStatus: ConnectivityStatus by instance()
     private val driverFactory: DriverFactory by instance()
 
-    @Suppress("detekt:ForbiddenComment")
     // TODO: handle with the "previous" way
     private val isConnectionAvailable: MutableStateFlow<Boolean> = MutableStateFlow(true)
 
@@ -92,12 +89,11 @@ class MyApp :
                             R.string.network_connectivity_lost
                         }
 
-                    Toast
+                    Toast.makeText(
-                        .makeText(
+                        applicationContext,
-                            applicationContext,
+                        toastMessage,
-                            toastMessage,
+                        Toast.LENGTH_SHORT,
-                            Toast.LENGTH_SHORT,
+                    ).show()
-                        ).show()
                 }
             }
         }
@@ -155,13 +151,13 @@ class MyApp :
 
             val name = getString(R.string.notification_channel_sync)
             val importance = NotificationManager.IMPORTANCE_LOW
-            val mChannel = NotificationChannel(AppSettingsService.SYNC_CHANNEL_ID, name, importance)
+            val mChannel = NotificationChannel(AppSettingsService.syncChannelId, name, importance)
 
             val newItemsChannelname = getString(R.string.new_items_channel_sync)
             val newItemsChannelimportance = NotificationManager.IMPORTANCE_DEFAULT
             val newItemsChannelmChannel =
                 NotificationChannel(
-                    AppSettingsService.NEW_ITEMS_CHANNEL,
+                    AppSettingsService.newItemsChannelId,
                     newItemsChannelname,
                     newItemsChannelimportance,
                 )
@@ -203,4 +199,4 @@ class MyApp :
             super.onPause(owner)
         }
     }
-}
+}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/ReaderActivity.kt

@@ -22,9 +22,7 @@ import org.kodein.di.DIAware
 import org.kodein.di.android.closestDI
 import org.kodein.di.instance
 
-class ReaderActivity :
+class ReaderActivity : AppCompatActivity(), DIAware {
-    AppCompatActivity(),
-    DIAware {
     private var currentItem: Int = 0
 
     private lateinit var toolbarMenu: Menu
@@ -53,7 +51,6 @@ class ReaderActivity :
         showMenuItem(false)
     }
 
-    @Suppress("detekt:SwallowedException")
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         binding = ActivityReaderBinding.inflate(layoutInflater)
@@ -102,9 +99,8 @@ class ReaderActivity :
         oldInstanceState.clear()
     }
 
-    private inner class ScreenSlidePagerAdapter(
+    private inner class ScreenSlidePagerAdapter(fa: FragmentActivity) :
-        fa: FragmentActivity,
+        FragmentStateAdapter(fa) {
-    ) : FragmentStateAdapter(fa) {
         override fun getItemCount(): Int = allItems.size
 
         override fun createFragment(position: Int): Fragment = ArticleFragment.newInstance(allItems[position])
@@ -113,26 +109,25 @@ class ReaderActivity :
     override fun onKeyDown(
         keyCode: Int,
         event: KeyEvent?,
-    ): Boolean =
+    ): Boolean {
-        when (keyCode) {
+        return when (keyCode) {
             KeyEvent.KEYCODE_VOLUME_DOWN -> {
                 val currentFragment =
                     supportFragmentManager.findFragmentByTag("f" + binding.pager.currentItem) as ArticleFragment
-                currentFragment.volumeButtonScrollDown()
+                currentFragment.scrollDown()
                 true
             }
-
             KeyEvent.KEYCODE_VOLUME_UP -> {
                 val currentFragment =
                     supportFragmentManager.findFragmentByTag("f" + binding.pager.currentItem) as ArticleFragment
-                currentFragment.volumeButtonScrollUp()
+                currentFragment.scrollUp()
                 true
             }
-
             else -> {
                 super.onKeyDown(keyCode, event)
             }
         }
+    }
 
     private fun alignmentMenu() {
         val showJustify = appSettingsService.getActiveAllignment() == AppSettingsService.ALIGN_LEFT
@@ -192,7 +187,6 @@ class ReaderActivity :
                 onBackPressedDispatcher.onBackPressed()
                 return true
             }
-
             R.id.star -> {
                 if (allItems[binding.pager.currentItem].starred) {
                     CoroutineScope(Dispatchers.IO).launch {
@@ -206,12 +200,10 @@ class ReaderActivity :
                     afterSave()
                 }
             }
-
             R.id.align_left -> {
                 switchAlignmentSetting(AppSettingsService.ALIGN_LEFT)
                 refreshFragment()
             }
-
             R.id.align_justify -> {
                 switchAlignmentSetting(AppSettingsService.JUSTIFY)
                 refreshFragment()

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/SourcesActivity.kt

@@ -18,9 +18,7 @@ import org.kodein.di.DIAware
 import org.kodein.di.android.closestDI
 import org.kodein.di.instance
 
-class SourcesActivity :
+class SourcesActivity : AppCompatActivity(), DIAware {
-    AppCompatActivity(),
-    DIAware {
     private lateinit var binding: ActivitySourcesBinding
 
     override val di by closestDI()
@@ -70,12 +68,11 @@ class SourcesActivity :
                 binding.recyclerView.adapter = mAdapter
                 mAdapter.notifyDataSetChanged()
             } else {
-                Toast
+                Toast.makeText(
-                    .makeText(
+                    this@SourcesActivity,
-                        this@SourcesActivity,
+                    R.string.cant_get_sources,
-                        R.string.cant_get_sources,
+                    Toast.LENGTH_SHORT,
-                        Toast.LENGTH_SHORT,
+                ).show()
-                    ).show()
             }
             CountingIdlingResourceSingleton.decrement()
         }
@@ -84,4 +81,4 @@ class SourcesActivity :
             startActivity(Intent(this@SourcesActivity, UpsertSourceActivity::class.java))
         }
     }
-}
+}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/UpsertSourceActivity.kt

@@ -21,9 +21,7 @@ import org.kodein.di.DIAware
 import org.kodein.di.android.closestDI
 import org.kodein.di.instance
 
-class UpsertSourceActivity :
+class UpsertSourceActivity : AppCompatActivity(), DIAware {
-    AppCompatActivity(),
-    DIAware {
     private var existingSource: SelfossModel.SourceDetail? = null
     private var mSpoutsValue: String? = null
 
@@ -85,7 +83,6 @@ class UpsertSourceActivity :
         }
     }
 
-    @Suppress("detekt:SwallowedException")
     private fun handleSpoutsSpinner() {
         val spoutsKV = HashMap<String, String>()
         binding.spoutsSpinner.onItemSelectedListener =
@@ -108,12 +105,11 @@ class UpsertSourceActivity :
             }
 
         fun handleSpoutFailure(networkIssue: Boolean = false) {
-            Toast
+            Toast.makeText(
-                .makeText(
+                this@UpsertSourceActivity,
-                    this@UpsertSourceActivity,
+                if (networkIssue) R.string.cant_get_spouts_no_network else R.string.cant_get_spouts,
-                    if (networkIssue) R.string.cant_get_spouts_no_network else R.string.cant_get_spouts,
+                Toast.LENGTH_SHORT,
-                    Toast.LENGTH_SHORT,
+            ).show()
-                ).show()
             binding.progress.visibility = View.GONE
         }
 
@@ -174,7 +170,6 @@ class UpsertSourceActivity :
             sourceDetailsUnavailable -> {
                 Toast.makeText(this, R.string.form_not_complete, Toast.LENGTH_SHORT).show()
             }
-
             else -> {
                 CoroutineScope(Dispatchers.Main).launch {
                     val successfullyAddedSource =
@@ -197,12 +192,11 @@ class UpsertSourceActivity :
                     if (successfullyAddedSource) {
                         finish()
                     } else {
-                        Toast
+                        Toast.makeText(
-                            .makeText(
+                            this@UpsertSourceActivity,
-                                this@UpsertSourceActivity,
+                            R.string.cant_create_source,
-                                R.string.cant_create_source,
+                            Toast.LENGTH_SHORT,
-                                Toast.LENGTH_SHORT,
+                        ).show()
-                            ).show()
                     }
                 }
             }

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemCardAdapter.kt

@@ -49,10 +49,7 @@ class ItemCardAdapter(
         return ViewHolder(binding)
     }
 
-    private fun handleClickListeners(
+    private fun handleClickListeners(holderBinding: CardItemBinding, position: Int) {
-        holderBinding: CardItemBinding,
-        position: Int,
-    ) {
         holderBinding.favButton.setOnClickListener {
             val item = items[position]
             if (item.starred) {
@@ -99,13 +96,12 @@ class ItemCardAdapter(
 
             binding.title.setLinkTextColor(c.resources.getColor(R.color.colorAccent))
 
-            binding.sourceTitleAndDate.text =
+            binding.sourceTitleAndDate.text = try {
-                try {
+                itm.sourceAuthorAndDate()
-                    itm.sourceAuthorAndDate()
+            } catch (e: Exception) {
-                } catch (e: Exception) {
+                e.sendSilentlyWithAcraWithName("ItemCardAdapter parse date")
-                    e.sendSilentlyWithAcraWithName("ItemCardAdapter parse date")
+                itm.sourceAuthorOnly()
-                    itm.sourceAuthorOnly()
+            }
-                }
 
             if (!appSettingsService.isFullHeightCardsEnabled()) {
                 binding.itemImage.maxHeight = imageMaxHeight
@@ -118,18 +114,16 @@ class ItemCardAdapter(
                 binding.itemImage.setImageDrawable(null)
             } else {
                 binding.itemImage.visibility = View.VISIBLE
-                c.bitmapCenterCrop(itm.getThumbnail(repository.baseUrl), binding.itemImage, appSettingsService)
+                c.bitmapCenterCrop(itm.getThumbnail(repository.baseUrl), binding.itemImage)
             }
 
             if (itm.getIcon(repository.baseUrl).isEmpty()) {
                 binding.sourceImage.setBackgroundAndText(itm.sourcetitle.getHtmlDecoded())
             } else {
-                c.circularDrawable(itm.getIcon(repository.baseUrl), binding.sourceImage, appSettingsService)
+                c.circularDrawable(itm.getIcon(repository.baseUrl), binding.sourceImage)
             }
         }
     }
 
-    inner class ViewHolder(
+    inner class ViewHolder(val binding: CardItemBinding) : RecyclerView.ViewHolder(binding.root)
-        val binding: CardItemBinding,
+}
-    ) : RecyclerView.ViewHolder(binding.root)
-}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemListAdapter.kt

@@ -53,27 +53,24 @@ class ItemListAdapter(
 
             binding.title.setLinkTextColor(c.resources.getColor(R.color.colorAccent))
 
-            binding.sourceTitleAndDate.text =
+            binding.sourceTitleAndDate.text = try {
-                try {
+                itm.sourceAuthorAndDate()
-                    itm.sourceAuthorAndDate()
+            } catch (e: Exception) {
-                } catch (e: Exception) {
+                e.sendSilentlyWithAcraWithName("ItemListAdapter parse date")
-                    e.sendSilentlyWithAcraWithName("ItemListAdapter parse date")
+                itm.sourceAuthorOnly()
-                    itm.sourceAuthorOnly()
+            }
-                }
 
             if (itm.getThumbnail(repository.baseUrl).isEmpty()) {
                 if (itm.getIcon(repository.baseUrl).isEmpty()) {
                     binding.itemImage.setBackgroundAndText(itm.sourcetitle.getHtmlDecoded())
                 } else {
-                    c.circularDrawable(itm.getIcon(repository.baseUrl), binding.itemImage, appSettingsService)
+                    c.circularDrawable(itm.getIcon(repository.baseUrl), binding.itemImage)
                 }
             } else {
-                c.circularDrawable(itm.getThumbnail(repository.baseUrl), binding.itemImage, appSettingsService)
+                c.circularDrawable(itm.getThumbnail(repository.baseUrl), binding.itemImage)
             }
         }
     }
 
-    inner class ViewHolder(
+    inner class ViewHolder(val binding: ListItemBinding) : RecyclerView.ViewHolder(binding.root)
-        val binding: ListItemBinding,
+}
-    ) : RecyclerView.ViewHolder(binding.root)
-}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemsAdapter.kt

@@ -18,9 +18,7 @@ import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
 import org.kodein.di.DIAware
 
-abstract class ItemsAdapter<VH : RecyclerView.ViewHolder?> :
+abstract class ItemsAdapter<VH : RecyclerView.ViewHolder?> : RecyclerView.Adapter<VH>(), DIAware {
-    RecyclerView.Adapter<VH>(),
-    DIAware {
     abstract val items: ArrayList<SelfossModel.Item>
     abstract val repository: Repository
     abstract val binding: ViewBinding
@@ -47,7 +45,8 @@ abstract class ItemsAdapter<VH : RecyclerView.ViewHolder?> :
                     app.findViewById(R.id.coordLayout),
                     R.string.marked_as_read,
                     Snackbar.LENGTH_LONG,
-                ).setAction(R.string.undo_string) {
+                )
+                .setAction(R.string.undo_string) {
                     unreadItemAtIndex(item, position, false)
                 }
 
@@ -67,7 +66,8 @@ abstract class ItemsAdapter<VH : RecyclerView.ViewHolder?> :
                     app.findViewById(R.id.coordLayout),
                     R.string.marked_as_unread,
                     Snackbar.LENGTH_LONG,
-                ).setAction(R.string.undo_string) {
+                )
+                .setAction(R.string.undo_string) {
                     readItemAtIndex(item, position, false)
                 }
 
@@ -77,10 +77,7 @@ abstract class ItemsAdapter<VH : RecyclerView.ViewHolder?> :
         s.show()
     }
 
-    protected fun handleLinkOpening(
+    protected fun handleLinkOpening(holderBinding: ViewBinding, position: Int) {
-        holderBinding: ViewBinding,
-        position: Int,
-    ) {
         holderBinding.root.setOnClickListener {
             repository.setReaderItems(items)
             c.openItemUrl(

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/SourcesListAdapter.kt

@@ -16,7 +16,6 @@ import bou.amine.apps.readerforselfossv2.android.databinding.SourceListItemBindi
 import bou.amine.apps.readerforselfossv2.android.utils.glide.circularDrawable
 import bou.amine.apps.readerforselfossv2.model.SelfossModel
 import bou.amine.apps.readerforselfossv2.repository.Repository
-import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 import bou.amine.apps.readerforselfossv2.utils.getHtmlDecoded
 import bou.amine.apps.readerforselfossv2.utils.getIcon
 import kotlinx.coroutines.CoroutineScope
@@ -30,14 +29,12 @@ import org.kodein.di.instance
 class SourcesListAdapter(
     private val app: Activity,
     private val items: ArrayList<SelfossModel.SourceDetail>,
-) : RecyclerView.Adapter<SourcesListAdapter.ViewHolder>(),
+) : RecyclerView.Adapter<SourcesListAdapter.ViewHolder>(), DIAware {
-    DIAware {
     private val c: Context = app.baseContext
     private lateinit var binding: SourceListItemBinding
 
     override val di: DI by closestDI(app)
     private val repository: Repository by instance()
-    private val appSettingsService: AppSettingsService by instance()
 
     override fun onCreateViewHolder(
         parent: ViewGroup,
@@ -64,12 +61,11 @@ class SourcesListAdapter(
                     notifyItemRemoved(position)
                     notifyItemRangeChanged(position, itemCount)
                 } else {
-                    Toast
+                    Toast.makeText(
-                        .makeText(
+                        app,
-                            app,
+                        R.string.can_delete_source,
-                            R.string.can_delete_source,
+                        Toast.LENGTH_SHORT,
-                            Toast.LENGTH_SHORT,
+                    ).show()
-                        ).show()
                 }
             }
         }
@@ -84,7 +80,7 @@ class SourcesListAdapter(
         if (itm.getIcon(repository.baseUrl).isEmpty()) {
             binding.itemImage.setBackgroundAndText(itm.title.getHtmlDecoded())
         } else {
-            c.circularDrawable(itm.getIcon(repository.baseUrl), binding.itemImage, appSettingsService)
+            c.circularDrawable(itm.getIcon(repository.baseUrl), binding.itemImage)
         }
 
         if (!itm.error.isNullOrBlank()) {
@@ -103,7 +99,5 @@ class SourcesListAdapter(
 
     override fun getItemCount(): Int = items.size
 
-    inner class ViewHolder(
+    inner class ViewHolder(val mView: ConstraintLayout) : RecyclerView.ViewHolder(mView)
-        val mView: ConstraintLayout,
-    ) : RecyclerView.ViewHolder(mView)
 }

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/background/background.kt

@@ -23,15 +23,11 @@ import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
 import org.kodein.di.DIAware
 import org.kodein.di.instance
-import java.util.Timer
+import java.util.*
 import kotlin.concurrent.schedule
 
-private const val NOTIFICATION_DELAY = 4000L
+class LoadingWorker(val context: Context, params: WorkerParameters) :
-
+    Worker(context, params),
-class LoadingWorker(
-    val context: Context,
-    params: WorkerParameters,
-) : Worker(context, params),
     DIAware {
     override val di by lazy { (applicationContext as MyApp).di }
     private val repository: Repository by instance()
@@ -44,13 +40,12 @@ class LoadingWorker(
                     applicationContext.getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager
 
                 val notification =
-                    NotificationCompat
+                    NotificationCompat.Builder(applicationContext, AppSettingsService.syncChannelId)
-                        .Builder(applicationContext, AppSettingsService.SYNC_CHANNEL_ID)
                         .setContentTitle(context.getString(R.string.loading_notification_title))
                         .setContentText(context.getString(R.string.loading_notification_text))
                         .setOngoing(true)
                         .setPriority(PRIORITY_LOW)
-                        .setChannelId(AppSettingsService.SYNC_CHANNEL_ID)
+                        .setChannelId(AppSettingsService.syncChannelId)
                         .setSmallIcon(R.drawable.ic_stat_cloud_download_black_24dp)
 
                 notificationManager.notify(1, notification.build())
@@ -63,7 +58,7 @@ class LoadingWorker(
                         handleNewItemsNotification(apiItems, notificationManager)
                     }
                 }
-                apiItems.map { it.preloadImages(context, appSettingsService) }
+                apiItems.map { it.preloadImages(context) }
             }
         }
         return Result.success()
@@ -92,27 +87,28 @@ class LoadingWorker(
                     PendingIntent.getActivity(context, 0, intent, pflags)
 
                 val newItemsNotification =
-                    NotificationCompat
+                    NotificationCompat.Builder(
-                        .Builder(
+                        applicationContext,
-                            applicationContext,
+                        AppSettingsService.newItemsChannelId,
-                            AppSettingsService.NEW_ITEMS_CHANNEL,
+                    )
-                        ).setContentTitle(context.getString(R.string.new_items_notification_title))
+                        .setContentTitle(context.getString(R.string.new_items_notification_title))
                         .setContentText(
                             context.getString(
                                 R.string.new_items_notification_text,
                                 newSize,
                             ),
-                        ).setPriority(PRIORITY_DEFAULT)
+                        )
-                        .setChannelId(AppSettingsService.NEW_ITEMS_CHANNEL)
+                        .setPriority(PRIORITY_DEFAULT)
+                        .setChannelId(AppSettingsService.newItemsChannelId)
                         .setContentIntent(pendingIntent)
                         .setAutoCancel(true)
                         .setSmallIcon(R.drawable.ic_tab_fiber_new_black_24dp)
 
-                Timer("", false).schedule(NOTIFICATION_DELAY) {
+                Timer("", false).schedule(4000) {
                     notificationManager.notify(2, newItemsNotification.build())
                 }
             }
-            Timer("", false).schedule(NOTIFICATION_DELAY) {
+            Timer("", false).schedule(4000) {
                 notificationManager.cancel(1)
             }
         }

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/ArticleFragment.kt

@@ -1,15 +1,17 @@
 package bou.amine.apps.readerforselfossv2.android.fragments
 
-import android.content.Context
 import android.content.Intent
+import android.content.res.ColorStateList
 import android.content.res.TypedArray
 import android.graphics.Bitmap
 import android.graphics.Typeface
+import android.graphics.drawable.ColorDrawable
 import android.os.Bundle
-import android.util.TypedValue.DATA_NULL_UNDEFINED
+import android.util.TypedValue
 import android.view.GestureDetector
 import android.view.InflateException
 import android.view.LayoutInflater
+import android.view.MenuItem
 import android.view.MotionEvent
 import android.view.View
 import android.view.ViewGroup
@@ -19,6 +21,7 @@ import android.webkit.WebView
 import android.webkit.WebViewClient
 import android.widget.Toast
 import androidx.appcompat.app.AlertDialog
+import androidx.core.widget.NestedScrollView
 import androidx.fragment.app.Fragment
 import bou.amine.apps.readerforselfossv2.android.ImageActivity
 import bou.amine.apps.readerforselfossv2.android.R
@@ -27,11 +30,7 @@ import bou.amine.apps.readerforselfossv2.android.model.ParecelableItem
 import bou.amine.apps.readerforselfossv2.android.model.toModel
 import bou.amine.apps.readerforselfossv2.android.model.toParcelable
 import bou.amine.apps.readerforselfossv2.android.utils.acra.sendSilentlyWithAcraWithName
-import bou.amine.apps.readerforselfossv2.android.utils.bottombar.addHomeMadeActionItem
-import bou.amine.apps.readerforselfossv2.android.utils.getColorFromAttr
-import bou.amine.apps.readerforselfossv2.android.utils.glide.bitmapFitCenter
 import bou.amine.apps.readerforselfossv2.android.utils.glide.getBitmapInputStream
-import bou.amine.apps.readerforselfossv2.android.utils.glide.getGlideImageForResource
 import bou.amine.apps.readerforselfossv2.android.utils.isUrlValid
 import bou.amine.apps.readerforselfossv2.android.utils.openItemUrlInBrowserAsNewTask
 import bou.amine.apps.readerforselfossv2.android.utils.openUrlInBrowser
@@ -45,7 +44,11 @@ import bou.amine.apps.readerforselfossv2.utils.getHtmlDecoded
 import bou.amine.apps.readerforselfossv2.utils.getImages
 import bou.amine.apps.readerforselfossv2.utils.getThumbnail
 import bou.amine.apps.readerforselfossv2.utils.isEmptyOrNullOrNullString
-import com.leinardi.android.speeddial.SpeedDialView
+import com.bumptech.glide.Glide
+import com.bumptech.glide.load.engine.DiskCacheStrategy
+import com.bumptech.glide.request.RequestOptions
+import com.github.rubensousa.floatingtoolbar.FloatingToolbar
+import com.google.android.material.floatingactionbutton.FloatingActionButton
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
@@ -60,19 +63,9 @@ import java.util.Locale
 import java.util.concurrent.ExecutionException
 
 private const val IMAGE_JPG = "image/jpg"
-private const val IMAGE_PNG = "image/png"
-private const val IMAGE_WEBP = "image/webp"
 
-private const val WHITE_COLOR_HEX = 0xFFFFFF
+class ArticleFragment : Fragment(), DIAware {
-
+    private var fontSize: Int = 16
-private const val DEFAULT_FONT_SIZE = 16
-
-class ArticleFragment :
-    Fragment(),
-    DIAware {
-    private var colorOnSurface: Int = 0
-    private var colorSurface: Int = 0
-    private var fontSize: Int = DEFAULT_FONT_SIZE
     private lateinit var item: SelfossModel.Item
     private lateinit var url: String
     private lateinit var contentText: String
@@ -80,7 +73,7 @@ class ArticleFragment :
     private lateinit var contentImage: String
     private lateinit var contentTitle: String
     private lateinit var allImages: ArrayList<String>
-    private lateinit var fab: SpeedDialView
+    private lateinit var fab: FloatingActionButton
     private lateinit var textAlignment: String
     private lateinit var binding: FragmentArticleBinding
 
@@ -91,6 +84,7 @@ class ArticleFragment :
     private var typeface: Typeface? = null
     private var resId: Int = 0
     private var font = ""
+    private var staticBar = false
 
     private val mercuryApi: MercuryApi by instance()
 
@@ -102,7 +96,6 @@ class ArticleFragment :
         item = pi.toModel()
     }
 
-    @Suppress("detekt:LongMethod")
     override fun onCreateView(
         inflater: LayoutInflater,
         container: ViewGroup?,
@@ -117,27 +110,35 @@ class ArticleFragment :
                 e.sendSilentlyWithAcra()
             }
 
-            colorOnSurface = requireContext().getColorFromAttr(R.attr.colorOnSurface)
-            colorSurface = requireContext().getColorFromAttr(R.attr.colorSurface)
-
             contentText = item.content
             contentTitle = item.title.getHtmlDecoded()
             contentImage = item.getThumbnail(repository.baseUrl)
-            contentSource =
+            contentSource = try {
-                try {
+                item.sourceAuthorAndDate()
-                    item.sourceAuthorAndDate()
+            } catch (e: Exception) {
-                } catch (e: Exception) {
+                e.sendSilentlyWithAcraWithName("Article Fragment parse date")
-                    e.sendSilentlyWithAcraWithName("Article Fragment parse date")
+                item.sourceAuthorOnly()
-                    item.sourceAuthorOnly()
+            }
-                }
             allImages = item.getImages()
 
             fontSize = appSettingsService.getFontSize()
+            staticBar = appSettingsService.isStaticBarEnabled()
             font = appSettingsService.getFont()
 
             refreshAlignment()
 
-            handleFloatingToolbar()
+            fab = binding.fab
+
+            fab.backgroundTintList = ColorStateList.valueOf(resources.getColor(R.color.colorAccent))
+
+            fab.rippleColor = resources.getColor(R.color.colorAccentDark)
+
+            val floatingToolbar: FloatingToolbar = handleFloatingToolbar()
+
+            if (staticBar) {
+                fab.hide()
+                floatingToolbar.show()
+            }
 
             binding.source.text = contentSource
             if (typeface != null) {
@@ -145,11 +146,25 @@ class ArticleFragment :
             }
 
             handleContent()
+
+            binding.nestedScrollView.setOnScrollChangeListener(
+                NestedScrollView.OnScrollChangeListener { _, _, scrollY, _, oldScrollY ->
+                    if (scrollY > oldScrollY) {
+                        floatingToolbar.hide()
+                        fab.hide()
+                    } else {
+                        if (staticBar) {
+                            floatingToolbar.show()
+                        } else {
+                            if (floatingToolbar.isShowing) floatingToolbar.hide() else fab.show()
+                        }
+                    }
+                },
+            )
         } catch (e: InflateException) {
             e.sendSilentlyWithAcraWithName("webview not available")
             try {
-                AlertDialog
+                AlertDialog.Builder(requireContext())
-                    .Builder(requireContext())
                     .setMessage(requireContext().getString(R.string.webview_dialog_issue_message))
                     .setTitle(requireContext().getString(R.string.webview_dialog_issue_title))
                     .setPositiveButton(
@@ -157,7 +172,8 @@ class ArticleFragment :
                     ) { _, _ ->
                         appSettingsService.disableArticleViewer()
                         requireActivity().finish()
-                    }.create()
+                    }
+                    .create()
                     .show()
             } catch (e: IllegalStateException) {
                 e.sendSilentlyWithAcraWithName("Context required is null")
@@ -182,84 +198,70 @@ class ArticleFragment :
 
             if (!contentImage.isEmptyOrNullOrNullString() && context != null) {
                 binding.imageView.visibility = View.VISIBLE
-                requireContext().bitmapFitCenter(contentImage, binding.imageView, appSettingsService)
+                Glide
+                    .with(requireContext())
+                    .asBitmap()
+                    .load(contentImage)
+                    .apply(RequestOptions.fitCenterTransform())
+                    .into(binding.imageView)
             } else {
                 binding.imageView.visibility = View.GONE
             }
         }
     }
 
-    private fun handleFloatingToolbar() {
+    private fun handleFloatingToolbar(): FloatingToolbar {
-        fab = binding.speedDial
+        val floatingToolbar: FloatingToolbar = binding.floatingToolbar
-        fab.mainFabClosedIconColor = colorOnSurface
+        if (appSettingsService.getPublicAccess()) {
-        fab.mainFabOpenedIconColor = colorOnSurface
+            floatingToolbar.setMenu(R.menu.reader_toolbar_no_read)
-
-        handleFloatingToolbarActionItems()
-
-        fab.setOnActionSelectedListener { actionItem ->
-            when (actionItem.id) {
-                R.id.share_action -> requireActivity().shareLink(url, contentTitle)
-                R.id.open_action -> requireActivity().openItemUrlInBrowserAsNewTask(this@ArticleFragment.item)
-                R.id.unread_action ->
-                    try {
-                        if (this@ArticleFragment.item.unread) {
-                            CoroutineScope(Dispatchers.IO).launch {
-                                repository.markAsRead(this@ArticleFragment.item)
-                            }
-                            this@ArticleFragment.item.unread = false
-                            Toast
-                                .makeText(
-                                    requireContext(),
-                                    R.string.marked_as_read,
-                                    Toast.LENGTH_LONG,
-                                ).show()
-                        } else {
-                            CoroutineScope(Dispatchers.IO).launch {
-                                repository.unmarkAsRead(this@ArticleFragment.item)
-                            }
-                            this@ArticleFragment.item.unread = true
-                            Toast
-                                .makeText(
-                                    context,
-                                    R.string.marked_as_unread,
-                                    Toast.LENGTH_LONG,
-                                ).show()
-                        }
-                    } catch (e: IllegalStateException) {
-                        e.sendSilentlyWithAcraWithName("Context required is null")
-                    }
-
-                else -> Unit
-            }
-            false
         }
-    }
+        floatingToolbar.attachFab(fab)
 
-    private fun handleFloatingToolbarActionItems() {
+        floatingToolbar.background = ColorDrawable(resources.getColor(R.color.colorAccent))
-        fab.addHomeMadeActionItem(
+
-            R.id.share_action,
+        floatingToolbar.setClickListener(
-            resources.getDrawable(R.drawable.ic_share_white_24dp),
+            object : FloatingToolbar.ItemClickListener {
-            R.string.reader_action_share,
+                override fun onItemClick(item: MenuItem) {
-            colorOnSurface,
+                    when (item.itemId) {
-            colorSurface,
+                        R.id.share_action -> requireActivity().shareLink(url, contentTitle)
-            requireContext(),
+                        R.id.open_action -> requireActivity().openItemUrlInBrowserAsNewTask(this@ArticleFragment.item)
-        )
+                        R.id.unread_action ->
-        fab.addHomeMadeActionItem(
+                            try {
-            R.id.open_action,
+                                if (this@ArticleFragment.item.unread) {
-            resources.getDrawable(R.drawable.ic_open_in_browser_white_24dp),
+                                    CoroutineScope(Dispatchers.IO).launch {
-            R.string.reader_action_open,
+                                        repository.markAsRead(this@ArticleFragment.item)
-            colorOnSurface,
+                                    }
-            colorSurface,
+                                    this@ArticleFragment.item.unread = false
-            requireContext(),
+                                    Toast.makeText(
-        )
+                                        requireContext(),
-        fab.addHomeMadeActionItem(
+                                        R.string.marked_as_read,
-            R.id.unread_action,
+                                        Toast.LENGTH_LONG,
-            resources.getDrawable(R.drawable.ic_baseline_white_eye_24dp),
+                                    ).show()
-            R.string.unmark,
+                                } else {
-            colorOnSurface,
+                                    CoroutineScope(Dispatchers.IO).launch {
-            colorSurface,
+                                        repository.unmarkAsRead(this@ArticleFragment.item)
-            requireContext(),
+                                    }
+                                    this@ArticleFragment.item.unread = true
+                                    Toast.makeText(
+                                        context,
+                                        R.string.marked_as_unread,
+                                        Toast.LENGTH_LONG,
+                                    ).show()
+                                }
+                            } catch (e: IllegalStateException) {
+                                e.sendSilentlyWithAcraWithName("Context required is null")
+                            }
+
+                        else -> Unit
+                    }
+                }
+
+                override fun onItemLongClick(item: MenuItem?) {
+                    // We do nothing
+                }
+            },
         )
+        return floatingToolbar
     }
 
     private fun refreshAlignment() {
@@ -271,7 +273,6 @@ class ArticleFragment :
             }
     }
 
-    @Suppress("detekt:SwallowedException")
     private fun getContentFromMercury() {
         binding.progressBar.visibility = View.VISIBLE
 
@@ -310,10 +311,17 @@ class ArticleFragment :
         }
     }
 
-    private fun handleLeadImage(leadImageUrl: String?) {
+    private fun handleLeadImage(lead_image_url: String?) {
-        if (!leadImageUrl.isNullOrEmpty() && context != null) {
+        if (!lead_image_url.isNullOrEmpty() && context != null) {
             binding.imageView.visibility = View.VISIBLE
-            requireContext().bitmapFitCenter(leadImageUrl, binding.imageView, appSettingsService)
+            Glide
+                .with(requireContext())
+                .asBitmap()
+                .load(
+                    lead_image_url,
+                )
+                .apply(RequestOptions.fitCenterTransform())
+                .into(binding.imageView)
         } else {
             binding.imageView.visibility = View.GONE
         }
@@ -326,85 +334,84 @@ class ArticleFragment :
                 override fun shouldOverrideUrlLoading(
                     view: WebView?,
                     url: String,
-                ): Boolean =
+                ): Boolean {
-                    if (context != null &&
+                    return if (context != null && url.isUrlValid() && binding.webcontent.hitTestResult.type != WebView.HitTestResult.SRC_IMAGE_ANCHOR_TYPE) {
-                        url.isUrlValid() &&
-                        binding.webcontent.hitTestResult.type != WebView.HitTestResult.SRC_IMAGE_ANCHOR_TYPE
-                    ) {
                         requireContext().openUrlInBrowser(url)
                         true
                     } else {
                         false
                     }
+                }
 
-                @Suppress("detekt:SwallowedException", "detekt:ReturnCount")
                 @Deprecated("Deprecated in Java")
                 override fun shouldInterceptRequest(
                     view: WebView,
                     url: String,
                 ): WebResourceResponse? {
-                    val (mime: String?, compression: Bitmap.CompressFormat) =
+                    val glideOptions = RequestOptions.diskCacheStrategyOf(DiskCacheStrategy.ALL)
-                        if (url
+                    if (url.lowercase(Locale.US).contains(".jpg") ||
-                                .lowercase(Locale.US)
+                        url.lowercase(Locale.US)
-                                .contains(".jpg") ||
+                            .contains(".jpeg")
-                            url.lowercase(Locale.US).contains(".jpeg")
+                    ) {
-                        ) {
+                        try {
-                            Pair(IMAGE_JPG, Bitmap.CompressFormat.JPEG)
+                            val image =
-                        } else if (url.lowercase(Locale.US).contains(".png")) {
+                                Glide.with(view).asBitmap().apply(glideOptions).load(url).submit()
-                            Pair(IMAGE_PNG, Bitmap.CompressFormat.PNG)
+                                    .get()
-                        } else if (url.lowercase(Locale.US).contains(".webp")) {
+                            return WebResourceResponse(
-                            Pair(IMAGE_WEBP, Bitmap.CompressFormat.WEBP)
+                                IMAGE_JPG,
-                        } else {
+                                "UTF-8",
-                            return super.shouldInterceptRequest(view, url)
+                                getBitmapInputStream(image, Bitmap.CompressFormat.JPEG),
+                            )
+                        } catch (e: ExecutionException) {
+                            // Do nothing
+                        }
+                    } else if (url.lowercase(Locale.US).contains(".png")) {
+                        try {
+                            val image =
+                                Glide.with(view).asBitmap().apply(glideOptions).load(url).submit()
+                                    .get()
+                            return WebResourceResponse(
+                                IMAGE_JPG,
+                                "UTF-8",
+                                getBitmapInputStream(image, Bitmap.CompressFormat.PNG),
+                            )
+                        } catch (e: ExecutionException) {
+                            // Do nothing
+                        }
+                    } else if (url.lowercase(Locale.US).contains(".webp")) {
+                        try {
+                            val image =
+                                Glide.with(view).asBitmap().apply(glideOptions).load(url).submit()
+                                    .get()
+                            return WebResourceResponse(
+                                IMAGE_JPG,
+                                "UTF-8",
+                                getBitmapInputStream(image, Bitmap.CompressFormat.WEBP),
+                            )
+                        } catch (e: ExecutionException) {
+                            // Do nothing
                         }
-
-                    try {
-                        val image = view.getGlideImageForResource(url, appSettingsService)
-                        return WebResourceResponse(
-                            mime,
-                            "UTF-8",
-                            getBitmapInputStream(image, compression),
-                        )
-                    } catch (e: ExecutionException) {
-                        return super.shouldInterceptRequest(view, url)
                     }
+
+                    return super.shouldInterceptRequest(view, url)
                 }
             }
     }
 
-    @Suppress("detekt:LongMethod", "detekt:ImplicitDefaultLocale")
     private fun htmlToWebview() {
-        val context: Context
-        try {
-            context = requireContext()
-        } catch (e: IllegalStateException) {
-            e.sendSilentlyWithAcraWithName("Context required is null")
-            return
-        }
-
         try {
             val attrs: IntArray = intArrayOf(android.R.attr.fontFamily)
-            val a: TypedArray = context.obtainStyledAttributes(resId, attrs)
+            val a: TypedArray = requireContext().obtainStyledAttributes(resId, attrs)
 
             binding.webcontent.settings.standardFontFamily = a.getString(0)
             binding.webcontent.visibility = View.VISIBLE
-        } catch (e: IllegalStateException) {
-            e.sendSilentlyWithAcraWithName("Context issue when setting attributes, but context wasn't null before")
-        }
 
-        val colorSurfaceString =
+            val colorOnSurface = TypedValue()
-            String.format(
+            requireContext().theme.resolveAttribute(R.attr.colorOnSurface, colorOnSurface, true)
-                "#%06X",
-                WHITE_COLOR_HEX and (if (colorSurface != DATA_NULL_UNDEFINED) colorSurface else WHITE_COLOR_HEX),
-            )
 
-        val colorOnSurfaceString =
+            val colorSurface = TypedValue()
-            String.format(
+            requireContext().theme.resolveAttribute(R.attr.colorSurface, colorSurface, true)
-                "#%06X",
-                WHITE_COLOR_HEX and (if (colorOnSurface != DATA_NULL_UNDEFINED) colorOnSurface else 0),
-            )
 
-        try {
             binding.webcontent.settings.useWideViewPort = true
             binding.webcontent.settings.loadWithOverviewMode = true
             binding.webcontent.settings.javaScriptEnabled = false
@@ -415,25 +422,19 @@ class ArticleFragment :
                 GestureDetector(
                     activity,
                     object : GestureDetector.SimpleOnGestureListener() {
-                        override fun onSingleTapUp(e: MotionEvent): Boolean = performClick()
+                        override fun onSingleTapUp(e: MotionEvent): Boolean {
+                            return performClick()
+                        }
                     },
                 )
 
-            binding.webcontent.setOnTouchListener { _, event ->
+            binding.webcontent.setOnTouchListener { _, event -> gestureDetector.onTouchEvent(event) }
-                gestureDetector.onTouchEvent(
-                    event,
-                )
-            }
 
             binding.webcontent.settings.layoutAlgorithm =
                 WebSettings.LayoutAlgorithm.TEXT_AUTOSIZING
-        } catch (e: IllegalStateException) {
-            e.sendSilentlyWithAcraWithName("Context is null but wasn't, and that's causing issues with webview config")
-            return
-        }
 
-        try {
             var baseUrl: String? = null
+
             try {
                 val itemUrl = URL(url)
                 baseUrl = itemUrl.protocol + "://" + itemUrl.host
@@ -483,12 +484,12 @@ class ArticleFragment :
                 |        color: ${
                     String.format(
                         "#%06X",
-                        WHITE_COLOR_HEX and context.resources.getColor(R.color.colorAccent),
+                        0xFFFFFF and resources.getColor(R.color.colorAccent),
                     )
                 } !important;
                 |      }
                 |      *:not(a) {
-                |        color: $colorOnSurfaceString;
+                |        color: ${String.format("#%06X", 0xFFFFFF and colorOnSurface.data)};
                 |      }
                 |      * {
                 |        font-size: ${fontSize}px;
@@ -496,11 +497,26 @@ class ArticleFragment :
                 |        word-break: break-word;
                 |        overflow:hidden;
                 |        line-height: 1.5em;
-                |        background-color: $colorSurfaceString;
+                |        background-color: ${
+                    String.format(
+                        "#%06X",
+                        0xFFFFFF and colorSurface.data,
+                    )
+                };
                 |      }
                 |      body, html {
-                |        background-color: $colorSurfaceString !important;
+                |        background-color: ${
-                |        border-color: $colorSurfaceString  !important;
+                    String.format(
+                        "#%06X",
+                        0xFFFFFF and colorSurface.data,
+                    )
+                } !important;
+                |        border-color: ${
+                    String.format(
+                        "#%06X",
+                        0xFFFFFF and colorSurface.data,
+                    )
+                }  !important;
                 |        padding: 0 !important;
                 |        margin: 0 !important;
                 |      }
@@ -510,7 +526,12 @@ class ArticleFragment :
                 |      pre, code {
                 |        white-space: pre-wrap;
                 |        width:100%;
-                |        background-color: $colorSurfaceString;
+                |        background-color: ${
+                    String.format(
+                        "#%06X",
+                        0xFFFFFF and colorSurface.data,
+                    )
+                };
                 |      }
                 |   </style>
                 |   $fontLinkAndStyle
@@ -524,16 +545,16 @@ class ArticleFragment :
                 null,
             )
         } catch (e: IllegalStateException) {
-            e.sendSilentlyWithAcraWithName("Context required is still null ?")
+            e.sendSilentlyWithAcraWithName("Context required is null")
         }
     }
 
-    fun volumeButtonScrollDown() {
+    fun scrollDown() {
         val height = binding.nestedScrollView.measuredHeight
         binding.nestedScrollView.smoothScrollBy(0, height / 2)
     }
 
-    fun volumeButtonScrollUp() {
+    fun scrollUp() {
         val height = binding.nestedScrollView.measuredHeight
         binding.nestedScrollView.smoothScrollBy(0, -height / 2)
     }
@@ -560,11 +581,10 @@ class ArticleFragment :
     }
 
     fun performClick(): Boolean {
-        if (allImages != null &&
+        if (allImages != null && (
-            (
+                    binding.webcontent.hitTestResult.type == WebView.HitTestResult.IMAGE_TYPE ||
-                binding.webcontent.hitTestResult.type == WebView.HitTestResult.IMAGE_TYPE ||
+                            binding.webcontent.hitTestResult.type == WebView.HitTestResult.SRC_IMAGE_ANCHOR_TYPE
-                    binding.webcontent.hitTestResult.type == WebView.HitTestResult.SRC_IMAGE_ANCHOR_TYPE
+                    )
-            )
         ) {
             val position: Int = allImages.indexOf(binding.webcontent.hitTestResult.extra)
 
@@ -576,4 +596,4 @@ class ArticleFragment :
         }
         return false
     }
-}
+}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/FilterSheetFragment.kt

@@ -16,12 +16,11 @@ import bou.amine.apps.readerforselfossv2.android.HomeActivity
 import bou.amine.apps.readerforselfossv2.android.R
 import bou.amine.apps.readerforselfossv2.android.databinding.FilterFragmentBinding
 import bou.amine.apps.readerforselfossv2.android.utils.acra.sendSilentlyWithAcraWithName
-import bou.amine.apps.readerforselfossv2.android.utils.glide.imageIntoViewTarget
 import bou.amine.apps.readerforselfossv2.repository.Repository
-import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 import bou.amine.apps.readerforselfossv2.utils.getColorHexCode
 import bou.amine.apps.readerforselfossv2.utils.getHtmlDecoded
 import bou.amine.apps.readerforselfossv2.utils.getIcon
+import com.bumptech.glide.Glide
 import com.bumptech.glide.request.target.ViewTarget
 import com.bumptech.glide.request.transition.Transition
 import com.google.android.material.bottomsheet.BottomSheetDialogFragment
@@ -34,15 +33,10 @@ import org.kodein.di.DIAware
 import org.kodein.di.android.x.closestDI
 import org.kodein.di.instance
 
-private const val DRAWABLE_SIZE = 30
+class FilterSheetFragment : BottomSheetDialogFragment(), DIAware {
-
-class FilterSheetFragment :
-    BottomSheetDialogFragment(),
-    DIAware {
     private lateinit var binding: FilterFragmentBinding
     override val di: DI by closestDI()
     private val repository: Repository by instance()
-    private val appSettingsService: AppSettingsService by instance()
 
     private var selectedChip: Chip? = null
 
@@ -86,22 +80,22 @@ class FilterSheetFragment :
             val c = Chip(context)
             c.ellipsize = TextUtils.TruncateAt.END
 
-            context.imageIntoViewTarget(
+            Glide.with(context)
-                source.getIcon(repository.baseUrl),
+                .load(source.getIcon(repository.baseUrl))
-                object : ViewTarget<Chip?, Drawable?>(c) {
+                .into(
-                    override fun onResourceReady(
+                    object : ViewTarget<Chip?, Drawable?>(c) {
-                        resource: Drawable,
+                        override fun onResourceReady(
-                        transition: Transition<in Drawable?>?,
+                            resource: Drawable,
-                    ) {
+                            transition: Transition<in Drawable?>?,
-                        try {
+                        ) {
-                            c.chipIcon = resource
+                            try {
-                        } catch (e: Exception) {
+                                c.chipIcon = resource
-                            e.sendSilentlyWithAcraWithName("sources > onResourceReady")
+                            } catch (e: Exception) {
+                                e.sendSilentlyWithAcraWithName("sources > onResourceReady")
+                            }
                         }
-                    }
+                    },
-                },
+                )
-                appSettingsService,
-            )
 
             c.text = source.title.getHtmlDecoded()
 
@@ -159,8 +153,8 @@ class FilterSheetFragment :
                         }
                     gd.setColor(gdColor)
                     gd.shape = GradientDrawable.RECTANGLE
-                    gd.setSize(DRAWABLE_SIZE, DRAWABLE_SIZE)
+                    gd.setSize(30, 30)
-                    gd.cornerRadius = DRAWABLE_SIZE.toFloat()
+                    gd.cornerRadius = 30F
                     c.chipIcon = gd
                 } catch (e: Exception) {
                     e.sendSilentlyWithAcraWithName("tags > GradientDrawable")
@@ -196,4 +190,4 @@ class FilterSheetFragment :
     companion object {
         const val TAG = "FilterModalBottomSheet"
     }
-}
+}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/ImageFragment.kt

@@ -6,21 +6,15 @@ import android.view.View
 import android.view.ViewGroup
 import androidx.fragment.app.Fragment
 import bou.amine.apps.readerforselfossv2.android.databinding.FragmentImageBinding
-import bou.amine.apps.readerforselfossv2.android.utils.glide.bitmapWithCache
+import com.bumptech.glide.Glide
-import bou.amine.apps.readerforselfossv2.service.AppSettingsService
+import com.bumptech.glide.load.engine.DiskCacheStrategy
-import org.kodein.di.DI
+import com.bumptech.glide.request.RequestOptions
-import org.kodein.di.DIAware
-import org.kodein.di.android.x.closestDI
-import org.kodein.di.instance
 
-class ImageFragment :
+class ImageFragment : Fragment() {
-    Fragment(),
-    DIAware {
-    override val di: DI by closestDI()
-    private val appSettingsService: AppSettingsService by instance()
     private lateinit var imageUrl: String
+    private val glideOptions = RequestOptions.diskCacheStrategyOf(DiskCacheStrategy.ALL)
     private var _binding: FragmentImageBinding? = null
-    val binding get() = _binding
+    private val binding get() = _binding
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
@@ -37,7 +31,11 @@ class ImageFragment :
         val view = binding?.root
 
         binding!!.photoView.visibility = View.VISIBLE
-        requireActivity().bitmapWithCache(imageUrl, binding!!.photoView, appSettingsService)
+        Glide.with(requireActivity())
+            .asBitmap()
+            .apply(glideOptions)
+            .load(imageUrl)
+            .into(binding!!.photoView)
 
         return view
     }

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/model/AndroidIModelUtils.kt

@@ -3,21 +3,23 @@ package bou.amine.apps.readerforselfossv2.android.model
 import android.content.Context
 import android.webkit.URLUtil
 import bou.amine.apps.readerforselfossv2.android.utils.acra.sendSilentlyWithAcraWithName
-import bou.amine.apps.readerforselfossv2.android.utils.glide.preloadImage
 import bou.amine.apps.readerforselfossv2.model.SelfossModel
-import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 import bou.amine.apps.readerforselfossv2.utils.getImages
+import com.bumptech.glide.Glide
+import com.bumptech.glide.load.engine.DiskCacheStrategy
+import com.bumptech.glide.request.RequestOptions
 
-fun SelfossModel.Item.preloadImages(
+fun SelfossModel.Item.preloadImages(context: Context): Boolean {
-    context: Context,
-    appSettingsService: AppSettingsService,
-): Boolean {
     val imageUrls = this.getImages()
 
+    val glideOptions = RequestOptions.diskCacheStrategyOf(DiskCacheStrategy.ALL).timeout(10000)
+
     try {
         for (url in imageUrls) {
             if (URLUtil.isValidUrl(url)) {
-                context.preloadImage(url, appSettingsService)
+                Glide.with(context).asBitmap()
+                    .apply(glideOptions)
+                    .load(url).submit()
             }
         }
     } catch (e: Error) {
@@ -38,4 +40,4 @@ fun String.toTextDrawableString(): String {
         }
     }
     return textDrawable.toString()
-}
+}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/settings/SettingsActivity.kt

@@ -17,19 +17,12 @@ import bou.amine.apps.readerforselfossv2.android.databinding.ActivitySettingsBin
 import bou.amine.apps.readerforselfossv2.android.utils.acra.sendSilentlyWithAcraWithName
 import bou.amine.apps.readerforselfossv2.android.utils.openUrlInBrowser
 import bou.amine.apps.readerforselfossv2.service.AppSettingsService
-import bou.amine.apps.readerforselfossv2.service.AppSettingsService.Companion.API_ITEMS_NUMBER
-import bou.amine.apps.readerforselfossv2.service.AppSettingsService.Companion.CURRENT_THEME
-import bou.amine.apps.readerforselfossv2.service.AppSettingsService.Companion.READER_FONT_SIZE
 import com.mikepenz.aboutlibraries.LibsBuilder
 import org.kodein.di.DIAware
 import org.kodein.di.android.closestDI
 
 private const val TITLE_TAG = "settingsActivityTitle"
 
-const val MAX_ITEMS_NUMBER = 200
-
-private const val MIN_ITEMS_NUMBER = 1
-
 class SettingsActivity :
     AppCompatActivity(),
     PreferenceFragmentCompat.OnPreferenceStartFragmentCallback,
@@ -68,14 +61,15 @@ class SettingsActivity :
         outState.putCharSequence(TITLE_TAG, title)
     }
 
-    override fun onSupportNavigateUp(): Boolean =
+    override fun onSupportNavigateUp(): Boolean {
-        if (supportFragmentManager.popBackStackImmediate()) {
+        return if (supportFragmentManager.popBackStackImmediate()) {
             supportActionBar?.title = getText(R.string.title_activity_settings)
             false
         } else {
             super.onBackPressed()
             true
         }
+    }
 
     override fun onPreferenceStartFragment(
         caller: PreferenceFragmentCompat,
@@ -84,17 +78,15 @@ class SettingsActivity :
         // Instantiate the new Fragment
         val args = pref.extras
         val fragment =
-            supportFragmentManager.fragmentFactory
+            supportFragmentManager.fragmentFactory.instantiate(
-                .instantiate(
+                classLoader,
-                    classLoader,
+                pref.fragment.toString(),
-                    pref.fragment.toString(),
+            ).apply {
-                ).apply {
+                arguments = args
-                    arguments = args
+                setTargetFragment(caller, 0)
-                    setTargetFragment(caller, 0)
+            }
-                }
         // Replace the existing Fragment with the new Fragment
-        supportFragmentManager
+        supportFragmentManager.beginTransaction()
-            .beginTransaction()
             .replace(R.id.settings, fragment)
             .addToBackStack(null)
             .commit()
@@ -110,10 +102,10 @@ class SettingsActivity :
         ) {
             setPreferencesFromResource(R.xml.pref_main, rootKey)
 
-            preferenceManager.findPreference<Preference>(CURRENT_THEME)?.onPreferenceChangeListener =
+            preferenceManager.findPreference<Preference>("currentMode")?.onPreferenceChangeListener =
                 Preference.OnPreferenceChangeListener { _, newValue ->
                     AppCompatDelegate.setDefaultNightMode(
-                        newValue.toString().toInt(),
+                        newValue.toString().toInt()
                     ) // ListPreference Only takes string-arrays ¯\_(ツ)_/¯
                     true
                 }
@@ -139,7 +131,7 @@ class SettingsActivity :
             setPreferencesFromResource(R.xml.pref_general, rootKey)
 
             val editTextPreference =
-                preferenceManager.findPreference<EditTextPreference>(API_ITEMS_NUMBER)
+                preferenceManager.findPreference<EditTextPreference>("prefer_api_items_number")
             editTextPreference?.setOnBindEditTextListener { editText ->
                 editText.inputType = InputType.TYPE_CLASS_NUMBER
                 editText.filters =
@@ -147,14 +139,13 @@ class SettingsActivity :
                         InputFilter { source, _, _, dest, _, _ ->
                             try {
                                 val input: Int = (dest.toString() + source.toString()).toInt()
-                                if (input in MIN_ITEMS_NUMBER..MAX_ITEMS_NUMBER) return@InputFilter null
+                                if (input in 1..200) return@InputFilter null
                             } catch (nfe: NumberFormatException) {
-                                Toast
+                                Toast.makeText(
-                                    .makeText(
+                                    activity,
-                                        activity,
+                                    R.string.items_number_should_be_number,
-                                        R.string.items_number_should_be_number,
+                                    Toast.LENGTH_LONG
-                                        Toast.LENGTH_LONG,
+                                ).show()
-                                    ).show()
                             }
                             ""
                         },
@@ -170,7 +161,7 @@ class SettingsActivity :
         ) {
             setPreferencesFromResource(R.xml.pref_viewer, rootKey)
 
-            val fontSize = preferenceManager.findPreference<EditTextPreference>(READER_FONT_SIZE)
+            val fontSize = preferenceManager.findPreference<EditTextPreference>("reader_font_size")
             fontSize?.setOnBindEditTextListener { editText ->
                 editText.inputType = InputType.TYPE_CLASS_NUMBER
                 editText.addTextChangedListener {
@@ -227,6 +218,23 @@ class SettingsActivity :
         }
     }
 
+    class ThemePreferenceFragment : PreferenceFragmentCompat() {
+        override fun onCreatePreferences(
+            savedInstanceState: Bundle?,
+            rootKey: String?,
+        ) {
+            setPreferencesFromResource(R.xml.pref_theme, rootKey)
+
+            preferenceManager.findPreference<Preference>("currentMode")?.onPreferenceChangeListener =
+                Preference.OnPreferenceChangeListener { _, newValue ->
+                    AppCompatDelegate.setDefaultNightMode(
+                        newValue.toString().toInt()
+                    ) // ListPreference Only takes string-arrays ¯\_(ツ)_/¯
+                    true
+                }
+        }
+    }
+
     class LinksPreferenceFragment : PreferenceFragmentCompat() {
         private fun openUrl(url: String) {
             context?.openUrlInBrowser(url)
@@ -240,19 +248,19 @@ class SettingsActivity :
 
             preferenceManager.findPreference<Preference>("trackerLink")?.onPreferenceClickListener =
                 Preference.OnPreferenceClickListener {
-                    openUrl(AppSettingsService.BUG_URL)
+                    openUrl(AppSettingsService.trackerUrl)
                     true
                 }
 
             preferenceManager.findPreference<Preference>("sourceLink")?.onPreferenceClickListener =
                 Preference.OnPreferenceClickListener {
-                    openUrl(AppSettingsService.SOURCE_URL)
+                    openUrl(AppSettingsService.sourceUrl)
                     false
                 }
 
             preferenceManager.findPreference<Preference>("translation")?.onPreferenceClickListener =
                 Preference.OnPreferenceClickListener {
-                    openUrl(AppSettingsService.TRANSLATION_URL)
+                    openUrl(AppSettingsService.translationUrl)
                     false
                 }
         }
@@ -266,4 +274,4 @@ class SettingsActivity :
             setPreferencesFromResource(R.xml.pref_experimental, rootKey)
         }
     }
-}
+}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/testing/CountingIdlingResourceSingleton.kt

@@ -3,6 +3,7 @@ package bou.amine.apps.readerforselfossv2.android.testing
 import androidx.test.espresso.idling.CountingIdlingResource
 
 object CountingIdlingResourceSingleton {
+
     private const val RESOURCE = "GLOBAL"
 
     @JvmField
@@ -17,4 +18,4 @@ object CountingIdlingResourceSingleton {
             countingIdlingResource.decrement()
         }
     }
-}
+}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/testing/TestingHelper.kt

@@ -2,6 +2,7 @@ package bou.amine.apps.readerforselfossv2.android.testing
 
 import android.os.Build
 
+
 class TestingHelper {
     fun isUnitTest(): Boolean {
         var device = Build.DEVICE
@@ -15,4 +16,4 @@ class TestingHelper {
         }
         return device == "robolectric" && product == "robolectric"
     }
-}
+}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/AppUtils.kt

@@ -2,11 +2,7 @@ package bou.amine.apps.readerforselfossv2.android.utils
 
 import android.content.Context
 import android.content.Intent
-import android.util.TypedValue
-import androidx.annotation.AttrRes
-import androidx.annotation.ColorInt
 import bou.amine.apps.readerforselfossv2.android.R
-import bou.amine.apps.readerforselfossv2.android.utils.acra.sendSilentlyWithAcraWithName
 import bou.amine.apps.readerforselfossv2.utils.toStringUriWithHttp
 
 fun Context.shareLink(
@@ -20,24 +16,9 @@ fun Context.shareLink(
     sendIntent.putExtra(Intent.EXTRA_SUBJECT, itemTitle)
     sendIntent.type = "text/plain"
     startActivity(
-        Intent
+        Intent.createChooser(
-            .createChooser(
+            sendIntent,
-                sendIntent,
+            getString(R.string.share),
-                getString(R.string.share),
+        ).setFlags(Intent.FLAG_ACTIVITY_NEW_TASK),
-            ).setFlags(Intent.FLAG_ACTIVITY_NEW_TASK),
     )
 }
-
-@ColorInt
-fun Context.getColorFromAttr(
-    @AttrRes attrColor: Int,
-    resolveRefs: Boolean = true,
-): Int {
-    val typedValue = TypedValue()
-    try {
-        this.theme.resolveAttribute(attrColor, typedValue, resolveRefs)
-    } catch (e: Throwable) {
-        e.sendSilentlyWithAcraWithName("ColorFromAttr")
-    }
-    return typedValue.data
-}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/CircleImageView.kt

@@ -59,5 +59,7 @@ class CircleImageView
             textView.text = text.toTextDrawableString()
         }
 
-        private fun colorFromIdentifier(key: String): Int = colorScheme[abs(key.hashCode()) % colorScheme.size]
+        private fun colorFromIdentifier(key: String): Int {
+            return colorScheme[abs(key.hashCode()) % colorScheme.size]
+        }
     }

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/LinksUtils.kt

@@ -18,6 +18,7 @@ import bou.amine.apps.readerforselfossv2.model.SelfossModel
 import bou.amine.apps.readerforselfossv2.utils.toStringUriWithHttp
 import okhttp3.HttpUrl.Companion.toHttpUrlOrNull
 
+
 fun Context.openItemUrl(
     currentItem: Int,
     linkDecoded: String,
@@ -25,12 +26,11 @@ fun Context.openItemUrl(
     app: Activity,
 ) {
     if (!linkDecoded.isUrlValid()) {
-        Toast
+        Toast.makeText(
-            .makeText(
+            this,
-                this,
+            this.getString(R.string.cant_open_invalid_url),
-                this.getString(R.string.cant_open_invalid_url),
+            Toast.LENGTH_LONG,
-                Toast.LENGTH_LONG,
+        ).show()
-            ).show()
     } else {
         if (articleViewer) {
             val intent = Intent(this, ReaderActivity::class.java)
@@ -42,7 +42,8 @@ fun Context.openItemUrl(
     }
 }
 
-fun String.isUrlValid(): Boolean = this.toHttpUrlOrNull() != null && Patterns.WEB_URL.matcher(this).matches()
+fun String.isUrlValid(): Boolean =
+    this.toHttpUrlOrNull() != null && Patterns.WEB_URL.matcher(this).matches()
 
 fun String.isBaseUrlInvalid(): Boolean {
     val baseUrl = this.toHttpUrlOrNull()
@@ -60,6 +61,7 @@ fun Context.openItemUrlInBrowserAsNewTask(i: SelfossModel.Item) {
 }
 
 fun Context.openUrlInBrowserAsNewTask(url: String) {
+
     val intent = Intent(Intent.ACTION_VIEW)
     intent.flags = Intent.FLAG_ACTIVITY_NEW_TASK
     intent.data = Uri.parse(url)
@@ -72,13 +74,13 @@ fun Context.openUrlInBrowser(url: String) {
     this.mayBeStartActivity(intent)
 }
 
-@Suppress("detekt:SwallowedException")
 fun Context.mayBeStartActivity(intent: Intent) {
     try {
         this.startActivity(intent)
     } catch (e: ActivityNotFoundException) {
         Toast.makeText(this, getString(R.string.no_browser), Toast.LENGTH_SHORT).show()
     }
+
 }
 
 class LinkOnTouchListener : View.OnTouchListener {
@@ -120,4 +122,4 @@ class LinkOnTouchListener : View.OnTouchListener {
         }
         return ret
     }
-}
+}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/acra/ACRAUtils.kt

@@ -6,4 +6,4 @@ import org.acra.ktx.sendSilentlyWithAcra
 fun Throwable.sendSilentlyWithAcraWithName(name: String) {
     ACRA.errorReporter.putCustomData("error_source", name)
     this.sendSilentlyWithAcra()
-}
+}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/acra/AcraReportingAdministrator.kt

@@ -8,19 +8,22 @@ import org.acra.config.CoreConfiguration
 import org.acra.config.ReportingAdministrator
 import org.acra.data.CrashReportData
 
+
 @AutoService(ReportingAdministrator::class)
 class AcraReportingAdministrator : ReportingAdministrator {
     override fun shouldStartCollecting(
         context: Context,
         config: CoreConfiguration,
-        reportBuilder: ReportBuilder,
+        reportBuilder: ReportBuilder
-    ): Boolean =
+    ): Boolean {
-        reportBuilder.exception !is DeadSystemException &&
+        return reportBuilder.exception !is DeadSystemException && (reportBuilder.exception != null && reportBuilder.exception!!::class.simpleName != "CannotDeliverBroadcastException")
-            (reportBuilder.exception != null && reportBuilder.exception!!::class.simpleName != "CannotDeliverBroadcastException")
+    }
 
     override fun shouldSendReport(
         context: Context,
         config: CoreConfiguration,
-        crashReportData: CrashReportData,
+        crashReportData: CrashReportData
-    ): Boolean = crashReportData.get("BRAND") != "redroid"
+    ): Boolean {
-}
+        return crashReportData.get("BRAND") != "redroid"
+    }
+}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/bottombar/BottomBarUtils.kt

@@ -1,13 +1,6 @@
 package bou.amine.apps.readerforselfossv2.android.utils.bottombar
 
-import android.content.Context
-import android.graphics.drawable.Drawable
-import androidx.annotation.IdRes
-import androidx.annotation.StringRes
-import bou.amine.apps.readerforselfossv2.android.R
 import com.ashokvarma.bottomnavigation.TextBadgeItem
-import com.leinardi.android.speeddial.SpeedDialActionItem
-import com.leinardi.android.speeddial.SpeedDialView
 
 fun TextBadgeItem.removeBadge(): TextBadgeItem {
     this.setText("")
@@ -16,25 +9,3 @@ fun TextBadgeItem.removeBadge(): TextBadgeItem {
 }
 
 fun TextBadgeItem.maybeShow(): TextBadgeItem = if (this.isHidden) this.show() else this
-
-@Suppress("detekt:LongParameterList")
-fun SpeedDialView.addHomeMadeActionItem(
-    @IdRes actionId: Int,
-    actionIcon: Drawable,
-    @StringRes labelId: Int,
-    colorOnSurface: Int,
-    colorSurface: Int,
-    context: Context,
-) {
-    this.addActionItem(
-        SpeedDialActionItem
-            .Builder(actionId, actionIcon)
-            .setFabBackgroundColor(context.resources.getColor(R.color.colorAccent))
-            .setFabImageTintColor(colorOnSurface)
-            .setLabel(context.getString(labelId))
-            .setLabelClickable(false)
-            .setLabelBackgroundColor(colorOnSurface)
-            .setLabelColor(colorSurface)
-            .create(),
-    )
-}

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/glide/GlideUtils.kt

@@ -2,134 +2,40 @@ package bou.amine.apps.readerforselfossv2.android.utils.glide
 
 import android.content.Context
 import android.graphics.Bitmap
-import android.graphics.drawable.Drawable
-import android.webkit.WebView
 import android.widget.ImageView
 import bou.amine.apps.readerforselfossv2.android.utils.CircleImageView
-import bou.amine.apps.readerforselfossv2.service.AppSettingsService
-import bou.amine.apps.readerforselfossv2.utils.isEmptyOrNullOrNullString
 import com.bumptech.glide.Glide
-import com.bumptech.glide.load.engine.DiskCacheStrategy
-import com.bumptech.glide.load.model.GlideUrl
-import com.bumptech.glide.load.model.LazyHeaders
 import com.bumptech.glide.request.RequestOptions
-import com.bumptech.glide.request.target.ViewTarget
-import com.google.android.material.chip.Chip
 import java.io.ByteArrayInputStream
 import java.io.ByteArrayOutputStream
 import java.io.InputStream
-import kotlin.io.encoding.Base64
-import kotlin.io.encoding.ExperimentalEncodingApi
-
-private const val PRELOAD_IMAGE_TIMEOUT = 10000
-
-@OptIn(ExperimentalEncodingApi::class)
-fun String.toGlideUrl(appSettingsService: AppSettingsService): GlideUrl {
-    if (this.isEmptyOrNullOrNullString()) {
-        return GlideUrl("")
-    }
-    if (appSettingsService.getBasicUserName().isNotEmpty()) {
-        val authString = "${appSettingsService.getBasicUserName()}:${appSettingsService.getBasicPassword()}"
-        val authBuf = Base64.encode(authString.toByteArray(Charsets.UTF_8))
-
-        return GlideUrl(
-            this,
-            LazyHeaders
-                .Builder()
-                .addHeader("Authorization", "Basic $authBuf")
-                .build(),
-        )
-    } else {
-        return GlideUrl(
-            this,
-        )
-    }
-}
-
-fun WebView.getGlideImageForResource(
-    url: String,
-    appSettingsService: AppSettingsService,
-) = Glide
-    .with(this)
-    .asBitmap()
-    .apply(RequestOptions.diskCacheStrategyOf(DiskCacheStrategy.ALL))
-    .load(url.toGlideUrl(appSettingsService))
-    .submit()
-    .get()
-
-fun Context.preloadImage(
-    url: String,
-    appSettingsService: AppSettingsService,
-) = Glide
-    .with(this)
-    .asBitmap()
-    .apply(RequestOptions.diskCacheStrategyOf(DiskCacheStrategy.ALL).timeout(PRELOAD_IMAGE_TIMEOUT))
-    .load(url.toGlideUrl(appSettingsService))
-    .submit()
-
-fun Context.imageIntoViewTarget(
-    url: String,
-    target: ViewTarget<Chip?, Drawable?>,
-    appSettingsService: AppSettingsService,
-) = Glide
-    .with(this)
-    .load(url.toGlideUrl(appSettingsService))
-    .into(target)
-
-fun Context.bitmapWithCache(
-    url: String,
-    iv: ImageView,
-    appSettingsService: AppSettingsService,
-) = Glide
-    .with(this)
-    .asBitmap()
-    .apply(RequestOptions.diskCacheStrategyOf(DiskCacheStrategy.ALL))
-    .load(url.toGlideUrl(appSettingsService))
-    .into(iv)
 
 fun Context.bitmapCenterCrop(
     url: String,
     iv: ImageView,
-    appSettingsService: AppSettingsService,
+) = Glide.with(this)
-) = Glide
-    .with(this)
     .asBitmap()
-    .load(url.toGlideUrl(appSettingsService))
+    .load(url)
     .apply(RequestOptions.centerCropTransform())
     .into(iv)
 
-fun Context.bitmapFitCenter(
-    url: String,
-    iv: ImageView,
-    appSettingsService: AppSettingsService,
-) = Glide
-    .with(this)
-    .asBitmap()
-    .load(url.toGlideUrl(appSettingsService))
-    .apply(RequestOptions.fitCenterTransform())
-    .into(iv)
-
 fun Context.circularDrawable(
     url: String,
     view: CircleImageView,
-    appSettingsService: AppSettingsService,
 ) {
     view.textView.text = ""
 
-    Glide
+    Glide.with(this)
-        .with(this)
+        .load(url)
-        .load(url.toGlideUrl(appSettingsService))
         .into(view.imageView)
 }
 
-private const val BITMAP_INPUT_STREAM_COMPRESSION_QUALITY = 80
-
 fun getBitmapInputStream(
     bitmap: Bitmap,
     compressFormat: Bitmap.CompressFormat,
 ): InputStream {
     val byteArrayOutputStream = ByteArrayOutputStream()
-    bitmap.compress(compressFormat, BITMAP_INPUT_STREAM_COMPRESSION_QUALITY, byteArrayOutputStream)
+    bitmap.compress(compressFormat, 80, byteArrayOutputStream)
     val bitmapData: ByteArray = byteArrayOutputStream.toByteArray()
     return ByteArrayInputStream(bitmapData)
 }

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/network/NetworkUtils.kt

@@ -3,6 +3,7 @@ package bou.amine.apps.readerforselfossv2.android.utils.network
 import android.content.Context
 import android.net.ConnectivityManager
 import android.net.NetworkCapabilities
+import android.os.Build
 import com.google.android.material.snackbar.Snackbar
 
 lateinit var s: Snackbar
@@ -10,13 +11,19 @@ lateinit var s: Snackbar
 fun isNetworkAccessible(context: Context): Boolean {
     val connectivityManager = context.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager
 
-    val networkCapabilities = connectivityManager.getNetworkCapabilities(connectivityManager.activeNetwork) ?: return false
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
+        val network = connectivityManager.activeNetwork ?: return false
+        val networkCapabilities = connectivityManager.getNetworkCapabilities(network) ?: return false
 
-    return when {
+        return when {
-        networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_BLUETOOTH) -> true
+            networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_BLUETOOTH) -> true
-        networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_CELLULAR) -> true
+            networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_CELLULAR) -> true
-        networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_ETHERNET) -> true
+            networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_ETHERNET) -> true
-        networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_WIFI) -> true
+            networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_WIFI) -> true
-        else -> false
+            else -> false
+        }
+    } else {
+        val network = connectivityManager.activeNetworkInfo ?: return false
+        return network.isConnectedOrConnecting
     }
 }

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/viewmodel/AppViewModel.kt

@@ -7,9 +7,7 @@ import kotlinx.coroutines.flow.MutableSharedFlow
 import kotlinx.coroutines.flow.asSharedFlow
 import kotlinx.coroutines.launch
 
-class AppViewModel(
+class AppViewModel(private val repository: Repository) : ViewModel() {
-    private val repository: Repository,
-) : ViewModel() {
     private val _networkAvailableProvider = MutableSharedFlow<Boolean>()
     val networkAvailableProvider = _networkAvailableProvider.asSharedFlow()
     private var wasConnected = true
@@ -21,10 +19,11 @@ class AppViewModel(
                     if (isConnected && !wasConnected && repository.connectionMonitored) {
                         _networkAvailableProvider.emit(true)
                         wasConnected = true
-                    } else if (!isConnected && wasConnected && repository.connectionMonitored) {
+                    } else if (!isConnected && wasConnected && repository.connectionMonitored)
-                        _networkAvailableProvider.emit(false)
+                        {
-                        wasConnected = false
+                            _networkAvailableProvider.emit(false)
-                    }
+                            wasConnected = false
+                        }
                 }
             }
         }

androidApp/src/main/res/layout/fragment_article.xml

@@ -71,13 +71,35 @@
 
     </androidx.core.widget.NestedScrollView>
 
-    <com.leinardi.android.speeddial.SpeedDialView
+    <FrameLayout
-        android:id="@+id/speedDial"
+        android:layout_width="match_parent"
-        android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_gravity="bottom|end"
+        android:layout_gravity="start|bottom|end"
-        app:layout_behavior="@string/speeddial_scrolling_view_snackbar_behavior"
+        app:layout_constraintBottom_toBottomOf="parent"
-        app:sdMainFabClosedSrc="@drawable/ic_add_white_24dp" />
+        app:layout_constraintEnd_toEndOf="parent"
+        app:layout_constraintStart_toStartOf="parent">
+
+        <com.github.rubensousa.floatingtoolbar.FloatingToolbar
+            android:id="@+id/floatingToolbar"
+            android:layout_width="match_parent"
+            android:layout_height="?attr/actionBarSize"
+            android:layout_gravity="bottom"
+            app:floatingMenu="@menu/reader_toolbar" />
+
+        <com.google.android.material.floatingactionbutton.FloatingActionButton
+            android:id="@+id/fab"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_gravity="end|bottom"
+            android:layout_marginEnd="16dp"
+            android:layout_marginBottom="16dp"
+            android:paddingTop="@dimen/activity_vertical_margin"
+            android:paddingBottom="@dimen/activity_vertical_margin"
+            android:src="@drawable/ic_add_white_24dp"
+            app:backgroundTint="?attr/colorAccent"
+            app:fabSize="mini"
+            app:rippleColor="?attr/colorAccentDark" />
+    </FrameLayout>
 
     <FrameLayout
         android:id="@+id/progressBar"
@@ -97,5 +119,4 @@
             android:progressTint="?attr/colorAccent" />
     </FrameLayout>
 
-
+</androidx.coordinatorlayout.widget.CoordinatorLayout>
-</androidx.coordinatorlayout.widget.CoordinatorLayout>

androidApp/src/main/res/menu/reader_toolbar.xml

@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="utf-8"?>
+<menu xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto">
+
+    <item
+        android:id="@+id/unread_action"
+        android:icon="@drawable/ic_baseline_white_eye_24dp"
+        android:title="@string/unmark"
+        app:showAsAction="ifRoom" />
+
+    <item
+        android:id="@+id/open_action"
+        android:icon="@drawable/ic_open_in_browser_white_24dp"
+        android:title="@string/reader_action_open"
+        app:showAsAction="ifRoom" />
+
+    <item
+        android:id="@+id/share_action"
+        android:icon="@drawable/ic_share_white_24dp"
+        android:title="@string/reader_action_share"
+        app:showAsAction="ifRoom" />
+
+</menu>

androidApp/src/main/res/values-ca-rES/strings.xml

@@ -106,6 +106,9 @@
     <string name="reader_text_align_left">Align left</string>
     <string name="reader_text_align_justify">Justify</string>
     <string name="settings_reader_font">Reader font</string>
+    <string name="reader_static_bar_title">Static bottom bar in the article viewer</string>
+    <string name="reader_static_bar_on">The bottom bar will always be displayed</string>
+    <string name="reader_static_bar_off">The bottom bar can be shown through the floating button</string>
     <string name="remove_source">Remove source</string>
     <string name="pref_theme_title">Light/Dark mode</string>
     <string name="mode_dark">Dark mode</string>
@@ -129,4 +132,4 @@
     <string name="action_about">"Quant a"</string>
     <string name="marked_as_read">"Element llegit"</string>
     <string name="marked_as_unread">"Item unread"</string>
-</resources>
+</resources>

androidApp/src/main/res/values-de-rDE/strings.xml

@@ -106,6 +106,9 @@
     <string name="reader_text_align_left">Linksbündig</string>
     <string name="reader_text_align_justify">Blocksatz</string>
     <string name="settings_reader_font">Schriftgröße im Lesemodus</string>
+    <string name="reader_static_bar_title">Statische untere Leiste im Lesemodus</string>
+    <string name="reader_static_bar_on">Die untere Leiste wird dauerhaft angezeigt</string>
+    <string name="reader_static_bar_off">Die untere Leiste kann über einen schwebenden Button angezeigt werden</string>
     <string name="remove_source">Quelle entfernen</string>
     <string name="pref_theme_title">Heller/Dunkler Modus</string>
     <string name="mode_dark">Dunkler Modus</string>
@@ -129,4 +132,4 @@
     <string name="action_about">"Über"</string>
     <string name="marked_as_read">"Artikel gelesen"</string>
     <string name="marked_as_unread">"Item unread"</string>
-</resources>
+</resources>

androidApp/src/main/res/values-es-rES/strings.xml

@@ -106,6 +106,9 @@
     <string name="reader_text_align_left">Alinear a la izquierda</string>
     <string name="reader_text_align_justify">Justificado</string>
     <string name="settings_reader_font">Modo lectura</string>
+    <string name="reader_static_bar_title">Static bottom bar in the article viewer</string>
+    <string name="reader_static_bar_on">The bottom bar will always be displayed</string>
+    <string name="reader_static_bar_off">The bottom bar can be shown through the floating button</string>
     <string name="remove_source">Remove source</string>
     <string name="pref_theme_title">Light/Dark mode</string>
     <string name="mode_dark">Dark mode</string>
@@ -129,4 +132,4 @@
     <string name="action_about">"Acerca de"</string>
     <string name="marked_as_read">"Artículo leído"</string>
     <string name="marked_as_unread">"Artículo no leído"</string>
-</resources>
+</resources>

androidApp/src/main/res/values-fr-rFR/strings.xml

@@ -106,6 +106,9 @@
     <string name="reader_text_align_left">Aligner à gauche</string>
     <string name="reader_text_align_justify">Justifier le texte</string>
     <string name="settings_reader_font">Police du lecteur d\'articles</string>
+    <string name="reader_static_bar_title">Barre statique pour le visionneur d\'articles</string>
+    <string name="reader_static_bar_on">La barre sera affichée</string>
+    <string name="reader_static_bar_off">La barre sera affichée grâce au bouton</string>
     <string name="remove_source">Supprimer la source</string>
     <string name="pref_theme_title">Thème Clair/Sombre</string>
     <string name="mode_dark">Thème sombre</string>
@@ -129,4 +132,4 @@
     <string name="action_about">"À propos"</string>
     <string name="marked_as_read">"Marqué comme lu"</string>
     <string name="marked_as_unread">"Marqué comme non lu"</string>
-</resources>
+</resources>

androidApp/src/main/res/values-gl-rES/strings.xml

@@ -106,6 +106,9 @@
     <string name="reader_text_align_left">Aliñar á esquerda</string>
     <string name="reader_text_align_justify">Xustificado</string>
     <string name="settings_reader_font">Modo lector</string>
+    <string name="reader_static_bar_title">Barra inferior estática na vista de artigos</string>
+    <string name="reader_static_bar_on">A barra inferior mostrarase sempre</string>
+    <string name="reader_static_bar_off">A barra inferior pode mostrarse a través do botón flotante</string>
     <string name="remove_source">Eliminar fonte</string>
     <string name="pref_theme_title">Modo Claro/Escuro</string>
     <string name="mode_dark">Modo escuro</string>
@@ -129,4 +132,4 @@
     <string name="action_about">"Acerca de"</string>
     <string name="marked_as_read">"Elemento lido"</string>
     <string name="marked_as_unread">"Elemento non lido"</string>
-</resources>
+</resources>

androidApp/src/main/res/values-in-rID/strings.xml

@@ -106,6 +106,9 @@
     <string name="reader_text_align_left">Align left</string>
     <string name="reader_text_align_justify">Justify</string>
     <string name="settings_reader_font">Reader font</string>
+    <string name="reader_static_bar_title">Static bottom bar in the article viewer</string>
+    <string name="reader_static_bar_on">The bottom bar will always be displayed</string>
+    <string name="reader_static_bar_off">The bottom bar can be shown through the floating button</string>
     <string name="remove_source">Remove source</string>
     <string name="pref_theme_title">Light/Dark mode</string>
     <string name="mode_dark">Dark mode</string>
@@ -129,4 +132,4 @@
     <string name="action_about">"Tentang"</string>
     <string name="marked_as_read">"Membaca item"</string>
     <string name="marked_as_unread">"Item unread"</string>
-</resources>
+</resources>

androidApp/src/main/res/values-it-rIT/strings.xml

@@ -106,6 +106,9 @@
     <string name="reader_text_align_left">Align left</string>
     <string name="reader_text_align_justify">Justify</string>
     <string name="settings_reader_font">Reader font</string>
+    <string name="reader_static_bar_title">Static bottom bar in the article viewer</string>
+    <string name="reader_static_bar_on">The bottom bar will always be displayed</string>
+    <string name="reader_static_bar_off">The bottom bar can be shown through the floating button</string>
     <string name="remove_source">Remove source</string>
     <string name="pref_theme_title">Light/Dark mode</string>
     <string name="mode_dark">Dark mode</string>
@@ -129,4 +132,4 @@
     <string name="action_about">"Informazioni"</string>
     <string name="marked_as_read">"Articolo letto"</string>
     <string name="marked_as_unread">"Item unread"</string>
-</resources>
+</resources>

androidApp/src/main/res/values-ko-rKR/strings.xml

@@ -106,6 +106,9 @@
     <string name="reader_text_align_left">Align left</string>
     <string name="reader_text_align_justify">Justify</string>
     <string name="settings_reader_font">Reader font</string>
+    <string name="reader_static_bar_title">Static bottom bar in the article viewer</string>
+    <string name="reader_static_bar_on">The bottom bar will always be displayed</string>
+    <string name="reader_static_bar_off">The bottom bar can be shown through the floating button</string>
     <string name="remove_source">Remove source</string>
     <string name="pref_theme_title">Light/Dark mode</string>
     <string name="mode_dark">Dark mode</string>
@@ -129,4 +132,4 @@
     <string name="action_about">"정보"</string>
     <string name="marked_as_read">"항목 읽기"</string>
     <string name="marked_as_unread">"Item unread"</string>
-</resources>
+</resources>

androidApp/src/main/res/values-nl-rNL/strings.xml

@@ -23,7 +23,6 @@
     <string name="wrong_infos">"Controleer de gegevens nogmaals."</string>
     <string name="all_posts_not_read">"Fout bij markeren als gelezen"</string>
     <string name="all_posts_read">"Alle artikelen gemarkeerd als gelezen"</string>
-    <string name="undo_string">"Ongedaan maken"</string>
     <string name="addStringNoUrl">"Login om bronnen toe te voegen"</string>
     <string name="cant_get_sources">"Kan de lijst met bronnen niet ophalen"</string>
     <string name="cant_create_source">"Kan bron niet creëeren"</string>
@@ -106,6 +105,9 @@
     <string name="reader_text_align_left">Align left</string>
     <string name="reader_text_align_justify">Justify</string>
     <string name="settings_reader_font">Reader font</string>
+    <string name="reader_static_bar_title">Static bottom bar in the article viewer</string>
+    <string name="reader_static_bar_on">The bottom bar will always be displayed</string>
+    <string name="reader_static_bar_off">The bottom bar can be shown through the floating button</string>
     <string name="remove_source">Remove source</string>
     <string name="pref_theme_title">Light/Dark mode</string>
     <string name="mode_dark">Dark mode</string>
@@ -129,4 +131,5 @@
     <string name="action_about">"Over"</string>
     <string name="marked_as_read">"Artikel gelezen"</string>
     <string name="marked_as_unread">"Item unread"</string>
-</resources>
+    <string name="undo_string">"Ongedaan maken"</string>
+</resources>

androidApp/src/main/res/values-pt-rBR/strings.xml

@@ -106,6 +106,9 @@
     <string name="reader_text_align_left">Align left</string>
     <string name="reader_text_align_justify">Justify</string>
     <string name="settings_reader_font">Reader font</string>
+    <string name="reader_static_bar_title">Static bottom bar in the article viewer</string>
+    <string name="reader_static_bar_on">The bottom bar will always be displayed</string>
+    <string name="reader_static_bar_off">The bottom bar can be shown through the floating button</string>
     <string name="remove_source">Remove source</string>
     <string name="pref_theme_title">Light/Dark mode</string>
     <string name="mode_dark">Dark mode</string>
@@ -129,4 +132,4 @@
     <string name="action_about">"Sobre"</string>
     <string name="marked_as_read">"Item lido"</string>
     <string name="marked_as_unread">"Item unread"</string>
-</resources>
+</resources>

androidApp/src/main/res/values-pt-rPT/strings.xml

@@ -106,6 +106,9 @@
     <string name="reader_text_align_left">Align left</string>
     <string name="reader_text_align_justify">Justify</string>
     <string name="settings_reader_font">Reader font</string>
+    <string name="reader_static_bar_title">Static bottom bar in the article viewer</string>
+    <string name="reader_static_bar_on">The bottom bar will always be displayed</string>
+    <string name="reader_static_bar_off">The bottom bar can be shown through the floating button</string>
     <string name="remove_source">Remove source</string>
     <string name="pref_theme_title">Light/Dark mode</string>
     <string name="mode_dark">Dark mode</string>
@@ -129,4 +132,4 @@
     <string name="action_about">"Sobre"</string>
     <string name="marked_as_read">"Item lido"</string>
     <string name="marked_as_unread">"Item unread"</string>
-</resources>
+</resources>

androidApp/src/main/res/values-si-rLK/strings.xml

@@ -106,6 +106,9 @@
     <string name="reader_text_align_left">Align left</string>
     <string name="reader_text_align_justify">Justify</string>
     <string name="settings_reader_font">Reader font</string>
+    <string name="reader_static_bar_title">Static bottom bar in the article viewer</string>
+    <string name="reader_static_bar_on">The bottom bar will always be displayed</string>
+    <string name="reader_static_bar_off">The bottom bar can be shown through the floating button</string>
     <string name="remove_source">Remove source</string>
     <string name="pref_theme_title">Light/Dark mode</string>
     <string name="mode_dark">Dark mode</string>
@@ -129,4 +132,4 @@
     <string name="action_about">"මේ ගැන"</string>
     <string name="marked_as_read">"Item read"</string>
     <string name="marked_as_unread">"Item unread"</string>
-</resources>
+</resources>

androidApp/src/main/res/values-tr-rTR/strings.xml

@@ -106,6 +106,9 @@
     <string name="reader_text_align_left">Align left</string>
     <string name="reader_text_align_justify">Justify</string>
     <string name="settings_reader_font">Reader font</string>
+    <string name="reader_static_bar_title">Static bottom bar in the article viewer</string>
+    <string name="reader_static_bar_on">The bottom bar will always be displayed</string>
+    <string name="reader_static_bar_off">The bottom bar can be shown through the floating button</string>
     <string name="remove_source">Remove source</string>
     <string name="pref_theme_title">Light/Dark mode</string>
     <string name="mode_dark">Dark mode</string>
@@ -129,4 +132,4 @@
     <string name="action_about">"Hakkında"</string>
     <string name="marked_as_read">"Öğeleri oku"</string>
     <string name="marked_as_unread">"Item unread"</string>
-</resources>
+</resources>

androidApp/src/main/res/values-zh-rCN/strings.xml

@@ -106,6 +106,9 @@
     <string name="reader_text_align_left">左对齐</string>
     <string name="reader_text_align_justify">左右对齐</string>
     <string name="settings_reader_font">阅读器字体</string>
+    <string name="reader_static_bar_title">文章查看器中的静态底部栏</string>
+    <string name="reader_static_bar_on">底部栏将始终显示</string>
+    <string name="reader_static_bar_off">底部栏可以通过浮动按钮显示</string>
     <string name="remove_source">删除源</string>
     <string name="pref_theme_title">浅色/深色模式</string>
     <string name="mode_dark">深色模式</string>
@@ -129,4 +132,4 @@
     <string name="action_about">"关于我们"</string>
     <string name="marked_as_read">"已读"</string>
     <string name="marked_as_unread">"未读条目"</string>
-</resources>
+</resources>

androidApp/src/main/res/values-zh-rTW/strings.xml

@@ -106,6 +106,9 @@
     <string name="reader_text_align_left">Align left</string>
     <string name="reader_text_align_justify">Justify</string>
     <string name="settings_reader_font">Reader font</string>
+    <string name="reader_static_bar_title">Static bottom bar in the article viewer</string>
+    <string name="reader_static_bar_on">The bottom bar will always be displayed</string>
+    <string name="reader_static_bar_off">The bottom bar can be shown through the floating button</string>
     <string name="remove_source">Remove source</string>
     <string name="pref_theme_title">Light/Dark mode</string>
     <string name="mode_dark">Dark mode</string>
@@ -129,4 +132,4 @@
     <string name="action_about">"关于我们"</string>
     <string name="marked_as_read">"已读"</string>
     <string name="marked_as_unread">"未讀項目"</string>
-</resources>
+</resources>

androidApp/src/main/res/values/ids.xml

@@ -1,6 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<resources>
-    <item name="unread_action" type="id" />
-    <item name="open_action" type="id" />
-    <item name="share_action" type="id" />
-</resources>

androidApp/src/main/res/values/strings.xml

@@ -108,6 +108,9 @@
     <string name="source_code_pro_font_id" translatable="false">source_code_pro_medium</string>
     <string name="open_sans_font_id" translatable="false">open_sans</string>
     <string name="roboto_font_id" translatable="false">roboto</string>
+    <string name="reader_static_bar_title">Static bottom bar in the article viewer</string>
+    <string name="reader_static_bar_on">The bottom bar will always be displayed</string>
+    <string name="reader_static_bar_off">The bottom bar can be shown through the floating button</string>
     <string name="remove_source">Remove source</string>
     <string name="pref_theme_title">Light/Dark mode</string>
     <string name="mode_dark">Dark mode</string>
@@ -131,4 +134,4 @@
     <string name="action_about">"About"</string>
     <string name="marked_as_read">"Item read"</string>
     <string name="marked_as_unread">"Item unread"</string>
-</resources>
+</resources>

androidApp/src/main/res/xml/pref_general.xml

@@ -30,6 +30,14 @@
         android:summaryOn="@string/pref_article_viewer_on"
         android:title="@string/pref_article_viewer_title"
         app:iconSpaceReserved="false"/>
+    <SwitchPreference
+        android:defaultValue="false"
+        android:dependency="prefer_article_viewer"
+        android:key="reader_static_bar"
+        android:summaryOff="@string/reader_static_bar_off"
+        android:summaryOn="@string/reader_static_bar_on"
+        android:title="@string/reader_static_bar_title"
+        app:iconSpaceReserved="false"/>
 
     <PreferenceCategory
         android:title="@string/pref_general_category_displaying">

androidApp/src/main/res/xml/pref_theme.xml

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto">
+
+    <ListPreference
+        android:defaultValue="0"
+        android:entries="@array/ModeTitles"
+        android:entryValues="@array/ModeValues"
+        android:key="currentMode"
+        app:iconSpaceReserved="false"
+        android:title="@string/pref_theme_title"
+        app:useSimpleSummaryProvider="false" />
+</PreferenceScreen>

androidApp/src/test/kotlin/bou/amine/apps/readerforselfossv2/android/tests/robolectric/LoginActivityTest.kt

@@ -11,8 +11,10 @@ import org.junit.Test
 import org.junit.runner.RunWith
 import org.robolectric.Robolectric
 
-@RunWith(RobotElectriqueRunner::class)
+
+@RunWith(RobotElectriqueRunnerclass::class)
 class LoginActivityTest {
+
     @Test
     fun login_shouldDisplay() {
         Robolectric.buildActivity(LoginActivity::class.java).use { controller ->
@@ -72,4 +74,4 @@ class LoginActivityTest {
              assertEquals(expectedIntent.component, actual.component)
          }
      }*/
-}
+}

androidApp/src/test/kotlin/bou/amine/apps/readerforselfossv2/android/tests/robolectric/RobotElectriqueRunner.kt

@@ -3,8 +3,10 @@ package bou.amine.apps.readerforselfossv2.android.tests.robolectric
 import org.robolectric.RobolectricTestRunner
 import org.robolectric.annotation.Config
 
-class RobotElectriqueRunner(
+class RobotElectriqueRunnerclass(testClass: Class<*>?) :
-    testClass: Class<*>?,
+    RobolectricTestRunner(testClass) {
-) : RobolectricTestRunner(testClass) {
+
-    override fun buildGlobalConfig(): Config = Config.Builder().setSdk(25, 30, 33).build()
+    override fun buildGlobalConfig(): Config {
-}
+        return Config.Builder().setSdk(25, 30, 33).build()
+    }
+}

androidApp/src/test/kotlin/bou/amine/apps/readerforselfossv2/android/tests/robolectric/helpers.kt

@@ -11,17 +11,13 @@ fun dialogMessage(): String {
     return latestDialog.findViewById<TextView>(android.R.id.message)?.text.toString()
 }
 
-fun Menu.assertClickable(
+fun Menu.assertClickable(@IdRes id: Int) {
-    @IdRes id: Int,
-) {
     this.assertVisible(id)
     val item = this.findItem(id)
     assertTrue(item.isEnabled)
 }
 
-fun Menu.assertVisible(
+fun Menu.assertVisible(@IdRes id: Int) {
-    @IdRes id: Int,
-) {
     val item = this.findItem(id)
     assertTrue(item.isVisible)
-}
+}

androidApp/src/test/kotlin/bou/amine/apps/readerforselfossv2/tests/repository/RepositoryTest.kt

@@ -1,5 +1,3 @@
-@file:Suppress("detekt:LargeClass")
-
 package bou.amine.apps.readerforselfossv2.tests.repository
 
 import bou.amine.apps.readerforselfossv2.dao.ReaderForSelfossDB
@@ -44,14 +42,14 @@ private const val FEED_URL = "https://test.com/feed"
 
 private const val TAGS = "Test, New"
 
-private const val NUMBER_ARTICLES = 100
-private const val NUMBER_UNREAD = 50
-private const val NUMBER_STARRED = 20
-
 class RepositoryTest {
     private val db = mockk<ReaderForSelfossDB>(relaxed = true)
     private val appSettingsService = mockk<AppSettingsService>()
     private val api = mockk<SelfossApi>()
+
+    private val NUMBER_ARTICLES = 100
+    private val NUMBER_UNREAD = 50
+    private val NUMBER_STARRED = 20
     private lateinit var repository: Repository
 
     private fun initializeRepository(
@@ -77,20 +75,19 @@ class RepositoryTest {
         every { appSettingsService.isUpdateSourcesEnabled() } returns false
 
         coEvery { api.apiInformation() } returns
-            StatusAndData(
+                StatusAndData(
-                success = true,
+                    success = true,
-                data =
+                    data = SelfossModel.ApiInformation(
-                    SelfossModel.ApiInformation(
                         "2.19-ba1e8e3",
                         "4.0.0",
-                        SelfossModel.ApiConfiguration(false, true),
+                        SelfossModel.ApiConfiguration(false, true)
                     ),
-            )
+                )
         coEvery { api.stats() } returns
-            StatusAndData(
+                StatusAndData(
-                success = true,
+                    success = true,
-                data = SelfossModel.Stats(NUMBER_ARTICLES, NUMBER_UNREAD, NUMBER_STARRED),
+                    data = SelfossModel.Stats(NUMBER_ARTICLES, NUMBER_UNREAD, NUMBER_STARRED),
-            )
+                )
 
         every { db.itemsQueries.deleteItemsWhereSource(any()) } returns Unit
         every { db.itemsQueries.items().executeAsList() } returns generateTestDBItems()
@@ -120,7 +117,7 @@ class RepositoryTest {
     fun get_api_4_date_with_api_1_version_stored() {
         every { appSettingsService.getApiVersion() } returns 1
         coEvery { api.getItems(any(), any(), any(), any(), any(), any(), any()) } returns
-            StatusAndData(success = true, data = generateTestApiItem())
+                StatusAndData(success = true, data = generateTestApiItem())
         every { appSettingsService.updateApiVersion(any()) } returns Unit
 
         initializeRepository()
@@ -136,15 +133,14 @@ class RepositoryTest {
     fun get_public_access() {
         every { appSettingsService.updatePublicAccess(any()) } returns Unit
         coEvery { api.apiInformation() } returns
-            StatusAndData(
+                StatusAndData(
-                success = true,
+                    success = true,
-                data =
+                    data = SelfossModel.ApiInformation(
-                    SelfossModel.ApiInformation(
                         "2.19-ba1e8e3",
                         "4.0.0",
-                        SelfossModel.ApiConfiguration(true, true),
+                        SelfossModel.ApiConfiguration(true, true)
                     ),
-            )
+                )
         every { appSettingsService.getUserName() } returns ""
 
         initializeRepository()
@@ -157,15 +153,14 @@ class RepositoryTest {
     fun get_public_access_username_not_empty() {
         every { appSettingsService.updatePublicAccess(any()) } returns Unit
         coEvery { api.apiInformation() } returns
-            StatusAndData(
+                StatusAndData(
-                success = true,
+                    success = true,
-                data =
+                    data = SelfossModel.ApiInformation(
-                    SelfossModel.ApiInformation(
                         "2.19-ba1e8e3",
                         "4.0.0",
-                        SelfossModel.ApiConfiguration(true, true),
+                        SelfossModel.ApiConfiguration(true, true)
                     ),
-            )
+                )
         every { appSettingsService.getUserName() } returns "username"
 
         initializeRepository()
@@ -178,15 +173,14 @@ class RepositoryTest {
     fun get_public_access_no_auth() {
         every { appSettingsService.updatePublicAccess(any()) } returns Unit
         coEvery { api.apiInformation() } returns
-            StatusAndData(
+                StatusAndData(
-                success = true,
+                    success = true,
-                data =
+                    data = SelfossModel.ApiInformation(
-                    SelfossModel.ApiInformation(
                         "2.19-ba1e8e3",
                         "4.0.0",
-                        SelfossModel.ApiConfiguration(true, false),
+                        SelfossModel.ApiConfiguration(true, false)
                     ),
-            )
+                )
         every { appSettingsService.getUserName() } returns ""
 
         initializeRepository()
@@ -199,15 +193,14 @@ class RepositoryTest {
     fun get_public_access_disabled() {
         every { appSettingsService.updatePublicAccess(any()) } returns Unit
         coEvery { api.apiInformation() } returns
-            StatusAndData(
+                StatusAndData(
-                success = true,
+                    success = true,
-                data =
+                    data = SelfossModel.ApiInformation(
-                    SelfossModel.ApiInformation(
                         "2.19-ba1e8e3",
                         "4.0.0",
-                        SelfossModel.ApiConfiguration(false, true),
+                        SelfossModel.ApiConfiguration(false, true)
                     ),
-            )
+                )
         every { appSettingsService.getUserName() } returns ""
 
         initializeRepository()
@@ -223,10 +216,10 @@ class RepositoryTest {
         val itemParameters = FakeItemParameters()
         itemParameters.datetime = "2021-04-23 11:45:32"
         coEvery { api.getItems(any(), any(), any(), any(), any(), any(), any()) } returns
-            StatusAndData(
+                StatusAndData(
-                success = true,
+                    success = true,
-                data = generateTestApiItem(itemParameters),
+                    data = generateTestApiItem(itemParameters),
-            )
+                )
 
         initializeRepository()
         runBlocking {
@@ -239,7 +232,7 @@ class RepositoryTest {
     @Test
     fun get_newer_items() {
         coEvery { api.getItems(any(), any(), any(), any(), any(), any(), any()) } returns
-            StatusAndData(success = true, data = generateTestApiItem())
+                StatusAndData(success = true, data = generateTestApiItem())
 
         initializeRepository()
         runBlocking {
@@ -254,7 +247,7 @@ class RepositoryTest {
     @Test
     fun get_all_newer_items() {
         coEvery { api.getItems(any(), any(), any(), any(), any(), any(), any()) } returns
-            StatusAndData(success = true, data = generateTestApiItem())
+                StatusAndData(success = true, data = generateTestApiItem())
 
         initializeRepository()
         repository.displayedItems = ItemType.ALL
@@ -270,7 +263,7 @@ class RepositoryTest {
     @Test
     fun get_newer_starred_items() {
         coEvery { api.getItems(any(), any(), any(), any(), any(), any(), any()) } returns
-            StatusAndData(success = true, data = generateTestApiItem())
+                StatusAndData(success = true, data = generateTestApiItem())
 
         initializeRepository()
         repository.displayedItems = ItemType.STARRED
@@ -309,8 +302,8 @@ class RepositoryTest {
         coEvery { db.itemsQueries.items().executeAsList() } returns generateTestDBItems(
             itemParameter1,
         ) +
-            generateTestDBItems(itemParameter2) +
+                generateTestDBItems(itemParameter2) +
-            generateTestDBItems(itemParameter3)
+                generateTestDBItems(itemParameter3)
 
         every { appSettingsService.isItemCachingEnabled() } returns true
 
@@ -337,8 +330,8 @@ class RepositoryTest {
         coEvery { db.itemsQueries.items().executeAsList() } returns generateTestDBItems(
             itemParameter1,
         ) +
-            generateTestDBItems(itemParameter2) +
+                generateTestDBItems(itemParameter2) +
-            generateTestDBItems(itemParameter3)
+                generateTestDBItems(itemParameter3)
 
         every { appSettingsService.isItemCachingEnabled() } returns true
 
@@ -367,7 +360,7 @@ class RepositoryTest {
     @Test
     fun get_older_items() {
         coEvery { api.getItems(any(), any(), any(), any(), any(), any(), any()) } returns
-            StatusAndData(success = true, data = generateTestApiItem())
+                StatusAndData(success = true, data = generateTestApiItem())
 
         initializeRepository()
         repository.items = ArrayList(generateTestApiItem())
@@ -383,7 +376,7 @@ class RepositoryTest {
     @Test
     fun get_all_older_items() {
         coEvery { api.getItems(any(), any(), any(), any(), any(), any(), any()) } returns
-            StatusAndData(success = true, data = generateTestApiItem())
+                StatusAndData(success = true, data = generateTestApiItem())
 
         initializeRepository()
         repository.items = ArrayList(generateTestApiItem())
@@ -400,7 +393,7 @@ class RepositoryTest {
     @Test
     fun get_older_starred_items() {
         coEvery { api.getItems(any(), any(), any(), any(), any(), any(), any()) } returns
-            StatusAndData(success = true, data = generateTestApiItem())
+                StatusAndData(success = true, data = generateTestApiItem())
 
         initializeRepository()
         repository.displayedItems = ItemType.STARRED
@@ -840,7 +833,7 @@ class RepositoryTest {
     @Test
     fun create_source() {
         coEvery { api.createSourceForVersion(any(), any(), any(), any()) } returns
-            SuccessResponse(true)
+                SuccessResponse(true)
 
         initializeRepository()
         var response: Boolean
@@ -868,7 +861,7 @@ class RepositoryTest {
     @Test
     fun create_source_but_response_fails() {
         coEvery { api.createSourceForVersion(any(), any(), any(), any()) } returns
-            SuccessResponse(false)
+                SuccessResponse(false)
 
         initializeRepository()
         var response: Boolean
@@ -896,7 +889,7 @@ class RepositoryTest {
     @Test
     fun create_source_without_connection() {
         coEvery { api.createSourceForVersion(any(), any(), any(), any()) } returns
-            SuccessResponse(true)
+                SuccessResponse(true)
 
         initializeRepository(MutableStateFlow(false))
         var response: Boolean
@@ -969,10 +962,10 @@ class RepositoryTest {
     @Test
     fun update_remote() {
         coEvery { api.update() } returns
-            StatusAndData(
+                StatusAndData(
-                success = true,
+                    success = true,
-                data = "finished",
+                    data = "finished",
-            )
+                )
 
         initializeRepository()
         var response: Boolean
@@ -987,10 +980,10 @@ class RepositoryTest {
     @Test
     fun update_remote_but_response_fails() {
         coEvery { api.update() } returns
-            StatusAndData(
+                StatusAndData(
-                success = false,
+                    success = false,
-                data = "unallowed access",
+                    data = "unallowed access",
-            )
+                )
 
         initializeRepository()
         var response: Boolean
@@ -1005,10 +998,10 @@ class RepositoryTest {
     @Test
     fun update_remote_with_unallowed_access() {
         coEvery { api.update() } returns
-            StatusAndData(
+                StatusAndData(
-                success = true,
+                    success = true,
-                data = "unallowed access",
+                    data = "unallowed access",
-            )
+                )
 
         initializeRepository()
         var response: Boolean
@@ -1023,10 +1016,10 @@ class RepositoryTest {
     @Test
     fun update_remote_without_connection() {
         coEvery { api.update() } returns
-            StatusAndData(
+                StatusAndData(
-                success = true,
+                    success = true,
-                data = "undocumented...",
+                    data = "undocumented...",
-            )
+                )
 
         initializeRepository(MutableStateFlow(false))
         var response: Boolean
@@ -1116,11 +1109,11 @@ class RepositoryTest {
                 any(),
             )
         } returnsMany
-            listOf(
+                listOf(
-                StatusAndData(success = true, data = generateTestApiItem(itemParameter1)),
+                    StatusAndData(success = true, data = generateTestApiItem(itemParameter1)),
-                StatusAndData(success = true, data = generateTestApiItem(itemParameter2)),
+                    StatusAndData(success = true, data = generateTestApiItem(itemParameter2)),
-                StatusAndData(success = true, data = generateTestApiItem(itemParameter1)),
+                    StatusAndData(success = true, data = generateTestApiItem(itemParameter1)),
-            )
+                )
 
         initializeRepository()
         prepareSearch()
@@ -1134,7 +1127,7 @@ class RepositoryTest {
     @Test
     fun cache_items_but_response_fails() {
         coEvery { api.getItems(any(), any(), any(), any(), any(), any(), any()) } returns
-            StatusAndData(success = false, data = generateTestApiItem())
+                StatusAndData(success = false, data = generateTestApiItem())
 
         initializeRepository()
         prepareSearch()
@@ -1148,7 +1141,7 @@ class RepositoryTest {
     @Test
     fun cache_items_without_connection() {
         coEvery { api.getItems(any(), any(), any(), any(), any(), any(), any()) } returns
-            StatusAndData(success = false, data = generateTestApiItem())
+                StatusAndData(success = false, data = generateTestApiItem())
 
         initializeRepository(MutableStateFlow(false))
         prepareSearch()
@@ -1175,4 +1168,4 @@ class RepositoryTest {
         )
         repository.searchFilter = "search"
     }
-}
+}

androidApp/src/test/kotlin/bou/amine/apps/readerforselfossv2/tests/repository/TestUtils.kt

@@ -3,8 +3,8 @@ package bou.amine.apps.readerforselfossv2.tests.repository
 import bou.amine.apps.readerforselfossv2.dao.ITEM
 import bou.amine.apps.readerforselfossv2.model.SelfossModel
 
-fun generateTestDBItems(item: FakeItemParameters = FakeItemParameters()): List<ITEM> =
+fun generateTestDBItems(item: FakeItemParameters = FakeItemParameters()): List<ITEM> {
-    listOf(
+    return listOf(
         ITEM(
             id = item.id,
             datetime = item.datetime,
@@ -20,9 +20,10 @@ fun generateTestDBItems(item: FakeItemParameters = FakeItemParameters()): List<I
             author = item.author,
         ),
     )
+}
 
-fun generateTestApiItem(item: FakeItemParameters = FakeItemParameters()): List<SelfossModel.Item> =
+fun generateTestApiItem(item: FakeItemParameters = FakeItemParameters()): List<SelfossModel.Item> {
-    listOf(
+    return listOf(
         SelfossModel.Item(
             id = item.id.toInt(),
             datetime = item.datetime,
@@ -38,6 +39,7 @@ fun generateTestApiItem(item: FakeItemParameters = FakeItemParameters()): List<S
             author = item.author,
         ),
     )
+}
 
 class FakeItemParameters {
     var id = "20"
@@ -54,4 +56,4 @@ class FakeItemParameters {
     var sourcetitle = "La Chimica e la Società"
     var tags = "Chimica, Testing"
     var author = "Someone important"
-}
+}

detekt.yml

@@ -1,786 +0,0 @@
-build:
-  maxIssues: 0
-  excludeCorrectable: false
-  weights:
-  # complexity: 2
-  # LongParameterList: 1
-  # style: 1
-  # comments: 1
-
-config:
-  validation: true
-  warningsAsErrors: false
-  checkExhaustiveness: false
-  # when writing own rules with new properties, exclude the property path e.g.: 'my_rule_set,.*>.*>[my_property]'
-  excludes: ''
-
-processors:
-  active: true
-  exclude:
-    - 'DetektProgressListener'
-  # - 'KtFileCountProcessor'
-  # - 'PackageCountProcessor'
-  # - 'ClassCountProcessor'
-  # - 'FunctionCountProcessor'
-  # - 'PropertyCountProcessor'
-  # - 'ProjectComplexityProcessor'
-  # - 'ProjectCognitiveComplexityProcessor'
-  # - 'ProjectLLOCProcessor'
-  # - 'ProjectCLOCProcessor'
-  # - 'ProjectLOCProcessor'
-  # - 'ProjectSLOCProcessor'
-  # - 'LicenseHeaderLoaderExtension'
-
-console-reports:
-  active: true
-  exclude:
-    - 'ProjectStatisticsReport'
-    - 'ComplexityReport'
-    - 'NotificationReport'
-    - 'FindingsReport'
-    - 'FileBasedFindingsReport'
-  #  - 'LiteFindingsReport'
-
-output-reports:
-  active: true
-  exclude:
-  # - 'TxtOutputReport'
-  # - 'XmlOutputReport'
-  # - 'HtmlOutputReport'
-  # - 'MdOutputReport'
-  # - 'SarifOutputReport'
-
-comments:
-  active: true
-  AbsentOrWrongFileLicense:
-    active: false
-    licenseTemplateFile: 'license.template'
-    licenseTemplateIsRegex: false
-  CommentOverPrivateFunction:
-    active: false
-  CommentOverPrivateProperty:
-    active: false
-  DeprecatedBlockTag:
-    active: false
-  EndOfSentenceFormat:
-    active: false
-    endOfSentenceFormat: '([.?!][ \t\n\r\f<])|([.?!:]$)'
-  KDocReferencesNonPublicProperty:
-    active: false
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-  OutdatedDocumentation:
-    active: false
-    matchTypeParameters: true
-    matchDeclarationsOrder: true
-    allowParamOnConstructorProperties: false
-  UndocumentedPublicClass:
-    active: false
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    searchInNestedClass: true
-    searchInInnerClass: true
-    searchInInnerObject: true
-    searchInInnerInterface: true
-    searchInProtectedClass: false
-  UndocumentedPublicFunction:
-    active: false
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    searchProtectedFunction: false
-  UndocumentedPublicProperty:
-    active: false
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    searchProtectedProperty: false
-
-complexity:
-  active: true
-  CognitiveComplexMethod:
-    active: false
-    threshold: 15
-  ComplexCondition:
-    active: true
-    threshold: 4
-  ComplexInterface:
-    active: false
-    threshold: 10
-    includeStaticDeclarations: false
-    includePrivateDeclarations: false
-    ignoreOverloaded: false
-  CyclomaticComplexMethod:
-    active: true
-    threshold: 15
-    ignoreSingleWhenExpression: false
-    ignoreSimpleWhenEntries: false
-    ignoreNestingFunctions: false
-    nestingFunctions:
-      - 'also'
-      - 'apply'
-      - 'forEach'
-      - 'isNotNull'
-      - 'ifNull'
-      - 'let'
-      - 'run'
-      - 'use'
-      - 'with'
-  LabeledExpression:
-    active: false
-    ignoredLabels: [ ]
-  LargeClass:
-    active: true
-    threshold: 600
-  LongMethod:
-    active: true
-    threshold: 60
-  LongParameterList:
-    active: true
-    functionThreshold: 6
-    constructorThreshold: 7
-    ignoreDefaultParameters: false
-    ignoreDataClasses: true
-    ignoreAnnotatedParameter: [ ]
-  MethodOverloading:
-    active: false
-    threshold: 6
-  NamedArguments:
-    active: false
-    threshold: 3
-    ignoreArgumentsMatchingNames: false
-  NestedBlockDepth:
-    active: true
-    threshold: 4
-  NestedScopeFunctions:
-    active: false
-    threshold: 1
-    functions:
-      - 'kotlin.apply'
-      - 'kotlin.run'
-      - 'kotlin.with'
-      - 'kotlin.let'
-      - 'kotlin.also'
-  ReplaceSafeCallChainWithRun:
-    active: false
-  StringLiteralDuplication:
-    active: false
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    threshold: 3
-    ignoreAnnotation: true
-    excludeStringsWithLessThan5Characters: true
-    ignoreStringsRegex: '$^'
-  TooManyFunctions:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**', '**/android/*Activity.kt', '**/fragments/*Fragment.kt' ]
-    thresholdInFiles: 11
-    thresholdInClasses: 11
-    thresholdInInterfaces: 11
-    thresholdInObjects: 11
-    thresholdInEnums: 11
-    ignoreDeprecated: false
-    ignorePrivate: false
-    ignoreOverridden: false
-    ignoreAnnotatedFunctions: [ ]
-
-coroutines:
-  active: true
-  GlobalCoroutineUsage:
-    active: false
-  InjectDispatcher:
-    active: true
-    dispatcherNames:
-      - 'IO'
-      - 'Default'
-      - 'Unconfined'
-  RedundantSuspendModifier:
-    active: true
-  SleepInsteadOfDelay:
-    active: true
-  SuspendFunSwallowedCancellation:
-    active: false
-  SuspendFunWithCoroutineScopeReceiver:
-    active: false
-  SuspendFunWithFlowReturnType:
-    active: true
-
-empty-blocks:
-  active: true
-  EmptyCatchBlock:
-    active: true
-    allowedExceptionNameRegex: '_|(ignore|expected).*'
-  EmptyClassBlock:
-    active: true
-  EmptyDefaultConstructor:
-    active: true
-  EmptyDoWhileBlock:
-    active: true
-  EmptyElseBlock:
-    active: true
-  EmptyFinallyBlock:
-    active: true
-  EmptyForBlock:
-    active: true
-  EmptyFunctionBlock:
-    active: true
-    ignoreOverridden: false
-  EmptyIfBlock:
-    active: true
-  EmptyInitBlock:
-    active: true
-  EmptyKtFile:
-    active: true
-  EmptySecondaryConstructor:
-    active: true
-  EmptyTryBlock:
-    active: true
-  EmptyWhenBlock:
-    active: true
-  EmptyWhileBlock:
-    active: true
-
-exceptions:
-  active: true
-  ExceptionRaisedInUnexpectedLocation:
-    active: true
-    methodNames:
-      - 'equals'
-      - 'finalize'
-      - 'hashCode'
-      - 'toString'
-  InstanceOfCheckForException:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-  NotImplementedDeclaration:
-    active: false
-  ObjectExtendsThrowable:
-    active: false
-  PrintStackTrace:
-    active: true
-  RethrowCaughtException:
-    active: true
-  ReturnFromFinally:
-    active: true
-    ignoreLabeled: false
-  SwallowedException:
-    active: true
-    ignoredExceptionTypes:
-      - 'InterruptedException'
-      - 'MalformedURLException'
-      - 'NumberFormatException'
-      - 'ParseException'
-    allowedExceptionNameRegex: '_|(ignore|expected).*'
-  ThrowingExceptionFromFinally:
-    active: true
-  ThrowingExceptionInMain:
-    active: false
-  ThrowingExceptionsWithoutMessageOrCause:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    exceptions:
-      - 'ArrayIndexOutOfBoundsException'
-      - 'Exception'
-      - 'IllegalArgumentException'
-      - 'IllegalMonitorStateException'
-      - 'IllegalStateException'
-      - 'IndexOutOfBoundsException'
-      - 'NullPointerException'
-      - 'RuntimeException'
-      - 'Throwable'
-  ThrowingNewInstanceOfSameException:
-    active: true
-  TooGenericExceptionCaught:
-    active: false
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    exceptionNames:
-      - 'ArrayIndexOutOfBoundsException'
-      - 'Error'
-      - 'Exception'
-      - 'IllegalMonitorStateException'
-      - 'IndexOutOfBoundsException'
-      - 'NullPointerException'
-      - 'RuntimeException'
-      - 'Throwable'
-    allowedExceptionNameRegex: '_|(ignore|expected).*'
-  TooGenericExceptionThrown:
-    active: true
-    exceptionNames:
-      - 'Error'
-      - 'Exception'
-      - 'RuntimeException'
-      - 'Throwable'
-
-naming:
-  active: true
-  BooleanPropertyNaming:
-    active: false
-    allowedPattern: '^(is|has|are)'
-  ClassNaming:
-    active: true
-    classPattern: '[A-Z][a-zA-Z0-9]*'
-  ConstructorParameterNaming:
-    active: true
-    parameterPattern: '[a-z][A-Za-z0-9]*'
-    privateParameterPattern: '[a-z][A-Za-z0-9]*'
-    excludeClassPattern: '$^'
-  EnumNaming:
-    active: true
-    enumEntryPattern: '[A-Z][_a-zA-Z0-9]*'
-  ForbiddenClassName:
-    active: false
-    forbiddenName: [ ]
-  FunctionMaxLength:
-    active: false
-    maximumFunctionNameLength: 30
-  FunctionMinLength:
-    active: false
-    minimumFunctionNameLength: 3
-  FunctionNaming:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    functionPattern: '[a-z][a-zA-Z0-9]*'
-    excludeClassPattern: '$^'
-  FunctionParameterNaming:
-    active: true
-    parameterPattern: '[a-z][A-Za-z0-9]*'
-    excludeClassPattern: '$^'
-  InvalidPackageDeclaration:
-    active: true
-    rootPackage: ''
-    requireRootInDeclaration: false
-  LambdaParameterNaming:
-    active: false
-    parameterPattern: '[a-z][A-Za-z0-9]*|_'
-  MatchingDeclarationName:
-    active: false # done in ktlint
-    mustBeFirst: true
-  MemberNameEqualsClassName:
-    active: true
-    ignoreOverridden: true
-  NoNameShadowing:
-    active: true
-  NonBooleanPropertyPrefixedWithIs:
-    active: false
-  ObjectPropertyNaming:
-    active: true
-    constantPattern: '[A-Za-z][_A-Za-z0-9]*'
-    propertyPattern: '[A-Za-z][_A-Za-z0-9]*'
-    privatePropertyPattern: '(_)?[A-Za-z][_A-Za-z0-9]*'
-  PackageNaming:
-    active: true
-    packagePattern: '[a-z]+(\.[a-z][A-Za-z0-9]*)*'
-  TopLevelPropertyNaming:
-    active: true
-    constantPattern: '[A-Z][_A-Z0-9]*'
-    propertyPattern: '[A-Za-z][_A-Za-z0-9]*'
-    privatePropertyPattern: '_?[A-Za-z][_A-Za-z0-9]*'
-  VariableMaxLength:
-    active: false
-    maximumVariableNameLength: 64
-  VariableMinLength:
-    active: false
-    minimumVariableNameLength: 1
-  VariableNaming:
-    active: true
-    variablePattern: '[a-z][A-Za-z0-9]*'
-    privateVariablePattern: '(_)?[a-z][A-Za-z0-9]*'
-    excludeClassPattern: '$^'
-
-performance:
-  active: true
-  ArrayPrimitive:
-    active: true
-  CouldBeSequence:
-    active: false
-    threshold: 3
-  ForEachOnRange:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-  SpreadOperator:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-  UnnecessaryPartOfBinaryExpression:
-    active: false
-  UnnecessaryTemporaryInstantiation:
-    active: true
-
-potential-bugs:
-  active: true
-  AvoidReferentialEquality:
-    active: true
-    forbiddenTypePatterns:
-      - 'kotlin.String'
-  CastNullableToNonNullableType:
-    active: false
-  CastToNullableType:
-    active: false
-  Deprecation:
-    active: false
-  DontDowncastCollectionTypes:
-    active: false
-  DoubleMutabilityForCollection:
-    active: true
-    mutableTypes:
-      - 'kotlin.collections.MutableList'
-      - 'kotlin.collections.MutableMap'
-      - 'kotlin.collections.MutableSet'
-      - 'java.util.ArrayList'
-      - 'java.util.LinkedHashSet'
-      - 'java.util.HashSet'
-      - 'java.util.LinkedHashMap'
-      - 'java.util.HashMap'
-  ElseCaseInsteadOfExhaustiveWhen:
-    active: false
-    ignoredSubjectTypes: [ ]
-  EqualsAlwaysReturnsTrueOrFalse:
-    active: true
-  EqualsWithHashCodeExist:
-    active: true
-  ExitOutsideMain:
-    active: false
-  ExplicitGarbageCollectionCall:
-    active: true
-  HasPlatformType:
-    active: true
-  IgnoredReturnValue:
-    active: true
-    restrictToConfig: true
-    returnValueAnnotations:
-      - 'CheckResult'
-      - '*.CheckResult'
-      - 'CheckReturnValue'
-      - '*.CheckReturnValue'
-    ignoreReturnValueAnnotations:
-      - 'CanIgnoreReturnValue'
-      - '*.CanIgnoreReturnValue'
-    returnValueTypes:
-      - 'kotlin.sequences.Sequence'
-      - 'kotlinx.coroutines.flow.*Flow'
-      - 'java.util.stream.*Stream'
-    ignoreFunctionCall: [ ]
-  ImplicitDefaultLocale:
-    active: true
-  ImplicitUnitReturnType:
-    active: false
-    allowExplicitReturnType: true
-  InvalidRange:
-    active: true
-  IteratorHasNextCallsNextMethod:
-    active: true
-  IteratorNotThrowingNoSuchElementException:
-    active: true
-  LateinitUsage:
-    active: false
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    ignoreOnClassesPattern: ''
-  MapGetWithNotNullAssertionOperator:
-    active: true
-  MissingPackageDeclaration:
-    active: false
-    excludes: [ '**/*.kts' ]
-  NullCheckOnMutableProperty:
-    active: false
-  NullableToStringCall:
-    active: false
-  PropertyUsedBeforeDeclaration:
-    active: false
-  UnconditionalJumpStatementInLoop:
-    active: false
-  UnnecessaryNotNullCheck:
-    active: false
-  UnnecessaryNotNullOperator:
-    active: true
-  UnnecessarySafeCall:
-    active: true
-  UnreachableCatchBlock:
-    active: true
-  UnreachableCode:
-    active: true
-  UnsafeCallOnNullableType:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-  UnsafeCast:
-    active: true
-  UnusedUnaryOperator:
-    active: true
-  UselessPostfixExpression:
-    active: true
-  WrongEqualsTypeParameter:
-    active: true
-
-style:
-  active: true
-  AlsoCouldBeApply:
-    active: false
-  BracesOnIfStatements:
-    active: false
-    singleLine: 'never'
-    multiLine: 'always'
-  BracesOnWhenStatements:
-    active: false
-    singleLine: 'necessary'
-    multiLine: 'consistent'
-  CanBeNonNullable:
-    active: false
-  CascadingCallWrapping:
-    active: false
-    includeElvis: true
-  ClassOrdering:
-    active: false
-  CollapsibleIfStatements:
-    active: false
-  DataClassContainsFunctions:
-    active: false
-    conversionFunctionPrefix:
-      - 'to'
-    allowOperators: false
-  DataClassShouldBeImmutable:
-    active: false
-  DestructuringDeclarationWithTooManyEntries:
-    active: true
-    maxDestructuringEntries: 3
-  DoubleNegativeLambda:
-    active: false
-    negativeFunctions:
-      - reason: 'Use `takeIf` instead.'
-        value: 'takeUnless'
-      - reason: 'Use `all` instead.'
-        value: 'none'
-    negativeFunctionNameParts:
-      - 'not'
-      - 'non'
-  EqualsNullCall:
-    active: true
-  EqualsOnSignatureLine:
-    active: false
-  ExplicitCollectionElementAccessMethod:
-    active: false
-  ExplicitItLambdaParameter:
-    active: true
-  ExpressionBodySyntax:
-    active: false
-    includeLineWrapping: false
-  ForbiddenAnnotation:
-    active: false
-    annotations:
-      - reason: 'it is a java annotation. Use `Suppress` instead.'
-        value: 'java.lang.SuppressWarnings'
-      - reason: 'it is a java annotation. Use `kotlin.Deprecated` instead.'
-        value: 'java.lang.Deprecated'
-      - reason: 'it is a java annotation. Use `kotlin.annotation.MustBeDocumented` instead.'
-        value: 'java.lang.annotation.Documented'
-      - reason: 'it is a java annotation. Use `kotlin.annotation.Target` instead.'
-        value: 'java.lang.annotation.Target'
-      - reason: 'it is a java annotation. Use `kotlin.annotation.Retention` instead.'
-        value: 'java.lang.annotation.Retention'
-      - reason: 'it is a java annotation. Use `kotlin.annotation.Repeatable` instead.'
-        value: 'java.lang.annotation.Repeatable'
-      - reason: 'Kotlin does not support @Inherited annotation, see https://youtrack.jetbrains.com/issue/KT-22265'
-        value: 'java.lang.annotation.Inherited'
-  ForbiddenComment:
-    active: true
-    comments:
-      - reason: 'Forbidden FIXME todo marker in comment, please fix the problem.'
-        value: 'FIXME:'
-      - reason: 'Forbidden STOPSHIP todo marker in comment, please address the problem before shipping the code.'
-        value: 'STOPSHIP:'
-      - reason: 'Forbidden TODO todo marker in comment, please do the changes.'
-        value: 'TODO:'
-    allowedPatterns: ''
-  ForbiddenImport:
-    active: false
-    imports: [ ]
-    forbiddenPatterns: ''
-  ForbiddenMethodCall:
-    active: false
-    methods:
-      - reason: 'print does not allow you to configure the output stream. Use a logger instead.'
-        value: 'kotlin.io.print'
-      - reason: 'println does not allow you to configure the output stream. Use a logger instead.'
-        value: 'kotlin.io.println'
-  ForbiddenSuppress:
-    active: false
-    rules: [ ]
-  ForbiddenVoid:
-    active: true
-    ignoreOverridden: false
-    ignoreUsageInGenerics: false
-  FunctionOnlyReturningConstant:
-    active: true
-    ignoreOverridableFunction: true
-    ignoreActualFunction: true
-    excludedFunctions: [ ]
-  LoopWithTooManyJumpStatements:
-    active: true
-    maxJumpCount: 1
-  MagicNumber:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**', '**/*.kts' ]
-    ignoreNumbers:
-      - '-1'
-      - '0'
-      - '1'
-      - '2'
-    ignoreHashCodeFunction: true
-    ignorePropertyDeclaration: false
-    ignoreLocalVariableDeclaration: false
-    ignoreConstantDeclaration: true
-    ignoreCompanionObjectPropertyDeclaration: true
-    ignoreAnnotation: false
-    ignoreNamedArgument: true
-    ignoreEnums: false
-    ignoreRanges: false
-    ignoreExtensionFunctions: true
-  MandatoryBracesLoops:
-    active: false
-  MaxChainedCallsOnSameLine:
-    active: false
-    maxChainedCalls: 5
-  MaxLineLength:
-    active: false # done in ktlint
-    maxLineLength: 140 # default is 120. 140 to match ktlint
-    excludePackageStatements: true
-    excludeImportStatements: true
-    excludeCommentStatements: false
-    excludeRawStrings: true
-  MayBeConst:
-    active: true
-  ModifierOrder:
-    active: true
-  MultilineLambdaItParameter:
-    active: false
-  MultilineRawStringIndentation:
-    active: false
-    indentSize: 4
-    trimmingMethods:
-      - 'trimIndent'
-      - 'trimMargin'
-  NestedClassesVisibility:
-    active: true
-  NewLineAtEndOfFile:
-    active: false # done in ktlint
-  NoTabs:
-    active: false
-  NullableBooleanCheck:
-    active: false
-  ObjectLiteralToLambda:
-    active: true
-  OptionalAbstractKeyword:
-    active: true
-  OptionalUnit:
-    active: false
-  PreferToOverPairSyntax:
-    active: false
-  ProtectedMemberInFinalClass:
-    active: true
-  RedundantExplicitType:
-    active: false
-  RedundantHigherOrderMapUsage:
-    active: true
-  RedundantVisibilityModifierRule:
-    active: false
-  ReturnCount:
-    active: true
-    max: 2
-    excludedFunctions:
-      - 'equals'
-    excludeLabeled: false
-    excludeReturnFromLambda: true
-    excludeGuardClauses: false
-  SafeCast:
-    active: true
-  SerialVersionUIDInSerializableClass:
-    active: true
-  SpacingBetweenPackageAndImports:
-    active: false
-  StringShouldBeRawString:
-    active: false
-    maxEscapedCharacterCount: 2
-    ignoredCharacters: [ ]
-  ThrowsCount:
-    active: true
-    max: 2
-    excludeGuardClauses: false
-  TrailingWhitespace:
-    active: false
-  TrimMultilineRawString:
-    active: false
-    trimmingMethods:
-      - 'trimIndent'
-      - 'trimMargin'
-  UnderscoresInNumericLiterals:
-    active: false
-    acceptableLength: 4
-    allowNonStandardGrouping: false
-  UnnecessaryAbstractClass:
-    active: true
-  UnnecessaryAnnotationUseSiteTarget:
-    active: false
-  UnnecessaryApply:
-    active: true
-  UnnecessaryBackticks:
-    active: false
-  UnnecessaryBracesAroundTrailingLambda:
-    active: false
-  UnnecessaryFilter:
-    active: true
-  UnnecessaryInheritance:
-    active: true
-  UnnecessaryInnerClass:
-    active: false
-  UnnecessaryLet:
-    active: false
-  UnnecessaryParentheses:
-    active: false
-    allowForUnclearPrecedence: false
-  UntilInsteadOfRangeTo:
-    active: false
-  UnusedImports:
-    active: false
-  UnusedParameter:
-    active: true
-    allowedNames: 'ignored|expected'
-  UnusedPrivateClass:
-    active: true
-  UnusedPrivateMember:
-    active: true
-    allowedNames: ''
-  UnusedPrivateProperty:
-    active: true
-    allowedNames: '_|ignored|expected|serialVersionUID'
-    excludes: [ '**/build.gradle.kts' ]
-  UseAnyOrNoneInsteadOfFind:
-    active: true
-  UseArrayLiteralsInAnnotations:
-    active: true
-  UseCheckNotNull:
-    active: true
-  UseCheckOrError:
-    active: true
-  UseDataClass:
-    active: false
-    allowVars: false
-  UseEmptyCounterpart:
-    active: false
-  UseIfEmptyOrIfBlank:
-    active: false
-  UseIfInsteadOfWhen:
-    active: false
-    ignoreWhenContainingVariableDeclaration: false
-  UseIsNullOrEmpty:
-    active: true
-  UseLet:
-    active: false
-  UseOrEmpty:
-    active: true
-  UseRequire:
-    active: true
-  UseRequireNotNull:
-    active: true
-  UseSumOfInsteadOfFlatMapSize:
-    active: false
-  UselessCallOnNotNull:
-    active: true
-  UtilityClassWithPublicConstructor:
-    active: true
-  VarCouldBeVal:
-    active: true
-    ignoreLateinitVar: false
-  WildcardImport:
-    active: true
-    excludeImports:
-      - 'java.util.*'

fastlane/metadata/android/en-US/changelogs/v125010031.txt

@@ -1,14 +0,0 @@
-**v125010031**
-
-- Merge pull request 'Bump dependencies' (#173) from upgarde into master
-- chore: "faster" action.
-- fastlane: icon change.
-- chore: ignoring a pixel issue.
-- test: fixed an ui test issue.
-- fix: center the loading thing.
-- test: items displaying.
-- bump: sqldelight.
-- bump: material, desugar jdk, jsoup, kodein, settings, napier, mock.
-- bump: androix and coroutines.
-- bump: ktor. Closes #67.
-- Changelog for v124123651

fastlane/metadata/android/en-US/changelogs/v125010111.txt

@@ -1,4 +0,0 @@
-**v125010111**
-
-- Debug trying to fix context issues. (#174)
-- Changelog for v125010031

fastlane/metadata/android/en-US/changelogs/v125010131.txt

@@ -1,5 +0,0 @@
-**v125010131**
-
-- fix: reload the adapter when it's needed. Fixes #128. (#176)
-- feat: basic auth and images loading. Fixes #172. (#175)
-- Changelog for v125010111

gradle.properties

@@ -18,7 +18,7 @@ kotlin.code.style=official
 #Android
 android.useAndroidX=true
 #android.nonTransitiveRClass=true
-android.enableJetifier=false
+android.enableJetifier=true
 android.nonTransitiveRClass=false
 #MPP
 kotlin.mpp.enableCInteropCommonization=true

shared/src/androidMain/kotlin/bou/amine/apps/readerforselfossv2/dao/DeviceDatabase.kt

@@ -4,13 +4,12 @@ import android.content.Context
 import app.cash.sqldelight.db.SqlDriver
 import app.cash.sqldelight.driver.android.AndroidSqliteDriver
 
-actual class DriverFactory(
+actual class DriverFactory(private val context: Context) {
-    private val context: Context,
+    actual fun createDriver(): SqlDriver {
-) {
+        return AndroidSqliteDriver(
-    actual fun createDriver(): SqlDriver =
-        AndroidSqliteDriver(
             ReaderForSelfossDB.Schema,
             context,
-            "ReaderForSelfossV2-android.db",
+            "ReaderForSelfossV2-android.db"
         )
-}
+    }
+}

shared/src/androidMain/kotlin/bou/amine/apps/readerforselfossv2/rest/NetworkSSL.kt

@@ -8,20 +8,16 @@ class NaiveTrustManager : X509TrustManager {
     override fun checkClientTrusted(
         chain: Array<out X509Certificate>?,
         authType: String?,
-    ) {
+    ) {}
-        // Nothing
-    }
 
     override fun checkServerTrusted(
         chain: Array<out X509Certificate>?,
         authType: String?,
-    ) {
+    ) {}
-        // Nothing
-    }
 
     override fun getAcceptedIssuers(): Array<out X509Certificate> = arrayOf()
 }
 
-actual fun setupInsecureHttpEngine(config: CIOEngineConfig) {
+actual fun setupInsecureHTTPEngine(config: CIOEngineConfig) {
     config.https.trustManager = NaiveTrustManager()
 }

shared/src/androidMain/kotlin/bou/amine/apps/readerforselfossv2/utils/DateUtils.kt

@@ -1,9 +1,9 @@
 package bou.amine.apps.readerforselfossv2.utils
 
 import android.text.format.DateUtils
-import kotlinx.datetime.Clock
+import io.github.aakira.napier.Napier
+import kotlinx.datetime.*
 
-@Suppress("detekt:UtilityClassWithPublicConstructor")
 actual class DateUtils {
     actual companion object {
         actual fun parseRelativeDate(dateString: String): String {

shared/src/androidMain/kotlin/bou/amine/apps/readerforselfossv2/utils/ModelConverters.kt

@@ -4,36 +4,46 @@ import android.net.Uri
 import android.text.Html
 import bou.amine.apps.readerforselfossv2.model.SelfossModel
 import org.jsoup.Jsoup
-import java.util.Locale
+import java.util.*
 
-actual fun String.getHtmlDecoded(): String = Html.fromHtml(this).toString()
+actual fun String.getHtmlDecoded(): String {
+    return Html.fromHtml(this).toString()
+}
 
-actual fun SelfossModel.Item.getIcon(baseUrl: String): String = constructUrl(baseUrl, "favicons", icon)
+actual fun SelfossModel.Item.getIcon(baseUrl: String): String {
+    return constructUrl(baseUrl, "favicons", icon)
+}
 
-actual fun SelfossModel.Item.getThumbnail(baseUrl: String): String = constructUrl(baseUrl, "thumbnails", thumbnail)
+actual fun SelfossModel.Item.getThumbnail(baseUrl: String): String {
-
+    return constructUrl(baseUrl, "thumbnails", thumbnail)
-val IMAGE_EXTENSION_REGEXP = """\.(jpg|jpeg|png|webp)""".toRegex()
+}
 
 actual fun SelfossModel.Item.getImages(): ArrayList<String> {
     val allImages = ArrayList<String>()
 
     for (image in Jsoup.parse(content).getElementsByTag("img")) {
         val url = image.attr("src")
-        if (IMAGE_EXTENSION_REGEXP.containsMatchIn(url.lowercase(Locale.US))) {
+        if (url.lowercase(Locale.US).contains(".jpg") ||
+            url.lowercase(Locale.US).contains(".jpeg") ||
+            url.lowercase(Locale.US).contains(".png") ||
+            url.lowercase(Locale.US).contains(".webp")
+        ) {
             allImages.add(url)
         }
     }
     return allImages
 }
 
-actual fun SelfossModel.Source.getIcon(baseUrl: String): String = constructUrl(baseUrl, "favicons", icon)
+actual fun SelfossModel.Source.getIcon(baseUrl: String): String {
+    return constructUrl(baseUrl, "favicons", icon)
+}
 
 actual fun constructUrl(
     baseUrl: String,
     path: String,
     file: String?,
-): String =
+): String {
-    if (file == null || file == "null" || file.isEmpty()) {
+    return if (file == null || file == "null" || file.isEmpty()) {
         ""
     } else {
         val baseUriBuilder = Uri.parse(baseUrl).buildUpon()
@@ -41,3 +51,4 @@ actual fun constructUrl(
 
         baseUriBuilder.toString()
     }
+}

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/DI/modules.kt

@@ -1,4 +1,4 @@
-package bou.amine.apps.readerforselfossv2.di
+package bou.amine.apps.readerforselfossv2.DI
 
 import bou.amine.apps.readerforselfossv2.rest.MercuryApi
 import bou.amine.apps.readerforselfossv2.rest.SelfossApi

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/dao/DeviceDatabase.kt

@@ -4,4 +4,4 @@ import app.cash.sqldelight.db.SqlDriver
 
 expect class DriverFactory {
     fun createDriver(): SqlDriver
-}
+}

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/model/MercuryModel.kt

@@ -1,16 +1,13 @@
-@file:Suppress("detekt:LongParameterList")
-
 package bou.amine.apps.readerforselfossv2.model
 
 import kotlinx.serialization.Serializable
 
 class MercuryModel {
-    @Suppress("detekt:ConstructorParameterNaming")
     @Serializable
     class ParsedContent(
         val title: String? = null,
         val content: String? = null,
-        val lead_image_url: String? = null,
+        val lead_image_url: String? = null, // NOSONAR
         val url: String? = null,
         val error: Boolean? = null,
         val message: String? = null,

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/model/ResultModel.kt

@@ -3,20 +3,19 @@ package bou.amine.apps.readerforselfossv2.model
 import kotlinx.serialization.Serializable
 
 @Serializable
-class SuccessResponse(
+class SuccessResponse(val success: Boolean) {
-    val success: Boolean,
-) {
     val isSuccess: Boolean
         get() = success
 }
 
-class StatusAndData<T>(
+class StatusAndData<T>(val success: Boolean, val data: T? = null) {
-    val success: Boolean,
-    val data: T? = null,
-) {
     companion object {
-        fun <T> succes(d: T): StatusAndData<T> = StatusAndData(true, d)
+        fun <T> succes(d: T): StatusAndData<T> {
+            return StatusAndData(true, d)
+        }
 
-        fun <T> error(): StatusAndData<T> = StatusAndData(false)
+        fun <T> error(): StatusAndData<T> {
+            return StatusAndData(false)
+        }
     }
 }

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/model/SelfossModel.kt

@@ -1,5 +1,3 @@
-@file:Suppress("detekt:LongParameterList")
-
 package bou.amine.apps.readerforselfossv2.model
 
 import bou.amine.apps.readerforselfossv2.utils.DateUtils
@@ -20,10 +18,6 @@ import kotlinx.serialization.json.booleanOrNull
 import kotlinx.serialization.json.int
 import kotlinx.serialization.json.jsonPrimitive
 
-class ModelException(
-    message: String,
-) : Throwable(message)
-
 class SelfossModel {
     @Serializable
     data class Tag(
@@ -147,7 +141,7 @@ class SelfossModel {
             }
 
             if (stringUrl.isEmptyOrNullOrNullString()) {
-                throw ModelException("Link $link was translated to $stringUrl, but was empty. Handle this.")
+                throw Exception("Link ${link} was translated to ${stringUrl}, but was empty. Handle this.")
             }
 
             return stringUrl
@@ -176,13 +170,14 @@ class SelfossModel {
         }
     }
 
-    // this seems to be super slow.
+    // TODO: this seems to be super slow.
     object TagsListSerializer : KSerializer<List<String>> {
-        override fun deserialize(decoder: Decoder): List<String> =
+        override fun deserialize(decoder: Decoder): List<String> {
-            when (val json = ((decoder as JsonDecoder).decodeJsonElement())) {
+            return when (val json = ((decoder as JsonDecoder).decodeJsonElement())) {
                 is JsonArray -> json.toList().map { it.toString().replace("^\"|\"$".toRegex(), "") }
                 else -> json.toString().split(",")
             }
+        }
 
         override val descriptor: SerialDescriptor
             get() = PrimitiveSerialDescriptor("tags", PrimitiveKind.STRING)
@@ -193,7 +188,7 @@ class SelfossModel {
         ) {
             encoder.encodeCollection(
                 PrimitiveSerialDescriptor("tags", PrimitiveKind.STRING),
-                value.size,
+                value.size
             ) { this.toString() }
         }
     }
@@ -209,11 +204,10 @@ class SelfossModel {
         }
 
         override val descriptor: SerialDescriptor
-            get() =
+            get() = PrimitiveSerialDescriptor(
-                PrimitiveSerialDescriptor(
+                "BooleanOrIntForSomeSelfossVersions",
-                    "BooleanOrIntForSomeSelfossVersions",
+                PrimitiveKind.BOOLEAN
-                    PrimitiveKind.BOOLEAN,
+            )
-                )
 
         override fun serialize(
             encoder: Encoder,
@@ -222,4 +216,4 @@ class SelfossModel {
             TODO("Not yet implemented")
         }
     }
-}
+}

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt

@@ -1,23 +1,12 @@
-@file:Suppress("detekt:TooManyFunctions")
-
 package bou.amine.apps.readerforselfossv2.repository
 
-import bou.amine.apps.readerforselfossv2.dao.ACTION
+import bou.amine.apps.readerforselfossv2.dao.*
-import bou.amine.apps.readerforselfossv2.dao.DriverFactory
-import bou.amine.apps.readerforselfossv2.dao.ITEM
-import bou.amine.apps.readerforselfossv2.dao.ReaderForSelfossDB
-import bou.amine.apps.readerforselfossv2.dao.SOURCE
-import bou.amine.apps.readerforselfossv2.dao.TAG
 import bou.amine.apps.readerforselfossv2.model.NetworkUnavailableException
 import bou.amine.apps.readerforselfossv2.model.SelfossModel
 import bou.amine.apps.readerforselfossv2.model.StatusAndData
 import bou.amine.apps.readerforselfossv2.rest.SelfossApi
 import bou.amine.apps.readerforselfossv2.service.AppSettingsService
-import bou.amine.apps.readerforselfossv2.utils.ItemType
+import bou.amine.apps.readerforselfossv2.utils.*
-import bou.amine.apps.readerforselfossv2.utils.getHtmlDecoded
-import bou.amine.apps.readerforselfossv2.utils.toEntity
-import bou.amine.apps.readerforselfossv2.utils.toParsedDate
-import bou.amine.apps.readerforselfossv2.utils.toView
 import io.github.aakira.napier.Napier
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
@@ -25,8 +14,6 @@ import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.flow.asStateFlow
 import kotlinx.coroutines.launch
 
-private const val MAX_ITEMS_NUMBER = 200
-
 class Repository(
     private val api: SelfossApi,
     private val appSettingsService: AppSettingsService,
@@ -131,7 +118,7 @@ class Repository(
                     null,
                     null,
                     null,
-                    MAX_ITEMS_NUMBER,
+                    200,
                 )
             return if (items.success && items.data != null) {
                 items.data
@@ -143,7 +130,6 @@ class Repository(
         }
     }
 
-    @Suppress("detekt:ForbiddenComment")
     suspend fun reloadBadges(): Boolean {
         var success = false
         if (isNetworkAvailable()) {
@@ -184,8 +170,8 @@ class Repository(
         }
     }
 
-    suspend fun getSpouts(): Map<String, SelfossModel.Spout> =
+    suspend fun getSpouts(): Map<String, SelfossModel.Spout> {
-        if (isNetworkAvailable()) {
+        return if (isNetworkAvailable()) {
             val spouts = api.spouts()
             if (spouts.success && spouts.data != null) {
                 spouts.data
@@ -195,6 +181,7 @@ class Repository(
         } else {
             throw NetworkUnavailableException()
         }
+    }
 
     suspend fun getSourcesDetailsOrStats(): ArrayList<SelfossModel.Source> {
         var sources = ArrayList<SelfossModel.Source>()
@@ -247,13 +234,14 @@ class Repository(
         return success
     }
 
-    private suspend fun markAsReadById(id: Int): Boolean =
+    private suspend fun markAsReadById(id: Int): Boolean {
-        if (isNetworkAvailable()) {
+        return if (isNetworkAvailable()) {
             api.markAsRead(id.toString()).isSuccess
         } else {
             insertDBAction(id.toString(), read = true)
             true
         }
+    }
 
     suspend fun unmarkAsRead(item: SelfossModel.Item): Boolean {
         val success = unmarkAsReadById(item.id)
@@ -264,13 +252,14 @@ class Repository(
         return success
     }
 
-    private suspend fun unmarkAsReadById(id: Int): Boolean =
+    private suspend fun unmarkAsReadById(id: Int): Boolean {
-        if (isNetworkAvailable()) {
+        return if (isNetworkAvailable()) {
             api.unmarkAsRead(id.toString()).isSuccess
         } else {
             insertDBAction(id.toString(), unread = true)
             true
         }
+    }
 
     suspend fun starr(item: SelfossModel.Item): Boolean {
         val success = starrById(item.id)
@@ -281,13 +270,14 @@ class Repository(
         return success
     }
 
-    private suspend fun starrById(id: Int): Boolean =
+    private suspend fun starrById(id: Int): Boolean {
-        if (isNetworkAvailable()) {
+        return if (isNetworkAvailable()) {
             api.starr(id.toString()).isSuccess
         } else {
             insertDBAction(id.toString(), starred = true)
             true
         }
+    }
 
     suspend fun unstarr(item: SelfossModel.Item): Boolean {
         val success = unstarrById(item.id)
@@ -298,13 +288,14 @@ class Repository(
         return success
     }
 
-    private suspend fun unstarrById(id: Int): Boolean =
+    private suspend fun unstarrById(id: Int): Boolean {
-        if (isNetworkAvailable()) {
+        return if (isNetworkAvailable()) {
             api.unstarr(id.toString()).isSuccess
         } else {
             insertDBAction(id.toString(), starred = true)
             true
         }
+    }
 
     suspend fun markAllAsRead(items: ArrayList<SelfossModel.Item>): Boolean {
         var success = false
@@ -370,13 +361,12 @@ class Repository(
     ): Boolean {
         var response = false
         if (isNetworkAvailable()) {
-            response = api
+            response = api.createSourceForVersion(
-                .createSourceForVersion(
+                title,
-                    title,
+                url,
-                    url,
+                spout,
-                    spout,
+                tags,
-                    tags,
+            ).isSuccess == true
-                ).isSuccess == true
         }
 
         return response
@@ -417,12 +407,13 @@ class Repository(
         return success
     }
 
-    suspend fun updateRemote(): Boolean =
+    suspend fun updateRemote(): Boolean {
-        if (isNetworkAvailable()) {
+        return if (isNetworkAvailable()) {
             api.update().data.equals("finished")
         } else {
             false
         }
+    }
 
     suspend fun login(): Boolean {
         var result = false
@@ -431,7 +422,7 @@ class Repository(
                 val response = api.login()
                 result = response.isSuccess == true
             } catch (cause: Throwable) {
-                Napier.e("login failed", cause, tag = "Repository.login")
+                Napier.e("login failed", cause, tag = "RepositoryImpl.login")
             }
         }
         return result
@@ -445,7 +436,7 @@ class Repository(
                 // a random rss feed, that would throw a NoTransformationFoundException
                 fetchFailed = !api.getItemsWithoutCatch().success
             } catch (e: Throwable) {
-                Napier.e("checkIfFetchFails failed", e, tag = "Repository.shouldBeSelfossInstance")
+                Napier.e("checkIfFetchFails failed", e, tag = "RepositoryImpl.shouldBeSelfossInstance")
             }
         }
 
@@ -457,10 +448,10 @@ class Repository(
             try {
                 val response = api.logout()
                 if (!response.isSuccess) {
-                    Napier.e("Couldn't logout.", tag = "Repository.logout")
+                    Napier.e("Couldn't logout.", tag = "RepositoryImpl.logout")
                 }
             } catch (cause: Throwable) {
-                Napier.e("logout failed", cause, tag = "Repository.logout")
+                Napier.e("logout failed", cause, tag = "RepositoryImpl.logout")
             }
             appSettingsService.clearAll()
         } else {
@@ -564,7 +555,6 @@ class Repository(
             item.id.toString(),
         )
 
-    @Suppress("detekt:SwallowedException")
     suspend fun tryToCacheItemsAndGetNewOnes(): List<SelfossModel.Item> {
         try {
             val newItems = getMaxItemsForBackground(ItemType.UNREAD)
@@ -588,19 +578,16 @@ class Repository(
                         markAsReadById(action.articleid.toInt()),
                         action,
                     )
-
                 action.unread ->
                     doAndReportOnFail(
                         unmarkAsReadById(action.articleid.toInt()),
                         action,
                     )
-
                 action.starred ->
                     doAndReportOnFail(
                         starrById(action.articleid.toInt()),
                         action,
                     )
-
                 action.unstarred ->
                     doAndReportOnFail(
                         unstarrById(action.articleid.toInt()),
@@ -631,7 +618,9 @@ class Repository(
         _readerItems = readerItems
     }
 
-    fun getReaderItems(): ArrayList<SelfossModel.Item> = _readerItems
+    fun getReaderItems(): ArrayList<SelfossModel.Item> {
+        return _readerItems
+    }
 
     fun migrate(driverFactory: DriverFactory) {
         ReaderForSelfossDB.Schema.migrate(driverFactory.createDriver(), 0, 1)
@@ -645,5 +634,7 @@ class Repository(
         _selectedSource = null
     }
 
-    fun getSelectedSource(): SelfossModel.SourceDetail? = _selectedSource
+    fun getSelectedSource(): SelfossModel.SourceDetail? {
+        return _selectedSource
+    }
 }

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/rest/MercuryApi.kt

@@ -17,8 +17,8 @@ import kotlinx.serialization.json.Json
 class MercuryApi {
     var client = createHttpClient()
 
-    private fun createHttpClient(): HttpClient =
+    private fun createHttpClient(): HttpClient {
-        HttpClient {
+        return HttpClient {
             install(HttpCache)
             install(ContentNegotiation) {
                 json(
@@ -40,6 +40,7 @@ class MercuryApi {
             }
             expectSuccess = false
         }
+    }
 
     suspend fun query(url: String): StatusAndData<MercuryModel.ParsedContent> =
         bodyOrFailure(
@@ -47,4 +48,4 @@ class MercuryApi {
                 parameter("link", url)
             },
         )
-}
+}

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/rest/RestUtils.kt

@@ -3,28 +3,23 @@ package bou.amine.apps.readerforselfossv2.rest
 import bou.amine.apps.readerforselfossv2.model.StatusAndData
 import bou.amine.apps.readerforselfossv2.model.SuccessResponse
 import io.github.aakira.napier.Napier
-import io.ktor.client.HttpClient
+import io.ktor.client.*
-import io.ktor.client.call.body
+import io.ktor.client.call.*
-import io.ktor.client.request.HttpRequestBuilder
+import io.ktor.client.request.*
-import io.ktor.client.request.delete
+import io.ktor.client.request.forms.*
-import io.ktor.client.request.forms.submitForm
+import io.ktor.client.statement.*
-import io.ktor.client.request.get
+import io.ktor.http.*
-import io.ktor.client.request.post
-import io.ktor.client.request.url
-import io.ktor.client.statement.HttpResponse
-import io.ktor.http.HttpStatusCode
-import io.ktor.http.Parameters
-import io.ktor.http.isSuccess
 
-suspend fun responseOrSuccessIf404(r: HttpResponse?): SuccessResponse =
+suspend fun responseOrSuccessIf404(r: HttpResponse?): SuccessResponse {
-    if (r != null && r.status === HttpStatusCode.NotFound) {
+    return if (r != null && r.status === HttpStatusCode.NotFound) {
         SuccessResponse(true)
     } else {
         maybeResponse(r)
     }
+}
 
-suspend fun maybeResponse(r: HttpResponse?): SuccessResponse =
+suspend fun maybeResponse(r: HttpResponse?): SuccessResponse {
-    if (r != null && r.status.isSuccess()) {
+    return if (r != null && r.status.isSuccess()) {
         r.body()
     } else {
         if (r != null) {
@@ -32,8 +27,8 @@ suspend fun maybeResponse(r: HttpResponse?): SuccessResponse =
         }
         SuccessResponse(false)
     }
+}
 
-@Suppress("detekt:SwallowedException")
 suspend inline fun <reified T> bodyOrFailure(r: HttpResponse?): StatusAndData<T> {
     try {
         return if (r != null && r.status.isSuccess()) {
@@ -103,4 +98,4 @@ suspend fun HttpClient.tryToSubmitForm(
             url(url)
             block()
         }
-    }
+    }

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/rest/SelfossApi.kt

@@ -1,5 +1,3 @@
-@file:Suppress("detekt:TooManyFunctions", "detekt:LongParameterList", "detekt:LargeClass")
-
 package bou.amine.apps.readerforselfossv2.rest
 
 import bou.amine.apps.readerforselfossv2.model.SelfossModel
@@ -35,20 +33,16 @@ import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
 import kotlinx.serialization.json.Json
 
-expect fun setupInsecureHttpEngine(config: CIOEngineConfig)
+expect fun setupInsecureHTTPEngine(config: CIOEngineConfig)
 
-private const val VERSION_WHERE_POST_LOGIN_SHOULD_WORK = 5
+class SelfossApi(private val appSettingsService: AppSettingsService) {
-
-class SelfossApi(
-    private val appSettingsService: AppSettingsService,
-) {
     var client = createHttpClient()
 
     fun createHttpClient() =
         HttpClient(CIO) {
             if (appSettingsService.getSelfSigned()) {
                 engine {
-                    setupInsecureHttpEngine(this)
+                    setupInsecureHTTPEngine(this)
                 }
             }
             install(HttpCache)
@@ -111,14 +105,12 @@ class SelfossApi(
 
     private fun hasLoginInfo() =
         appSettingsService.getUserName().isNotEmpty() &&
-            appSettingsService
+                appSettingsService.getPassword()
-                .getPassword()
+                    .isNotEmpty()
-                .isNotEmpty()
 
     suspend fun login(): SuccessResponse =
         if (appSettingsService.getUserName().isNotEmpty() &&
-            appSettingsService
+            appSettingsService.getPassword()
-                .getPassword()
                 .isNotEmpty()
         ) {
             if (shouldHavePostLogin()) {
@@ -135,10 +127,8 @@ class SelfossApi(
             client.tryToGet(url("/login")) {
                 parameter("username", appSettingsService.getUserName())
                 parameter("password", appSettingsService.getPassword())
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -160,10 +150,8 @@ class SelfossApi(
             client.tryToPost(url("/login")) {
                 parameter("username", appSettingsService.getUserName())
                 parameter("password", appSettingsService.getPassword())
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -180,7 +168,8 @@ class SelfossApi(
             },
         )
 
-    private fun shouldHaveNewLogout() = appSettingsService.getApiVersion() >= VERSION_WHERE_POST_LOGIN_SHOULD_WORK // We are missing 4.1.0
+    private fun shouldHaveNewLogout() =
+        appSettingsService.getApiVersion() >= 5 // We are missing 4.1.0
 
     suspend fun logout(): SuccessResponse =
         if (shouldHaveNewLogout()) {
@@ -192,10 +181,8 @@ class SelfossApi(
     private suspend fun maybeLogoutIfAvailable() =
         responseOrSuccessIf404(
             client.tryToGet(url("/logout")) {
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -215,10 +202,8 @@ class SelfossApi(
     private suspend fun doLogout() =
         maybeResponse(
             client.tryToDelete(url("/api/session/current")) {
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -257,10 +242,8 @@ class SelfossApi(
                 parameter("updatedsince", updatedSince)
                 parameter("items", items ?: appSettingsService.getItemsNumber())
                 parameter("offset", offset)
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -286,10 +269,8 @@ class SelfossApi(
                 }
                 parameter("type", "all")
                 parameter("items", 1)
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -313,10 +294,8 @@ class SelfossApi(
                     parameter("username", appSettingsService.getUserName())
                     parameter("password", appSettingsService.getPassword())
                 }
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -340,10 +319,8 @@ class SelfossApi(
                     parameter("username", appSettingsService.getUserName())
                     parameter("password", appSettingsService.getPassword())
                 }
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -367,10 +344,8 @@ class SelfossApi(
                     parameter("username", appSettingsService.getUserName())
                     parameter("password", appSettingsService.getPassword())
                 }
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -394,10 +369,8 @@ class SelfossApi(
                     parameter("username", appSettingsService.getUserName())
                     parameter("password", appSettingsService.getPassword())
                 }
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -421,10 +394,8 @@ class SelfossApi(
                     parameter("username", appSettingsService.getUserName())
                     parameter("password", appSettingsService.getPassword())
                 }
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -448,10 +419,8 @@ class SelfossApi(
                     parameter("username", appSettingsService.getUserName())
                     parameter("password", appSettingsService.getPassword())
                 }
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -471,10 +440,8 @@ class SelfossApi(
     suspend fun apiInformation(): StatusAndData<SelfossModel.ApiInformation> =
         bodyOrFailure(
             client.tryToGet(url("/api/about")) {
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -498,10 +465,8 @@ class SelfossApi(
                     parameter("username", appSettingsService.getUserName())
                     parameter("password", appSettingsService.getPassword())
                 }
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -525,10 +490,8 @@ class SelfossApi(
                     parameter("username", appSettingsService.getUserName())
                     parameter("password", appSettingsService.getPassword())
                 }
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -552,10 +515,8 @@ class SelfossApi(
                     parameter("username", appSettingsService.getUserName())
                     parameter("password", appSettingsService.getPassword())
                 }
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -579,10 +540,8 @@ class SelfossApi(
                     parameter("username", appSettingsService.getUserName())
                     parameter("password", appSettingsService.getPassword())
                 }
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -604,18 +563,16 @@ class SelfossApi(
             client.tryToSubmitForm(
                 url = url("/mark"),
                 formParameters =
-                    Parameters.build {
+                Parameters.build {
-                        if (!shouldHavePostLogin()) {
+                    if (!shouldHavePostLogin()) {
-                            append("username", appSettingsService.getUserName())
+                        append("username", appSettingsService.getUserName())
-                            append("password", appSettingsService.getPassword())
+                        append("password", appSettingsService.getPassword())
-                        }
+                    }
-                        ids.map { append("ids[]", it) }
+                    ids.map { append("ids[]", it) }
-                    },
+                },
                 block = {
-                    if (appSettingsService
+                    if (appSettingsService.getBasicUserName()
-                            .getBasicUserName()
+                            .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                            .isNotEmpty() &&
-                        appSettingsService.getBasicPassword().isNotEmpty()
                     ) {
                         headers {
                             append(
@@ -657,21 +614,19 @@ class SelfossApi(
         client.tryToSubmitForm(
             url = url("/source"),
             formParameters =
-                Parameters.build {
+            Parameters.build {
-                    if (!shouldHavePostLogin()) {
+                if (!shouldHavePostLogin()) {
-                        append("username", appSettingsService.getUserName())
+                    append("username", appSettingsService.getUserName())
-                        append("password", appSettingsService.getPassword())
+                    append("password", appSettingsService.getPassword())
-                    }
+                }
-                    append("title", title)
+                append("title", title)
-                    append("url", url)
+                append("url", url)
-                    append("spout", spout)
+                append("spout", spout)
-                    append(tagsParamName, tags)
+                append(tagsParamName, tags)
-                },
+            },
             block = {
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -714,21 +669,19 @@ class SelfossApi(
         client.tryToSubmitForm(
             url = url("/source/$id"),
             formParameters =
-                Parameters.build {
+            Parameters.build {
-                    if (!shouldHavePostLogin()) {
+                if (!shouldHavePostLogin()) {
-                        append("username", appSettingsService.getUserName())
+                    append("username", appSettingsService.getUserName())
-                        append("password", appSettingsService.getPassword())
+                    append("password", appSettingsService.getPassword())
-                    }
+                }
-                    append("title", title)
+                append("title", title)
-                    append("url", url)
+                append("url", url)
-                    append("spout", spout)
+                append("spout", spout)
-                    append(tagsParamName, tags)
+                append(tagsParamName, tags)
-                },
+            },
             block = {
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -752,10 +705,8 @@ class SelfossApi(
                     parameter("username", appSettingsService.getUserName())
                     parameter("password", appSettingsService.getPassword())
                 }
-                if (appSettingsService
+                if (appSettingsService.getBasicUserName()
-                        .getBasicUserName()
+                        .isNotEmpty() && appSettingsService.getBasicPassword().isNotEmpty()
-                        .isNotEmpty() &&
-                    appSettingsService.getBasicPassword().isNotEmpty()
                 ) {
                     headers {
                         append(
@@ -771,4 +722,4 @@ class SelfossApi(
                 }
             },
         )
-}
+}

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/service/ACRASettings.kt

@@ -1,5 +1,3 @@
-@file:Suppress("detekt:TooManyFunctions")
-
 package bou.amine.apps.readerforselfossv2.service
 
 import com.russhwolf.settings.Settings
@@ -123,4 +121,4 @@ class ACRASettings : Settings {
         longs.remove(key)
         strings.remove(key)
     }
-}
+}

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/service/AppSettingsService.kt

@@ -1,22 +1,8 @@
-@file:Suppress("detekt:TooManyFunctions")
-
 package bou.amine.apps.readerforselfossv2.service
 
 import com.russhwolf.settings.Settings
 
-private const val DEFAULT_FONT_SIZE = 16
+class AppSettingsService(acraSenderServiceProcess: Boolean = false) {
-
-private const val DEFAULT_REFRESH_MINUTES = 360L
-
-private const val MIN_REFRESH_MINUTES = 15L
-
-private const val DEFAULT_API_TIMEOUT = 60L
-
-private const val DEFAULT_ITEMS_NUMBER = 20
-
-class AppSettingsService(
-    acraSenderServiceProcess: Boolean = false,
-) {
     val settings: Settings =
         if (acraSenderServiceProcess) {
             ACRASettings()
@@ -25,36 +11,37 @@ class AppSettingsService(
         }
 
     // Api related
-    private var apiVersion: Int = -1
+    private var _apiVersion: Int = -1
-    private var publicAccess: Boolean? = null
+    private var _publicAccess: Boolean? = null
-    private var selfSigned: Boolean? = null
+    private var _selfSigned: Boolean? = null
-    private var baseUrl: String = ""
+    private var _baseUrl: String = ""
-    private var userName: String = ""
+    private var _userName: String = ""
-    private var basicUserName: String = ""
+    private var _basicUserName: String = ""
-    private var password: String = ""
+    private var _password: String = ""
-    private var basicPassword: String = ""
+    private var _basicPassword: String = ""
 
     // User settings related
-    private var itemsCaching: Boolean? = null
+    private var _itemsCaching: Boolean? = null
-    private var articleViewer: Boolean? = null
+    private var _articleViewer: Boolean? = null
-    private var shouldBeCardView: Boolean? = null
+    private var _shouldBeCardView: Boolean? = null
-    private var displayUnreadCount: Boolean? = null
+    private var _displayUnreadCount: Boolean? = null
-    private var displayAllCount: Boolean? = null
+    private var _displayAllCount: Boolean? = null
-    private var fullHeightCards: Boolean? = null
+    private var _fullHeightCards: Boolean? = null
-    private var updateSources: Boolean? = null
+    private var _updateSources: Boolean? = null
-    private var periodicRefresh: Boolean? = null
+    private var _periodicRefresh: Boolean? = null
-    private var refreshWhenChargingOnly: Boolean? = null
+    private var _refreshWhenChargingOnly: Boolean? = null
-    private var infiniteLoading: Boolean? = null
+    private var _infiniteLoading: Boolean? = null
-    private var notifyNewItems: Boolean? = null
+    private var _notifyNewItems: Boolean? = null
-    private var itemsNumber: Int? = null
+    private var _itemsNumber: Int? = null
-    private var apiTimeout: Long? = null
+    private var _apiTimeout: Long? = null
-    private var refreshMinutes: Long = DEFAULT_REFRESH_MINUTES
+    private var _refreshMinutes: Long = 360
-    private var markOnScroll: Boolean? = null
+    private var _markOnScroll: Boolean? = null
-    private var activeAlignment: Int? = null
+    private var _activeAlignment: Int? = null
 
-    private var fontSize: Int? = null
+    private var _fontSize: Int? = null
-    private var font: String = ""
+    private var _staticBar: Boolean? = null
-    private var theme: Int? = null
+    private var _font: String = ""
+    private var _theme: Int? = null
 
     init {
         refreshApiSettings()
@@ -62,11 +49,11 @@ class AppSettingsService(
     }
 
     fun getApiVersion(): Int {
-        if (apiVersion == -1) {
+        if (_apiVersion == -1) {
             refreshApiVersion()
-            return apiVersion
+            return _apiVersion
         }
-        return apiVersion
+        return _apiVersion
     }
 
     fun updateApiVersion(apiMajorVersion: Int) {
@@ -75,14 +62,14 @@ class AppSettingsService(
     }
 
     private fun refreshApiVersion() {
-        apiVersion = settings.getInt(API_VERSION_MAJOR, -1)
+        _apiVersion = settings.getInt(API_VERSION_MAJOR, -1)
     }
 
     fun getPublicAccess(): Boolean {
-        if (publicAccess == null) {
+        if (_publicAccess == null) {
             refreshPublicAccess()
         }
-        return publicAccess!!
+        return _publicAccess!!
     }
 
     fun updatePublicAccess(publicAccess: Boolean) {
@@ -91,14 +78,14 @@ class AppSettingsService(
     }
 
     private fun refreshPublicAccess() {
-        publicAccess = settings.getBoolean(API_PUBLIC_ACCESS, false)
+        _publicAccess = settings.getBoolean(API_PUBLIC_ACCESS, false)
     }
 
     fun getSelfSigned(): Boolean {
-        if (selfSigned == null) {
+        if (_selfSigned == null) {
             refreshSelfSigned()
         }
-        return selfSigned!!
+        return _selfSigned!!
     }
 
     fun updateSelfSigned(selfSigned: Boolean) {
@@ -107,304 +94,312 @@ class AppSettingsService(
     }
 
     private fun refreshSelfSigned() {
-        selfSigned = settings.getBoolean(API_SELF_SIGNED, false)
+        _selfSigned = settings.getBoolean(API_SELF_SIGNED, false)
     }
 
     fun getBaseUrl(): String {
-        if (baseUrl.isEmpty()) {
+        if (_baseUrl.isEmpty()) {
             refreshBaseUrl()
         }
-        return baseUrl
+        return _baseUrl
     }
 
     fun getUserName(): String {
-        if (userName.isEmpty()) {
+        if (_userName.isEmpty()) {
             refreshUsername()
         }
-        return userName
+        return _userName
     }
 
     fun getPassword(): String {
-        if (password.isEmpty()) {
+        if (_password.isEmpty()) {
             refreshPassword()
         }
-        return password
+        return _password
     }
 
     fun getBasicUserName(): String {
-        if (basicUserName.isEmpty()) {
+        if (_basicUserName.isEmpty()) {
             refreshBasicUsername()
         }
-        return basicUserName
+        return _basicUserName
     }
 
     fun getBasicPassword(): String {
-        if (basicPassword.isEmpty()) {
+        if (_basicPassword.isEmpty()) {
             refreshBasicPassword()
         }
-        return basicPassword
+        return _basicPassword
     }
 
     fun getItemsNumber(): Int {
-        if (itemsNumber == null) {
+        if (_itemsNumber == null) {
             refreshItemsNumber()
         }
-        return itemsNumber!!
+        return _itemsNumber!!
     }
 
-    @Suppress("detekt:SwallowedException")
     private fun refreshItemsNumber() {
-        itemsNumber =
+        _itemsNumber =
             try {
-                settings.getString(API_ITEMS_NUMBER, DEFAULT_ITEMS_NUMBER.toString()).toInt()
+                settings.getString(API_ITEMS_NUMBER, "20").toInt()
             } catch (e: Exception) {
                 settings.remove(API_ITEMS_NUMBER)
-                DEFAULT_ITEMS_NUMBER
+                20
             }
     }
 
     fun getApiTimeout(): Long {
-        if (apiTimeout == null) {
+        if (_apiTimeout == null) {
             refreshApiTimeout()
         }
-        return apiTimeout!!
+        return _apiTimeout!!
     }
 
-    @Suppress("detekt:MagicNumber")
     private fun secToMs(n: Long) = n * 1000
 
-    @Suppress("detekt:SwallowedException")
     private fun refreshApiTimeout() {
-        apiTimeout =
+        _apiTimeout =
             secToMs(
                 try {
-                    val settingsTimeout = settings.getString(API_TIMEOUT, DEFAULT_API_TIMEOUT.toString())
+                    val settingsTimeout = settings.getString(API_TIMEOUT, "60")
                     if (settingsTimeout.toLong() > 0) {
                         settingsTimeout.toLong()
                     } else {
                         settings.remove(API_TIMEOUT)
-                        DEFAULT_API_TIMEOUT
+                        60
                     }
                 } catch (e: Exception) {
                     settings.remove(API_TIMEOUT)
-                    DEFAULT_API_TIMEOUT
+                    60
                 },
             )
     }
 
     private fun refreshBaseUrl() {
-        baseUrl = settings.getString(BASE_URL, "")
+        _baseUrl = settings.getString(BASE_URL, "")
     }
 
     private fun refreshUsername() {
-        userName = settings.getString(LOGIN, "")
+        _userName = settings.getString(LOGIN, "")
     }
 
     private fun refreshPassword() {
-        password = settings.getString(PASSWORD, "")
+        _password = settings.getString(PASSWORD, "")
     }
 
     private fun refreshBasicUsername() {
-        basicUserName = settings.getString(BASIC_LOGIN, "")
+        _basicUserName = settings.getString(BASIC_LOGIN, "")
     }
 
     private fun refreshBasicPassword() {
-        basicPassword = settings.getString(BASIC_PASSWORD, "")
+        _basicPassword = settings.getString(BASIC_PASSWORD, "")
     }
 
     private fun refreshArticleViewerEnabled() {
-        articleViewer = settings.getBoolean(PREFER_ARTICLE_VIEWER, true)
+        _articleViewer = settings.getBoolean(PREFER_ARTICLE_VIEWER, true)
     }
 
     fun isArticleViewerEnabled(): Boolean {
-        if (articleViewer != null) {
+        if (_articleViewer != null) {
             refreshArticleViewerEnabled()
         }
-        return articleViewer == true
+        return _articleViewer == true
     }
 
     private fun refreshShouldBeCardViewEnabled() {
-        shouldBeCardView = settings.getBoolean(CARD_VIEW_ACTIVE, false)
+        _shouldBeCardView = settings.getBoolean(CARD_VIEW_ACTIVE, false)
     }
 
     fun isCardViewEnabled(): Boolean {
-        if (shouldBeCardView != null) {
+        if (_shouldBeCardView != null) {
             refreshShouldBeCardViewEnabled()
         }
-        return shouldBeCardView == true
+        return _shouldBeCardView == true
     }
 
     private fun refreshDisplayUnreadCountEnabled() {
-        displayUnreadCount = settings.getBoolean(DISPLAY_UNREAD_COUNT, true)
+        _displayUnreadCount = settings.getBoolean(DISPLAY_UNREAD_COUNT, true)
     }
 
     fun isDisplayUnreadCountEnabled(): Boolean {
-        if (displayUnreadCount != null) {
+        if (_displayUnreadCount != null) {
             refreshDisplayUnreadCountEnabled()
         }
-        return displayUnreadCount == true
+        return _displayUnreadCount == true
     }
 
     private fun refreshDisplayAllCountEnabled() {
-        displayAllCount = settings.getBoolean(DISPLAY_OTHER_COUNT, false)
+        _displayAllCount = settings.getBoolean(DISPLAY_OTHER_COUNT, false)
     }
 
     fun isDisplayAllCountEnabled(): Boolean {
-        if (displayAllCount != null) {
+        if (_displayAllCount != null) {
             refreshDisplayAllCountEnabled()
         }
-        return displayAllCount == true
+        return _displayAllCount == true
     }
 
     private fun refreshFullHeightCardsEnabled() {
-        fullHeightCards = settings.getBoolean(FULL_HEIGHT_CARDS, false)
+        _fullHeightCards = settings.getBoolean(FULL_HEIGHT_CARDS, false)
     }
 
     fun isFullHeightCardsEnabled(): Boolean {
-        if (fullHeightCards != null) {
+        if (_fullHeightCards != null) {
             refreshFullHeightCardsEnabled()
         }
-        return fullHeightCards == true
+        return _fullHeightCards == true
     }
 
     private fun refreshUpdateSourcesEnabled() {
-        updateSources = settings.getBoolean(UPDATE_SOURCES, true)
+        _updateSources = settings.getBoolean(UPDATE_SOURCES, true)
     }
 
     fun isUpdateSourcesEnabled(): Boolean {
-        if (updateSources != null) {
+        if (_updateSources != null) {
             refreshUpdateSourcesEnabled()
         }
-        return updateSources == true
+        return _updateSources == true
     }
 
     private fun refreshPeriodicRefreshEnabled() {
-        periodicRefresh = settings.getBoolean(PERIODIC_REFRESH, false)
+        _periodicRefresh = settings.getBoolean(PERIODIC_REFRESH, false)
     }
 
     fun isPeriodicRefreshEnabled(): Boolean {
-        if (periodicRefresh != null) {
+        if (_periodicRefresh != null) {
             refreshPeriodicRefreshEnabled()
         }
-        return periodicRefresh == true
+        return _periodicRefresh == true
     }
 
     private fun refreshRefreshWhenChargingOnlyEnabled() {
-        refreshWhenChargingOnly = settings.getBoolean(REFRESH_WHEN_CHARGING, false)
+        _refreshWhenChargingOnly = settings.getBoolean(REFRESH_WHEN_CHARGING, false)
     }
 
     fun isRefreshWhenChargingOnlyEnabled(): Boolean {
-        if (refreshWhenChargingOnly != null) {
+        if (_refreshWhenChargingOnly != null) {
             refreshRefreshWhenChargingOnlyEnabled()
         }
-        return refreshWhenChargingOnly == true
+        return _refreshWhenChargingOnly == true
     }
 
     private fun refreshRefreshMinutes() {
-        refreshMinutes = settings.getString(PERIODIC_REFRESH_MINUTES, DEFAULT_REFRESH_MINUTES.toString()).toLong()
+        _refreshMinutes = settings.getString(PERIODIC_REFRESH_MINUTES, "360").toLong()
-        if (refreshMinutes <= MIN_REFRESH_MINUTES) {
+        if (_refreshMinutes <= 15) {
-            refreshMinutes = MIN_REFRESH_MINUTES
+            _refreshMinutes = 15
         }
     }
 
     fun getRefreshMinutes(): Long {
-        if (refreshMinutes != DEFAULT_REFRESH_MINUTES) {
+        if (_refreshMinutes != 360L) {
             refreshRefreshMinutes()
         }
-        return refreshMinutes
+        return _refreshMinutes
     }
 
     private fun refreshInfiniteLoadingEnabled() {
-        infiniteLoading = settings.getBoolean(INFINITE_LOADING, false)
+        _infiniteLoading = settings.getBoolean(INFINITE_LOADING, false)
     }
 
     fun isInfiniteLoadingEnabled(): Boolean {
-        if (infiniteLoading != null) {
+        if (_infiniteLoading != null) {
             refreshInfiniteLoadingEnabled()
         }
-        return infiniteLoading == true
+        return _infiniteLoading == true
     }
 
     private fun refreshItemCachingEnabled() {
-        itemsCaching = settings.getBoolean(ITEMS_CACHING, false)
+        _itemsCaching = settings.getBoolean(ITEMS_CACHING, false)
     }
 
     fun isItemCachingEnabled(): Boolean {
-        if (itemsCaching != null) {
+        if (_itemsCaching != null) {
             refreshItemCachingEnabled()
         }
-        return itemsCaching == true
+        return _itemsCaching == true
     }
 
     private fun refreshNotifyNewItemsEnabled() {
-        notifyNewItems = settings.getBoolean(NOTIFY_NEW_ITEMS, false)
+        _notifyNewItems = settings.getBoolean(NOTIFY_NEW_ITEMS, false)
     }
 
     fun isNotifyNewItemsEnabled(): Boolean {
-        if (notifyNewItems != null) {
+        if (_notifyNewItems != null) {
             refreshNotifyNewItemsEnabled()
         }
-        return notifyNewItems == true
+        return _notifyNewItems == true
     }
 
     private fun refreshMarkOnScrollEnabled() {
-        markOnScroll = settings.getBoolean(MARK_ON_SCROLL, false)
+        _markOnScroll = settings.getBoolean(MARK_ON_SCROLL, false)
     }
 
     fun isMarkOnScrollEnabled(): Boolean {
-        if (markOnScroll != null) {
+        if (_markOnScroll != null) {
             refreshMarkOnScrollEnabled()
         }
-        return markOnScroll == true
+        return _markOnScroll == true
     }
 
     private fun refreshActiveAllignment() {
-        activeAlignment = settings.getInt(TEXT_ALIGN, JUSTIFY)
+        _activeAlignment = settings.getInt(TEXT_ALIGN, JUSTIFY)
     }
 
     fun getActiveAllignment(): Int {
-        if (activeAlignment != null) {
+        if (_activeAlignment != null) {
             refreshActiveAllignment()
         }
-        return activeAlignment ?: JUSTIFY
+        return _activeAlignment ?: JUSTIFY
     }
 
     fun changeAllignment(allignment: Int) {
         settings.putInt(TEXT_ALIGN, allignment)
-        activeAlignment = allignment
+        _activeAlignment = allignment
     }
 
     private fun refreshFontSize() {
-        fontSize = settings.getString(READER_FONT_SIZE, "16").toInt()
+        _fontSize = settings.getString(READER_FONT_SIZE, "16").toInt()
     }
 
     fun getFontSize(): Int {
-        if (fontSize != null) {
+        if (_fontSize != null) {
             refreshFontSize()
         }
-        return fontSize ?: DEFAULT_FONT_SIZE
+        return _fontSize ?: 16
+    }
+
+    private fun refreshStaticBarEnabled() {
+        _staticBar = settings.getBoolean(READER_STATIC_BAR, false)
+    }
+
+    fun isStaticBarEnabled(): Boolean {
+        if (_staticBar != null) {
+            refreshStaticBarEnabled()
+        }
+        return _staticBar == true
     }
 
     private fun refreshFont() {
-        font = settings.getString(READER_FONT, "")
+        _font = settings.getString(READER_FONT, "")
     }
 
     fun getFont(): String {
-        if (font.isEmpty()) {
+        if (_font.isEmpty()) {
             refreshFont()
         }
-        return font
+        return _font
     }
 
     private fun refreshCurrentTheme() {
-        theme = settings.getString(CURRENT_THEME, "-1").toInt()
+        _theme = settings.getString(CURRENT_THEME, "-1").toInt()
     }
 
     fun getCurrentTheme(): Int {
-        if (theme == null) {
+        if (_theme == null) {
             refreshCurrentTheme()
         }
-        return theme ?: -1
+        return _theme ?: -1
     }
 
     fun refreshApiSettings() {
@@ -437,6 +432,7 @@ class AppSettingsService(
         refreshActiveAllignment()
         refreshFontSize()
         refreshFont()
+        refreshStaticBarEnabled()
         refreshCurrentTheme()
     }
 
@@ -482,15 +478,15 @@ class AppSettingsService(
     }
 
     companion object {
-        const val TRANSLATION_URL = "https://crwd.in/readerforselfoss"
+        const val translationUrl = "https://crwd.in/readerforselfoss"
 
-        const val SOURCE_URL = "https://gitea.amine-bouabdallaoui.fr/Louvorg/ReaderForSelfoss-multiplatform"
+        const val sourceUrl = "https://gitea.amine-bouabdallaoui.fr/Louvorg/ReaderForSelfoss-multiplatform"
 
-        const val BUG_URL = "https://gitea.amine-bouabdallaoui.fr/Louvorg/ReaderForSelfoss-multiplatform/issues"
+        const val trackerUrl = "https://gitea.amine-bouabdallaoui.fr/Louvorg/ReaderForSelfoss-multiplatform/issues"
 
-        const val SYNC_CHANNEL_ID = "sync-channel-id"
+        const val syncChannelId = "sync-channel-id"
 
-        const val NEW_ITEMS_CHANNEL = "new-items-channel-id"
+        const val newItemsChannelId = "new-items-channel-id"
 
         const val JUSTIFY = 1
 
@@ -534,6 +530,8 @@ class AppSettingsService(
 
         const val READER_FONT = "reader_font"
 
+        const val READER_STATIC_BAR = "reader_static_bar"
+
         const val READER_FONT_SIZE = "reader_font_size"
 
         const val TEXT_ALIGN = "text_align"

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/utils/DateUtils.kt

@@ -4,12 +4,6 @@ import kotlinx.datetime.LocalDateTime
 import kotlinx.datetime.TimeZone
 import kotlinx.datetime.toInstant
 
-class DateParseException(
-    message: String,
-    e: Throwable? = null,
-) : Throwable(message, e)
-
-@Suppress("detekt:ThrowsCount")
 fun String.toParsedDate(): Long {
     // Possible formats are
     // yyyy-mm-dd hh:mm:ss format
@@ -23,22 +17,17 @@ fun String.toParsedDate(): Long {
             if (this.matches(oldVersionFormat)) {
                 this.replace(" ", "T")
             } else if (this.matches(newVersionFormat)) {
-                newVersionFormat
+                newVersionFormat.find(this)?.groups?.get(1)?.value ?: throw Exception("Couldn't parse $this")
-                    .find(this)
-                    ?.groups
-                    ?.get(1)
-                    ?.value ?: throw DateParseException("Couldn't parse $this")
             } else {
-                throw DateParseException("Unrecognized format for $this")
+                throw Exception("Unrecognized format for $this")
             }
         } catch (e: Exception) {
-            throw DateParseException("parseDate failed for $this", e)
+            throw Exception("parseDate failed for $this", e)
         }
 
     return LocalDateTime.parse(isoDateString).toInstant(TimeZone.currentSystemDefault()).toEpochMilliseconds()
 }
 
-@Suppress("detekt:UtilityClassWithPublicConstructor")
 expect class DateUtils() {
     companion object {
         fun parseRelativeDate(dateString: String): String

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/utils/EntityUtils.kt

@@ -17,7 +17,7 @@ fun SOURCE.toView(): SelfossModel.SourceDetail =
         this.id.toInt(),
         this.title,
         null,
-        this.tags.split(","),
+        this.tags?.split(","),
         this.spout,
         this.error,
         this.icon,
@@ -74,7 +74,6 @@ fun SelfossModel.Item.toEntity(): ITEM =
         this.author,
     )
 
-@Suppress("detekt:MagicNumber")
 fun SelfossModel.Tag.getColorHexCode(): String =
     if (this.color.length == 4) { // #000
         val char1 = this.color.get(1)
@@ -83,4 +82,4 @@ fun SelfossModel.Tag.getColorHexCode(): String =
         "#$char1$char1$char2$char2$char3$char3"
     } else {
         this.color
-    }
+    }

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/utils/Enums.kt

@@ -1,10 +1,6 @@
 package bou.amine.apps.readerforselfossv2.utils
 
-@Suppress("detekt:MagicNumber")
+enum class ItemType(val position: Int, val type: String) {
-enum class ItemType(
-    val position: Int,
-    val type: String,
-) {
     UNREAD(1, "unread"),
     ALL(2, "all"),
     STARRED(3, "starred"),

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/utils/StringUtils.kt

@@ -2,7 +2,6 @@ package bou.amine.apps.readerforselfossv2.utils
 
 fun String?.isEmptyOrNullOrNullString(): Boolean = this == null || this == "null" || this.isEmpty()
 
-@Suppress("detekt:MagicNumber")
 fun String.longHash(): Long {
     var h = 98764321261L
     val l = this.length

shared/src/commonTest/kotlin/DatesTest.kt

@@ -8,29 +8,27 @@ import kotlin.test.Test
 import kotlin.test.assertEquals
 
 class DatesTest {
-    private val newVersionDateVariant = "2022-12-24T17:00:08+00"
+    private val newVersionDateVariant =     "2022-12-24T17:00:08+00"
-    private val newVersionDate = "2013-04-07T13:43:00+01:00"
+    private val newVersionDate =            "2013-04-07T13:43:00+01:00"
-    private val newVersionDate2 = "2013-04-07T13:43:00-01:00"
+    private val newVersionDate2 =            "2013-04-07T13:43:00-01:00"
-    private val oldVersionDate = "2013-05-07 13:46:00"
+    private val oldVersionDate =            "2013-05-07 13:46:00"
-    private val oldVersionDateVariant = "2021-03-21 10:32:00.000000"
+    private val oldVersionDateVariant =     "2021-03-21 10:32:00.000000"
+
 
     @Test
     fun new_version_date_should_be_parsed() {
         val date = newVersionDate.toParsedDate()
         val expected =
-            LocalDateTime(2013, 4, 7, 13, 43, 0, 0)
+            LocalDateTime(2013, 4, 7, 13, 43, 0, 0).toInstant(TimeZone.currentSystemDefault())
-                .toInstant(TimeZone.currentSystemDefault())
                 .toEpochMilliseconds()
 
         assertEquals(expected, date)
     }
-
     @Test
     fun new_version_date2_should_be_parsed() {
         val date = newVersionDate2.toParsedDate()
         val expected =
-            LocalDateTime(2013, 4, 7, 13, 43, 0, 0)
+            LocalDateTime(2013, 4, 7, 13, 43, 0, 0).toInstant(TimeZone.currentSystemDefault())
-                .toInstant(TimeZone.currentSystemDefault())
                 .toEpochMilliseconds()
 
         assertEquals(expected, date)
@@ -40,8 +38,7 @@ class DatesTest {
     fun old_version_date_should_be_parsed() {
         val date = oldVersionDate.toParsedDate()
         val expected =
-            LocalDateTime(2013, 5, 7, 13, 46, 0, 0)
+            LocalDateTime(2013, 5, 7, 13, 46, 0, 0).toInstant(TimeZone.currentSystemDefault())
-                .toInstant(TimeZone.currentSystemDefault())
                 .toEpochMilliseconds()
 
         assertEquals(expected, date)
@@ -51,8 +48,7 @@ class DatesTest {
     fun old_version_variant_date_should_be_parsed() {
         val date = oldVersionDateVariant.toParsedDate()
         val expected =
-            LocalDateTime(2021, 3, 21, 10, 32, 0, 0)
+            LocalDateTime(2021, 3, 21, 10, 32, 0, 0).toInstant(TimeZone.currentSystemDefault())
-                .toInstant(TimeZone.currentSystemDefault())
                 .toEpochMilliseconds()
 
         assertEquals(expected, date)
@@ -62,8 +58,7 @@ class DatesTest {
     fun new_version_variant_date_should_be_parsed() {
         val date = newVersionDateVariant.toParsedDate()
         val expected =
-            LocalDateTime(2022, 12, 24, 17, 0, 8, 0)
+            LocalDateTime(2022, 12, 24, 17, 0, 8, 0).toInstant(TimeZone.currentSystemDefault())
-                .toInstant(TimeZone.currentSystemDefault())
                 .toEpochMilliseconds()
 
         assertEquals(expected, date)

shared/src/iosArm64Main/kotlin/bou/amine/apps/readerforselfossv2/dao/DriverFactory.kt

@@ -4,5 +4,7 @@ import app.cash.sqldelight.db.SqlDriver
 import app.cash.sqldelight.driver.native.NativeSqliteDriver
 
 actual class DriverFactory {
-    actual fun createDriver(): SqlDriver = NativeSqliteDriver(ReaderForSelfossDB.Schema, "ReaderForSelfossV2-IOS.db")
+    actual fun createDriver(): SqlDriver {
-}
+        return NativeSqliteDriver(ReaderForSelfossDB.Schema, "ReaderForSelfossV2-IOS.db")
+    }
+}

shared/src/iosArm64Main/kotlin/bou/amine/apps/readerforselfossv2/rest/SetupInsecureHttpEngine.kt

@@ -1,7 +0,0 @@
-package bou.amine.apps.readerforselfossv2.rest
-
-import io.ktor.client.engine.cio.CIOEngineConfig
-
-@Suppress("detekt:EmptyFunctionBlock")
-actual fun setupInsecureHttpEngine(config: CIOEngineConfig) {
-}

shared/src/iosArm64Main/kotlin/bou/amine/apps/readerforselfossv2/rest/setupInsecureHTTPEngine.kt

@@ -0,0 +1,6 @@
+package bou.amine.apps.readerforselfossv2.rest
+
+import io.ktor.client.engine.cio.CIOEngineConfig
+
+actual fun setupInsecureHTTPEngine(config: CIOEngineConfig) {
+}

shared/src/iosArm64Main/kotlin/bou/amine/apps/readerforselfossv2/utils/DateUtils.kt

@@ -1,10 +1,9 @@
 package bou.amine.apps.readerforselfossv2.utils
 
-@Suppress("detekt:UtilityClassWithPublicConstructor")
 actual class DateUtils {
     actual companion object {
         actual fun parseRelativeDate(dateString: String): String {
             TODO("Not yet implemented")
         }
     }
-}
+}

shared/src/iosSimulatorArm64Main/kotlin/bou/amine/apps/readerforselfossv2/utils/DateUtils.iosSimulatorArm64.kt

@@ -1,10 +1,9 @@
 package bou.amine.apps.readerforselfossv2.utils
 
-@Suppress("detekt:UtilityClassWithPublicConstructor")
 actual class DateUtils actual constructor() {
     actual companion object {
         actual fun parseRelativeDate(dateString: String): String {
             TODO("Not yet implemented")
         }
     }
-}
+}

shared/src/iosX64Main/kotlin/bou/amine/apps/readerforselfossv2/dao/DriverFactory.kt

@@ -4,5 +4,7 @@ import app.cash.sqldelight.db.SqlDriver
 import app.cash.sqldelight.driver.native.NativeSqliteDriver
 
 actual class DriverFactory {
-    actual fun createDriver(): SqlDriver = NativeSqliteDriver(ReaderForSelfossDB.Schema, "ReaderForSelfossV2-IOS.db")
+    actual fun createDriver(): SqlDriver {
-}
+        return NativeSqliteDriver(ReaderForSelfossDB.Schema, "ReaderForSelfossV2-IOS.db")
+    }
+}

shared/src/iosX64Main/kotlin/bou/amine/apps/readerforselfossv2/rest/SetupInsecureHttpEngine.kt

@@ -1,7 +0,0 @@
-package bou.amine.apps.readerforselfossv2.rest
-
-import io.ktor.client.engine.cio.CIOEngineConfig
-
-@Suppress("detekt:EmptyFunctionBlock")
-actual fun setupInsecureHttpEngine(config: CIOEngineConfig) {
-}

shared/src/iosX64Main/kotlin/bou/amine/apps/readerforselfossv2/rest/setupInsecureHTTPEngine.kt

@@ -0,0 +1,6 @@
+package bou.amine.apps.readerforselfossv2.rest
+
+import io.ktor.client.engine.cio.CIOEngineConfig
+
+actual fun setupInsecureHTTPEngine(config: CIOEngineConfig) {
+}