Louvorg/ReaderForSelfoss-multiplatform
Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 11 Pull Requests Actions Releases 75 Wiki Activity

Improve right to left support #130

Merged
AmineB merged 5 commits from davidoskky/ReaderForSelfoss-multiplatform:rtl into master 2023-01-29 12:55:29 +00:00
Conversation 3 Commits 5 Files Changed 9 +181 -223
davidoskky commented 2023-01-28 16:43:24 +00:00
Contributor
Copy Link

Types of changes

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This is NOT translation related.

Improved the layout for phones using right to left languages.
Some pages were previously completely unusable.

## Types of changes - [x] I have read the **CONTRIBUTING** document. - [x] My code follows the code style of this project. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [x] All new and existing tests passed. - [x] This is **NOT** translation related. Improved the layout for phones using right to left languages. Some pages were previously completely unusable.
davidoskky added 5 commits 2023-01-28 16:43:25 +00:00 
Adapted the layout for LTR, in LTR the title is always aligned on the right while the error depends on the language. Gave more prominence to the title text and set the error to italic.
Clean up fragments layout
All checks were successful
continuous-integration/drone/pr Build is passing
Details
45e4215a6b
AmineB reviewed 2023-01-28 19:21:38 +00:00
androidApp/src/main/res/layout/activity_login.xml
@ -37,2 +35,3 @@
android:visibility="gone" />
<ScrollView
<LinearLayout
AmineB commented 2023-01-28 19:21:38 +00:00
Owner
Copy Link

Why did you remove the scroll view ?

Why did you remove the scroll view ?
davidoskky commented 2023-01-28 20:21:50 +00:00
Author
Contributor
Copy Link

The layout is quite small, it doesn't appear to require scrolling on any kind of device.

The layout is quite small, it doesn't appear to require scrolling on any kind of device.
AmineB reviewed 2023-01-28 19:25:47 +00:00
androidApp/src/main/res/layout/activity_upsert_source.xml
@ -33,4 +27,0 @@
android:layout_height="match_parent"
android:layout_width="match_parent"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintRight_toRightOf="parent"
AmineB commented 2023-01-28 19:25:47 +00:00
Owner
Copy Link

Why was this line removed ?

Why was this line removed ?
davidoskky commented 2023-01-28 20:22:38 +00:00
Author
Contributor
Copy Link

It's implicit in match_parent dimension

It's implicit in match_parent dimension
AmineB reviewed 2023-01-28 19:25:57 +00:00
androidApp/src/main/res/layout/activity_upsert_source.xml
@ -35,4 +27,0 @@
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintRight_toRightOf="parent"
app:layout_constraintLeft_toLeftOf="parent"
app:layout_constraintBottom_toBottomOf="parent"
AmineB commented 2023-01-28 19:25:57 +00:00
Owner
Copy Link

Why was this line removed ?

Why was this line removed ?
davidoskky commented 2023-01-28 20:22:45 +00:00
Author
Contributor
Copy Link

It's implicit in match_parent dimension

It's implicit in match_parent dimension
AmineB merged commit ee064f3cb4 into master 2023-01-29 12:55:28 +00:00
davidoskky deleted branch rtl 2023-01-29 13:02:18 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#130
No description provided.
Delete Branch "davidoskky/ReaderForSelfoss-multiplatform:rtl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?