Improve right to left support #130

2023-01-28T16:43:24Z

davidoskky commented

2023-01-28 16:43:24 +00:00

Types of changes

I have read the CONTRIBUTING document.
My code follows the code style of this project.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.
This is NOT translation related.

Improved the layout for phones using right to left languages.
Some pages were previously completely unusable.

## Types of changes - [x] I have read the **CONTRIBUTING** document. - [x] My code follows the code style of this project. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [x] All new and existing tests passed. - [x] This is **NOT** translation related. Improved the layout for phones using right to left languages. Some pages were previously completely unusable.

davidoskky added 5 commits 2023-01-28 16:43:25 +00:00

Clean up and improve RTL in sources list 5c744d2f18

Adapted the layout for LTR, in LTR the title is always aligned on the right while the error depends on the language. Gave more prominence to the title text and set the error to italic.

Clean up upsert source activity layout a93bd45f0d

Clean up and improve RTL in login layout b0acc403fe

Clean up and improve RTL in home layout 232ccee991

Clean up fragments layout

continuous-integration/drone/pr Build is passing

Details

45e4215a6b

AmineB reviewed 2023-01-28 19:21:38 +00:00

androidApp/src/main/res/layout/activity_login.xml

						
				@@ -37,2 +35,3 @@

				            android:visibility="gone" />

				        <ScrollView

				        <LinearLayout

AmineB commented

2023-01-28 19:21:38 +00:00

Why did you remove the scroll view ?

davidoskky commented

2023-01-28 20:21:50 +00:00

The layout is quite small, it doesn't appear to require scrolling on any kind of device.

AmineB reviewed 2023-01-28 19:25:47 +00:00

androidApp/src/main/res/layout/activity_upsert_source.xml

						
				@@ -33,4 +27,0 @@

				            android:layout_height="match_parent"

				            android:layout_width="match_parent"

				            app:layout_constraintTop_toTopOf="parent"

				            app:layout_constraintRight_toRightOf="parent"

AmineB commented

2023-01-28 19:25:47 +00:00

Why was this line removed ?

davidoskky commented

2023-01-28 20:22:38 +00:00

It's implicit in match_parent dimension

AmineB reviewed 2023-01-28 19:25:57 +00:00

androidApp/src/main/res/layout/activity_upsert_source.xml

						
				@@ -35,4 +27,0 @@

				            app:layout_constraintTop_toTopOf="parent"

				            app:layout_constraintRight_toRightOf="parent"

				            app:layout_constraintLeft_toLeftOf="parent"

				            app:layout_constraintBottom_toBottomOf="parent"