Slow login process #135
Labels
No Label
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Louvorg/ReaderForSelfoss-multiplatform#135
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
When opening the app, if we previously logged in the application will perform a check while in the login screen.
In particular, it will try to load one item from the feed to make sure that the url provided does in fact host a valid and working selfoss instance.
Doing this increases the loading time of the application by several seconds each time it is opened.
However, this is already checked before logging in the first time. Having some old url in the settings shouldn't be too much of a problem anyways because even providing an invalid url, the home screen opens without any article in it and it is possible to perform a logout.
Moreover, this part of the logic introduces a bug: if we open the application with no internet access, we are logged out from the instance. This practically makes the offline mode unusable.
Solutions
This is the part of the code in question:
629ca01d99/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/LoginActivity.kt (L62)
Nope, this was needed because using a non selfoss url was causing an issue, because it was trying to deserialize things that didn't match the model.
I didn't see the issue reintroduced, so i'll remove it.