No favicons/thumbnails with basic auth #172

New Issue

2024-12-30T12:21:05Z

cmm commented

2024-12-30 12:21:05 +00:00

Prerequisites

[v] Are you running the latest version?
[v] Did you check for an existing issue ?
[v] Are you reporting to the correct repository?
[v] Did you perform a cursory search?
[v] Did you read the CONTRIBUTING guide ?

Description

I have "auth_basic" enabled in Nginx on the server (the built-in Selfoss auth is too expiration-happy to be usable).
I put the creds in the URL string in the app (BTW I hope they don't travel over the Internets like that?).

Things work, but the app does not show site favicons any more.

Steps to Reproduce

Disable the built-in auth in Selfoss
Configure "auth_basic" in Nginx
Fumble with the reader configuration until things work
Observe sudden lack of favicons

Device

Device (manufacturer, model ...): Xiaomi, Redmi Note 13 Pro 5G
OS (Android Version, ROM/Stock, Rooted/not, mods...): HyperOS 1 (Android 14), stock, not rooted, not modded
App version (See Prerequisites): 124123421-github

### Prerequisites * [v] Are you running the latest version? * [v] Did you check for an existing issue ? * [v] Are you reporting to the correct repository? * [v] Did you perform a cursory search? * [v] Did you read the `CONTRIBUTING` guide ? ### Description I have "auth_basic" enabled in Nginx on the server (the built-in Selfoss auth is too expiration-happy to be usable). I put the creds in the URL string in the app (BTW I hope they don't travel over the Internets like that?). Things work, but the app does not show site favicons any more. ### Steps to Reproduce 1. Disable the built-in auth in Selfoss 2. Configure "auth_basic" in Nginx 2. Fumble with the reader configuration until things work 3. Observe sudden lack of favicons ### Device - Device (manufacturer, model ...): Xiaomi, Redmi Note 13 Pro 5G - OS (Android Version, ROM/Stock, Rooted/not, mods...): HyperOS 1 (Android 14), stock, not rooted, not modded - App version _(See Prerequisites)_: `124123421-github`

AmineB commented

2024-12-30 12:57:55 +00:00

Hi,

Thanks for the head up.

Regarding your question about basic auth, the details are encoded before sending.

Hi, Thanks for the head up. Regarding your question about basic auth, the details are [encoded before sending](https://gitea.amine-bouabdallaoui.fr/Louvorg/ReaderForSelfoss-multiplatform/src/branch/master/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/rest/SelfossApi.kt#L96).

AmineB added the Type = Bug label 2024-12-30 12:58:08 +00:00

AmineB referenced this issue from a commit

2025-01-12 21:22:23 +00:00

feat: basic auth and images loading. Fixes #172.

AmineB referenced a pull request that will close this issue

2025-01-12 21:22:33 +00:00

feat: basic auth and images loading. Fixes #172. #175

AmineB closed this issue

2025-01-13 07:39:14 +00:00

AmineB referenced this issue from a commit

2025-01-13 07:39:16 +00:00

feat: basic auth and images loading. Fixes #172. (#175)