Android specific code in commonMain #23
Labels
No Label
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Louvorg/ReaderForSelfoss-multiplatform#23
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
There's some Android specific code in commonMain, this has to be fixed as I guess it will introduce problems when porting it to iOS.
In particular, the problematic code is in
It comes from the imports, thus either a kotlin library should be found or a platform specific version should be written.
The problem with SelfossModel should be easily solved, since its some simple html processing.
DateUtils appears to be a little bit more difficult for a common code solution. It is now using Java time libraries, I've found this kotlin library to handle dates, however it doesn't appear to have a way to generate relative dates. Which we are doing in those functions.
Deciding what to do about this will be important for the conclusion of #32 since the functions are now using one of the injection classes and I'll have to edit the code eventually.