Update remote option crashes the app #25

New Issue

AmineB · 2022-08-16T18:30:14Z

AmineB commented

2022-08-16 18:30:14 +00:00

The return type is wrong.

Here is the logcat.

2022-08-16 20:29:11.631 6173-6173/bou.amine.apps.readerforselfossv2.android E/AndroidRuntime: FATAL EXCEPTION: main
    Process: bou.amine.apps.readerforselfossv2.android, PID: 6173
    io.ktor.client.call.NoTransformationFoundException: No transformation found: class io.ktor.utils.io.ByteBufferChannel (Kotlin reflection is not available) -> class bou.amine.apps.readerforselfossv2.rest.SelfossModel$SuccessResponse (Kotlin reflection is not available)
    with response from https://selfoss.amine-louveau.fr/update?username=Amine&password=%40tdZn3KqK6dpXXFi:
    status: 200 OK
    response headers: 
    connection: keep-alive
    , content-type: text/html; charset=UTF-8
    , date: Tue, 16 Aug 2022 18:29:11 GMT
    , server: nginx/1.18.0 (Ubuntu)
    , set-cookie: PHPSESSID=bggv7csn4ag42tdakhr9531bec; expires=Thu, 15-Sep-2022 18:29:09 GMT; Max-Age=2592000; path=/; domain=selfoss.amine-louveau.fr; secure; HttpOnly; SameSite=Lax
    , transfer-encoding: chunked
    , x-android-received-millis: 1660674551533
    , x-android-response-source: NETWORK 200
    , x-android-selected-protocol: http/1.1
    , x-android-sent-millis: 1660674549097
    , x-debug-message: username=Amine&password=%40tdZn3KqK6dpXXFi
    
        at io.ktor.client.call.HttpClientCall.body(HttpClientCall.kt:92)
        at bou.amine.apps.readerforselfossv2.rest.SelfossApi.update(SelfossApi.kt:254)
        at bou.amine.apps.readerforselfossv2.rest.SelfossApi$update$1.invokeSuspend(Unknown Source:14)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
        at android.os.Handler.handleCallback(Handler.java:873)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:193)
        at android.app.ActivityThread.main(ActivityThread.java:6669)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
    	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@d6e9b4d, Dispatchers.Main]
2022-08-16 20:29:11.745 1918-2026/system_process E/InputDispatcher: channel '71fe99e bou.amine.apps.readerforselfossv2.android/bou.amine.apps.readerforselfossv2.android.HomeActivity (server)' ~ Channel is unrecoverably broken and will be disposed!

The return type is wrong. Here is the logcat. ``` 2022-08-16 20:29:11.631 6173-6173/bou.amine.apps.readerforselfossv2.android E/AndroidRuntime: FATAL EXCEPTION: main Process: bou.amine.apps.readerforselfossv2.android, PID: 6173 io.ktor.client.call.NoTransformationFoundException: No transformation found: class io.ktor.utils.io.ByteBufferChannel (Kotlin reflection is not available) -> class bou.amine.apps.readerforselfossv2.rest.SelfossModel$SuccessResponse (Kotlin reflection is not available) with response from https://selfoss.amine-louveau.fr/update?username=Amine&password=%40tdZn3KqK6dpXXFi: status: 200 OK response headers: connection: keep-alive , content-type: text/html; charset=UTF-8 , date: Tue, 16 Aug 2022 18:29:11 GMT , server: nginx/1.18.0 (Ubuntu) , set-cookie: PHPSESSID=bggv7csn4ag42tdakhr9531bec; expires=Thu, 15-Sep-2022 18:29:09 GMT; Max-Age=2592000; path=/; domain=selfoss.amine-louveau.fr; secure; HttpOnly; SameSite=Lax , transfer-encoding: chunked , x-android-received-millis: 1660674551533 , x-android-response-source: NETWORK 200 , x-android-selected-protocol: http/1.1 , x-android-sent-millis: 1660674549097 , x-debug-message: username=Amine&password=%40tdZn3KqK6dpXXFi at io.ktor.client.call.HttpClientCall.body(HttpClientCall.kt:92) at bou.amine.apps.readerforselfossv2.rest.SelfossApi.update(SelfossApi.kt:254) at bou.amine.apps.readerforselfossv2.rest.SelfossApi$update$1.invokeSuspend(Unknown Source:14) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106) at android.os.Handler.handleCallback(Handler.java:873) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:193) at android.app.ActivityThread.main(ActivityThread.java:6669) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858) Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@d6e9b4d, Dispatchers.Main] 2022-08-16 20:29:11.745 1918-2026/system_process E/InputDispatcher: channel '71fe99e bou.amine.apps.readerforselfossv2.android/bou.amine.apps.readerforselfossv2.android.HomeActivity (server)' ~ Channel is unrecoverably broken and will be disposed! ```

AmineB added the

Priority = High

Type = Bug

labels 2022-08-16 18:30:14 +00:00

AmineB added this to the Dev project 2022-08-16 18:30:14 +00:00

AmineB added this to the Same as before milestone 2022-08-16 18:31:16 +00:00

AmineB changed title from ~~Update remove option crashes the app~~ to Update remote option crashes the app

2022-08-19 20:34:13 +00:00

AmineB referenced this issue from a commit

2022-08-19 20:39:55 +00:00

Fixes #25;

AmineB commented

2022-08-19 20:40:42 +00:00

Fixed in 51583b4996743c81fed116a420b105c316b0f20b

AmineB closed this issue

2022-08-19 20:41:05 +00:00

davidoskky commented

2022-08-20 08:48:55 +00:00

This fix works for me on api version 4; didn't realize this issue existed, definitely it's not present in the F-Droid version.
Does this work on selfoss 2.18 as well?

This fix works for me on api version 4; didn't realize this issue existed, definitely it's not present in the F-Droid version. Does this work on selfoss 2.18 as well?

AmineB commented

2022-08-20 10:41:09 +00:00

This was introduced when migrating.

I tested it with selfoss 2.19, not sure for other versions.

This was introduced when migrating. I tested it with selfoss 2.19, not sure for other versions.

AmineB referenced this issue from a commit

2022-08-23 20:46:56 +00:00

Fixes #25;

Sign in to join this conversation.

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#25