Repository tests #49

New Issue

davidoskky · 2022-09-07T07:06:19Z

davidoskky commented

2022-09-07 07:06:19 +00:00

Since the repository is taking care of most of the logic, it appears to be the best place to start introducing tests.
Moreover, since it does not depend on the Android implementation, these can be unit tests.

I'll start working on this since it doesn't appear to me that there are any more important tasks to do that stop the F-Droid publication.
This will likely take me some time; I'll open a draft PR when I can so that if you wish you can also take a look.

I don't know how the CI is setup on here; I hope it'll just pick them up and work.

Since the repository is taking care of most of the logic, it appears to be the best place to start introducing tests. Moreover, since it does not depend on the Android implementation, these can be unit tests. I'll start working on this since it doesn't appear to me that there are any more important tasks to do that stop the F-Droid publication. This will likely take me some time; I'll open a draft PR when I can so that if you wish you can also take a look. I don't know how the CI is setup on here; I hope it'll just pick them up and work.

davidoskky commented

2022-09-07 11:15:01 +00:00

I had a first look and there are some difficulties: the repository depends on the ConnectivityStatus library which cannot be directly mocked as far as I can see.

AmineB commented

2022-09-07 17:07:26 +00:00

Hi,

I use a private droneci instance as ci/cd tool.

It's not public (yet ?) as I use it for other personal projects.

You could try and add a test step in the .drone.yml file, and I'll check if it works when it's merged.

I had a first look and there are some difficulties: the repository depends on the ConnectivityStatus library which cannot be directly mocked as far as I can see.

Can the ConnectivityStatus library be replaced with a mock that returns true or false ?

Hi, I use a private [droneci](https://www.drone.io/) instance as ci/cd tool. It's not public (yet ?) as I use it for other personal projects. You could try and add a test step in the `.drone.yml` file, and I'll check if it works when it's merged. > I had a first look and there are some difficulties: the repository depends on the ConnectivityStatus library which cannot be directly mocked as far as I can see. Can the ConnectivityStatus library be replaced with a mock that returns true or false ?

davidoskky commented

2022-09-09 09:08:57 +00:00

I have checked, the library can be mocked; I'll thus proceed by mocking all the dependencies of the repository.

davidoskky referenced this issue

2022-09-09 11:46:05 +00:00

Repository Unit Tests #50

AmineB added this to the A little better milestone 2022-09-12 19:16:52 +00:00

AmineB added this to the (deleted) project 2022-09-13 14:32:44 +00:00

AmineB closed this issue

2022-09-30 11:32:08 +00:00

Sign in to join this conversation.