Louvorg/ReaderForSelfoss-multiplatform
Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 16 Pull Requests Projects 1 Releases 65 Wiki Activity

Add support for item author #77

New Issue
Closed
opened 2022-10-09 19:36:11 +00:00 by jtojnar · 3 comments
jtojnar commented 2022-10-09 19:36:11 +00:00
Copy Link

I have moved the tweet authorship out of title into the author field but it looks like the model does not support that.

Turns out it was previously undocumented so I added it to schema and made it null instead of empty string for unknown authors, targetting selfoss 2.19/API 6.0.0:

4f49455870

I have [moved the tweet authorship out of title into the `author` field](https://github.com/fossar/selfoss/commit/4f4945587049a146a13cd0bc136adb0f69c77d39) but it looks like the [model does not support that](https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/src/commit/023a30c00816f380fde4b9d836bf8e19282b0153/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/model/SelfossModel.kt#L68-L83). Turns out it was previously undocumented so I added it to schema and made it `null` instead of empty string for unknown authors, targetting selfoss 2.19/API 6.0.0: https://github.com/fossar/selfoss/commit/4f4945587049a146a13cd0bc136adb0f69c77d39
davidoskky commented 2022-10-10 11:16:26 +00:00
Contributor
Copy Link

Would it be ok to add it below the source title in the article reader?

Would it be ok to add it below the source title in the article reader? ![](https://gitea.amine-louveau.fr/attachments/Screenshot_20221010_124221.png)
Screenshot_20221010_124221.png
354 KiB
Screenshot_20221010_124221.png
AmineB added the
Type = Enhancement
Type = UX/Design
 labels 2022-10-10 18:32:17 +00:00
AmineB added this to the Version 2 milestone 2022-10-10 18:32:22 +00:00
AmineB commented 2022-10-10 18:56:56 +00:00
Owner
Copy Link

@davidoskky Twitter items do not open inside the article viewer.

This is displayed in the card view.
image

This is displayed in the list view
image

Not sure how/what would the author field would change.

@davidoskky Twitter items do not open inside the article viewer. This is displayed in the card view. ![image](/attachments/c9a66b5f-40e8-44fa-95b3-c8014c3edddb) This is displayed in the list view ![image](/attachments/a3b528e0-3c57-4fc0-9a21-d12b1e35134b) Not sure how/what would the author field would change.
image.png
104 KiB
image.png
100 KiB
image.png
222 KiB
image.png
davidoskky commented 2022-10-10 22:34:00 +00:00
Contributor
Copy Link

Also other spouts have an author field.
I'm unsure how useful that is however, often in blogs the author is always the same...

Also other spouts have an author field. I'm unsure how useful that is however, often in blogs the author is always the same...
AmineB added this to the Dev project 2022-12-26 20:50:27 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Difficulty - Beginner friendly

   
Difficulty = Easy

   
Difficulty = Hard

   
Difficulty = Medium

   
Priority = CRITICAL

   
Priority = High

   
Priority = Low

   
Priority = Normal

   
Priority = Some day

   
Status - Fixed somewhere else

   
Status - No details provided

   
Status = Can't fix

   
Status = Duplicate

   
Status = Help wanted

   
Status = Invalid

   
Status = Need more details

   
Status = Taken

   
Status = Wontfix

   
Type - Selfoss works like this

   
Type = Bug

   
Type = Chore

   
Type = Enhancement

   
Type = Feature

   
Type = Question

   
Type = SELFOSS API ISSUE

   
Type = Tools

   
Type = UX/Design

   
Up For Grabs
No Label
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
Milestone
Clear milestone
No items
No Milestone
Version 2
Projects
Clear projects
No project
Dev
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#77
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?