Cleaning. #88

Merged
AmineB merged 7 commits from cleaning into master 2022-10-31 20:42:23 +00:00
Owner

Types of changes

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This is NOT translation related.

This closes issue #XXX

This is implements feature #YYY

This finishes chore #ZZZ

## Types of changes - [ ] I have read the **CONTRIBUTING** document. - [ ] My code follows the code style of this project. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [ ] This is **NOT** translation related. This closes issue #XXX This is implements feature #YYY This finishes chore #ZZZ
AmineB added 1 commit 2022-10-29 20:58:40 +00:00
Cleaning.
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/pr Build is passing
5494978db8
AmineB added 2 commits 2022-10-30 20:22:10 +00:00
Cleaning.
Some checks failed
continuous-integration/drone/pr Build is failing
continuous-integration/drone/push Build is failing
7b40a31979
AmineB added 1 commit 2022-10-30 20:28:00 +00:00
No daemon
Some checks failed
continuous-integration/drone/pr Build is failing
continuous-integration/drone/push Build is failing
b0d1d9c29a
AmineB added 1 commit 2022-10-30 20:38:09 +00:00
Still cleaning.
Some checks failed
continuous-integration/drone/pr Build is failing
continuous-integration/drone/push Build is failing
d862bfba4f
AmineB added 1 commit 2022-10-30 21:02:13 +00:00
More cleaning.
Some checks failed
continuous-integration/drone/push Build is failing
continuous-integration/drone/pr Build is passing
94a0747947
davidoskky reviewed 2022-10-31 08:14:47 +00:00
@ -14,3 +7,1 @@
actual fun parseDate(dateString: String): Long {
val FORMATTERV1 = "yyyy-MM-dd HH:mm:ss"
actual class DateUtils {
Contributor

Since DateUtils does not need to store any data, wouldn't it be better to just have it as two expect functions?
In this way we remove the need of instantiating the object within the repository.
Moreover, if I'm not mistaken one of the two is full kotlin and could thus be in the common source.

Since DateUtils does not need to store any data, wouldn't it be better to just have it as two expect functions? In this way we remove the need of instantiating the object within the repository. Moreover, if I'm not mistaken one of the two is full kotlin and could thus be in the common source.
Author
Owner

Since DateUtils does not need to store any data, wouldn't it be better to just have it as two expect functions?

It is now.

In this way we remove the need of instantiating the object within the repository.

I cleaned a little bit.

> Since DateUtils does not need to store any data, wouldn't it be better to just have it as two expect functions? It is now. > In this way we remove the need of instantiating the object within the repository. I cleaned a little bit.
AmineB added 1 commit 2022-10-31 20:28:20 +00:00
Cleaning still.
All checks were successful
continuous-integration/drone/pr Build is passing
continuous-integration/drone/push Build is passing
27c55e59a1
AmineB merged commit af8969ce4a into master 2022-10-31 20:42:23 +00:00
AmineB deleted branch cleaning 2022-10-31 20:42:23 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#88
No description provided.