Louvorg/ReaderForSelfoss-multiplatform
Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 16 Pull Requests Projects 1 Releases 65 Wiki Activity

Make the author field nullable #117

Merged
AmineB merged 3 commits from davidoskky/ReaderForSelfoss-multiplatform:author into master 2022-12-28 14:25:38 +00:00
Conversation 2 Commits 3 Files Changed 5 +7 -1
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3a654f6ede - Show all commits

2
shared/src/commonMain/sqldelight/bou/amine/apps/readerforselfossv2/dao/1.sqm
View File

@ -1 +1 @@
ALTER TABLE ITEM ADD COLUMN `author` TEXT;
ALTER TABLE ITEM ADD COLUMN `author` TEXT NOT NULL;
AmineB commented 2022-12-28 10:56:30 +00:00
Outdated
Review
Copy Link

You can´t update a sqldelight migration file. You have to create a new file 2.sq and add the sql query changing the column inside.

You can´t update a sqldelight migration file. You have to create a new file `2.sq` and add the sql query changing the column inside.
davidoskky commented 2022-12-28 10:58:21 +00:00
Outdated
Review
Copy Link

Ops, I thought this version hadn't been released yet and that thus that would be fine.

Ops, I thought this version hadn't been released yet and that thus that would be fine.
AmineB commented 2022-12-28 12:18:56 +00:00
Outdated
Review
Copy Link

I just saw that you can't update a column type in sqlite.

You'll have to rename the existing one create a new one with the old name and the right type, and then drop the old one.(not possible in older versions of android because it's only available since version 3.25.0 of sqlite, and Android has old versions)

You'll have to drop the old column, and recreate it.

Will you be able to do these changes today ? This seem to cause issues for multiple users.

I just saw that you [can't update a column type in sqlite](https://www.sqlite.org/lang_altertable.html#alter_table_rename_column). ~~You'll have to rename the existing one create a new one with the old name and the right type, and then drop the old one.~~(not possible in older versions of android because it's only available since version 3.25.0 of sqlite, and Android has [old versions](https://stackoverflow.com/a/52346199)) You'll have to drop the old column, and recreate it. Will you be able to do these changes today ? This seem to cause issues for multiple users.
davidoskky commented 2022-12-28 13:15:07 +00:00
Outdated
Review
Copy Link

Yes, I'll submit everything soon.

Yes, I'll submit everything soon.
👍 1

6
shared/src/commonMain/sqldelight/bou/amine/apps/readerforselfossv2/dao/2.sqm Normal file
View File

@ -0,0 +1,6 @@
CREATE TABLE ITEM_BACKUP AS SELECT `id`, `datetime`, `title`, `content`,
AmineB commented 2022-12-28 13:32:15 +00:00
Review
Copy Link

This is unnecessary.

The data will be updated if needed with the update of updateItem you made.

Droping the column and recreating it should by enough.

This is unnecessary. The data will be updated if needed with the update of `updateItem` you made. Droping the column and recreating it should by enough.
davidoskky commented 2022-12-28 13:38:45 +00:00
Review
Copy Link

Dropping columns was introduced in version 3.35 https://sqlite.org/changes.html

Dropping columns was introduced in version 3.35 https://sqlite.org/changes.html
👍 1
`unread`, `starred`, `thumbnail`, `icon`, `link`, `sourcetitle`,
`tags` FROM ITEM;
ALTER TABLE ITEM_BACKUP ADD COLUMN `author` TEXT;
DROP TABLE ITEM;
ALTER TABLE ITEM_BACKUP RENAME TO ITEM;