Louvorg/ReaderForSelfoss-multiplatform
3
2 Fork 2
Code Issues 7 Pull Requests 2 Actions Releases 84 Wiki Activity

Tentative self signed ssl support #141

Merged
AmineB merged 12 commits from davidoskky/ReaderForSelfoss-multiplatform:self_ssl into master 2023-09-17 18:28:48 +00:00
Conversation 20 Commits 12 Files Changed 24
+21 -5
19 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b5de30f561 - Show all commits

No files matched your search

androidApp/src/main/res/layout/activity_login.xml
+1 -1
View File
@@ -55,7 +55,7 @@
android:id="@+id/selfSigned"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:text="@string/disableSSL"
android:text="@string/disable_ssl"
AmineB marked this conversation as resolved Outdated
AmineB commented 2023-07-15 18:28:55 +00:00
Outdated
Review
Copy Link
Copy Source

disableSSL should be disable_ssl

`disableSSL` should be `disable_ssl`
AmineB commented 2023-09-07 18:49:59 +00:00
Outdated
Review
Copy Link
Copy Source

@string/disable_ssl should be named @string/use_self_signed_cert

`@string/disable_ssl` should be named `@string/use_self_signed_cert`
davidoskky commented 2023-09-10 19:22:04 +00:00
Outdated
Review
Copy Link
Copy Source

As I understand it, this would be misleading because we are not just accepting self signed certificates but rather disregarding ssl validation all together. The SSL certificate may very well be for another domain or missing altogether.

As I understand it, this would be misleading because we are not just accepting self signed certificates but rather disregarding ssl validation all together. The SSL certificate may very well be for another domain or missing altogether.
android:textAlignment="viewStart" />
<com.google.android.material.switchmaterial.SwitchMaterial
androidApp/src/main/res/values-ca-rES/strings.xml
+1
View File
@@ -130,4 +130,5 @@
<string name="update_source">Update source</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
AmineB marked this conversation as resolved Outdated
AmineB commented 2023-09-07 18:50:39 +00:00
Outdated
Review
Copy Link
Copy Source

<string name="disable_ssl">Disable SSL</string> => <string name="use_self_signed_cert">Use a self signed certificate</string> in all the files.

` <string name="disable_ssl">Disable SSL</string> ` => ` <string name="use_self_signed_cert">Use a self signed certificate</string> ` in all the files.
</resources>
androidApp/src/main/res/values-de-rDE/strings.xml
+1
View File
@@ -130,4 +130,5 @@
<string name="update_source">Update source</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
</resources>
androidApp/src/main/res/values-es-rES/strings.xml
+1
View File
@@ -130,4 +130,5 @@
<string name="update_source">Update source</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
</resources>
androidApp/src/main/res/values-fa-rIR/strings.xml
+1
View File
@@ -130,4 +130,5 @@
<string name="update_source">Update source</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
</resources>
androidApp/src/main/res/values-fr-rFR/strings.xml
+1
View File
@@ -130,4 +130,5 @@
<string name="update_source">Update source</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
</resources>
androidApp/src/main/res/values-gl-rES/strings.xml
+1
View File
@@ -130,4 +130,5 @@
<string name="update_source">Update source</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
</resources>
androidApp/src/main/res/values-in-rID/strings.xml
+1
View File
@@ -130,4 +130,5 @@
<string name="update_source">Update source</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
</resources>
androidApp/src/main/res/values-it-rIT/strings.xml
+2 -1
View File
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<resources xmlns:tools="http://schemas.android.com/tools">
AmineB commented 2023-09-07 18:51:32 +00:00
Outdated
Review
Copy Link
Copy Source

Please revert this change.

Please revert this change.
👍 1
AmineB commented 2023-09-12 19:08:19 +00:00
Outdated
Review
Copy Link
Copy Source

Please revert this.

Please revert this.
<resources>
<string name="app_name">"Lettore RSS per Selfoss"</string>
<string name="title_activity_login">"Accedi"</string>
<string name="prompt_password">"Password"</string>
@@ -130,4 +130,5 @@
<string name="update_source">Update source</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
AmineB marked this conversation as resolved Outdated
AmineB commented 2023-07-15 18:31:16 +00:00
Outdated
Review
Copy Link
Copy Source

Translations should be done on the translation tool. This will be overwritten when merged.

Translations should be done on the translation tool. This will be overwritten when merged.
👍 1
</resources>
androidApp/src/main/res/values-ko-rKR/strings.xml
+1
View File
@@ -130,4 +130,5 @@
<string name="update_source">Update source</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
</resources>
androidApp/src/main/res/values-night/strings.xml
+1 -1
View File
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<resources xmlns:tools="http://schemas.android.com/tools">
AmineB commented 2023-09-07 18:53:53 +00:00
Outdated
Review
Copy Link
Copy Source

No idea why I added this file. Can you please delete it ?

No idea why I added this file. Can you please delete it ?
👍 1
<string name="gdpr_dialog_title">The app does not share any personal data about you.</string>
<string name="gdpr_dialog_message"><![CDATA[Crash reports sending is now enabled. It can be disabled from the settings page. Keep in mind that crash reports are essential for the app development.]]></string>
<string name="crash_toast_text">A crash occured. Sending the details to the developper.</string>
androidApp/src/main/res/values-nl-rNL/strings.xml
+1
View File
@@ -130,4 +130,5 @@
<string name="update_source">Update source</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
</resources>
androidApp/src/main/res/values-pt-rBR/strings.xml
+1
View File
@@ -130,4 +130,5 @@
<string name="update_source">Update source</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
</resources>
androidApp/src/main/res/values-pt-rPT/strings.xml
+1
View File
@@ -130,4 +130,5 @@
<string name="update_source">Update source</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
</resources>
androidApp/src/main/res/values-si-rLK/strings.xml
+1
View File
@@ -130,4 +130,5 @@
<string name="update_source">Update source</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
</resources>
androidApp/src/main/res/values-tr-rTR/strings.xml
+1
View File
@@ -130,4 +130,5 @@
<string name="update_source">Update source</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
</resources>
androidApp/src/main/res/values-zh-rCN/strings.xml
+1
View File
@@ -130,4 +130,5 @@
<string name="update_source">更新源</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
</resources>
androidApp/src/main/res/values-zh-rTW/strings.xml
+1
View File
@@ -130,4 +130,5 @@
<string name="update_source">Update source</string>
<string name="confirm_disconnect_title">Disconnect ?</string>
<string name="confirm_disconnect_description">You will be disconnected from your selfoss instance.</string>
<string name="disable_ssl">Disable SSL</string>
</resources>
androidApp/src/main/res/values/strings.xml
+2 -2
View File
@@ -1,4 +1,4 @@
<resources>
<resources xmlns:tools="http://schemas.android.com/tools">
<string name="app_name">"Reader for Selfoss"</string>
<string name="title_activity_login">"Log in"</string>
<string name="prompt_password">"Password"</string>
@@ -6,7 +6,7 @@
<string name="error_invalid_password">"Password not long enough"</string>
<string name="error_field_required">"Field required"</string>
<string name="prompt_url">"Url"</string>
<string name="disableSSL">"Disable SSL"</string>
<string name="disable_ssl">"Disable SSL"</string>
<string name="withLoginSwitch">"Login required ?"</string>
<string name="login_url_problem">"Oops. You may need to add a \"/\" at the end of the url."</string>
<string name="prompt_login">"Username"</string>