Louvorg/ReaderForSelfoss-multiplatform
Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 18 Pull Requests Actions Projects 1 Releases 65 Wiki Activity

Repository Unit Tests #50

Merged
AmineB merged 38 commits from davidoskky/ReaderForSelfoss-multiplatform:repository_tests into master 2022-09-30 11:31:55 +00:00
Conversation 7 Commits 38 Files Changed 7 -4
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 27bb056397 - Show all commits

1
androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/ArticleFragment.kt
View File

@ -249,7 +249,6 @@ class ArticleFragment : Fragment(), DIAware {
private fun getContentFromMercury() {
if (repository.isNetworkAvailable()) {
binding.progressBar.visibility = View.VISIBLE
// TODO: The api should be accessed through the repository
val parser = MercuryApi()
AmineB marked this conversation as resolved Outdated
AmineB commented 2022-09-30 09:41:16 +00:00
Outdated
Review
Copy Link

Please remove this comment.

Please remove this comment.
parser.parseUrl(url).enqueue(

3
shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt
View File

@ -403,8 +403,6 @@ class Repository(private val api: SelfossApi, private val appSettingsService: Ap
}
}
// TODO: This should be private (since all api calls are made through the repository
// no other entity needs to know about the connectivity status)
fun isNetworkAvailable() = isConnectionAvailable.value && !offlineOverride
AmineB marked this conversation as resolved Outdated
AmineB commented 2022-09-30 09:43:37 +00:00
Outdated
Review
Copy Link

Because of the mercury api using this, can you remove this comment, please ?

Because of the mercury api using this, can you remove this comment, please ?
private fun getDBActions(): List<ACTION> =
@ -458,7 +456,6 @@ class Repository(private val api: SelfossApi, private val appSettingsService: Ap
// TODO: This function should check for duplicate items
suspend fun tryToCacheItemsAndGetNewOnes(): List<SelfossModel.Item> {
try {
AmineB marked this conversation as resolved Outdated
AmineB commented 2022-09-30 09:44:53 +00:00
Outdated
Review
Copy Link

I think that the DB handles the duplicates.

I think that the DB handles the duplicates.
davidoskky commented 2022-09-30 09:51:56 +00:00
Outdated
Review
Copy Link

Does it use the id to check for duplicates? If that is the case then all is good.

Does it use the id to check for duplicates? If that is the case then all is good.
val previousNewItems = getDBItems().count { it.unread }
val newItems = getMaxItemsForBackground(ItemType.UNREAD)
val allItems = getMaxItemsForBackground(ItemType.ALL)
val starredItems = getMaxItemsForBackground(ItemType.STARRED)
AmineB marked this conversation as resolved Outdated
AmineB commented 2022-09-30 09:38:26 +00:00
Outdated
Review
Copy Link

This is useless.

This is useless.