Louvorg/ReaderForSelfoss-multiplatform
Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 18 Pull Requests Actions Projects 1 Releases 65 Wiki Activity

Repository Unit Tests #50

Merged
AmineB merged 38 commits from davidoskky/ReaderForSelfoss-multiplatform:repository_tests into master 2022-09-30 11:31:55 +00:00
Conversation 7 Commits 38 Files Changed 7 +24 -3
1 changed files with 24 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 41c951b659 - Show all commits

27
shared/src/commonTest/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryTest.kt
View File

@ -45,7 +45,14 @@ class RepositoryTest() {
@Test
fun `Instantiate repository`() {
AmineB marked this conversation as resolved
AmineB commented 2022-09-27 13:54:00 +00:00
Review
Copy Link

This does not seem to do anything. Is it needed ?

This does not seem to do anything. Is it needed ?
davidoskky commented 2022-09-27 18:18:37 +00:00
Review
Copy Link

The test can fail if the repository initialization generates an error; this is just a very general case to identify if something in the repository initialization is broken.
All other tests would fail as well, but this will give you certainty that the point of failure is in the initialization.

The test can fail if the repository initialization generates an error; this is just a very general case to identify if something in the repository initialization is broken. All other tests would fail as well, but this will give you certainty that the point of failure is in the initialization.
AmineB commented 2022-09-27 18:29:28 +00:00
Review
Copy Link

The way I understand your comment is that sometimes, the repository can fail an throw an error.

This should not be handled in a unit test, but handled in the code.

The exception should be catched and handled there.

You can keep your tests, but the call should return something, and the tests should actually test something.

Same for the three following tests.

The way I understand your comment is that sometimes, the repository can fail an throw an error. This should not be handled in a unit test, but handled in the code. The exception should be catched and handled there. You can keep your tests, but the call should return something, and the tests should actually **test** something. Same for the three following tests.
👍 1
val repository = Repository(api, appSettingsService, connectivityStatus, db)
val success = try {
Repository(api, appSettingsService, connectivityStatus, db)
AmineB marked this conversation as resolved Outdated
AmineB commented 2022-09-28 06:41:59 +00:00
Outdated
Review
Copy Link

As mentionnend in my previous comment. The try catch must be in the code, not in the unit test.

As mentionnend in my previous comment. The try catch must be in the code, not in the unit test.
AmineB commented 2022-09-28 06:42:17 +00:00
Outdated
Review
Copy Link

Same for all the other try catch in here.

Same for all the other try catch in here.
davidoskky commented 2022-09-28 06:55:47 +00:00
Outdated
Review
Copy Link

I'm not sure how I would implement this test otherwise, I guess the repository should raise an exception during initialization then.

I'm not sure how I would implement this test otherwise, I guess the repository should raise an exception during initialization then.
AmineB commented 2022-09-28 06:57:14 +00:00
Outdated
Review
Copy Link

I guess the repository should raise an exception during initialization then.

Yep. That should be the case.

> I guess the repository should raise an exception during initialization then. Yep. That should be the case.
true
} catch (e: Exception) {
false
AmineB marked this conversation as resolved Outdated
AmineB commented 2022-09-27 13:54:06 +00:00
Outdated
Review
Copy Link

This does not seem to do anything. Is it needed ?

This does not seem to do anything. Is it needed ?
davidoskky commented 2022-09-27 18:18:48 +00:00
Outdated
Review
Copy Link

Same as above.

Same as above.
}
assertEquals(true, success)
}
@Test
@ -53,14 +60,28 @@ class RepositoryTest() {
every { appSettingsService.getApiVersion() } returns -1
AmineB marked this conversation as resolved Outdated
AmineB commented 2022-09-27 13:54:19 +00:00
Outdated
Review
Copy Link

This does not seem to do anything. Is it needed ?

This does not seem to do anything. Is it needed ?
davidoskky commented 2022-09-27 18:19:20 +00:00
Outdated
Review
Copy Link

Same as above.

Same as above.
every { connectivityStatus.isNetworkConnected } returns MutableStateFlow(false)
val repository = Repository(api, appSettingsService, connectivityStatus, db)
val success = try {
Repository(api, appSettingsService, connectivityStatus, db)
true
} catch (e: Exception) {
false
}
assertEquals(true, success)
}
@Test
fun `Instantiate repository with negative stats`() {
coEvery { api.stats() } returns SelfossModel.StatusAndData(success = true, data = SelfossModel.Stats(-100, -50, -20))
val repository = Repository(api, appSettingsService, connectivityStatus, db)
val success = try {
Repository(api, appSettingsService, connectivityStatus, db)
true
} catch (e: Exception) {
false
}
assertEquals(true, success)
}
@Test