Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 7 Pull Requests 2 Actions Releases 84 Wiki Activity

Repository Unit Tests #50

Merged
AmineB merged 38 commits from davidoskky/ReaderForSelfoss-multiplatform:repository_tests into master 2022-09-30 11:31:55 +00:00
Conversation 15 Commits 38 Files Changed 7
+8 -3
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f9ba13dc32 - Show all commits
androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/background/background.kt
+4 -2
View File
@@ -52,11 +52,13 @@ override fun doWork(): Result {
repository.handleDBActions()
val apiItems = repository.tryToCacheItemsAndGetNewOnes()
if (appSettingsService.isNotifyNewItemsEnabled()) {
launch {
handleNewItemsNotification(repository.tryToCacheItemsAndGetNewOnes(), notificationManager)
handleNewItemsNotification(apiItems, notificationManager)
}
}
apiItems.map { it.preloadImages(context) }
}
}
return Result.success()
@@ -66,6 +68,7 @@ override fun doWork(): Result {
newItems: List<SelfossModel.Item>?,
notificationManager: NotificationManager
) {
// TODO: Check if this coroutine is actually required
CoroutineScope(Dispatchers.IO).launch {
val apiItems = newItems.orEmpty()
@@ -102,7 +105,6 @@ override fun doWork(): Result {
notificationManager.notify(2, newItemsNotification.build())
}
}
apiItems.map { it.preloadImages(context) }
Timer("", false).schedule(4000) {
notificationManager.cancel(1)
}
shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt
+4 -1
View File
6
 @@ -456,16 +456,19 @@ class Repository(private val api: SelfossApi, private val appSettingsService: Ap
db.itemsQueries.updateItem(item.datetime, item.title.getHtmlDecoded(), item.content, item.unread, item.starred, item.thumbnail, item.icon, item.link, item.sourcetitle, item.tags.joinToString(","), item.id.toString())
// TODO: This function should check for duplicate items
AmineB marked this conversation as resolved Outdated
AmineB commented 2022-09-30 09:44:53 +00:00
Outdated
Review
Copy Link
Copy Source

I think that the DB handles the duplicates.

I think that the DB handles the duplicates.
davidoskky commented 2022-09-30 09:51:56 +00:00
Outdated
Review
Copy Link
Copy Source

Does it use the id to check for duplicates? If that is the case then all is good.

Does it use the id to check for duplicates? If that is the case then all is good.
suspend fun tryToCacheItemsAndGetNewOnes() {
suspend fun tryToCacheItemsAndGetNewOnes(): List<SelfossModel.Item> {
try {
val previousNewItems = getDBItems().count { it.unread }
AmineB marked this conversation as resolved Outdated
AmineB commented 2022-09-30 09:38:26 +00:00
Outdated
Review
Copy Link
Copy Source

This is useless.

This is useless.
val newItems = getMaxItemsForBackground(ItemType.UNREAD)
val allItems = getMaxItemsForBackground(ItemType.ALL)
val starredItems = getMaxItemsForBackground(ItemType.STARRED)
AmineB commented 2022-09-30 10:00:09 +00:00
Outdated
Review
Copy Link
Copy Source

As the function name describes, this must only return the new items.

As the function name describes, this must only return the new items.
davidoskky commented 2022-09-30 11:13:32 +00:00
Outdated
Review
Copy Link
Copy Source

Ops, you're right I made a mistake while changing things...

Ops, you're right I made a mistake while changing things...
val fullItemsList = newItems + allItems + starredItems
insertDBItems(fullItemsList)
return fullItemsList
} catch (e: Throwable) {
// We do nothing
}
return emptyList()
}
// TODO: Add tests