Only do api calls on network available.

app/src/main/java/apps/amine/bou/readerforselfoss/HomeActivity.kt

@@ -204,7 +204,7 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
                     recyclerView: RecyclerView,
                     viewHolder: RecyclerView.ViewHolder
                 ): Int =
-                    if (elementsShown != UNREAD_SHOWN) {
+                    if (elementsShown != UNREAD_SHOWN || !this@HomeActivity.isNetworkAccessible(null)) {
                         0
                     } else {
                         super.getSwipeDirs(
@@ -696,6 +696,7 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
             var sources: List<Source>?
 
             fun sourcesApiCall() {
+                if (this@HomeActivity.isNetworkAccessible(null)) {
                     api.sources.enqueue(object : Callback<List<Source>> {
                         override fun onResponse(
                             call: Call<List<Source>>?,
@@ -712,7 +713,9 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
                         }
                     })
                 }
+            }
 
+            if (this@HomeActivity.isNetworkAccessible(null)) {
                 api.tags.enqueue(object : Callback<List<Tag>> {
                     override fun onResponse(
                         call: Call<List<Tag>>,
@@ -727,6 +730,7 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
                     }
                 })
             }
+        }
 
         drawer.addItem(
             PrimaryDrawerItem().withName(getString(R.string.drawer_loading)).withSelectable(
@@ -1128,7 +1132,7 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
     }
 
     private fun reloadBadges() {
-        if (displayUnreadCount || displayAllCount) {
+        if (this@HomeActivity.isNetworkAccessible(null) && (displayUnreadCount || displayAllCount)) {
             api.stats.enqueue(object : Callback<Stats> {
                 override fun onResponse(call: Call<Stats>, response: Response<Stats>) {
                     if (response.body() != null) {
@@ -1234,6 +1238,7 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
     override fun onOptionsItemSelected(item: MenuItem): Boolean {
         when (item.itemId) {
             R.id.refresh -> {
+                if (this@HomeActivity.isNetworkAccessible(null)) {
                     needsConfirmation(R.string.menu_home_refresh, R.string.refresh_dialog_message) {
                         api.update().enqueue(object : Callback<String> {
                             override fun onResponse(
@@ -1258,9 +1263,12 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
                         Toast.makeText(this, R.string.refresh_in_progress, Toast.LENGTH_SHORT).show()
                     }
                     return true
+                } else {
+                    return false
+                }
             }
             R.id.readAll -> {
-                if (elementsShown == UNREAD_SHOWN) {
+                if (elementsShown == UNREAD_SHOWN && this@HomeActivity.isNetworkAccessible(null)) {
                     needsConfirmation(R.string.readAll, R.string.markall_dialog_message) {
                         swipeRefreshLayout.isRefreshing = false
                         val ids = allItems.map { it.id }

app/src/main/java/apps/amine/bou/readerforselfoss/LoginActivity.kt

@@ -21,6 +21,7 @@ import apps.amine.bou.readerforselfoss.themes.AppColors
 import apps.amine.bou.readerforselfoss.utils.Config
 import apps.amine.bou.readerforselfoss.utils.isBaseUrlValid
 import apps.amine.bou.readerforselfoss.utils.maybeHandleSilentException
+import apps.amine.bou.readerforselfoss.utils.network.isNetworkAccessible
 import com.mikepenz.aboutlibraries.Libs
 import com.mikepenz.aboutlibraries.LibsBuilder
 import kotlinx.android.synthetic.main.activity_login.*
@@ -196,6 +197,8 @@ class LoginActivity : AppCompatActivity() {
                 isWithSelfSignedCert,
                 isWithSelfSignedCert
             )
+
+            if (this@LoginActivity.isNetworkAccessible(this@LoginActivity.findViewById(R.id.loginForm))) {
                 api.login().enqueue(object : Callback<SuccessResponse> {
                     private fun preferenceError(t: Throwable) {
                         editor.remove("url")
@@ -235,6 +238,9 @@ class LoginActivity : AppCompatActivity() {
                         preferenceError(t)
                     }
                 })
+            } else {
+                showProgress(false)
+            }
         }
     }
 

app/src/main/java/apps/amine/bou/readerforselfoss/ReaderActivity.kt

@@ -24,6 +24,7 @@ import apps.amine.bou.readerforselfoss.themes.AppColors
 import apps.amine.bou.readerforselfoss.themes.Toppings
 import apps.amine.bou.readerforselfoss.transformers.DepthPageTransformer
 import apps.amine.bou.readerforselfoss.utils.maybeHandleSilentException
+import apps.amine.bou.readerforselfoss.utils.network.isNetworkAccessible
 import apps.amine.bou.readerforselfoss.utils.persistence.toEntity
 import apps.amine.bou.readerforselfoss.utils.succeeded
 import apps.amine.bou.readerforselfoss.utils.toggleStar
@@ -103,7 +104,8 @@ class ReaderActivity : AppCompatActivity() {
 
         readItem(allItems[currentItem])
 
-        pager.adapter = ScreenSlidePagerAdapter(supportFragmentManager, AppColors(this@ReaderActivity))
+        pager.adapter =
+                ScreenSlidePagerAdapter(supportFragmentManager, AppColors(this@ReaderActivity))
         pager.currentItem = currentItem
     }
 
@@ -132,7 +134,7 @@ class ReaderActivity : AppCompatActivity() {
     }
 
     fun readItem(item: Item) {
-        if (markOnScroll) {
+        if (this@ReaderActivity.isNetworkAccessible(this@ReaderActivity.findViewById(R.id.reader_activity_view)) && markOnScroll) {
             thread {
                 db.itemsDao().delete(item.toEntity())
             }
@@ -164,7 +166,8 @@ class ReaderActivity : AppCompatActivity() {
                             db.itemsDao().insertAllItems(item.toEntity())
                         }
                         if (debugReadingItems) {
-                            ACRA.getErrorReporter().maybeHandleSilentException(t, this@ReaderActivity)
+                            ACRA.getErrorReporter()
+                                .maybeHandleSilentException(t, this@ReaderActivity)
                         }
                     }
                 }
@@ -191,7 +194,6 @@ class ReaderActivity : AppCompatActivity() {
     private inner class ScreenSlidePagerAdapter(fm: FragmentManager, val appColors: AppColors) :
         FragmentStatePagerAdapter(fm) {
 
-
         override fun getCount(): Int {
             return allItems.size
         }
@@ -203,7 +205,12 @@ class ReaderActivity : AppCompatActivity() {
         override fun startUpdate(container: ViewGroup) {
             super.startUpdate(container)
 
-            container.background = ColorDrawable(ContextCompat.getColor(this@ReaderActivity, appColors.colorBackground))
+            container.background = ColorDrawable(
+                ContextCompat.getColor(
+                    this@ReaderActivity,
+                    appColors.colorBackground
+                )
+            )
         }
     }
 
@@ -228,6 +235,7 @@ class ReaderActivity : AppCompatActivity() {
                 return true
             }
             R.id.save -> {
+                if (this@ReaderActivity.isNetworkAccessible(null)) {
                     api.starrItem(allItems[pager.currentItem].id)
                         .enqueue(object : Callback<SuccessResponse> {
                             override fun onResponse(
@@ -251,7 +259,9 @@ class ReaderActivity : AppCompatActivity() {
                             }
                         })
                 }
+            }
             R.id.unsave -> {
+                if (this@ReaderActivity.isNetworkAccessible(null)) {
                     api.unstarrItem(allItems[pager.currentItem].id)
                         .enqueue(object : Callback<SuccessResponse> {
                             override fun onResponse(
@@ -276,6 +286,7 @@ class ReaderActivity : AppCompatActivity() {
                         })
                 }
             }
+        }
         return super.onOptionsItemSelected(item)
     }
 

app/src/main/java/apps/amine/bou/readerforselfoss/SourcesActivity.kt

@@ -13,6 +13,7 @@ import apps.amine.bou.readerforselfoss.api.selfoss.SelfossApi
 import apps.amine.bou.readerforselfoss.api.selfoss.Source
 import apps.amine.bou.readerforselfoss.themes.AppColors
 import apps.amine.bou.readerforselfoss.themes.Toppings
+import apps.amine.bou.readerforselfoss.utils.network.isNetworkAccessible
 import com.ftinc.scoop.Scoop
 import kotlinx.android.synthetic.main.activity_sources.*
 import retrofit2.Call
@@ -66,6 +67,7 @@ class SourcesActivity : AppCompatActivity() {
         recyclerView.setHasFixedSize(true)
         recyclerView.layoutManager = mLayoutManager
 
+        if (this@SourcesActivity.isNetworkAccessible(this@SourcesActivity.findViewById(R.id.recyclerView))) {
             api.sources.enqueue(object : Callback<List<Source>> {
                 override fun onResponse(
                     call: Call<List<Source>>,
@@ -94,6 +96,7 @@ class SourcesActivity : AppCompatActivity() {
                     ).show()
                 }
             })
+        }
 
         fab.setOnClickListener {
             startActivity(Intent(this@SourcesActivity, AddSourceActivity::class.java))

app/src/main/java/apps/amine/bou/readerforselfoss/adapters/ItemCardAdapter.kt

@@ -21,6 +21,7 @@ import apps.amine.bou.readerforselfoss.utils.buildCustomTabsIntent
 import apps.amine.bou.readerforselfoss.utils.customtabs.CustomTabActivityHelper
 import apps.amine.bou.readerforselfoss.utils.glide.bitmapCenterCrop
 import apps.amine.bou.readerforselfoss.utils.glide.circularBitmapDrawable
+import apps.amine.bou.readerforselfoss.utils.network.isNetworkAccessible
 import apps.amine.bou.readerforselfoss.utils.openInBrowserAsNewTask
 import apps.amine.bou.readerforselfoss.utils.openItemUrl
 import apps.amine.bou.readerforselfoss.utils.shareLink
@@ -117,6 +118,7 @@ class ItemCardAdapter(
 
             mView.favButton.setOnLikeListener(object : OnLikeListener {
                 override fun liked(likeButton: LikeButton) {
+                    if (c.isNetworkAccessible(null)) {
                         val (id) = items[adapterPosition]
                         api.starrItem(id).enqueue(object : Callback<SuccessResponse> {
                             override fun onResponse(
@@ -138,8 +140,10 @@ class ItemCardAdapter(
                             }
                         })
                     }
+                }
 
                 override fun unLiked(likeButton: LikeButton) {
+                    if (c.isNetworkAccessible(null)) {
                         val (id) = items[adapterPosition]
                         api.unstarrItem(id).enqueue(object : Callback<SuccessResponse> {
                             override fun onResponse(
@@ -161,6 +165,7 @@ class ItemCardAdapter(
                             }
                         })
                     }
+                }
             })
 
             mView.shareBtn.setOnClickListener {

app/src/main/java/apps/amine/bou/readerforselfoss/adapters/ItemsAdapter.kt

@@ -13,6 +13,7 @@ import apps.amine.bou.readerforselfoss.api.selfoss.SuccessResponse
 import apps.amine.bou.readerforselfoss.persistence.database.AppDatabase
 import apps.amine.bou.readerforselfoss.themes.AppColors
 import apps.amine.bou.readerforselfoss.utils.maybeHandleSilentException
+import apps.amine.bou.readerforselfoss.utils.network.isNetworkAccessible
 import apps.amine.bou.readerforselfoss.utils.persistence.toEntity
 import apps.amine.bou.readerforselfoss.utils.succeeded
 import org.acra.ACRA
@@ -45,6 +46,7 @@ abstract class ItemsAdapter<VH : RecyclerView.ViewHolder?> : RecyclerView.Adapte
                 Snackbar.LENGTH_LONG
             )
             .setAction(R.string.undo_string) {
+                if (app.isNetworkAccessible(null)) {
                     items.add(position, i)
                     thread {
                         db.itemsDao().insertAllItems(i.toEntity())
@@ -70,6 +72,7 @@ abstract class ItemsAdapter<VH : RecyclerView.ViewHolder?> : RecyclerView.Adapte
                         }
                     })
                 }
+            }
 
         val view = s.view
         val tv: TextView = view.findViewById(com.google.android.material.R.id.snackbar_text)
@@ -78,7 +81,7 @@ abstract class ItemsAdapter<VH : RecyclerView.ViewHolder?> : RecyclerView.Adapte
     }
 
     fun removeItemAtIndex(position: Int) {
-
+        if (app.isNetworkAccessible(null)) {
             val i = items[position]
 
             items.remove(i)
@@ -133,6 +136,7 @@ abstract class ItemsAdapter<VH : RecyclerView.ViewHolder?> : RecyclerView.Adapte
                 }
             })
         }
+    }
 
     fun addItemAtIndex(item: Item, position: Int) {
         items.add(position, item)

app/src/main/java/apps/amine/bou/readerforselfoss/adapters/SourcesListAdapter.kt

@@ -13,6 +13,7 @@ import apps.amine.bou.readerforselfoss.api.selfoss.SelfossApi
 import apps.amine.bou.readerforselfoss.api.selfoss.Source
 import apps.amine.bou.readerforselfoss.api.selfoss.SuccessResponse
 import apps.amine.bou.readerforselfoss.utils.glide.circularBitmapDrawable
+import apps.amine.bou.readerforselfoss.utils.network.isNetworkAccessible
 import apps.amine.bou.readerforselfoss.utils.toTextDrawableString
 import com.amulyakhare.textdrawable.TextDrawable
 import com.amulyakhare.textdrawable.util.ColorGenerator
@@ -70,6 +71,7 @@ class SourcesListAdapter(
             val deleteBtn: Button = mView.findViewById(R.id.deleteBtn)
 
             deleteBtn.setOnClickListener {
+                if (c.isNetworkAccessible(null)) {
                     val (id) = items[adapterPosition]
                     api.deleteSource(id).enqueue(object : Callback<SuccessResponse> {
                         override fun onResponse(
@@ -100,4 +102,5 @@ class SourcesListAdapter(
                 }
             }
         }
+    }
 }

app/src/main/java/apps/amine/bou/readerforselfoss/fragments/ArticleFragment.kt

@@ -29,6 +29,7 @@ import apps.amine.bou.readerforselfoss.utils.buildCustomTabsIntent
 import apps.amine.bou.readerforselfoss.utils.customtabs.CustomTabActivityHelper
 import apps.amine.bou.readerforselfoss.utils.isEmptyOrNullOrNullString
 import apps.amine.bou.readerforselfoss.utils.maybeHandleSilentException
+import apps.amine.bou.readerforselfoss.utils.network.isNetworkAccessible
 import apps.amine.bou.readerforselfoss.utils.openItemUrl
 import apps.amine.bou.readerforselfoss.utils.shareLink
 import apps.amine.bou.readerforselfoss.utils.sourceAndDateText
@@ -135,7 +136,8 @@ class ArticleFragment : Fragment() {
                             false,
                             activity!!
                         )
-                        R.id.unread_action -> api.unmarkItem(allItems[pageNumber.toInt()].id).enqueue(
+                        R.id.unread_action -> if ((context != null && context!!.isNetworkAccessible(null)) || context == null) {
+                            api.unmarkItem(allItems[pageNumber.toInt()].id).enqueue(
                                 object : Callback<SuccessResponse> {
                                     override fun onResponse(
                                         call: Call<SuccessResponse>,
@@ -164,6 +166,7 @@ class ArticleFragment : Fragment() {
                                     }
                                 }
                             )
+                        }
                         else -> Unit
                     }
                 }
@@ -212,6 +215,7 @@ class ArticleFragment : Fragment() {
         customTabsIntent: CustomTabsIntent,
         prefs: SharedPreferences
     ) {
+        if ((context != null && context!!.isNetworkAccessible(null)) || context == null) {
             rootView.progressBar.visibility = View.VISIBLE
             val parser = MercuryApi(
                 prefs.getBoolean("should_log_everything", false)
@@ -303,6 +307,7 @@ class ArticleFragment : Fragment() {
                 }
             )
         }
+    }
 
     private fun htmlToWebview(c: String, prefs: SharedPreferences) {
         val stringColor = String.format("#%06X", 0xFFFFFF and appColors.colorAccent)

app/src/main/java/apps/amine/bou/readerforselfoss/utils/network/NetworkUtils.kt

@@ -10,13 +10,15 @@ import apps.amine.bou.readerforselfoss.R
 import com.google.android.material.snackbar.Snackbar
 
 var snackBarShown = false
+var view: View? = null
 
 fun Context.isNetworkAccessible(v: View?): Boolean {
     val cm = this.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager
     val activeNetwork: NetworkInfo? = cm.activeNetworkInfo
     val networkIsAccessible = activeNetwork != null && activeNetwork.isConnectedOrConnecting
 
-    if (v != null && !networkIsAccessible && !snackBarShown) {
+    if (v != null && !networkIsAccessible && (!snackBarShown || v != view)) {
+        view = v
         val s = Snackbar
             .make(
                 v,

app/src/main/res/layout/activity_reader.xml

@@ -2,6 +2,7 @@
 <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     android:layout_width="match_parent"
+    android:id="@+id/reader_activity_view"
     android:layout_height="match_parent">
 
     <com.google.android.material.appbar.AppBarLayout