CHANGELOG.md

@@ -48,8 +48,6 @@
 
 - Dropped support for android 4, the last version supporting it is v1721030811
 
-- Added ability to scroll articles up and down using the volume keys #400
-
 **1.6.x**
 
 - Handling hidden tags.

README.md

@@ -1 +1,47 @@
-# Project moved to https://github.com/aminecmi/ReaderforSelfoss-multiplatform
+# ReaderForSelfoss **(Only available from F-Droid)**
+
+[![Crowdin](https://d322cqt584bo4o.cloudfront.net/readerforselfoss/localized.svg)](https://crowdin.com/project/readerforselfoss)
+
+It's an RSS Reader for Android, that **only** works with [Selfoss](https://selfoss.aditu.de/)
+
+**The project is not dead at all.** 
+
+I still want to work on it, but for the last few months, I didn't have that much time to do so. 
+
+If you are a developer, don't hesitate to help with PRs.
+
+If you are a user, you can still create new issues. I'll fix them when I can.
+
+<a href="https://f-droid.org/packages/apps.amine.bou.readerforselfoss"><img src="https://f-droid.org/badge/get-it-on.png" alt="Get it on F-Droid" height="100"></a>
+
+## Screen captures
+
+<img src="res//fr-card.png?raw=true" alt="card view" width="400"/> <img src="res//fr-list.png?raw=true" alt="list view" width="400"/>
+
+## Like my app ?
+
+<a href="https://www.buymeacoffee.com/aminecmi" target="_blank"><img src="https://cdn.buymeacoffee.com/buttons/lato-orange.png" alt="Buy Me A Coffee" style="height: 51px !important;width: 217px !important;" ></a>
+
+## Want to help ?
+
+1. **You'll have to have a Selfoss instance running.** You'll find everything you need to install it [here](https://selfoss.aditu.de/).
+
+2. Check the [Contribution guide](https://github.com/aminecmi/ReaderforSelfoss/blob/master/.github/CONTRIBUTING.md).
+
+3. Build the project by following [these steps](https://github.com/aminecmi/ReaderforSelfoss/blob/master/.github/CONTRIBUTING.md#build-the-project) (you should have read them after the contribution guide)
+
+## Useful links
+
+- [Check what changed](https://github.com/aminecmi/ReaderforSelfoss/blob/master/CHANGELOG.md)
+- [See what I'm doing](https://github.com/aminecmi/ReaderforSelfoss/projects/1)
+- [Create an issue, or request a new feature](https://github.com/aminecmi/ReaderforSelfoss/issues)
+- [Help translation the app](https://crowdin.com/project/readerforselfoss)
+
+## Contributors (Alphabetical order) ❤️
+
+- [@aancel](https://github.com/aancel)
+- [@Binnette](https://github.com/Binnette)
+- [@davidoskky](https://github.com/davidoskky)
+- [@hectorgabucio](https://github.com/hectorgabucio)
+- [@licaon-kter](https://github.com/licaon-kter)
+- [@sergey-babkin](https://github.com/sergey-babkin)

app/src/androidTest/java/apps/amine/bou/readerforselfoss/DateUtilsTest.kt

@@ -1,5 +1,7 @@
-package apps.amine.bou.readerforselfoss.utils
+package apps.amine.bou.readerforselfoss
 
+import apps.amine.bou.readerforselfoss.utils.Config
+import apps.amine.bou.readerforselfoss.utils.parseDate
 import org.junit.Test
 
 class DateUtilsTest {

app/src/androidTest/java/apps/amine/bou/readerforselfoss/HomeActivityEspressoTest.kt

@@ -7,20 +7,23 @@ import androidx.test.espresso.Espresso.onView
 import androidx.test.espresso.Espresso.openActionBarOverflowOrOptionsMenu
 import androidx.test.espresso.action.ViewActions.click
 import androidx.test.espresso.action.ViewActions.closeSoftKeyboard
+import androidx.test.espresso.action.ViewActions.pressBack
 import androidx.test.espresso.action.ViewActions.pressKey
 import androidx.test.espresso.action.ViewActions.typeText
 import androidx.test.espresso.assertion.ViewAssertions.matches
+import androidx.test.espresso.contrib.DrawerActions
 import androidx.test.espresso.intent.Intents
 import androidx.test.espresso.intent.Intents.intended
+import androidx.test.espresso.intent.Intents.times
 import androidx.test.espresso.intent.matcher.IntentMatchers.hasComponent
 import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
+import androidx.test.espresso.matcher.ViewMatchers.isRoot
 import androidx.test.espresso.matcher.ViewMatchers.withContentDescription
 import androidx.test.espresso.matcher.ViewMatchers.withId
 import androidx.test.espresso.matcher.ViewMatchers.withText
 import androidx.test.rule.ActivityTestRule
 import androidx.test.runner.AndroidJUnit4
 import android.view.KeyEvent
-import androidx.test.espresso.matcher.RootMatchers.isDialog
 import apps.amine.bou.readerforselfoss.utils.Config
 import org.junit.After
 import org.junit.Before
@@ -81,14 +84,11 @@ class HomeActivityEspressoTest {
         onView(withMenu(id = R.id.refresh, titleId = R.string.menu_home_refresh))
                 .perform(click())
 
-        onView(withText(android.R.string.ok))
-            .inRoot(isDialog()).check(matches(isDisplayed())).perform(click())
-
         openActionBarOverflowOrOptionsMenu(context)
 
         onView(withText(R.string.action_disconnect)).perform(click())
 
-        intended(hasComponent(LoginActivity::class.java.name))
+        intended(hasComponent(LoginActivity::class.java.name), times(1))
     }
 
     // TODO: test articles opening and actions for cards and lists

app/src/androidTest/java/apps/amine/bou/readerforselfoss/LoginActivityEspressoTest.kt

@@ -85,7 +85,7 @@ class LoginActivityEspressoTest {
 
         onView(withId(R.id.signInButton)).perform(click())
 
-        onView(withId(R.id.urlView)).check(matches(isHintOrErrorEnabled()))
+        onView(withId(R.id.urlLayout)).check(matches(isHintOrErrorEnabled()))
     }
 
     // TODO: Add tests for multiple false urls with dialog
@@ -101,19 +101,19 @@ class LoginActivityEspressoTest {
 
         onView(withId(R.id.signInButton)).perform(click())
 
-        onView(withId(R.id.loginView)).check(matches(isHintOrErrorEnabled()))
+        onView(withId(R.id.loginLayout)).check(matches(isHintOrErrorEnabled()))
-        onView(withId(R.id.passwordView)).check(matches(isHintOrErrorEnabled()))
+        onView(withId(R.id.passwordLayout)).check(matches(isHintOrErrorEnabled()))
 
         onView(withId(R.id.loginView)).perform(click()).perform(
                 typeText(username),
                 closeSoftKeyboard()
         )
 
-        onView(withId(R.id.passwordView)).check(matches(isHintOrErrorEnabled()))
+        onView(withId(R.id.passwordLayout)).check(matches(isHintOrErrorEnabled()))
 
         onView(withId(R.id.signInButton)).perform(click())
 
-        onView(withId(R.id.passwordView)).check(
+        onView(withId(R.id.passwordLayout)).check(
                 matches(
                         isHintOrErrorEnabled()
                 )
@@ -141,9 +141,9 @@ class LoginActivityEspressoTest {
 
         onView(withId(R.id.signInButton)).perform(click())
 
-        onView(withId(R.id.urlView)).check(matches(isHintOrErrorEnabled()))
+        onView(withId(R.id.urlLayout)).check(matches(isHintOrErrorEnabled()))
-        onView(withId(R.id.loginView)).check(matches(isHintOrErrorEnabled()))
+        onView(withId(R.id.loginLayout)).check(matches(isHintOrErrorEnabled()))
-        onView(withId(R.id.passwordView)).check(matches(isHintOrErrorEnabled()))
+        onView(withId(R.id.passwordLayout)).check(matches(isHintOrErrorEnabled()))
     }
 
     @Test
@@ -167,7 +167,6 @@ class LoginActivityEspressoTest {
 
         onView(withId(R.id.signInButton)).perform(click())
 
-        Thread.sleep(2000)
         intended(hasComponent(HomeActivity::class.java.name))
     }
 

app/src/androidTest/java/apps/amine/bou/readerforselfoss/MainActivityEspressoTest.kt

@@ -1,6 +1,5 @@
 package apps.amine.bou.readerforselfoss
 
-import android.content.Context
 import android.content.Intent
 import android.content.SharedPreferences
 import android.preference.PreferenceManager
@@ -11,7 +10,6 @@ import androidx.test.espresso.intent.Intents.times
 import androidx.test.espresso.intent.matcher.IntentMatchers.hasComponent
 import androidx.test.rule.ActivityTestRule
 import androidx.test.runner.AndroidJUnit4
-import apps.amine.bou.readerforselfoss.utils.Config
 import org.junit.After
 
 import org.junit.Before
@@ -24,9 +22,6 @@ class MainActivityEspressoTest {
 
     lateinit var intent: Intent
     lateinit var preferencesEditor: SharedPreferences.Editor
-    private lateinit var url: String
-    private lateinit var username: String
-    private lateinit var password: String
 
     @Rule @JvmField
     val rule = ActivityTestRule(MainActivity::class.java, true, false)
@@ -37,39 +32,31 @@ class MainActivityEspressoTest {
         val context = getInstrumentation().targetContext
 
         // create a SharedPreferences editor
-        preferencesEditor = context.getSharedPreferences(Config.settingsName, Context.MODE_PRIVATE).edit()
+        preferencesEditor = PreferenceManager.getDefaultSharedPreferences(context).edit()
-
-        url = BuildConfig.LOGIN_URL
-        username = BuildConfig.LOGIN_USERNAME
-        password = BuildConfig.LOGIN_PASSWORD
 
         Intents.init()
     }
 
     @Test
     fun checkFirstOpenLaunchesIntro() {
-        preferencesEditor.putString("url", "")
+        preferencesEditor.putBoolean("firstStart", true)
-        preferencesEditor.putString("password", "")
-        preferencesEditor.putString("login", "")
-        preferencesEditor.commit()
-
-        rule.launchActivity(intent)
-
-        intended(hasComponent(LoginActivity::class.java.name))
-        intended(hasComponent(HomeActivity::class.java.name), times(0))
-    }
-
-    @Test
-    fun checkNotFirstOpenLaunchesLogin() {
-        preferencesEditor.putString("url", url)
-        preferencesEditor.putString("password", password)
-        preferencesEditor.putString("login", username)
         preferencesEditor.commit()
 
         rule.launchActivity(intent)
 
         intended(hasComponent(MainActivity::class.java.name))
-        intended(hasComponent(HomeActivity::class.java.name))
+        intended(hasComponent(LoginActivity::class.java.name), times(0))
+    }
+
+    @Test
+    fun checkNotFirstOpenLaunchesLogin() {
+        preferencesEditor.putBoolean("firstStart", false)
+        preferencesEditor.commit()
+
+        rule.launchActivity(intent)
+
+        intended(hasComponent(MainActivity::class.java.name))
+        intended(hasComponent(LoginActivity::class.java.name))
     }
 
     @After

app/src/androidTest/java/apps/amine/bou/readerforselfoss/Utils.kt

@@ -1,8 +1,8 @@
 package apps.amine.bou.readerforselfoss
 
+import com.google.android.material.textfield.TextInputLayout
 import androidx.test.espresso.matcher.ViewMatchers
 import android.view.View
-import android.widget.EditText
 import org.hamcrest.Description
 import org.hamcrest.Matcher
 import org.hamcrest.Matchers
@@ -14,11 +14,11 @@ fun isHintOrErrorEnabled(): Matcher<View> =
             }
 
             override fun matchesSafely(item: View?): Boolean {
-                if (item !is EditText) {
+                if (item !is TextInputLayout) {
                     return false
                 }
 
-                return item.error.isNotEmpty()
+                return item.isHintEnabled || item.isErrorEnabled
             }
         }
 

app/src/main/java/apps/amine/bou/readerforselfoss/HomeActivity.kt

@@ -18,6 +18,7 @@ import androidx.appcompat.app.ActionBarDrawerToggle
 import androidx.appcompat.app.AlertDialog
 import androidx.appcompat.app.AppCompatActivity
 import androidx.appcompat.widget.SearchView
+import androidx.core.view.MenuItemCompat
 import androidx.core.view.doOnNextLayout
 import androidx.drawerlayout.widget.DrawerLayout
 import androidx.recyclerview.widget.*
@@ -216,7 +217,7 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
             lastFetchDone = false
             handleDrawerItems()
             CoroutineScope(Dispatchers.Main).launch {
-                refreshFocusedItems(applicationContext, api, db, itemsNumber)
+                refreshFocusedItems(applicationContext, api, db)
                 getElementsAccordingToTab()
                 binding.swipeRefreshLayout.isRefreshing = false
             }
@@ -247,7 +248,7 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
                 ): Boolean = false
 
                 override fun onSwiped(viewHolder: RecyclerView.ViewHolder, swipeDir: Int) {
-                    val position = viewHolder.bindingAdapterPosition
+                    val position = viewHolder.adapterPosition
                     val i = items.elementAtOrNull(position)
 
                     if (i != null) {
@@ -981,7 +982,7 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
         CoroutineScope(Dispatchers.Main).launch {
             if (appendResults || !SharedItems.fetchedUnread) {
                 binding.swipeRefreshLayout.isRefreshing = true
-                getUnreadItems(applicationContext, api, db, itemsNumber, offset)
+                getUnreadItems(applicationContext, api, db, offset)
                 binding.swipeRefreshLayout.isRefreshing = false
             }
             SharedItems.getUnRead()
@@ -994,7 +995,7 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
         CoroutineScope(Dispatchers.Main).launch {
             if (appendResults || !SharedItems.fetchedAll) {
                 binding.swipeRefreshLayout.isRefreshing = true
-                getReadItems(applicationContext, api, db, itemsNumber, offset)
+                getReadItems(applicationContext, api, db, offset)
                 binding.swipeRefreshLayout.isRefreshing = false
             }
             SharedItems.getAll()
@@ -1007,7 +1008,7 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
         CoroutineScope(Dispatchers.Main).launch {
             if (appendResults || !SharedItems.fetchedStarred) {
                 binding.swipeRefreshLayout.isRefreshing = true
-                getStarredItems(applicationContext, api, db, itemsNumber, offset)
+                getStarredItems(applicationContext, api, db, offset)
                 binding.swipeRefreshLayout.isRefreshing = false
             }
             SharedItems.getStarred()
@@ -1133,12 +1134,22 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
         return false
     }
 
+    override fun onActivityResult(req: Int, result: Int, data: Intent?) {
+        when (req) {
+            MENU_PREFERENCES -> {
+                //drawer.closeDrawer()
+                recreate()
+            }
+            else -> super.onActivityResult(req, result, data)
+        }
+    }
+
     override fun onCreateOptionsMenu(menu: Menu): Boolean {
         val inflater = menuInflater
         inflater.inflate(R.menu.home_menu, menu)
 
         val searchItem = menu.findItem(R.id.action_search)
-        val searchView = searchItem.getActionView() as SearchView
+        val searchView = MenuItemCompat.getActionView(searchItem) as SearchView
         searchView.setOnQueryTextListener(this)
 
         return true
@@ -1253,7 +1264,8 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
                     .addTag("selfoss-loading")
                     .build()
 
-            WorkManager.getInstance(baseContext).enqueueUniquePeriodicWork("selfoss-loading", ExistingPeriodicWorkPolicy.KEEP, backgroundWork)
+
+            WorkManager.getInstance().enqueueUniquePeriodicWork("selfoss-loading", ExistingPeriodicWorkPolicy.KEEP, backgroundWork)
         }
     }
 

app/src/main/java/apps/amine/bou/readerforselfoss/ReaderActivity.kt

@@ -4,7 +4,6 @@ import android.content.Context
 import android.content.SharedPreferences
 import android.graphics.Color
 import android.os.Bundle
-import android.view.KeyEvent
 import androidx.preference.PreferenceManager
 import androidx.appcompat.app.AppCompatActivity
 import android.view.Menu
@@ -136,30 +135,13 @@ class ReaderActivity : AppCompatActivity() {
     private inner class ScreenSlidePagerAdapter(fa: FragmentActivity) :
         FragmentStateAdapter(fa) {
 
+
         override fun getItemCount(): Int = allItems.size
 
         override fun createFragment(position: Int): Fragment = ArticleFragment.newInstance(allItems[position])
 
     }
 
-    override fun onKeyDown(keyCode: Int, event: KeyEvent?): Boolean {
-        return when (keyCode) {
-            KeyEvent.KEYCODE_VOLUME_DOWN -> {
-                val currentFragment = supportFragmentManager.findFragmentByTag("f" + binding.pager.currentItem) as ArticleFragment
-                currentFragment.scrollDown()
-                true
-            }
-            KeyEvent.KEYCODE_VOLUME_UP -> {
-                val currentFragment = supportFragmentManager.findFragmentByTag("f" + binding.pager.currentItem) as ArticleFragment
-                currentFragment.scrollUp()
-                true
-            }
-            else -> {
-                super.onKeyDown(keyCode, event)
-            }
-        }
-    }
-
     private fun alignmentMenu(showJustify: Boolean) {
         toolbarMenu.findItem(R.id.align_left).isVisible = !showJustify
         toolbarMenu.findItem(R.id.align_justify).isVisible = showJustify

app/src/main/java/apps/amine/bou/readerforselfoss/api/selfoss/SelfossFetching.kt

@@ -39,13 +39,13 @@ suspend fun updateItems(context: Context, api: SelfossApi, db: AppDatabase) = co
     }
 }
 
-suspend fun refreshFocusedItems(context: Context, api: SelfossApi, db: AppDatabase, itemsNumber: Int) = withContext(Dispatchers.IO) {
+suspend fun refreshFocusedItems(context: Context, api: SelfossApi, db: AppDatabase) = withContext(Dispatchers.IO) {
     if (isNetworkAvailable(context)) {
         val response = when (SharedItems.displayedItems) {
-            "read" -> api.readItems(itemsNumber, 0)
+            "read" -> api.readItems(200, 0)
-            "unread" -> api.newItems(itemsNumber, 0)
+            "unread" -> api.newItems(200, 0)
-            "starred" -> api.starredItems(itemsNumber, 0)
+            "starred" -> api.starredItems(200, 0)
-            else -> api.readItems(itemsNumber, 0)
+            else -> api.readItems(200, 0)
         }
 
         if (response.isSuccessful) {
@@ -55,33 +55,33 @@ suspend fun refreshFocusedItems(context: Context, api: SelfossApi, db: AppDataba
     }
 }
 
-suspend fun getReadItems(context: Context, api: SelfossApi, db: AppDatabase, itemsNumber: Int, offset: Int) = withContext(Dispatchers.IO) {
+suspend fun getReadItems(context: Context, api: SelfossApi, db: AppDatabase, offset: Int) = withContext(Dispatchers.IO) {
     if (isNetworkAvailable(context)) {
             try {
-                enqueueArticles(api.readItems( itemsNumber, offset), db, false)
+                enqueueArticles(api.readItems( 200, offset), db, false)
                 SharedItems.fetchedAll = true
                 SharedItems.updateDatabase(db)
             } catch (e: Throwable) {}
     }
 }
 
-suspend fun getUnreadItems(context: Context, api: SelfossApi, db: AppDatabase, itemsNumber: Int, offset: Int) = withContext(Dispatchers.IO) {
+suspend fun getUnreadItems(context: Context, api: SelfossApi, db: AppDatabase, offset: Int) = withContext(Dispatchers.IO) {
     if (isNetworkAvailable(context)) {
         try {
             if (!SharedItems.fetchedUnread) {
                 SharedItems.clearDBItems(db)
             }
-            enqueueArticles(api.newItems(itemsNumber, offset), db, false)
+            enqueueArticles(api.newItems(200, offset), db, false)
             SharedItems.fetchedUnread = true
         } catch (e: Throwable) {}
     }
     SharedItems.updateDatabase(db)
 }
 
-suspend fun getStarredItems(context: Context, api: SelfossApi, db: AppDatabase, itemsNumber: Int, offset: Int) = withContext(Dispatchers.IO) {
+suspend fun getStarredItems(context: Context, api: SelfossApi, db: AppDatabase, offset: Int) = withContext(Dispatchers.IO) {
     if (isNetworkAvailable(context)) {
         try {
-            enqueueArticles(api.starredItems(itemsNumber, offset), db, false)
+            enqueueArticles(api.starredItems(200, offset), db, false)
             SharedItems.fetchedStarred = true
             SharedItems.updateDatabase(db)
         } catch (e: Throwable) {

app/src/main/java/apps/amine/bou/readerforselfoss/fragments/ArticleFragment.kt

@@ -511,16 +511,6 @@ class ArticleFragment : Fragment() {
         )
     }
 
-    fun scrollDown() {
-        val height = binding.nestedScrollView.measuredHeight
-        binding.nestedScrollView.smoothScrollBy(0, height/2)
-    }
-
-    fun scrollUp() {
-        val height = binding.nestedScrollView.measuredHeight
-        binding.nestedScrollView.smoothScrollBy(0, -height/2)
-    }
-
     private fun openInBrowserAfterFailing(customTabsIntent: CustomTabsIntent) {
         binding.progressBar.visibility = View.GONE
         requireActivity().openItemUrlInternalBrowser(