From da4bdd2355bd8623f5bc2434b10d4f466b09fda9 Mon Sep 17 00:00:00 2001 From: davide Date: Mon, 25 Jul 2022 14:10:50 +0200 Subject: [PATCH] Simplify boolean returns --- .../readerforselfossv2/repository/RepositoryImpl.kt | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt index 874a289..34cdbcc 100644 --- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt +++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt @@ -232,7 +232,6 @@ class RepositoryImpl(private val api: SelfossApi, private val apiDetails: ApiDet filter: String ): Boolean { // TODO: Check connectivity - var result = false val response = api.createSourceForVersion( title, url, @@ -242,11 +241,7 @@ class RepositoryImpl(private val api: SelfossApi, private val apiDetails: ApiDet apiMajorVersion ) - if (response != null) { - result = true - } - - return result + return response != null } override suspend fun deleteSource(id: Int): Boolean { @@ -263,11 +258,7 @@ class RepositoryImpl(private val api: SelfossApi, private val apiDetails: ApiDet override suspend fun updateRemote(): Boolean { // TODO: Handle connectivity issues val response = api.update() - return if (response != null) { - response.isSuccess - } else { - false - } + return response?.isSuccess ?: false } override suspend fun login(): Boolean {