shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt

@@ -37,9 +37,6 @@ class Repository(private val api: SelfossApi, private val appSettingsService: Ap
     var badgeStarred = 0
     set(value) {field = if (value < 0) { 0 } else { value } }
 
-    private var fetchedSources = false
-    private var fetchedTags = false
-
     init {
         // TODO: Dispatchers.IO not available in KMM, an alternative solution should be found
         runBlocking {
@@ -109,9 +106,9 @@ class Repository(private val api: SelfossApi, private val appSettingsService: Ap
             val items = api.getItems(
                 itemType.type,
                 0,
-                null,
+                tagFilter?.tag,
-                null,
+                sourceFilter?.id?.toLong(),
-                null,
+                searchFilter,
                 null,
                 200
             )
@@ -135,32 +132,25 @@ class Repository(private val api: SelfossApi, private val appSettingsService: Ap
                 badgeStarred = response.data.starred
                 success = true
             }
-        } else if (appSettingsService.isItemCachingEnabled()) {
+        } else {
             // TODO: do this differently, because it's not efficient
             val dbItems = getDBItems()
             badgeUnread = dbItems.filter { item -> item.unread }.size
             badgeStarred = dbItems.filter { item -> item.starred }.size
-            badgeAll = dbItems.size
+            badgeAll = items.size
-            success = true
         }
         return success
     }
 
     suspend fun getTags(): List<SelfossModel.Tag> {
-        val isDatabaseEnabled = appSettingsService.isItemCachingEnabled() || !appSettingsService.isUpdateSourcesEnabled()
+        return if (isNetworkAvailable()) {
-        return if (isNetworkAvailable() && !fetchedTags) {
             val apiTags = api.tags()
-            if (apiTags.success && apiTags.data != null && isDatabaseEnabled) {
+            if (apiTags.success && apiTags.data != null && (appSettingsService.isItemCachingEnabled() || !appSettingsService.isUpdateSourcesEnabled())) {
                 resetDBTagsWithData(apiTags.data)
-                if (!appSettingsService.isUpdateSourcesEnabled()) {
-                    fetchedTags = true
-                }
             }
             apiTags.data ?: emptyList()
-        } else if (isDatabaseEnabled) {
-            getDBTags().map { it.toView() }
         } else {
-            emptyList()
+            getDBTags().map { it.toView() }
         }
     }
 
@@ -178,21 +168,15 @@ class Repository(private val api: SelfossApi, private val appSettingsService: Ap
         }
     }
 
-    suspend fun getSources(): ArrayList<SelfossModel.Source> {
+    suspend fun getSources(): ArrayList<SelfossModel.Source>? {
-        val isDatabaseEnabled = appSettingsService.isItemCachingEnabled() || !appSettingsService.isUpdateSourcesEnabled()
+        return if (isNetworkAvailable()) {
-        return if (isNetworkAvailable() && !fetchedSources) {
             val apiSources = api.sources()
-            if (apiSources.success && apiSources.data != null && isDatabaseEnabled) {
+            if (apiSources.success && apiSources.data != null && (appSettingsService.isItemCachingEnabled() || !appSettingsService.isUpdateSourcesEnabled())) {
                 resetDBSourcesWithData(apiSources.data)
-                if (!appSettingsService.isUpdateSourcesEnabled()) {
-                    fetchedSources = true
             }
-            }
+            apiSources.data
-            apiSources.data ?: ArrayList()
-        } else if (isDatabaseEnabled) {
-            ArrayList(getDBSources().map { it.toView() })
         } else {
-            ArrayList()
+            ArrayList(getDBSources().map { it.toView() })
         }
     }
 
@@ -363,7 +347,7 @@ class Repository(private val api: SelfossApi, private val appSettingsService: Ap
 
     suspend fun updateRemote(): Boolean {
         return if (isNetworkAvailable()) {
-            api.update().data.equals("finished")
+            api.update().equals("finished")
         } else {
             false
         }
@@ -455,7 +439,7 @@ class Repository(private val api: SelfossApi, private val appSettingsService: Ap
     private fun updateDBItem(item: SelfossModel.Item) =
         db.itemsQueries.updateItem(item.datetime, item.title.getHtmlDecoded(), item.content, item.unread, item.starred, item.thumbnail, item.icon, item.link, item.sourcetitle, item.tags.joinToString(","), item.id.toString())
 
-    // TODO: This function should check for duplicate items
+
     suspend fun tryToCacheItemsAndGetNewOnes(): List<SelfossModel.Item> {
         try {
             val newItems = getMaxItemsForBackground(ItemType.UNREAD)

shared/src/commonTest/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryTest.kt

@@ -17,7 +17,7 @@ import kotlin.test.*
 
 class RepositoryTest() {
     private val connectivityStatus = mockk<ConnectivityStatus>()
-    private val db = mockk<ReaderForSelfossDB>(relaxed = true)
+    private val db = mockk<ReaderForSelfossDB>()
     private val appSettingsService = mockk<AppSettingsService>()
     private val api = mockk<SelfossApi>()
 
@@ -31,7 +31,7 @@ class RepositoryTest() {
         every { appSettingsService.getApiVersion() } returns 4
         every { appSettingsService.getBaseUrl() } returns "https://test.com/selfoss/"
         every { appSettingsService.isItemCachingEnabled() } returns false
-        every { appSettingsService.isUpdateSourcesEnabled() } returns false
+        every { appSettingsService.isUpdateSourcesEnabled() } returns true
 
         every { connectivityStatus.isNetworkConnected } returns MutableStateFlow(true)
 
@@ -46,10 +46,14 @@ class RepositoryTest() {
 
     @Test
     fun `Instantiate repository`() {
+        val success = try {
             Repository(api, appSettingsService, connectivityStatus, db)
+            true
+        } catch (e: Exception) {
+            false
+        }
 
-        coVerify(exactly = 1) { api.version() }
+        assertEquals(true, success)
-        coVerify(exactly = 1) { api.stats() }
     }
 
     @Test
@@ -57,23 +61,28 @@ class RepositoryTest() {
         every { appSettingsService.getApiVersion() } returns -1
         every { connectivityStatus.isNetworkConnected } returns MutableStateFlow(false)
 
+        val success = try {
             Repository(api, appSettingsService, connectivityStatus, db)
+            true
+        } catch (e: Exception) {
+            false
+        }
 
-        coVerify(exactly = 0) { api.version() }
+        assertEquals(true, success)
-        coVerify(exactly = 0) { api.stats() }
     }
 
     @Test
     fun `Instantiate repository with negative stats`() {
         coEvery { api.stats() } returns  SelfossModel.StatusAndData(success = true, data = SelfossModel.Stats(-100, -50, -20))
 
-        val repository = Repository(api, appSettingsService, connectivityStatus, db)
+        val success = try {
+            Repository(api, appSettingsService, connectivityStatus, db)
+            true
+        } catch (e: Exception) {
+            false
+        }
 
-        assertEquals(0, repository.badgeAll)
+        assertEquals(true, success)
-        assertEquals(0, repository.badgeStarred)
-        assertEquals(0, repository.badgeUnread)
-        coVerify(exactly = 1) { api.version() }
-        coVerify(exactly = 1) { api.stats() }
     }
 
     @Test
@@ -258,19 +267,24 @@ class RepositoryTest() {
     }
 
     @Test
-    fun `Reload badges without connection`() {
+    fun `Reload badges with items caching`() {
         every { connectivityStatus.isNetworkConnected } returns MutableStateFlow(false)
         every { appSettingsService.isItemCachingEnabled() } returns true
         every { db.itemsQueries.items().executeAsList() } returns generateTestDBItems()
 
+        val itemParameter = FakeItemParameters()
+        itemParameter.starred = true
+        itemParameter.unread = false
+
         var success = false
 
         val repository = Repository(api, appSettingsService, connectivityStatus, db)
+        repository.items = ArrayList(generateTestApiItem(itemParameter))
         runBlocking {
             success = repository.reloadBadges()
         }
 
-        assertTrue(success)
+        assertSame(true, success)
         assertSame(1, repository.badgeAll)
         assertSame(1, repository.badgeUnread)
         assertSame(1, repository.badgeStarred)
@@ -279,19 +293,23 @@ class RepositoryTest() {
     }
 
     @Test
-    fun `Reload badges without connection and items caching disabled`() {
+    fun `Reload badges without items caching`() {
         every { connectivityStatus.isNetworkConnected } returns MutableStateFlow(false)
         every { appSettingsService.isItemCachingEnabled() } returns false
-        every { appSettingsService.isUpdateSourcesEnabled() } returns true
+
+        val itemParameter = FakeItemParameters()
+        itemParameter.starred = true
+        itemParameter.unread = false
 
         var success = false
 
         val repository = Repository(api, appSettingsService, connectivityStatus, db)
+        repository.items = ArrayList(generateTestApiItem(itemParameter))
         runBlocking {
             success = repository.reloadBadges()
         }
 
-        assertFalse(success)
+        assertSame(false, success)
         assertSame(0, repository.badgeAll)
         assertSame(0, repository.badgeUnread)
         assertSame(0, repository.badgeStarred)
@@ -303,13 +321,8 @@ class RepositoryTest() {
     fun `Get tags`() {
         val tags = listOf(SelfossModel.Tag("test", "red", 6),
             SelfossModel.Tag("second", "yellow", 0))
-        val tagsDB = listOf(TAG("test_DB", "red", 6),
-            TAG("second_DB", "yellow", 0))
 
         coEvery { api.tags() } returns SelfossModel.StatusAndData(success = true, data = tags)
-        coEvery { db.tagsQueries.tags().executeAsList() } returns tagsDB
-        every { appSettingsService.isUpdateSourcesEnabled() } returns true
-        every { appSettingsService.isItemCachingEnabled() } returns true
 
         val repository = Repository(api, appSettingsService, connectivityStatus, db)
         var testTags: List<SelfossModel.Tag>? = null
@@ -318,8 +331,7 @@ class RepositoryTest() {
         }
 
         assertSame(tags, testTags)
-        assertNotSame(tagsDB.map { it.toView() }, testTags)
+        verify(exactly = 0) { db.tagsQueries.tags().executeAsList() }
-        coVerify(exactly = 1) { api.tags() }
     }
 
     @Test
@@ -332,43 +344,18 @@ class RepositoryTest() {
         coEvery { api.tags() } returns SelfossModel.StatusAndData(success = true, data = tags)
         coEvery { db.tagsQueries.tags().executeAsList() } returns tagsDB
         every { appSettingsService.isUpdateSourcesEnabled() } returns false
-        every { appSettingsService.isItemCachingEnabled() } returns true
 
         val repository = Repository(api, appSettingsService, connectivityStatus, db)
         var testTags: List<SelfossModel.Tag> = emptyList()
         runBlocking {
             testTags = repository.getTags()
-            // Tags will be fetched from the database on the second call, thus testTags != tags
             testTags = repository.getTags()
         }
 
-        coVerify(exactly = 1) { api.tags() }
         assertNotSame(tags, testTags)
         assertContentEquals(tagsDB.map { it.toView() }, testTags)
-        verify(atLeast = 1) { db.tagsQueries.tags().executeAsList() }
-    }
-
-    @Test
-    fun `Get tags with items caching disabled`() {
-        val tags = listOf(SelfossModel.Tag("test", "red", 6),
-            SelfossModel.Tag("second", "yellow", 0))
-        val tagsDB = listOf(TAG("test_DB", "red", 6),
-            TAG("second_DB", "yellow", 0))
-
-        coEvery { api.tags() } returns SelfossModel.StatusAndData(success = true, data = tags)
-        coEvery { db.tagsQueries.tags().executeAsList() } returns tagsDB
-        every { appSettingsService.isUpdateSourcesEnabled() } returns true
-        every { appSettingsService.isItemCachingEnabled() } returns false
-
-        val repository = Repository(api, appSettingsService, connectivityStatus, db)
-        var testTags: List<SelfossModel.Tag> = emptyList()
-        runBlocking {
-            testTags = repository.getTags()
-        }
-
-        assertSame(tags, testTags)
         coVerify(exactly = 1) { api.tags() }
-        verify(exactly = 0) { db.tagsQueries.tags().executeAsList() }
+        verify(atLeast = 1) { db.tagsQueries.tags().executeAsList() }
     }
 
     @Test
@@ -387,13 +374,11 @@ class RepositoryTest() {
         var testTags: List<SelfossModel.Tag> = emptyList()
         runBlocking {
             testTags = repository.getTags()
-            testTags = repository.getTags()
         }
 
-        coVerify(exactly = 1) { api.tags() }
+        assertSame(emptyList(), testTags)
-        assertNotSame(tags, testTags)
+        coVerify(exactly = 0) { api.tags() }
-        assertContentEquals(tagsDB.map { it.toView() }, testTags)
+        verify(exactly = 0) { db.tagsQueries.tags().executeAsList() }
-        verify(atLeast = 1) { db.tagsQueries.tags().executeAsList() }
     }
 
     @Test
@@ -406,8 +391,6 @@ class RepositoryTest() {
         coEvery { api.tags() } returns SelfossModel.StatusAndData(success = true, data = tags)
         coEvery { db.tagsQueries.tags().executeAsList() } returns tagsDB
         every { connectivityStatus.isNetworkConnected } returns MutableStateFlow(false)
-        every { appSettingsService.isUpdateSourcesEnabled() } returns true
-        every { appSettingsService.isItemCachingEnabled() } returns true
 
         val repository = Repository(api, appSettingsService, connectivityStatus, db)
         var testTags: List<SelfossModel.Tag> = emptyList()
@@ -416,7 +399,7 @@ class RepositoryTest() {
         }
 
         assertNotSame(tags, testTags)
-        assertContentEquals(tagsDB.map { it.toView() }, testTags)
+        assertSame(tagsDB.first().name, testTags.first().tag)
         coVerify(exactly = 0) { api.tags() }
         verify(atLeast = 1) { db.tagsQueries.tags().executeAsList() }
     }
@@ -432,7 +415,6 @@ class RepositoryTest() {
         coEvery { db.tagsQueries.tags().executeAsList() } returns tagsDB
         every { connectivityStatus.isNetworkConnected } returns MutableStateFlow(false)
         every { appSettingsService.isItemCachingEnabled() } returns false
-        every { appSettingsService.isUpdateSourcesEnabled() } returns true
 
         val repository = Repository(api, appSettingsService, connectivityStatus, db)
         var testTags: List<SelfossModel.Tag> = emptyList()
@@ -440,9 +422,9 @@ class RepositoryTest() {
             testTags = repository.getTags()
         }
 
-        assertSame(emptyList(), testTags)
+        assertContentEquals(tagsDB.map { it.toView() }, testTags)
         coVerify(exactly = 0) { api.tags() }
-        verify(exactly = 0) { db.tagsQueries.tags().executeAsList() }
+        verify(atLeast = 1) { db.tagsQueries.tags().executeAsList() }
     }
 
     @Test
@@ -456,7 +438,6 @@ class RepositoryTest() {
         coEvery { db.tagsQueries.tags().executeAsList() } returns tagsDB
         every { connectivityStatus.isNetworkConnected } returns MutableStateFlow(false)
         every { appSettingsService.isUpdateSourcesEnabled() } returns false
-        every { appSettingsService.isItemCachingEnabled() } returns true
 
         val repository = Repository(api, appSettingsService, connectivityStatus, db)
         var testTags: List<SelfossModel.Tag> = emptyList()
@@ -470,37 +451,31 @@ class RepositoryTest() {
         verify(atLeast = 1) { db.tagsQueries.tags().executeAsList() }
     }
 
-    @Test
-    fun `Get tags without connection and sources update and items caching disabled`() {
-        val tags = listOf(SelfossModel.Tag("test", "red", 6),
-            SelfossModel.Tag("second", "yellow", 0))
-        val tagsDB = listOf(TAG("test_DB", "red", 6),
-            TAG("second_DB", "yellow", 0))
-
-        coEvery { api.tags() } returns SelfossModel.StatusAndData(success = true, data = tags)
-        coEvery { db.tagsQueries.tags().executeAsList() } returns tagsDB
-        every { connectivityStatus.isNetworkConnected } returns MutableStateFlow(false)
-        every { appSettingsService.isUpdateSourcesEnabled() } returns false
-        every { appSettingsService.isItemCachingEnabled() } returns false
-
-        val repository = Repository(api, appSettingsService, connectivityStatus, db)
-        var testTags: List<SelfossModel.Tag> = emptyList()
-        runBlocking {
-            testTags = repository.getTags()
-        }
-
-        assertContentEquals(tagsDB.map { it.toView() }, testTags)
-        coVerify(exactly = 0) { api.tags() }
-        verify(atLeast = 1) { db.tagsQueries.tags().executeAsList() }
-    }
-
     @Test
     fun `get sources`() {
         val sources = arrayListOf(SelfossModel.Source(1, "First source", listOf("Test", "second"),"spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
             SelfossModel.Source(2, "Second source", listOf("second"),"spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
-        val sourcesDB = listOf<SOURCE>(SOURCE("1", "First DB source", "Test,second","spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
+
+        coEvery { api.sources() } returns SelfossModel.StatusAndData(success = true, data = sources)
+        val repository = Repository(api, appSettingsService, connectivityStatus, db)
+        var testSources: List<SelfossModel.Source>? = null
+        runBlocking {
+            testSources = repository.getSources()
+        }
+
+        assertSame(sources, testSources)
+        coVerify(exactly = 1) { api.sources() }
+        verify(exactly = 0) { db.sourcesQueries.sources().executeAsList() }
+    }
+
+    @Test
+    fun `get sources without connection`() {
+        val sources = arrayListOf(SelfossModel.Source(1, "First source", listOf("Test", "second"),"spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
+            SelfossModel.Source(2, "Second source", listOf("second"),"spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
+        val sourcesDB = listOf<SOURCE>(SOURCE("1", "First source", "Test,second","spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
             SOURCE("2", "Second source", "second","spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
 
+        every { connectivityStatus.isNetworkConnected } returns MutableStateFlow(false)
         coEvery { api.sources() } returns SelfossModel.StatusAndData(success = true, data = sources)
         every { db.sourcesQueries.sources().executeAsList() } returns sourcesDB
         val repository = Repository(api, appSettingsService, connectivityStatus, db)
@@ -509,45 +484,41 @@ class RepositoryTest() {
             testSources = repository.getSources()
         }
 
-        assertSame(sources, testSources)
+        assertContentEquals(sources, testSources)
-        assertNotEquals(sourcesDB.map { it.toView() }, testSources)
+        coVerify(exactly = 0) { api.sources() }
-        coVerify(exactly = 1) { api.sources() }
+        verify(atLeast = 1) { db.sourcesQueries.sources().executeAsList() }
+    }
+
+    @Test
+    fun `get sources without connection and items caching disabled`() {
+        val sources = arrayListOf(SelfossModel.Source(1, "First source", listOf("Test", "second"),"spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
+            SelfossModel.Source(2, "Second source", listOf("second"),"spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
+        val sourcesDB = listOf<SOURCE>(SOURCE("1", "First source", "Test,second","spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
+            SOURCE("2", "Second source", "second","spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
+
+        every { connectivityStatus.isNetworkConnected } returns MutableStateFlow(false)
+        every { appSettingsService.isItemCachingEnabled() } returns false
+        coEvery { api.sources() } returns SelfossModel.StatusAndData(success = true, data = sources)
+        every { db.sourcesQueries.sources().executeAsList() } returns sourcesDB
+        val repository = Repository(api, appSettingsService, connectivityStatus, db)
+        var testSources: List<SelfossModel.Source>? = null
+        runBlocking {
+            testSources = repository.getSources()
+        }
+
+        assertSame(null, testSources)
+        coVerify(exactly = 0) { api.sources() }
+        verify(exactly = 0) { db.sourcesQueries.sources().executeAsList() }
     }
 
     @Test
     fun `get sources with sources update disabled`() {
-        val sources = arrayListOf(SelfossModel.Source(1, "First source", listOf("Test", "second"),"spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
-            SelfossModel.Source(2, "Second DB source", listOf("second"),"spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
-        val sourcesDB = listOf<SOURCE>(SOURCE("1", "First source", "Test,second","spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
-            SOURCE("2", "Second source", "second","spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
-
-        every { appSettingsService.isUpdateSourcesEnabled() } returns false
-        every { appSettingsService.isItemCachingEnabled() } returns true
-        coEvery { api.sources() } returns SelfossModel.StatusAndData(success = true, data = sources)
-        every { db.sourcesQueries.sources().executeAsList() } returns sourcesDB
-        val repository = Repository(api, appSettingsService, connectivityStatus, db)
-        var testSources: List<SelfossModel.Source>? = null
-        runBlocking {
-            testSources = repository.getSources()
-            // Sources will be fetched from the database on the second call, thus testSources != sources
-            testSources = repository.getSources()
-        }
-
-        coVerify(exactly = 1) { api.sources() }
-        assertNotSame(sources, testSources)
-        assertContentEquals(sourcesDB.map { it.toView() }, testSources)
-        verify(atLeast = 1) { db.sourcesQueries.sources().executeAsList() }
-    }
-
-    @Test
-    fun `get sources with items caching disabled`() {
         val sources = arrayListOf(SelfossModel.Source(1, "First source", listOf("Test", "second"),"spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
             SelfossModel.Source(2, "Second source", listOf("second"),"spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
         val sourcesDB = listOf<SOURCE>(SOURCE("1", "First source", "Test,second","spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
             SOURCE("2", "Second source", "second","spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
 
-        every { appSettingsService.isUpdateSourcesEnabled() } returns true
+        every { appSettingsService.isUpdateSourcesEnabled() } returns false
-        every { appSettingsService.isItemCachingEnabled() } returns false
         coEvery { api.sources() } returns SelfossModel.StatusAndData(success = true, data = sources)
         every { db.sourcesQueries.sources().executeAsList() } returns sourcesDB
         val repository = Repository(api, appSettingsService, connectivityStatus, db)
@@ -556,9 +527,9 @@ class RepositoryTest() {
             testSources = repository.getSources()
         }
 
-        assertSame(sources, testSources)
+        assertContentEquals(sources, testSources)
-        coVerify(exactly = 1) { api.sources() }
+        coVerify(exactly = 0) { api.sources() }
-        verify(exactly = 0) { db.sourcesQueries }
+        verify(atLeast = 1) { db.sourcesQueries.sources().executeAsList() }
     }
 
     @Test
@@ -578,101 +549,11 @@ class RepositoryTest() {
             testSources = repository.getSources()
         }
 
-        assertSame(sources, testSources)
+        assertSame(null, testSources)
-        coVerify(exactly = 1) { api.sources() }
-        verify(atLeast = 1) { db.sourcesQueries }
-    }
-
-    @Test
-    fun `get sources without connection`() {
-        val sources = arrayListOf(SelfossModel.Source(1, "First source", listOf("Test", "second"),"spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
-            SelfossModel.Source(2, "Second source", listOf("second"),"spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
-        val sourcesDB = listOf<SOURCE>(SOURCE("1", "First DB source", "Test,second","spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
-            SOURCE("2", "Second source", "second","spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
-
-        every { connectivityStatus.isNetworkConnected } returns MutableStateFlow(false)
-        coEvery { api.sources() } returns SelfossModel.StatusAndData(success = true, data = sources)
-        every { db.sourcesQueries.sources().executeAsList() } returns sourcesDB
-        val repository = Repository(api, appSettingsService, connectivityStatus, db)
-        var testSources: List<SelfossModel.Source>? = null
-        runBlocking {
-            testSources = repository.getSources()
-        }
-
-        assertContentEquals(sourcesDB.map { it.toView() }, testSources)
-        coVerify(exactly = 0) { api.sources() }
-        verify(atLeast = 1) { db.sourcesQueries.sources().executeAsList() }
-    }
-
-    @Test
-    fun `get sources without connection and items caching disabled`() {
-        val sources = arrayListOf(SelfossModel.Source(1, "First source", listOf("Test", "second"),"spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
-            SelfossModel.Source(2, "Second source", listOf("second"),"spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
-        val sourcesDB = listOf<SOURCE>(SOURCE("1", "First DB source", "Test,second","spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
-            SOURCE("2", "Second source", "second","spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
-
-        every { connectivityStatus.isNetworkConnected } returns MutableStateFlow(false)
-        every { appSettingsService.isItemCachingEnabled() } returns false
-        every { appSettingsService.isUpdateSourcesEnabled() } returns true
-        coEvery { api.sources() } returns SelfossModel.StatusAndData(success = true, data = sources)
-        every { db.sourcesQueries.sources().executeAsList() } returns sourcesDB
-        val repository = Repository(api, appSettingsService, connectivityStatus, db)
-        var testSources: List<SelfossModel.Source>? = null
-        runBlocking {
-            testSources = repository.getSources()
-        }
-
-        assertContentEquals(ArrayList(), testSources)
         coVerify(exactly = 0) { api.sources() }
         verify(exactly = 0) { db.sourcesQueries.sources().executeAsList() }
     }
 
-    @Test
-    fun `get sources without connection and sources update disabled`() {
-        val sources = arrayListOf(SelfossModel.Source(1, "First source", listOf("Test", "second"),"spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
-            SelfossModel.Source(2, "Second source", listOf("second"),"spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
-        val sourcesDB = listOf<SOURCE>(SOURCE("1", "First DB source", "Test,second","spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
-            SOURCE("2", "Second source", "second","spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
-
-        every { connectivityStatus.isNetworkConnected } returns MutableStateFlow(false)
-        every { appSettingsService.isItemCachingEnabled() } returns true
-        every { appSettingsService.isUpdateSourcesEnabled() } returns false
-        coEvery { api.sources() } returns SelfossModel.StatusAndData(success = true, data = sources)
-        every { db.sourcesQueries.sources().executeAsList() } returns sourcesDB
-        val repository = Repository(api, appSettingsService, connectivityStatus, db)
-        var testSources: List<SelfossModel.Source>? = null
-        runBlocking {
-            testSources = repository.getSources()
-        }
-
-        assertContentEquals(sourcesDB.map { it.toView() }, testSources)
-        coVerify(exactly = 0) { api.sources() }
-        verify(atLeast = 1) { db.sourcesQueries.sources().executeAsList() }
-    }
-
-    @Test
-    fun `get sources without connection and items caching and sources update disabled`() {
-        val sources = arrayListOf(SelfossModel.Source(1, "First source", listOf("Test", "second"),"spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
-            SelfossModel.Source(2, "Second source", listOf("second"),"spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
-        val sourcesDB = listOf<SOURCE>(SOURCE("1", "First DB source", "Test,second","spouts\\rss\\fulltextrss", "", "d8c92cdb1ef119ea85c4b9205c879ca7.png"),
-            SOURCE("2", "Second source", "second","spouts\\rss\\fulltextrss", "", "b3aa8a664d08eb15d6ff1db2fa83e0d9.png"))
-
-        every { connectivityStatus.isNetworkConnected } returns MutableStateFlow(false)
-        every { appSettingsService.isItemCachingEnabled() } returns false
-        every { appSettingsService.isUpdateSourcesEnabled() } returns false
-        coEvery { api.sources() } returns SelfossModel.StatusAndData(success = true, data = sources)
-        every { db.sourcesQueries.sources().executeAsList() } returns sourcesDB
-        val repository = Repository(api, appSettingsService, connectivityStatus, db)
-        var testSources: List<SelfossModel.Source>? = null
-        runBlocking {
-            testSources = repository.getSources()
-        }
-
-        assertContentEquals(sourcesDB.map { it.toView() }, testSources)
-        coVerify(exactly = 0) { api.sources() }
-        verify(atLeast = 1) { db.sourcesQueries.sources().executeAsList() }
-    }
-
     @Test
     fun `create source`() {
         coEvery { api.createSourceForVersion(any(), any(), any(), any(), any(), any()) } returns
@@ -773,26 +654,12 @@ class RepositoryTest() {
         }
 
         coVerify(exactly = 1) { api.update() }
-        assertTrue(response)
+        assertSame(true, response)
     }
 
     @Test
     fun `update remote but response fails`() {
-        coEvery { api.update()} returns SelfossModel.StatusAndData(success = false, data = "unallowed access")
+        coEvery { api.update()} returns SelfossModel.StatusAndData(success = false, data = "undocumented...")
-
-        val repository = Repository(api, appSettingsService, connectivityStatus, db)
-        var response = false
-        runBlocking {
-            response = repository.updateRemote()
-        }
-
-        coVerify(exactly = 1) { api.update() }
-        assertSame(false, response)
-    }
-
-    @Test
-    fun `update remote with unallowed access`() {
-        coEvery { api.update()} returns SelfossModel.StatusAndData(success = true, data = "unallowed access")
 
         val repository = Repository(api, appSettingsService, connectivityStatus, db)
         var response = false
@@ -874,19 +741,10 @@ class RepositoryTest() {
         coVerify(exactly = 1) {appSettingsService.refreshLoginInformation("https://test.com/selfoss/", "login", "password")}
     }
 
-    // TODO: This function should check if duplicate items are added to the database
     @Test
     fun `cache items`() {
-        val itemParameter1 = FakeItemParameters()
+        coEvery { api.getItems(any(), any(), any(), any(), any(), any(), any()) } returns
-        val itemParameter2 = FakeItemParameters()
+                SelfossModel.StatusAndData(success = true, data = generateTestApiItem())
-        val itemParameter3 = FakeItemParameters()
-        itemParameter2.id = "2"
-        itemParameter3.id = "3"
-        coEvery { api.getItems(any(), any(), any(), any(), any(), any(), any()) } returnsMany listOf(
-                SelfossModel.StatusAndData(success = true, data = generateTestApiItem(itemParameter1)),
-                SelfossModel.StatusAndData(success = true, data = generateTestApiItem(itemParameter2)),
-                SelfossModel.StatusAndData(success = true, data = generateTestApiItem(itemParameter1)),
-        )
 
         val repository = Repository(api, appSettingsService, connectivityStatus, db)
         repository.tagFilter = SelfossModel.Tag("Tag", "read", 0)
@@ -905,6 +763,7 @@ class RepositoryTest() {
         }
 
         coVerify(exactly = 3) { api.getItems(any(), 0, null, null, null, null, 200) }
+        assertSame(3, items.size)
     }
 
     @Test
@@ -993,7 +852,7 @@ fun generateTestApiItem(item : FakeItemParameters = FakeItemParameters()) : List
 }
 
 class FakeItemParameters() {
-    var id = "20"
+    val id = "20"
     var datetime = "2022-09-09T03:32:01-04:00"
     val title = "Etica della ricerca sotto i riflettori."
     val content = "<p><strong>Luigi Campanella, già Presidente SCI</strong></p>\n<p>L’etica della scienza è di certo ambito di cui continuiamo a scoprire nuovi aspetti e risvolti.</p>\n<p>L’ultimo è quello delle intelligenze artificiali capaci di creare opere complesse basate su immagini e parole memorizzate con il rischio di fake news e di contenuti disturbanti.</p>\n<p>Per evitare che ciò accada si sta procedendo filtrando secondo criteri di autocensura i dati da cui l’intelligenza artificiale parte.</p>\n<p>Comincia ad intravedersi un futuro prossimo di competizione fra autori umani ed artificiali nel quale sarà importante, quando i loro prodotti saranno indistinguibili, dichiararne l’origine.</p>\n<p>Come si comprende, si conferma che gli aspetti etici dell’innovazione e della ricerca si diversificato sempre di più.</p>\n<p>La biologia molecolare e la genetica già in passato hanno posto all’attenzione comune aspetti di etica della scienza che hanno indotto a nuove riflessioni circa i limiti delle ricerche.</p>\n<p>L’argomento, sempre attuale, torna sulle prime pagine a seguito della pubblicazione di una ricerca della Università di Cambridge che ha sviluppato una struttura cellulare di un topo con un cuore che batte regolarmente.</p>\n<img src=\"https://ilblogdellasci.files.wordpress.com/2022/09/image002-1.png?w=481\" alt=\"\" width=\"697\" height=\"430\" /><img src=\"https://ilblogdellasci.files.wordpress.com/2022/09/image003-1.png?w=906\" alt=\"\" /><p>Magdalena Zernicka-Goetz</p>\n<img src=\"https://ilblogdellasci.files.wordpress.com/2022/09/image004.jpg?w=474\" alt=\"\" width=\"622\" height=\"465\" /><p>Gianluca Amadei</p>\n<p>Del gruppo fa parte anche uno scienziato italiano Gianluca Amadei,che dinnanzi alle obiezioni di natura etica sulla realizzazione della vita artificiale si è affrettato a sostenere che non è creare nuove vite il fine primario della ricerca, ma quello di salvare quelle esistenti, di dare contributi essenziali alla medicina citando il caso del fallimento tuttora non interpretato di alcune gravidanze e di superare la sperimentazione animale, così contribuendo positivamente alla soluzione di un altro dilemma etico.</p>\n<p>L’embrione sintetico ha ovviamente come primo traguardo il contributo ai trapianti oggi drammaticamente carenti nell’offerta rispetto alla domanda, con attese fino a 4 anni per i trapianti di cuore ed a 2 anni per quelli di fegato. Il lavoro dovrebbe adesso continuare presso l’Ateneo di Padova per creare nuovi organi e nuovi farmaci.</p>"