davidoskky
0 Followers · 0 Following
  • Joined on 2022-08-16
Repositories
1
 Projects Packages Public Activity Starred Repositories
davidoskky opened issue Louvorg/ReaderForSelfoss-multiplatform#71 2022-10-02 10:47:11 +00:00
Implement Selfoss API 5.0.0
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#70 2022-10-01 23:29:32 +00:00
Simplify sources and tags handling

This doesn't worked as expected since the itemAdapter is cleared immediately after.

davidoskky pushed to drawer_data at davidoskky/ReaderForSelfoss-multiplatform 2022-10-01 23:01:43 +00:00
c15bf44032 Adjust repository tests
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#70 2022-10-01 21:07:15 +00:00
Simplify sources and tags handling

As far as I can see this is not the case; the pull to refresh just calls handleDrawerData(). What I could do, is change the repository implementation of getTags() and getSources() so that…

davidoskky pushed to drawer_data at davidoskky/ReaderForSelfoss-multiplatform 2022-10-01 20:51:14 +00:00
0bcd55bd4e Add translated strings
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#70 2022-10-01 20:50:07 +00:00
Simplify sources and tags handling

Yes, I made a mistake. You were right in the first comment. However this behavior never update sources once they've been stored in the database.

davidoskky pushed to drawer_data at davidoskky/ReaderForSelfoss-multiplatform 2022-10-01 20:44:00 +00:00
ebef0b3511 Start monitoring connectivity status when the repository is initiated.
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#70 2022-10-01 20:36:59 +00:00
Simplify sources and tags handling

There is no change in behavior. Before api calls were made after checking this condition: `drawerData.sources?.isEmpty() == true

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#70 2022-10-01 20:27:41 +00:00
Simplify sources and tags handling

This starts tracking the connectivity status before the repository is initiated; it fixes a problem with the repository not correctly executing actions in the init method.

davidoskky created pull request Louvorg/ReaderForSelfoss-multiplatform#70 2022-09-30 13:11:33 +00:00
Simplify sources and tags handling
davidoskky pushed to drawer_data at davidoskky/ReaderForSelfoss-multiplatform 2022-09-30 13:07:22 +00:00
713ceb05bf Remove unnecessary data class
davidoskky pushed to drawer_data at davidoskky/ReaderForSelfoss-multiplatform 2022-09-30 13:00:29 +00:00
dc8381b661 Add missing string
davidoskky created branch drawer_data in davidoskky/ReaderForSelfoss-multiplatform 2022-09-30 13:00:06 +00:00
davidoskky pushed to drawer_data at davidoskky/ReaderForSelfoss-multiplatform 2022-09-30 13:00:06 +00:00
b5b820c64b Remove database access from the Home
f7055626d9 Start monitoring the connectivity before loading the Repository
Compare 2 commits »
davidoskky pushed to master at davidoskky/ReaderForSelfoss-multiplatform 2022-09-30 12:39:55 +00:00
6ec3e96909 Merge pull request 'Repository Unit Tests' (#50) from davidoskky/ReaderForSelfoss-multiplatform:repository_tests into master
22da30eaa8 Remove unnecessary call to api
79fd115f5e Only return new cached items
8dc3d319cd Cleanup
27bb056397 Cleanup
Compare 62 commits »
davidoskky deleted branch repository_tests from davidoskky/ReaderForSelfoss-multiplatform 2022-09-30 12:30:54 +00:00
22da30eaa8 Remove unnecessary call to api
79fd115f5e Only return new cached items
Compare 2 commits »
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-30 11:13:32 +00:00
Repository Unit Tests

Ops, you're right I made a mistake while changing things...

8dc3d319cd Cleanup
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-30 09:58:37 +00:00
Repository Unit Tests

getDBTags and getDBSources are used in the home activity. It would be better in my opinion to remove this direct access to the database and let the repository check all the logical steps. I feel…