davidoskky
  • Joined on 2022-08-16
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-30 09:51:56 +00:00
Repository Unit Tests

Does it use the id to check for duplicates? If that is the case then all is good.

27bb056397 Cleanup
f9ba13dc32 Always cache images in background
6f60ef4346 Remove unnecessary return value
28b950f467 Merge branch 'master' into repository_tests
381d6acc82 Analyzing should be with the rest.
Compare 2 commits »
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-29 23:20:13 +00:00
Repository Unit Tests

All tests pass now

a9c7ec3dc1 Cache items in background without filtering
920d4ac1ef Correctly implement disabling sources update
0e96d313ec Add tags parameters explicitly
7211fdb1a3 Fix update remote tests
d311c2cdeb Fix sources tests
Compare 8 commits »
15ec0f2d26 Merge branch 'master' into repository_tests
ad279c6683 Translation.
5f0817ddb7 Formating issue.
7124cbcacd Fixed issue with drone failing silently.
2a710a1a08 Translations.
Compare 23 commits »
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-28 06:55:47 +00:00
Repository Unit Tests

I'm not sure how I would implement this test otherwise, I guess the repository should raise an exception during initialization then.

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-28 06:54:42 +00:00
Repository Unit Tests

To test that api.tags() gets called only once regardless of how many calls are made to the repository.

4781e30da2 Remove unnecessary safe calls
c8759cc035 Fix tags tests
cb4f2f02ef Fix repository.tags() returning null
7517626ab7 Include database return definition within test function
Compare 3 commits »
41c951b659 Add test cases for repository instantiation cases
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 19:31:39 +00:00
Repository Unit Tests

It should be quicker and prevents errors in case some problems with DB clearing happens.

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 19:29:14 +00:00
Repository Unit Tests

No, filters can be set when this method is called. This method should deliberately ignore filters.

Imagine this:

  • Open the app
  • Select one tag
  • The background sync starts at this…
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 19:03:41 +00:00
Repository Unit Tests

With update_sources disabled, the api calls to tags and sources is done once to cache the data, and then, the data in the cache is used.

Alright, so I should verify that the call to the api…

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 18:55:02 +00:00
Repository Unit Tests

I expect the function to behave differently from how it is currently behaving.

Expected behavior: When background sync starts, the last 200 articles for each item type are cached. Thus I…

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 18:50:17 +00:00
Repository Unit Tests

I don't think sources and tags should be cached if items are not cached; what would be the use of such a function?

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 18:49:16 +00:00
Repository Unit Tests

Even if the DB is empty, there is no reason to call it if the setting is disabled. I placed something in the DB just to test that it was not called.

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 18:46:36 +00:00
Repository Unit Tests

Right, I definitely have to define these things within the functions to avoid these kinds of errors.