I am confused, as far as I remember update_sources was introduced to limit the amount of api calls to selfoss because that was heavy on the database and created some problems. That is also how it…
If update_sources handles tag fetching then it shouldn't. Maybe it would be better to rename update_sources so that it becomes more clear that it handles tags as well? I do get confused at times.
I would expect tags to be fetched from the database, since the api should not be used.
If update_sources handles tags fetching, then tags should not be fetched using the api.
As above
This function is supposed to store articles for the background; it should store all articles independently of the tags selected by the user in the foreground.
Why is tags caching handled by update_sources?
Yes, this is intended. Since items caching is disabled I would expect the function not to access items in the database. Maybe it's better if I define that item within this function to avoid…
Same as above.
Same as above.
The test can fail if the repository initialization generates an error; this is just a very general case to identify if something in the repository initialization is broken. All other tests would…
Yes, I do understand. I suggest this edit just because it would allow to keep all information about the connectivity private within the repository and increase incapsulation. But there is no…
This does not change the behavior of the function at all. runBlocking and Dispatchers.Main are basically the same thing. However, the testing framework for the common code does not support…
I have added all the tests I could. I had some problems mocking the functions required to mark items as read/starred because of some problems with expect functions, which I'm unsure how to go…