davidoskky
  • Joined on 2022-08-16
davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#47 2022-08-30 07:30:43 +00:00
Pressing back in setting goes back to home

Ok, I see the issue... I'm currently busy restructuring a flat. If I find some free time I'll take a look at that.

davidoskky opened issue Louvorg/ReaderForSelfoss-multiplatform#47 2022-08-28 22:14:50 +00:00
Pressing back in setting goes back to home
davidoskky pushed to master at davidoskky/ReaderForSelfoss-multiplatform 2022-08-28 22:01:10 +00:00
ff6038dbd4 Removing the backup function for security reasons.
8146cff011 Merge pull request 'Closes #44' (#46) from chore/cleaning_drawer_data into master
fc4c48dd12 Closes #44
94f1ec943c Cleaning.
0278540fb2 Merge pull request 'feature/api_timeout_and_settings_cleaning' (#45) from feature/api_timeout_and_settings_cleaning into master
Compare 13 commits »
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#45 2022-08-27 09:48:07 +00:00
feature/api_timeout_and_settings_cleaning

This has a typo

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#45 2022-08-27 09:35:31 +00:00
feature/api_timeout_and_settings_cleaning

I think you have to declare it's a val in the class constructor in order to make it a class variable and use it within functions.

davidoskky closed pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-27 09:32:09 +00:00
WIP: HomeActivity cleanup
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-26 11:25:21 +00:00
WIP: HomeActivity cleanup

I guess that most of the stuff in this PR isn't very useful since what we concluded discussing. I can close this and make a new one only including the changes which are useful after you merge the…

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-26 11:23:50 +00:00
WIP: HomeActivity cleanup

Yes, I feel this could be a great way to solve this issue.

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 19:17:02 +00:00
WIP: HomeActivity cleanup

Why don't you swipe between the articles ?

I have many articles to read and I do not read them in order, it is easier for me to get back to the list and select from there what I want to read…

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 18:35:33 +00:00
WIP: HomeActivity cleanup

Personal use case: selfoss fetches new articles every 15 minutes, in the application I will be reading an article in a couple of minutes and then going back to the articles list to select another…

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 16:02:39 +00:00
WIP: HomeActivity cleanup

updateRemote doesn't necessarily have to be there, I have done it because I think it makes it easier to read through the activity code. getItems in the viewmodel allows storing the items in the…

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 16:00:24 +00:00
WIP: HomeActivity cleanup

When init is run the connectivity check always fails. This allows retrieving the badges every time connectivity gets back. We could include here all operations that should be run as soon as…

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 15:57:55 +00:00
WIP: HomeActivity cleanup

Storing the items would allow sharing the same data across all activities without passing it around and it can be used to prevent making an api call every time you close an article and come back…

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 15:56:20 +00:00
WIP: HomeActivity cleanup

Alright, I'll find a different way to handle this then.

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 11:28:47 +00:00
WIP: HomeActivity cleanup

Oh, I did not notice that. I will wait for you to merge that before continuing.

davidoskky created pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 10:51:18 +00:00
WIP: HomeActivity cleanup
davidoskky pushed to dispatchers at davidoskky/ReaderForSelfoss-multiplatform 2022-08-25 10:42:51 +00:00
ac0156748b Use Dispatchers.IO for network and database operations
davidoskky pushed to dispatchers at davidoskky/ReaderForSelfoss-multiplatform 2022-08-25 10:39:02 +00:00
8c817b5938 Fetch badges and version on network available.
4857a3d0ac Move Home functionalities to the viewmodel
Compare 2 commits »
davidoskky created branch dispatchers in davidoskky/ReaderForSelfoss-multiplatform 2022-08-25 10:39:01 +00:00
davidoskky pushed to master at davidoskky/ReaderForSelfoss-multiplatform 2022-08-25 08:04:20 +00:00
fbcb428e96 Merge pull request 'Fetch api version on login' (#39) from davidoskky/ReaderForSelfoss-multiplatform:loginApi into master
e281751bb0 Fetch api version on login
Compare 2 commits »