davidoskky
  • Joined on 2022-08-16
davidoskky pushed to network at davidoskky/ReaderForSelfoss-multiplatform 2022-08-20 19:14:40 +00:00
767805981f Don't reset offline override before updating remote
99b34cfa41 Consider offline override before updating remote
8949f78177 Refactor functions
Compare 3 commits »
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-20 18:59:48 +00:00
network

@davidoskky it would be great to have the toast message displayed back on status change. Why was it removed ?

I have removed it because I figured it would be better to use a viewModel to send…

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-20 18:56:57 +00:00
network

I have tried; unfortunately this is not possible. Not really a technical problem, it is because the name of the library contains a dash (-) and this generates an error at build time. This issue…

davidoskky deleted branch logging from davidoskky/ReaderForSelfoss-multiplatform 2022-08-20 18:23:39 +00:00
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#32 2022-08-20 12:43:59 +00:00
Implement logging in the android application

What does it add to the default logcat ?

This allows logging using the Napier library which is required to log from commonMain. For example this line doesn't log anything if this piece of…

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#32 2022-08-20 10:49:13 +00:00
Implement logging in the android application

This logging is local, this shouldn't be affected by GDPR, this is needed when debugging; we can also not insert this, but we'll have to add it in every time we debug.

Regarding GDPR, I think…

davidoskky pushed to network at davidoskky/ReaderForSelfoss-multiplatform 2022-08-20 10:45:02 +00:00
49abc081b6 Don't send toast messages from the repository
1290d3c4dd Remove unused function
faac7fc621 Prepare the repository functions for DB implementation
59267e6759 Don't create the mercury api if not connection is available
9a33ba0dbb Stop monitoring the network when the app goes in background
Compare 19 commits »
davidoskky pushed to network at davidoskky/ReaderForSelfoss-multiplatform 2022-08-20 10:42:31 +00:00
17f7d58aed Don't send toast messages from the repository
davidoskky pushed to network at davidoskky/ReaderForSelfoss-multiplatform 2022-08-20 10:40:44 +00:00
ad2dfcae1b Remove unused function
davidoskky pushed to network at davidoskky/ReaderForSelfoss-multiplatform 2022-08-20 10:37:18 +00:00
ef0f326073 Prepare the repository functions for DB implementation
davidoskky created pull request Louvorg/ReaderForSelfoss-multiplatform#32 2022-08-20 10:30:26 +00:00
Implement logging in the android application
davidoskky created branch logging in davidoskky/ReaderForSelfoss-multiplatform 2022-08-20 10:29:23 +00:00
davidoskky pushed to logging at davidoskky/ReaderForSelfoss-multiplatform 2022-08-20 10:29:23 +00:00
72d9ef92d2 Implement logging in the android application
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-20 10:23:17 +00:00
network

Yes, however it might actually be better to remove this logic from the repository and implement a viewModel to send these messages. Localization in the common source set appears to be complicated.

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-20 10:20:00 +00:00
network

I have set it up to stop monitoring the network once the application goes into background. Unfortunately this doesn't work at the moment due to a bug in the library I'm using to monitor the…

davidoskky pushed to network at davidoskky/ReaderForSelfoss-multiplatform 2022-08-20 10:17:44 +00:00
3aa6934f86 Don't create the mercury api if not connection is available
0cec538d18 Stop monitoring the network when the app goes in background
Compare 2 commits »
davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#25 2022-08-20 08:48:55 +00:00
Update remote option crashes the app

This fix works for me on api version 4; didn't realize this issue existed, definitely it's not present in the F-Droid version. Does this work on selfoss 2.18 as well?

davidoskky pushed to master at davidoskky/ReaderForSelfoss-multiplatform 2022-08-20 08:04:52 +00:00
1392e2a571 Merge pull request 'Fixing some sonarqube issues.' (#30) from chore/sonarqube-fixes into master
e9cb3d2f37 Fixing some sonarqube issues.
dec620a409 Merge pull request 'Changed ids to items.' (#29) from id-to-int into master
4d29ee0b92 Last fixes.
33333ca998 This may work.
Compare 12 commits »
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-18 16:02:24 +00:00
network

Since the network state is checked by the repository, doing this when the app is sent to background would prevent background jobs. Calling stop before the app is closed appears redundant to me…

davidoskky pushed to network at davidoskky/ReaderForSelfoss-multiplatform 2022-08-18 12:50:44 +00:00
5eb46dc4e9 Do not change the network override from within the repository
a0d6159cf4 Reintroduce network checks where required
bea8f18db4 Refactor connectivity check
Compare 3 commits »