davidoskky
  • Joined on 2022-08-16
davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#121 2023-01-04 10:43:34 +00:00
[Dependency] com.github.chrisbanes:PhotoView

Could you create issues for these problems ?

I mean, the code I implemented to introduce that feature has problems with the viewpager, currently it works flawlessly as far as I've seen.

davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#121 2023-01-04 10:36:03 +00:00
[Dependency] com.github.chrisbanes:PhotoView

The dependency is used in the image activity to allow zooming and moving the images. As far as I know, it should be possible to remove the dependency and implement these behavior ourselves, but…

davidoskky deleted branch author from davidoskky/ReaderForSelfoss-multiplatform 2022-12-28 14:28:04 +00:00
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#117 2022-12-28 13:38:45 +00:00
Make the author field nullable

Dropping columns was introduced in version 3.35 https://sqlite.org/changes.html

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#117 2022-12-28 13:34:13 +00:00
Make the author field nullable

Alright, this should now work; I'm not able to test the migration because the previous version crashes on me, check that everything works smoothly. I had to drop the whole table since also…

davidoskky pushed to author at davidoskky/ReaderForSelfoss-multiplatform 2022-12-28 13:26:04 +00:00
e51915d1cd Include author field when updating the database
3a654f6ede Migrate the database table
Compare 2 commits »
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#117 2022-12-28 13:15:07 +00:00
Make the author field nullable

Yes, I'll submit everything soon.

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#117 2022-12-28 10:58:21 +00:00
Make the author field nullable

Ops, I thought this version hadn't been released yet and that thus that would be fine.

davidoskky created pull request Louvorg/ReaderForSelfoss-multiplatform#117 2022-12-28 10:03:54 +00:00
Make the author field nullable
davidoskky created branch author in davidoskky/ReaderForSelfoss-multiplatform 2022-12-28 10:02:49 +00:00
davidoskky pushed to author at davidoskky/ReaderForSelfoss-multiplatform 2022-12-28 10:02:49 +00:00
5227751dca Make the author field nullable
27eafe4ff4 Delete sources from DB and reload items on source deletion.
8c83a9408b Drone should work better.
fe2410f719 Handling author field.
a5e86bfb77 Date format issues.
Compare 10 commits »
davidoskky pushed to master at davidoskky/ReaderForSelfoss-multiplatform 2022-12-14 21:00:20 +00:00
7420adeb5c Do not ignore git version.
316027ca3b Tag for build.
9d58fba5c9 Cleaning.
284c19ef89 More cleaning.
7cfd17231a Cleaning.
Compare 48 commits »
davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#13 2022-12-13 20:51:59 +00:00
Close images swiping up or down

Hey @AmineL, I'm sorry as I've been pretty busy lately. If I'm not mistaken this is pretty much ready, I'll take a look in the next few days and send a PR.

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#103 2022-11-30 09:07:58 +00:00
Cookies login and logout.

Nice Missing api version 4.1.0 shouldn't be a problem since that was only present in nighly builds of Selfoss and I don't think we should provide support for all of those. In fact, we could just…

davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#53 2022-11-19 15:08:14 +00:00
Use POST /login to authenticate users

That is true, but is there another way to test if POST is supported? Maybe in Selfoss 2.17 you receive a particular reply which you could use to pinpoint the version as older than 2.18.

Otherwi…

davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#53 2022-11-18 20:07:28 +00:00
Use POST /login to authenticate users

You mean to say that it's impossible to determine wether the selfoss instance is running a version prior to 2.18? That could in fact be a problem. Is there any way to determine if someone is still…

davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#53 2022-11-18 09:24:50 +00:00
Use POST /login to authenticate users

Isn't POST/login supported in 2.18 as well?

davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#102 2022-11-16 08:18:23 +00:00
Replace the drawer.

Great idea! That filter looks really cool, the only problem I can see is that there will be two disappearing elements in the UI: the bottom bar and the top filter.

davidoskky deleted branch checkerboard from davidoskky/ReaderForSelfoss-multiplatform 2022-11-13 12:56:11 +00:00
davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#13 2022-11-13 12:54:11 +00:00
Close images swiping up or down

Oh, replying by email doesn't work. Yes, I can do it without library but without animation. It's probably much better than including that questionable library.