AmineB/ycombinator-keys
1
0
Fork 1
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

Rewrite #1

Open
brian6932 wants to merge 1 commits from brian6932/ycombinator-keys:rewrite into main
pull from: brian6932/ycombinator-keys:rewrite
merge into: AmineB:main
Conversation 0 Commits 1 Files Changed 4 +132 -73
brian6932 commented 2025-04-19 05:09:54 +00:00
First-time contributor
Copy Link
  • Added UserScripts capability.
  • Focused selectors to auto scroll on j & k.
  • Added a reply bind with r (will maybe try to implement an inline replier, but haven't tried it yet).
  • Switched to RES (Reddit Enhancement Suite) inspired binds, all link open binds now have a SHIFT layer to open in a new tab.
  • Removed re-queries as much as possible, feels a lot faster.
  • Now handles toggles collapsing threads, the same way as RES (ENTER toggles the state).
  • Now opens links similarly to RES (ENTER/SHIFT+ENTER/CTRL+ENTER). It's ever so slightly different, in the sense that opening a new tab uses CTRL, and a new window uses SHIFT, but that's just how the base browser click() method works, so not a big deal.
  • Migrated to Manifest v3.
  • Decreased the Web-Extension bundle size by removing unnecessary LICENSE and README.md files.
  • Removed deprecated usage of document.onkeypress.
  • I used the Web-Extension's code as a base, since the repo was a bit out of date.

On an unrelated note: It seems like the SSH cloning URI's down.

- Added UserScripts capability. - Focused selectors to auto scroll on <kbd>j</kbd> & <kbd>k</kbd>. - Added a reply bind with <kbd>r</kbd> (will maybe try to implement an inline replier, but haven't tried it yet). - Switched to RES (Reddit Enhancement Suite) inspired binds, all link `open` binds now have a <kbd>SHIFT</kbd> layer to open in a new tab. - Removed re-queries as much as possible, feels a lot faster. - Now handles toggles collapsing threads, the same way as RES (<kbd>ENTER</kbd> toggles the state). - Now opens links similarly to RES (<kbd>ENTER</kbd>/<kbd>SHIFT</kbd>+<kbd>ENTER</kbd>/<kbd>CTRL</kbd>+<kbd>ENTER</kbd>). It's ever so slightly different, in the sense that opening a new tab uses <kbd>CTRL</kbd>, and a new window uses <kbd>SHIFT</kbd>, but that's just how the base browser `click()` method works, so not a big deal. - Migrated to Manifest v3. - Decreased the Web-Extension bundle size by removing unnecessary `LICENSE` and `README.md` files. - Removed deprecated usage of `document.onkeypress`. - I used the Web-Extension's code as a base, since the repo was a bit out of date. ___ _On an unrelated note:_ It seems like the SSH cloning URI's down.
brian6932 added 1 commit 2025-04-19 05:09:54 +00:00
brian6932 force-pushed rewrite from 798cc18259 to 25fe0da7cb 2025-04-19 05:20:54 +00:00 Compare
brian6932 force-pushed rewrite from 25fe0da7cb to 125b0248de 2025-04-19 05:34:45 +00:00 Compare
brian6932 force-pushed rewrite from 125b0248de to 8aaa96a9ef 2025-04-19 05:44:50 +00:00 Compare
brian6932 force-pushed rewrite from 8aaa96a9ef to bff9258152 2025-04-19 05:59:42 +00:00 Compare
brian6932 force-pushed rewrite from bff9258152 to b8e6306c01 2025-04-19 06:15:03 +00:00 Compare
brian6932 force-pushed rewrite from b8e6306c01 to 8ec6a30a82 2025-04-19 16:45:32 +00:00 Compare
brian6932 force-pushed rewrite from 8ec6a30a82 to 996a38bacb 2025-04-19 16:53:14 +00:00 Compare
brian6932 force-pushed rewrite from 996a38bacb to 59a7af771c 2025-04-19 23:06:56 +00:00 Compare
brian6932 force-pushed rewrite from 59a7af771c to 7f3ee628a7 2025-04-20 04:57:58 +00:00 Compare
brian6932 force-pushed rewrite from 7f3ee628a7 to 98aee28da8 2025-04-20 08:23:56 +00:00 Compare
brian6932 force-pushed rewrite from 98aee28da8 to 2238f58178 2025-04-20 08:39:34 +00:00 Compare
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u rewrite:brian6932-rewrite
git checkout brian6932-rewrite
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
AmineB
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: AmineB/ycombinator-keys#1
No description provided.
Delete Branch "brian6932/ycombinator-keys:rewrite"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?