Amine Bouabdallaoui AmineB
0 Followers · 0 Following
Repositories
18
 Projects Packages Public Activity Starred Repositories
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#133 2023-02-07 20:55:00 +00:00
Use /sources/stats in the home

This should be an extension function fun SourceDetail.toSource(): Source

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#133 2023-02-07 19:57:29 +00:00
Use /sources/stats in the home

This does not make sens. If the error is null or blank, the error text should not be displayed.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#133 2023-02-07 19:54:59 +00:00
Use /sources/stats in the home

Why would the SourcesActivity use the "public" route, instead of the actual one ?

AmineB merged pull request Louvorg/ReaderForSelfoss-multiplatform#130 2023-01-29 12:55:29 +00:00
Improve right to left support
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2023-01-29 12:55:29 +00:00
ee064f3cb4 improvement: Improve right to left support (#130)
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#130 2023-01-28 19:25:57 +00:00
Improve right to left support

Why was this line removed ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#130 2023-01-28 19:25:47 +00:00
Improve right to left support

Why was this line removed ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#130 2023-01-28 19:21:39 +00:00
Improve right to left support

Why did you remove the scroll view ?

AmineB closed issue Louvorg/ReaderForSelfoss-multiplatform#106 2023-01-28 10:26:53 +00:00
Handle public selfoss instances
AmineB closed issue Louvorg/ReaderForSelfoss-multiplatform#127 2023-01-28 10:26:49 +00:00
Problems with disconnection
AmineB merged pull request Louvorg/ReaderForSelfoss-multiplatform#126 2023-01-28 10:25:37 +00:00
Handle public instances
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2023-01-28 10:25:33 +00:00
f28e702549 feat: Handle public instances (#126)
AmineB approved Louvorg/ReaderForSelfoss-multiplatform#126 2023-01-28 10:24:47 +00:00
Handle public instances
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2023-01-28 10:23:03 +00:00
fc31a4399c ci: Pull request should trigger ci.
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2023-01-28 10:20:28 +00:00
9b23053b66 fix: Complete the disconnection before redirecting to the login screen
AmineB merged pull request Louvorg/ReaderForSelfoss-multiplatform#129 2023-01-28 10:19:45 +00:00
Complete the disconnection before redirecting to the login screen
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2023-01-28 10:19:45 +00:00
b4e4aeb919 Merge pull request 'Complete the disconnection before redirecting to the login screen' (#129) from davidoskky/ReaderForSelfoss-multiplatform:disconnect into master
389a04d250 Complete the disconnection before redirecting to the login screen
Compare 2 commits »
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#126 2023-01-26 20:56:19 +00:00
Handle public instances

Can you please add this to a comment ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#126 2023-01-26 19:36:46 +00:00
Handle public instances

appSettingsService.updatePublicAccess(fetchedInformation.data.getApiConfiguration().isPublicModeEnabled()) isn't enough ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#126 2023-01-26 19:35:47 +00:00
Handle public instances

I didn't look into how public instances work, but this condition seems weird.