Amine Bouabdallaoui AmineB
0 Followers · 0 Following
Repositories
18
 Projects Packages Public Activity Starred Repositories
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2023-01-28 10:19:45 +00:00
b4e4aeb919 Merge pull request 'Complete the disconnection before redirecting to the login screen' (#129) from davidoskky/ReaderForSelfoss-multiplatform:disconnect into master
389a04d250 Complete the disconnection before redirecting to the login screen
Compare 2 commits »
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#126 2023-01-26 20:56:19 +00:00
Handle public instances

Can you please add this to a comment ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#126 2023-01-26 19:36:46 +00:00
Handle public instances

appSettingsService.updatePublicAccess(fetchedInformation.data.getApiConfiguration().isPublicModeEnabled()) isn't enough ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#126 2023-01-26 19:35:47 +00:00
Handle public instances

I didn't look into how public instances work, but this condition seems weird.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#126 2023-01-26 19:24:24 +00:00
Handle public instances

@Serializable

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#126 2023-01-26 19:21:41 +00:00
Handle public instances

Why was the buttons order changed ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#126 2023-01-26 19:15:18 +00:00
Handle public instances

and should be changed to &&.

AmineB merged pull request Louvorg/ReaderForSelfoss-multiplatform#122 2023-01-26 10:42:16 +00:00
Swipe down to close images
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2023-01-26 10:42:16 +00:00
2154ff3c33 Merge pull request 'feat: swipe down to close images' (#122) from davidoskky/ReaderForSelfoss-multiplatform:swipe_down into master
2245565f95 Remove unnecessary definition
014858f06b Remove unused import
3f1f86a78e Adjust the image closing animation
a549169a7c Add a dark hue to the underlying article when swiping to close images
Compare 11 commits »
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#122 2023-01-25 20:13:35 +00:00
Swipe down to close images

I meant the empty onclick listener

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#122 2023-01-25 19:41:27 +00:00
Swipe down to close images

I'll merge as soon as everything is ok

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#122 2023-01-25 19:40:13 +00:00
Swipe down to close images

Is this needed ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#122 2023-01-25 19:40:10 +00:00
Swipe down to close images

Is this needed ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#122 2023-01-25 19:35:53 +00:00
Swipe down to close images

This may be removed.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#122 2023-01-25 19:33:27 +00:00
Swipe down to close images

Just tested it, it works pretty good.

I'll review the code, now, and merge as soon as everything is closed.

AmineB opened issue Louvorg/ReaderForSelfoss-multiplatform#125 2023-01-23 21:44:21 +00:00
Notification runtime permission
AmineB deleted branch scroll-tag-filters from Louvorg/ReaderForSelfoss-multiplatform 2023-01-23 21:42:50 +00:00
AmineB closed issue Louvorg/ReaderForSelfoss-multiplatform#123 2023-01-23 21:42:44 +00:00
The filter menu cannot scroll
AmineB merged pull request Louvorg/ReaderForSelfoss-multiplatform#124 2023-01-23 21:42:44 +00:00
scroll-tag-filters
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2023-01-23 21:42:44 +00:00
ab0678d61e Merge pull request 'scroll-tag-filters' (#124) from scroll-tag-filters into master
a1b7d22d26 fix: added POST_NOTIFICATIONS to fix notifications issues.
29eae4b1f6 fix: scrollable filter sheet.
f5bbc63481 enhancement: Ellipsize chips text.
Compare 4 commits »