Amine Bouabdallaoui AmineB
0 Followers · 0 Following
Repositories
18
 Projects Packages Public Activity Starred Repositories
AmineB closed issue Louvorg/ReaderForSelfoss-multiplatform#31 2022-08-19 20:21:25 +00:00
Mercury API not up ?
AmineB commented on issue Louvorg/ReaderForSelfoss-multiplatform#31 2022-08-19 20:21:22 +00:00
Mercury API not up ?

Closed with 994e63163611c55cc04cbf7455b91209c7190ec3

AmineB pushed to chore/sonarqube-fixes at Louvorg/ReaderForSelfoss-multiplatform 2022-08-19 20:20:50 +00:00
994e631636 Fixed mercury issues.
AmineB pushed to chore/sonarqube-fixes at Louvorg/ReaderForSelfoss-multiplatform 2022-08-19 20:20:33 +00:00
2fce42dbef Push everywhere ?
79206f103a Added build cache.
1392e2a571 Merge pull request 'Fixing some sonarqube issues.' (#30) from chore/sonarqube-fixes into master
Compare 3 commits »
AmineB pushed to main at Louvorg/liste-de-courses-www 2022-08-19 19:26:07 +00:00
25e435b2ee Fixing displaying issue.
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-18 19:59:14 +00:00
network

This shouldn't be only on the home activity.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-18 19:59:14 +00:00
network

repository.offlineOverride should only refreshed on app reload or swipe to refresh.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-18 19:59:14 +00:00
network

There should be a message emited on network available too.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-18 19:59:14 +00:00
network

This should be reverted to the old network status check, because the network availability watcher should be stopped when the app is in the background.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-18 19:59:14 +00:00
network

This should only be done if the network is available as it was before.

AmineB suggested changes for Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-18 19:59:14 +00:00
network
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-18 17:06:18 +00:00
network

That´s why, in the background service, I asked to keep the network check as it was.

The background service should check, when executed, the network status.

Having things like so, let you…

AmineB opened issue Louvorg/ReaderForSelfoss-multiplatform#31 2022-08-17 21:25:06 +00:00
Mercury API not up ?
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-17 21:24:34 +00:00
network

This is mercury. It parses the page and fetch it´s content.

I'll look into why it does not work.

AmineB pushed to chore/sonarqube-fixes at Louvorg/ReaderForSelfoss-multiplatform 2022-08-17 20:53:10 +00:00
b33e811066 Push everywhere ?
AmineB pushed to chore/sonarqube-fixes at Louvorg/ReaderForSelfoss-multiplatform 2022-08-17 20:27:58 +00:00
e39bc896d2 Added build cache.
AmineB merged pull request Louvorg/ReaderForSelfoss-multiplatform#30 2022-08-17 19:10:48 +00:00
Fixing some sonarqube issues.
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-08-17 19:10:48 +00:00
1392e2a571 Merge pull request 'Fixing some sonarqube issues.' (#30) from chore/sonarqube-fixes into master
e9cb3d2f37 Fixing some sonarqube issues.
Compare 2 commits »
AmineB created pull request Louvorg/ReaderForSelfoss-multiplatform#30 2022-08-17 19:10:36 +00:00
Fixing some sonarqube issues.
AmineB created branch chore/sonarqube-fixes in Louvorg/ReaderForSelfoss-multiplatform 2022-08-17 19:01:00 +00:00