Amine Bouabdallaoui AmineB
0 Followers · 0 Following
Repositories
18
 Projects Packages Public Activity Starred Repositories
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-26 21:41:26 +00:00
WIP: HomeActivity cleanup

@davidoskky I did a big cleaning as tou can see in #45, but I still need to #44.

AmineB closed issue Louvorg/ReaderForSelfoss-multiplatform#43 2022-08-26 21:40:20 +00:00
Clean self signed certificates
AmineB closed issue Louvorg/ReaderForSelfoss-multiplatform#37 2022-08-26 21:40:17 +00:00
Clean http login code.
AmineB closed issue Louvorg/ReaderForSelfoss-multiplatform#19 2022-08-26 21:40:13 +00:00
Timeout handling
8b2be5c55c Refreshing settings.
e6afb4702d Cleaning code.
8cf462a755 Fixing api version issue on login.
17293e5574 Removing self signed certificate (Closes #43) and removing http login (Closes #37)
a99286a9b7 Really big settings cleaning.
Compare 8 commits »
AmineB created pull request Louvorg/ReaderForSelfoss-multiplatform#45 2022-08-26 21:29:46 +00:00
feature/api_timeout_and_settings_cleaning
AmineB opened issue Louvorg/ReaderForSelfoss-multiplatform#44 2022-08-26 21:27:31 +00:00
Clean drawer handling
f1f40ae2e0 Refreshing settings.
ab59f323c7 Cleaning code.
08b7fe06fa Fixing api version issue on login.
Compare 2 commits »
6e0cb6705d Removing self signed certificate (Closes #43) and removing http login (Closes #37)
ce20f6a99f Really big settings cleaning.
Compare 2 commits »
AmineB opened issue Louvorg/ReaderForSelfoss-multiplatform#43 2022-08-26 20:25:13 +00:00
Clean self signed certificates
AmineB opened issue Louvorg/ReaderForSelfoss-multiplatform#42 2022-08-26 20:23:58 +00:00
Add self signed certificats back
AmineB opened issue Louvorg/ReaderForSelfoss-multiplatform#41 2022-08-26 11:43:10 +00:00
Better handling of reloading content when inside the app
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-26 11:40:13 +00:00
WIP: HomeActivity cleanup

Ok, great ! I'll let you know when I finish my refactoring.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-26 07:42:34 +00:00
WIP: HomeActivity cleanup

That makes sens, but I still thinks the app needs to refresh onReload.

We could try to find a way to differenciate between "going back from another activity of the app" and "relaunching the…

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 18:43:11 +00:00
WIP: HomeActivity cleanup

Every time I go back to the articles list the fetching starts, which is annoying because of the loading spinner appearing at the top each time.

Why don't you swipe between the articles ? …

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 18:21:40 +00:00
WIP: HomeActivity cleanup

When init is run the connectivity check always fails.

So this is a bug that should be fixed instead of having this workaround.

This allows retrieving the badges every time connectivity…

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 18:18:22 +00:00
WIP: HomeActivity cleanup

updateRemote doesn't necessarily have to be there, I have done it because I think it makes it easier to read through the activity code.

I find it more difficult to read. Moving some code…

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 16:30:17 +00:00
WIP: HomeActivity cleanup

it can be used to prevent making an api call every time you close an article and come back to the article list

this is intended to fetch the new articles as soon as possible.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 12:07:31 +00:00
WIP: HomeActivity cleanup

Why were these moved here ?