feature/api_timeout_and_settings_cleaning #45

Merged
AmineB merged 8 commits from feature/api_timeout_and_settings_cleaning into master 2022-08-27 12:20:55 +00:00
Owner

Closes #43 #37 #19

Closes #43 #37 #19
AmineB added 2 commits 2022-08-26 21:29:46 +00:00
AmineB force-pushed feature/api_timeout_and_settings_cleaning from f1f40ae2e0 to 8b2be5c55c 2022-08-26 21:39:37 +00:00 Compare
davidoskky reviewed 2022-08-27 09:35:31 +00:00
@ -9,2 +10,3 @@
actual class DateUtils actual constructor(private val apiMajorVersion: Int) {
actual class DateUtils actual constructor(appSettingsService: AppSettingsService) {
val ads: AppSettingsService = appSettingsService // TODO: why is this needed now ?
Contributor

I think you have to declare it's a val in the class constructor in order to make it a class variable and use it within functions.

I think you have to declare it's a val in the class constructor in order to make it a class variable and use it within functions.
Author
Owner

I couldn't. I had to do as mentionned here to "fix" this.

I couldn't. I had to do as mentionned [here](https://stackoverflow.com/a/65249085) to "fix" this.
davidoskky reviewed 2022-08-27 09:48:07 +00:00
@ -0,0 +69,4 @@
fun getUserName(): String {
if (_userName.isEmpty()) {
refrershUsername()
Contributor

This has a typo

This has a typo
Author
Owner

Good catch

Good catch
AmineB added 2 commits 2022-08-27 11:06:22 +00:00
Fixing a todo.
Some checks reported errors
continuous-integration/drone/push Build was killed
continuous-integration/drone/pr Build is passing
109050d0cf
AmineB merged commit 0278540fb2 into master 2022-08-27 12:20:55 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#45
No description provided.