Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 7 Pull Requests 2 Actions Releases 84 Wiki Activity

feature/api_timeout_and_settings_cleaning #45

Merged
AmineB merged 8 commits from feature/api_timeout_and_settings_cleaning into master 2022-08-27 12:20:55 +00:00
Conversation 2 Commits 8 Files Changed 59 +671 -1547
AmineB commented 2022-08-26 21:29:46 +00:00
Owner
Copy Link

Closes #43 #37 #19

Closes #43 #37 #19
AmineB added 2 commits 2022-08-26 21:29:46 +00:00
Really big settings cleaning. ce20f6a99f
Removing self signed certificate (Closes #43) and removing http login (Closes #37)
Some checks are pending
continuous-integration/drone/push Build is running
Details
6e0cb6705d
AmineB force-pushed feature/api_timeout_and_settings_cleaning from f1f40ae2e0 to 8b2be5c55c 2022-08-26 21:39:37 +00:00 Compare
davidoskky reviewed 2022-08-27 09:35:31 +00:00
shared/src/androidMain/kotlin/bou/amine/apps/readerforselfossv2/utils/DateUtils.kt Outdated
@@ -9,2 +10,3 @@
actual class DateUtils actual constructor(private val apiMajorVersion: Int) {
actual class DateUtils actual constructor(appSettingsService: AppSettingsService) {
val ads: AppSettingsService = appSettingsService // TODO: why is this needed now ?
davidoskky commented 2022-08-27 09:35:31 +00:00
Contributor
Copy Link

I think you have to declare it's a val in the class constructor in order to make it a class variable and use it within functions.

I think you have to declare it's a val in the class constructor in order to make it a class variable and use it within functions.
AmineB commented 2022-08-27 11:06:53 +00:00
Author
Owner
Copy Link

I couldn't. I had to do as mentionned here to "fix" this.

I couldn't. I had to do as mentionned [here](https://stackoverflow.com/a/65249085) to "fix" this.
davidoskky reviewed 2022-08-27 09:48:07 +00:00
shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/service/AppSettingsService.kt Outdated
@@ -0,0 +69,4 @@
fun getUserName(): String {
if (_userName.isEmpty()) {
refrershUsername()
davidoskky commented 2022-08-27 09:48:07 +00:00
Contributor
Copy Link

This has a typo

This has a typo
AmineB commented 2022-08-27 11:00:31 +00:00
Author
Owner
Copy Link

Good catch

Good catch
AmineB added 2 commits 2022-08-27 11:06:22 +00:00
Typo fix. 0392e1b406
Fixing a todo.
Some checks failed
continuous-integration/drone/push Build was killed
Details
continuous-integration/drone/pr Build is passing
Details
109050d0cf
AmineB merged commit 0278540fb2 into master 2022-08-27 12:20:55 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
davidoskky
Labels
Clear labels
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
AmineB
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#45
Delete Branch "feature/api_timeout_and_settings_cleaning"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?