Amine Bouabdallaoui

AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform

2023-09-17 18:28:49 +00:00

c458871569 feat: Self signed ssl support.

056825aa0c Revert xmlns changes

16b19fc5ce Revert version upgrades

4ad4a23ed8 Revert to private functions

d8c215eacc Reintroduce removed parameter

Compare 13 commits »

AmineB merged pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-17 18:28:48 +00:00

Tentative self signed ssl support

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-16 18:48:32 +00:00

Tentative self signed ssl support

Yes please

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#149

2023-09-12 19:12:27 +00:00

gradle_upgrade

Please remove everything not related to upgrading dependencies.

AmineB suggested changes for Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-12 19:08:40 +00:00

Tentative self signed ssl support

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-12 19:08:40 +00:00

Tentative self signed ssl support

Please revert this

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-12 19:08:40 +00:00

Tentative self signed ssl support

Please revert this.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-11 18:50:16 +00:00

Tentative self signed ssl support

These two should be reverted to private.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-11 18:48:36 +00:00

Tentative self signed ssl support

Why was this removed ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-11 18:46:52 +00:00

Tentative self signed ssl support

There are still version changes. Can you please revert them ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-07 19:32:28 +00:00

Tentative self signed ssl support

Why was gradle and all the dependencies updated in this PR ?

Updating gradle forces to use java 17, so I'm unable to test this.

Can you revert all the version updates ? They should be done…

AmineB suggested changes for Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-07 19:03:32 +00:00

Tentative self signed ssl support

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-07 19:03:32 +00:00

Tentative self signed ssl support

No idea why I added this file. Can you please delete it ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-07 19:03:32 +00:00

Tentative self signed ssl support

Please revert this change.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-07 19:03:32 +00:00

Tentative self signed ssl support

<string name="disable_ssl">Disable SSL</string> => <string name="use_self_signed_cert">Use a self signed certificate</string> in all the files.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-07 19:03:32 +00:00

Tentative self signed ssl support

@string/disable_ssl should be named @string/use_self_signed_cert

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-07 19:03:32 +00:00

Tentative self signed ssl support

repository.updateApiInformation() is called in goToMain which is called at line 152. This should not be needed.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-07 19:03:32 +00:00

Tentative self signed ssl support

Why is this needed ? Can't it be replaced by this ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-09-07 13:37:01 +00:00

Tentative self signed ssl support

@davidoskky I restarted the build, it's now working.

I'll re review it pretty soon

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141

2023-08-21 18:48:50 +00:00

Tentative self signed ssl support

The CI build was already failing before. Your changes were not the cause of this.