Amine Bouabdallaoui AmineB
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141 2023-08-11 19:14:23 +00:00
Tentative self signed ssl support

Yes, please.

AmineB closed pull request Louvorg/ReaderForSelfoss-multiplatform#145 2023-07-15 18:40:47 +00:00
Delete unused preference setting
AmineB suggested changes for Louvorg/ReaderForSelfoss-multiplatform#141 2023-07-15 18:39:23 +00:00
Tentative self signed ssl support

These change break ios client handling. Please keep in mind to not break ios handling with the changed you make.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141 2023-07-15 18:38:34 +00:00
Tentative self signed ssl support

Why use the forEachIndexed, but don't use the index ? (same for the one just after)

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141 2023-07-15 18:38:34 +00:00
Tentative self signed ssl support

Is the java version upgrade necessary for something ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141 2023-07-15 18:38:34 +00:00
Tentative self signed ssl support

From this point on, everything should work the same for ios. Is there a way to handle this better ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141 2023-07-15 18:38:34 +00:00
Tentative self signed ssl support

Translations should be done on the translation tool. This will be overwritten when merged.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141 2023-07-15 18:38:34 +00:00
Tentative self signed ssl support

Please add back all the deleted xmlns:tools="http://schemas.android.com/tools".

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141 2023-07-15 18:38:34 +00:00
Tentative self signed ssl support

disableSSL should be disable_ssl

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#145 2023-07-15 18:24:10 +00:00
Delete unused preference setting

There is 22 uses of isUpdateSourcesEnabled in the code. It is still used.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141 2023-07-14 18:18:16 +00:00
Tentative self signed ssl support

I relaunched the build on the CI and the error is still here.

You can see that here

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#141 2023-07-13 14:58:39 +00:00
Tentative self signed ssl support

@davidoskky there is a build issue. Could you check this, please ?

> Task :androidApp:minifyGithubConfigReleaseWithR8
ERROR: Missing classes detected while running R8. Please add the…
AmineB closed issue Louvorg/ReaderForSelfoss-multiplatform#144 2023-06-30 19:15:04 +00:00
Confirmation for 'Discinnect'.
AmineB commented on issue Louvorg/ReaderForSelfoss-multiplatform#144 2023-06-30 19:14:59 +00:00
Confirmation for 'Discinnect'.

@mdione It's done.

You can wait for the fdroid update (that could be long) or download the last release from [here](https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/releases

AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2023-06-30 18:37:49 +00:00
ad72cb6f56 feat: Added confirmation dialog for disconnect item menu.
AmineB commented on issue Louvorg/ReaderForSelfoss-multiplatform#144 2023-06-30 18:22:26 +00:00
Confirmation for 'Discinnect'.

Hi,

Thanks for the feature request.

I'll add this today.

AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2023-06-13 18:52:45 +00:00
50d0b44315 i18n: Translation update.
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2023-06-13 18:52:40 +00:00
21b08ed384 i18n: Translation update.
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2023-06-12 18:50:33 +00:00
993c4d2ee9 i18n: Translation update.
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2023-06-12 18:37:22 +00:00
5a4b2ae39a i18n: Translation update.