Amine Bouabdallaoui AmineB
0 Followers · 0 Following
Repositories
18
 Projects Packages Public Activity Starred Repositories
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 12:07:30 +00:00
WIP: HomeActivity cleanup

Why did you remove this ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 12:07:30 +00:00
WIP: HomeActivity cleanup

I already started refactoring this, so I'll handle this.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 12:07:30 +00:00
WIP: HomeActivity cleanup

resetDBSourcesWithData should only be done if network the api call was done, and if update_sources setting is set to false.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 12:07:30 +00:00
WIP: HomeActivity cleanup

resetDBTagsWithData should only be done if network the api call was done, and if update_sources setting is set to false.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 12:07:30 +00:00
WIP: HomeActivity cleanup

updateApiVersion() and reloadBadges() both check the network availability. This change isn't needed.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 12:05:38 +00:00
WIP: HomeActivity cleanup

I already started refactoring this, so I'll handle this.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 11:42:36 +00:00
WIP: HomeActivity cleanup

Thanks !

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#40 2022-08-25 11:04:16 +00:00
WIP: HomeActivity cleanup

I'm already doing a lot of cleaning in here https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/src/branch/feature/api_timeout_and_settings_cleaning

Maybe wait to continue on…

AmineB closed issue Louvorg/ReaderForSelfoss-multiplatform#38 2022-08-25 02:26:14 +00:00
Api version fetching
AmineB merged pull request Louvorg/ReaderForSelfoss-multiplatform#39 2022-08-25 02:25:28 +00:00
Fetch api version on login
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-08-25 02:25:28 +00:00
fbcb428e96 Merge pull request 'Fetch api version on login' (#39) from davidoskky/ReaderForSelfoss-multiplatform:loginApi into master
e281751bb0 Fetch api version on login
Compare 2 commits »
51e9c62393 WIP: Big settings cleaning.
AmineB opened issue Louvorg/ReaderForSelfoss-multiplatform#37 2022-08-24 19:34:06 +00:00
Clean http login code.
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-08-24 12:41:59 +00:00
0eed9a8d07 Translations.
AmineB merged pull request Louvorg/ReaderForSelfoss-multiplatform#35 2022-08-24 12:37:38 +00:00
chore/sonarqube-fixes
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-08-24 12:37:38 +00:00
9603860bae Merge pull request 'chore/sonarqube-fixes' (#35) from chore/sonarqube-fixes into master
75b566a38d Some cleaning to handle actions on connection restore.
fb572dbb27 Closes #36
34028949d7 More code cleaning.
44a0469b17 Fixes #25;
Compare 9 commits »
AmineB closed issue Louvorg/ReaderForSelfoss-multiplatform#36 2022-08-24 11:58:57 +00:00
Handle offline actions in the repository
AmineB commented on issue Louvorg/ReaderForSelfoss-multiplatform#36 2022-08-24 11:58:54 +00:00
Handle offline actions in the repository

Done and done !

AmineB pushed to chore/sonarqube-fixes at Louvorg/ReaderForSelfoss-multiplatform 2022-08-24 11:58:27 +00:00
75b566a38d Some cleaning to handle actions on connection restore.