- France
- https://amine-bouabdallaoui.fr
- Joined on
2022-07-18
The else block would have the BD fetching that'll assign the DB items to fetchedItems.
I think that this should be the only place where the connectivity check should stay like this.
Same here.
Same here. We are fetching data from an api, and we there is no need to do try anything if there is no network available.
It's weird to have this here. offlineOverride shouldn't be overridden from inside the repository.
isConnectionAvailable.value && !offlineOverride should be refactored inside a method named isNetworkAvailable()
This should be moved after the else block
This should be moved after the else block
This should be removed.
This should be done when the app is sent to the background or closed.
@davidoskky can you please rebase your branch ? I just merged the last changed that I wanted on yesterday's PR.
The error message should be displayed when the network status change, not after every api call.
This block should be after the else, since the db will work as a fallback and we'll get the items from there.
This should be a todo