fix: Basic auth and password can have non whitspace characters. Fixes 142.

CHANGELOG.md

@@ -1,3 +1,17 @@
+**v124020451**
+
+- fix: Fixed handling of position in card adapter.
+- Changelog for v124010301 [CI SKIP]
+
+--------------------------------------------------------------------
+
+**v124010301**
+
+- fix: This may fix the oom errors.
+- Changelog for v124010191 [CI SKIP]
+
+--------------------------------------------------------------------
+
 **v124010191**
 
 - fix: moving listeners.

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemCardAdapter.kt

@@ -94,10 +94,10 @@ class ItemCardAdapter(
         position: Int,
     ) {
         with(holder) {
-            val itm = items[position]
+            val itm = items[holder.bindingAdapterPosition]
 
-            handleClickListeners(position)
-            handleLinkOpening(position)
+            handleClickListeners(holder.bindingAdapterPosition)
+            handleLinkOpening(holder.bindingAdapterPosition)
 
             binding.favButton.isSelected = itm.starred
             if (appSettingsService.getPublicAccess()) {

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemListAdapter.kt

@@ -45,13 +45,13 @@ class ItemListAdapter(
         position: Int,
     ) {
         with(holder) {
-            val itm = items[position]
+            val itm = items[holder.bindingAdapterPosition]
 
             binding.root.setOnClickListener {
                 repository.setReaderItems(items)
                 c.openItemUrl(
-                    bindingAdapterPosition,
-                    items[bindingAdapterPosition].getLinkDecoded(),
+                    holder.bindingAdapterPosition,
+                    items[holder.bindingAdapterPosition].getLinkDecoded(),
                     appSettingsService.isArticleViewerEnabled(),
                     app,
                 )

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemsAdapter.kt

@@ -89,6 +89,7 @@ abstract class ItemsAdapter<VH : RecyclerView.ViewHolder?> : RecyclerView.Adapte
         if (repository.displayedItems == ItemType.UNREAD) {
             items.remove(item)
             notifyItemRemoved(position)
+            notifyItemRangeChanged(position, itemCount)
             updateItems(items)
         } else {
             notifyItemChanged(position)

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/service/AppSettingsService.kt

@@ -441,7 +441,7 @@ class AppSettingsService(acraSenderServiceProcess: Boolean = false) {
         login: String,
         password: String,
     ) {
-        val regex = """\/\/(\D+):(\D+)@""".toRegex()
+        val regex = """\/\/(\S+):(\S+)@""".toRegex()
         val matchResult = regex.find(url)
         if (matchResult != null) {
             val (basicLogin, basicPassword) = matchResult.destructured