chore: code style fixes for ktlint

chore: more debug to fix a context issue.
2025-01-11 15:23:02 +01:00 · 2025-01-11 12:52:55 +01:00
47 changed files with 236 additions and 1140 deletions
--- a/.gitea/workflows/on_pr.yml
+++ b/.gitea/workflows/on_pr.yml
@@ -16,13 +16,13 @@ jobs:
          java-version: '17'
          cache: gradle
      - name: Install klint
-        run: curl -sSLO https://github.com/pinterest/ktlint/releases/download/1.5.0/ktlint && chmod a+x ktlint && mv ktlint /usr/local/bin/
+        run: curl -sSLO https://github.com/pinterest/ktlint/releases/download/1.0.0/ktlint && chmod a+x ktlint && mv ktlint /usr/local/bin/
      - name: Install detekt
-        run: curl -sSLO https://github.com/detekt/detekt/releases/download/v1.23.7/detekt-cli-1.23.7.zip && unzip detekt-cli-1.23.7.zip
+        run: curl -sSLO https://github.com/detekt/detekt/releases/download/v1.23.1/detekt-cli-1.23.1.zip && unzip detekt-cli-1.23.1.zip
      - name: Linting...
        run: ktlint 'shared/**/*.kt' 'androidApp/**/*.kt' '!shared/build'
      - name: Detecting...
-        run: ./detekt-cli-1.23.7/bin/detekt-cli -c detekt.yml --excludes '**/shared/build/**/*.kt'
+        run: ./detekt-cli-1.23.1/bin/detekt-cli --all-rules --excludes '**/shared/build/**/*.kt' || true
  build:
    needs: Lint
    uses: ./.gitea/workflows/common_build.yml
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,10 +1,3 @@
-**v125010111
-
- Debug trying to fix context issues. (#174)
- Changelog for v125010031
-
--------------------------------------------------------------------
-
 **v125010031

 - Merge pull request 'Bump dependencies' (#173) from upgarde into master
--- a/androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/Helpers.kt
+++ b/androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/Helpers.kt
@@ -30,16 +30,21 @@ fun withError(
 ): TypeSafeMatcher<View?> {
    return object : TypeSafeMatcher<View?>() {
        override fun matchesSafely(view: View?): Boolean {
-            if (view != null && (view !is EditText || view.error == null)) {
+            if (view == null) {
+                return false
+            }
+            val context = view.context
+            if (view !is EditText) {
+                return false
+            }
+            if (view.error == null) {
                return false
            }
-            val context = view!!.context

-            return (view as EditText).error.toString() == context.getString(id)
+            return view.error.toString() == context.getString(id)
        }

        override fun describeTo(description: Description?) {
-            // Nothing
        }
    }
 }
@@ -53,7 +58,6 @@ fun withDrawable(
        description.appendText("ImageView with drawable same as drawable with id $id")
    }

-    @Suppress("detekt:SwallowedException")
    override fun matchesSafely(view: View): Boolean {
        val context = view.context
        val expectedBitmap = context.getDrawable(id)!!.toBitmap()
--- a/androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/LoginActivityTest.kt
+++ b/androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/LoginActivityTest.kt
@@ -1,5 +1,6 @@
 package bou.amine.apps.readerforselfossv2.android

+import android.app.Activity
 import androidx.test.espresso.Espresso.onView
 import androidx.test.espresso.IdlingRegistry
 import androidx.test.espresso.action.ViewActions.click
@@ -25,6 +26,14 @@ class LoginActivityTest {
    @get:Rule
    val activityRule = ActivityScenarioRule(LoginActivity::class.java)

+    private fun getActivity(): Activity? {
+        var activity: Activity? = null
+        activityRule.scenario.onActivity {
+            activity = it
+        }
+        return activity
+    }
+
    @Before
    fun registerIdlingResource() {
        IdlingRegistry
--- a/androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/SettingsActivityGeneralTest.kt
+++ b/androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/SettingsActivityGeneralTest.kt
@@ -42,7 +42,6 @@ class SettingsActivityGeneralTest {
        onView(withText(R.string.pref_header_general)).perform(click())
    }

-    @Suppress("detekt:LongMethod")
    @Test
    fun testGeneral() {
        onView(withText(R.string.pref_api_items_number_title)).check(matches(isDisplayed()))
@@ -119,7 +118,6 @@ class SettingsActivityGeneralTest {
        )
    }

-    @Suppress("detekt:ForbiddenComment")
    @Test
    fun testGeneralActionsNumberItems() {
        onView(withText(R.string.pref_api_items_number_title)).perform(click())
--- a/androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/SettingsActivityOfflineTest.kt
+++ b/androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/SettingsActivityOfflineTest.kt
@@ -42,7 +42,6 @@ class SettingsActivityOfflineTest {
        onView(withText(R.string.pref_header_offline)).perform(click())
    }

-    @Suppress("detekt:LongMethod")
    @Test
    fun testOffline() {
        onView(withSettingsCheckboxWidget(R.string.pref_switch_periodic_refresh)).check(
@@ -108,7 +107,6 @@ class SettingsActivityOfflineTest {
        )
    }

-    @Suppress("detekt:LongMethod")
    @Test
    fun testOfflineActions() {
        onView(withText(R.string.pref_switch_items_caching_off)).check(matches(isDisplayed()))
--- a/androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/SourcesActivityTest.kt
+++ b/androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/SourcesActivityTest.kt
@@ -45,7 +45,6 @@ class SourcesActivityTest {
        )
    }

-    @Suppress("detekt:SwallowedException")
    @Test
    fun addSourceCheckContent() {
        testAddSourceWithUrl("https://news.google.com/rss?hl=en-US&gl=US&ceid=US:en", sourceName)
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/HomeActivity.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/HomeActivity.kt
@@ -49,8 +49,6 @@ import org.kodein.di.instance
 import java.security.MessageDigest
 import java.util.concurrent.TimeUnit

-private const val MIN_WIDTH_CARD_DP = 300
-
 class HomeActivity :
    AppCompatActivity(),
    SearchView.OnQueryTextListener,
@@ -202,7 +200,6 @@ class HomeActivity :
        }
    }

-    @Suppress("detekt:LongMethod")
    private fun handleBottomBar() {
        tabNewBadge =
            TextBadgeItem()
@@ -285,7 +282,7 @@ class HomeActivity :

        handleBottomBarActions()

-        handleGdprDialog(appSettingsService.settings.getBoolean("GDPR_shown", false))
+        handleGDPRDialog(appSettingsService.settings.getBoolean("GDPR_shown", false))

        handleRecurringTask()
        CountingIdlingResourceSingleton.increment()
@@ -297,10 +294,10 @@ class HomeActivity :
        getElementsAccordingToTab()
    }

-    private fun handleGdprDialog(gdprShown: Boolean) {
+    private fun handleGDPRDialog(GDPRShown: Boolean) {
        val messageDigest: MessageDigest = MessageDigest.getInstance("SHA-256")
        messageDigest.update(appSettingsService.getBaseUrl().toByteArray())
-        if (!gdprShown) {
+        if (!GDPRShown) {
            val alertDialog = AlertDialog.Builder(this).create()
            alertDialog.setTitle(getString(R.string.gdpr_dialog_title))
            alertDialog.setMessage(getString(R.string.gdpr_dialog_message))
@@ -317,44 +314,50 @@ class HomeActivity :

    private fun reloadLayoutManager() {
        val currentManager = binding.recyclerView.layoutManager
+        val layoutManager: RecyclerView.LayoutManager

-        fun gridLayoutManager() {
-            val layoutManager =
-                GridLayoutManager(
-                    this,
-                    calculateNoOfColumns(),
-                )
-            binding.recyclerView.layoutManager = layoutManager
-        }
-
-        fun staggererdGridLayoutManager() {
-            var layoutManager =
-                StaggeredGridLayoutManager(
-                    calculateNoOfColumns(),
-                    StaggeredGridLayoutManager.VERTICAL,
-                )
-            layoutManager.gapStrategy =
-                StaggeredGridLayoutManager.GAP_HANDLING_MOVE_ITEMS_BETWEEN_SPANS
-            binding.recyclerView.layoutManager = layoutManager
-        }
-
+        // This will only update the layout manager if settings changed
        when (currentManager) {
            is StaggeredGridLayoutManager ->
                if (!appSettingsService.isCardViewEnabled()) {
-                    gridLayoutManager()
+                    layoutManager =
+                        GridLayoutManager(
+                            this,
+                            calculateNoOfColumns(),
+                        )
+                    binding.recyclerView.layoutManager = layoutManager
                }

            is GridLayoutManager ->
                if (appSettingsService.isCardViewEnabled()) {
-                    staggererdGridLayoutManager()
+                    layoutManager =
+                        StaggeredGridLayoutManager(
+                            calculateNoOfColumns(),
+                            StaggeredGridLayoutManager.VERTICAL,
+                        )
+                    layoutManager.gapStrategy =
+                        StaggeredGridLayoutManager.GAP_HANDLING_MOVE_ITEMS_BETWEEN_SPANS
+                    binding.recyclerView.layoutManager = layoutManager
                }

            else ->
                if (currentManager == null) {
                    if (!appSettingsService.isCardViewEnabled()) {
-                        gridLayoutManager()
+                        layoutManager =
+                            GridLayoutManager(
+                                this,
+                                calculateNoOfColumns(),
+                            )
+                        binding.recyclerView.layoutManager = layoutManager
                    } else {
-                        staggererdGridLayoutManager()
+                        layoutManager =
+                            StaggeredGridLayoutManager(
+                                calculateNoOfColumns(),
+                                StaggeredGridLayoutManager.VERTICAL,
+                            )
+                        layoutManager.gapStrategy =
+                            StaggeredGridLayoutManager.GAP_HANDLING_MOVE_ITEMS_BETWEEN_SPANS
+                        binding.recyclerView.layoutManager = layoutManager
                    }
                }
        }
@@ -479,8 +482,8 @@ class HomeActivity :
    }

    private fun handleListResult(appendResults: Boolean = false) {
-        val oldManager = binding.recyclerView.layoutManager
        if (appendResults) {
+            val oldManager = binding.recyclerView.layoutManager
            firstVisible =
                when (oldManager) {
                    is StaggeredGridLayoutManager ->
@@ -493,13 +496,7 @@ class HomeActivity :
                }
        }

-        @Suppress("detekt:ComplexCondition")
-        if (recyclerAdapter == null ||
-            (
-                (recyclerAdapter is ItemListAdapter && appSettingsService.isCardViewEnabled()) ||
-                    (recyclerAdapter is ItemCardAdapter && !appSettingsService.isCardViewEnabled())
-            )
-        ) {
+        if (recyclerAdapter == null) {
            if (appSettingsService.isCardViewEnabled()) {
                recyclerAdapter =
                    ItemCardAdapter(
@@ -546,7 +543,7 @@ class HomeActivity :
    private fun calculateNoOfColumns(): Int {
        val displayMetrics = resources.displayMetrics
        val dpWidth = displayMetrics.widthPixels / displayMetrics.density
-        return (dpWidth / MIN_WIDTH_CARD_DP).toInt()
+        return (dpWidth / 300).toInt()
    }

    override fun onQueryTextChange(p0: String?): Boolean {
@@ -595,7 +592,6 @@ class HomeActivity :
            .show()
    }

-    @Suppress("detekt:ReturnCount", "detekt:LongMethod")
    override fun onOptionsItemSelected(item: MenuItem): Boolean {
        when (item.itemId) {
            R.id.issue_tracker -> {
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/LoginActivity.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/LoginActivity.kt
@@ -30,8 +30,6 @@ import org.kodein.di.DIAware
 import org.kodein.di.android.closestDI
 import org.kodein.di.instance

-private const val MAX_INVALID_LOGIN_BEFORE_ALERT_DISPLAYED = 3
-
 class LoginActivity :
    AppCompatActivity(),
    DIAware {
@@ -219,7 +217,7 @@ class LoginActivity :
            cancel = true
            binding.urlView.error = getString(R.string.login_url_problem)
            inValidCount++
-            if (inValidCount == MAX_INVALID_LOGIN_BEFORE_ALERT_DISPLAYED) {
+            if (inValidCount == 3) {
                val alertDialog = AlertDialog.Builder(this).create()
                alertDialog.setTitle(getString(R.string.warning_wrong_url))
                alertDialog.setMessage(getString(R.string.text_wrong_url))
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/MyApp.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/MyApp.kt
@@ -62,7 +62,6 @@ class MyApp :
    private val connectivityStatus: ConnectivityStatus by instance()
    private val driverFactory: DriverFactory by instance()

-    @Suppress("detekt:ForbiddenComment")
    // TODO: handle with the "previous" way
    private val isConnectionAvailable: MutableStateFlow<Boolean> = MutableStateFlow(true)

--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/ReaderActivity.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/ReaderActivity.kt
@@ -53,7 +53,6 @@ class ReaderActivity :
        showMenuItem(false)
    }

-    @Suppress("detekt:SwallowedException")
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        binding = ActivityReaderBinding.inflate(layoutInflater)
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/UpsertSourceActivity.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/UpsertSourceActivity.kt
@@ -85,7 +85,6 @@ class UpsertSourceActivity :
        }
    }

-    @Suppress("detekt:SwallowedException")
    private fun handleSpoutsSpinner() {
        val spoutsKV = HashMap<String, String>()
        binding.spoutsSpinner.onItemSelectedListener =
@@ -174,7 +173,6 @@ class UpsertSourceActivity :
            sourceDetailsUnavailable -> {
                Toast.makeText(this, R.string.form_not_complete, Toast.LENGTH_SHORT).show()
            }
-
            else -> {
                CoroutineScope(Dispatchers.Main).launch {
                    val successfullyAddedSource =
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemCardAdapter.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemCardAdapter.kt
@@ -118,13 +118,13 @@ class ItemCardAdapter(
                binding.itemImage.setImageDrawable(null)
            } else {
                binding.itemImage.visibility = View.VISIBLE
-                c.bitmapCenterCrop(itm.getThumbnail(repository.baseUrl), binding.itemImage, appSettingsService)
+                c.bitmapCenterCrop(itm.getThumbnail(repository.baseUrl), binding.itemImage)
            }

            if (itm.getIcon(repository.baseUrl).isEmpty()) {
                binding.sourceImage.setBackgroundAndText(itm.sourcetitle.getHtmlDecoded())
            } else {
-                c.circularDrawable(itm.getIcon(repository.baseUrl), binding.sourceImage, appSettingsService)
+                c.circularDrawable(itm.getIcon(repository.baseUrl), binding.sourceImage)
            }
        }
    }
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemListAdapter.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemListAdapter.kt
@@ -65,10 +65,10 @@ class ItemListAdapter(
                if (itm.getIcon(repository.baseUrl).isEmpty()) {
                    binding.itemImage.setBackgroundAndText(itm.sourcetitle.getHtmlDecoded())
                } else {
-                    c.circularDrawable(itm.getIcon(repository.baseUrl), binding.itemImage, appSettingsService)
+                    c.circularDrawable(itm.getIcon(repository.baseUrl), binding.itemImage)
                }
            } else {
-                c.circularDrawable(itm.getThumbnail(repository.baseUrl), binding.itemImage, appSettingsService)
+                c.circularDrawable(itm.getThumbnail(repository.baseUrl), binding.itemImage)
            }
        }
    }
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/SourcesListAdapter.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/SourcesListAdapter.kt
@@ -16,7 +16,6 @@ import bou.amine.apps.readerforselfossv2.android.databinding.SourceListItemBindi
 import bou.amine.apps.readerforselfossv2.android.utils.glide.circularDrawable
 import bou.amine.apps.readerforselfossv2.model.SelfossModel
 import bou.amine.apps.readerforselfossv2.repository.Repository
-import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 import bou.amine.apps.readerforselfossv2.utils.getHtmlDecoded
 import bou.amine.apps.readerforselfossv2.utils.getIcon
 import kotlinx.coroutines.CoroutineScope
@@ -37,7 +36,6 @@ class SourcesListAdapter(

    override val di: DI by closestDI(app)
    private val repository: Repository by instance()
-    private val appSettingsService: AppSettingsService by instance()

    override fun onCreateViewHolder(
        parent: ViewGroup,
@@ -84,7 +82,7 @@ class SourcesListAdapter(
        if (itm.getIcon(repository.baseUrl).isEmpty()) {
            binding.itemImage.setBackgroundAndText(itm.title.getHtmlDecoded())
        } else {
-            c.circularDrawable(itm.getIcon(repository.baseUrl), binding.itemImage, appSettingsService)
+            c.circularDrawable(itm.getIcon(repository.baseUrl), binding.itemImage)
        }

        if (!itm.error.isNullOrBlank()) {
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/background/LoadingWorker.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/background/LoadingWorker.kt
@@ -26,8 +26,6 @@ import org.kodein.di.instance
 import java.util.Timer
 import kotlin.concurrent.schedule

-private const val NOTIFICATION_DELAY = 4000L
-
 class LoadingWorker(
    val context: Context,
    params: WorkerParameters,
@@ -63,7 +61,7 @@ class LoadingWorker(
                        handleNewItemsNotification(apiItems, notificationManager)
                    }
                }
-                apiItems.map { it.preloadImages(context, appSettingsService) }
+                apiItems.map { it.preloadImages(context) }
            }
        }
        return Result.success()
@@ -108,11 +106,11 @@ class LoadingWorker(
                        .setAutoCancel(true)
                        .setSmallIcon(R.drawable.ic_tab_fiber_new_black_24dp)

-                Timer("", false).schedule(NOTIFICATION_DELAY) {
+                Timer("", false).schedule(4000) {
                    notificationManager.notify(2, newItemsNotification.build())
                }
            }
-            Timer("", false).schedule(NOTIFICATION_DELAY) {
+            Timer("", false).schedule(4000) {
                notificationManager.cancel(1)
            }
        }
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/ArticleFragment.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/ArticleFragment.kt
@@ -32,9 +32,7 @@ import bou.amine.apps.readerforselfossv2.android.model.ParecelableItem
 import bou.amine.apps.readerforselfossv2.android.model.toModel
 import bou.amine.apps.readerforselfossv2.android.model.toParcelable
 import bou.amine.apps.readerforselfossv2.android.utils.acra.sendSilentlyWithAcraWithName
-import bou.amine.apps.readerforselfossv2.android.utils.glide.bitmapFitCenter
 import bou.amine.apps.readerforselfossv2.android.utils.glide.getBitmapInputStream
-import bou.amine.apps.readerforselfossv2.android.utils.glide.getGlideImageForResource
 import bou.amine.apps.readerforselfossv2.android.utils.isUrlValid
 import bou.amine.apps.readerforselfossv2.android.utils.openItemUrlInBrowserAsNewTask
 import bou.amine.apps.readerforselfossv2.android.utils.openUrlInBrowser
@@ -48,6 +46,9 @@ import bou.amine.apps.readerforselfossv2.utils.getHtmlDecoded
 import bou.amine.apps.readerforselfossv2.utils.getImages
 import bou.amine.apps.readerforselfossv2.utils.getThumbnail
 import bou.amine.apps.readerforselfossv2.utils.isEmptyOrNullOrNullString
+import com.bumptech.glide.Glide
+import com.bumptech.glide.load.engine.DiskCacheStrategy
+import com.bumptech.glide.request.RequestOptions
 import com.github.rubensousa.floatingtoolbar.FloatingToolbar
 import com.google.android.material.floatingactionbutton.FloatingActionButton
 import kotlinx.coroutines.CoroutineScope
@@ -64,17 +65,11 @@ import java.util.Locale
 import java.util.concurrent.ExecutionException

 private const val IMAGE_JPG = "image/jpg"
-private const val IMAGE_PNG = "image/png"
-private const val IMAGE_WEBP = "image/webp"
-
-private const val WHITE_COLOR_HEX = 0xFFFFFF
-
-private const val DEFAULT_FONT_SIZE = 16

 class ArticleFragment :
    Fragment(),
    DIAware {
-    private var fontSize: Int = DEFAULT_FONT_SIZE
+    private var fontSize: Int = 16
    private lateinit var item: SelfossModel.Item
    private lateinit var url: String
    private lateinit var contentText: String
@@ -105,7 +100,6 @@ class ArticleFragment :
        item = pi.toModel()
    }

-    @Suppress("detekt:LongMethod")
    override fun onCreateView(
        inflater: LayoutInflater,
        container: ViewGroup?,
@@ -209,7 +203,12 @@ class ArticleFragment :

            if (!contentImage.isEmptyOrNullOrNullString() && context != null) {
                binding.imageView.visibility = View.VISIBLE
-                requireContext().bitmapFitCenter(contentImage, binding.imageView, appSettingsService)
+                Glide
+                    .with(requireContext())
+                    .asBitmap()
+                    .load(contentImage)
+                    .apply(RequestOptions.fitCenterTransform())
+                    .into(binding.imageView)
            } else {
                binding.imageView.visibility = View.GONE
            }
@@ -281,7 +280,6 @@ class ArticleFragment :
            }
    }

-    @Suppress("detekt:SwallowedException")
    private fun getContentFromMercury() {
        binding.progressBar.visibility = View.VISIBLE

@@ -320,10 +318,16 @@ class ArticleFragment :
        }
    }

-    private fun handleLeadImage(leadImageUrl: String?) {
-        if (!leadImageUrl.isNullOrEmpty() && context != null) {
+    private fun handleLeadImage(lead_image_url: String?) {
+        if (!lead_image_url.isNullOrEmpty() && context != null) {
            binding.imageView.visibility = View.VISIBLE
-            requireContext().bitmapFitCenter(leadImageUrl, binding.imageView, appSettingsService)
+            Glide
+                .with(requireContext())
+                .asBitmap()
+                .load(
+                    lead_image_url,
+                ).apply(RequestOptions.fitCenterTransform())
+                .into(binding.imageView)
        } else {
            binding.imageView.visibility = View.GONE
        }
@@ -347,42 +351,77 @@ class ArticleFragment :
                        false
                    }

-                @Suppress("detekt:SwallowedException", "detekt:ReturnCount")
                @Deprecated("Deprecated in Java")
                override fun shouldInterceptRequest(
                    view: WebView,
                    url: String,
                ): WebResourceResponse? {
-                    val (mime: String?, compression: Bitmap.CompressFormat) =
-                        if (url
-                                .lowercase(Locale.US)
-                                .contains(".jpg") ||
-                            url.lowercase(Locale.US).contains(".jpeg")
-                        ) {
-                            Pair(IMAGE_JPG, Bitmap.CompressFormat.JPEG)
-                        } else if (url.lowercase(Locale.US).contains(".png")) {
-                            Pair(IMAGE_PNG, Bitmap.CompressFormat.PNG)
-                        } else if (url.lowercase(Locale.US).contains(".webp")) {
-                            Pair(IMAGE_WEBP, Bitmap.CompressFormat.WEBP)
-                        } else {
-                            return super.shouldInterceptRequest(view, url)
+                    val glideOptions = RequestOptions.diskCacheStrategyOf(DiskCacheStrategy.ALL)
+                    if (url.lowercase(Locale.US).contains(".jpg") ||
+                        url
+                            .lowercase(Locale.US)
+                            .contains(".jpeg")
+                    ) {
+                        try {
+                            val image =
+                                Glide
+                                    .with(view)
+                                    .asBitmap()
+                                    .apply(glideOptions)
+                                    .load(url)
+                                    .submit()
+                                    .get()
+                            return WebResourceResponse(
+                                IMAGE_JPG,
+                                "UTF-8",
+                                getBitmapInputStream(image, Bitmap.CompressFormat.JPEG),
+                            )
+                        } catch (e: ExecutionException) {
+                            // Do nothing
+                        }
+                    } else if (url.lowercase(Locale.US).contains(".png")) {
+                        try {
+                            val image =
+                                Glide
+                                    .with(view)
+                                    .asBitmap()
+                                    .apply(glideOptions)
+                                    .load(url)
+                                    .submit()
+                                    .get()
+                            return WebResourceResponse(
+                                IMAGE_JPG,
+                                "UTF-8",
+                                getBitmapInputStream(image, Bitmap.CompressFormat.PNG),
+                            )
+                        } catch (e: ExecutionException) {
+                            // Do nothing
+                        }
+                    } else if (url.lowercase(Locale.US).contains(".webp")) {
+                        try {
+                            val image =
+                                Glide
+                                    .with(view)
+                                    .asBitmap()
+                                    .apply(glideOptions)
+                                    .load(url)
+                                    .submit()
+                                    .get()
+                            return WebResourceResponse(
+                                IMAGE_JPG,
+                                "UTF-8",
+                                getBitmapInputStream(image, Bitmap.CompressFormat.WEBP),
+                            )
+                        } catch (e: ExecutionException) {
+                            // Do nothing
                        }
-
-                    try {
-                        val image = view.getGlideImageForResource(url, appSettingsService)
-                        return WebResourceResponse(
-                            mime,
-                            "UTF-8",
-                            getBitmapInputStream(image, compression),
-                        )
-                    } catch (e: ExecutionException) {
-                        return super.shouldInterceptRequest(view, url)
                    }
+
+                    return super.shouldInterceptRequest(view, url)
                }
            }
    }

-    @Suppress("detekt:LongMethod", "detekt:ImplicitDefaultLocale")
    private fun htmlToWebview() {
        val context: Context
        try {
@@ -412,13 +451,13 @@ class ArticleFragment :
        val colorSurfaceString =
            String.format(
                "#%06X",
-                WHITE_COLOR_HEX and (if (colorSurface.data != DATA_NULL_UNDEFINED) colorSurface.data else WHITE_COLOR_HEX),
+                0xFFFFFF and (if (colorSurface.data != DATA_NULL_UNDEFINED) colorSurface.data else 0xFFFFFF),
            )

        val colorOnSurfaceString =
            String.format(
                "#%06X",
-                WHITE_COLOR_HEX and (if (colorOnSurface.data != DATA_NULL_UNDEFINED) colorOnSurface.data else 0),
+                0xFFFFFF and (if (colorOnSurface.data != DATA_NULL_UNDEFINED) colorOnSurface.data else 0),
            )

        try {
@@ -500,7 +539,7 @@ class ArticleFragment :
                |        color: ${
                    String.format(
                        "#%06X",
-                        WHITE_COLOR_HEX and context.resources.getColor(R.color.colorAccent),
+                        0xFFFFFF and context.resources.getColor(R.color.colorAccent),
                    )
                } !important;
                |      }
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/FilterSheetFragment.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/FilterSheetFragment.kt
@@ -16,12 +16,11 @@ import bou.amine.apps.readerforselfossv2.android.HomeActivity
 import bou.amine.apps.readerforselfossv2.android.R
 import bou.amine.apps.readerforselfossv2.android.databinding.FilterFragmentBinding
 import bou.amine.apps.readerforselfossv2.android.utils.acra.sendSilentlyWithAcraWithName
-import bou.amine.apps.readerforselfossv2.android.utils.glide.imageIntoViewTarget
 import bou.amine.apps.readerforselfossv2.repository.Repository
-import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 import bou.amine.apps.readerforselfossv2.utils.getColorHexCode
 import bou.amine.apps.readerforselfossv2.utils.getHtmlDecoded
 import bou.amine.apps.readerforselfossv2.utils.getIcon
+import com.bumptech.glide.Glide
 import com.bumptech.glide.request.target.ViewTarget
 import com.bumptech.glide.request.transition.Transition
 import com.google.android.material.bottomsheet.BottomSheetDialogFragment
@@ -34,15 +33,12 @@ import org.kodein.di.DIAware
 import org.kodein.di.android.x.closestDI
 import org.kodein.di.instance

-private const val DRAWABLE_SIZE = 30
-
 class FilterSheetFragment :
    BottomSheetDialogFragment(),
    DIAware {
    private lateinit var binding: FilterFragmentBinding
    override val di: DI by closestDI()
    private val repository: Repository by instance()
-    private val appSettingsService: AppSettingsService by instance()

    private var selectedChip: Chip? = null

@@ -86,22 +82,23 @@ class FilterSheetFragment :
            val c = Chip(context)
            c.ellipsize = TextUtils.TruncateAt.END

-            context.imageIntoViewTarget(
-                source.getIcon(repository.baseUrl),
-                object : ViewTarget<Chip?, Drawable?>(c) {
-                    override fun onResourceReady(
-                        resource: Drawable,
-                        transition: Transition<in Drawable?>?,
-                    ) {
-                        try {
-                            c.chipIcon = resource
-                        } catch (e: Exception) {
-                            e.sendSilentlyWithAcraWithName("sources > onResourceReady")
+            Glide
+                .with(context)
+                .load(source.getIcon(repository.baseUrl))
+                .into(
+                    object : ViewTarget<Chip?, Drawable?>(c) {
+                        override fun onResourceReady(
+                            resource: Drawable,
+                            transition: Transition<in Drawable?>?,
+                        ) {
+                            try {
+                                c.chipIcon = resource
+                            } catch (e: Exception) {
+                                e.sendSilentlyWithAcraWithName("sources > onResourceReady")
+                            }
                        }
-                    }
-                },
-                appSettingsService,
-            )
+                    },
+                )

            c.text = source.title.getHtmlDecoded()

@@ -159,8 +156,8 @@ class FilterSheetFragment :
                        }
                    gd.setColor(gdColor)
                    gd.shape = GradientDrawable.RECTANGLE
-                    gd.setSize(DRAWABLE_SIZE, DRAWABLE_SIZE)
-                    gd.cornerRadius = DRAWABLE_SIZE.toFloat()
+                    gd.setSize(30, 30)
+                    gd.cornerRadius = 30F
                    c.chipIcon = gd
                } catch (e: Exception) {
                    e.sendSilentlyWithAcraWithName("tags > GradientDrawable")
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/ImageFragment.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/ImageFragment.kt
@@ -6,19 +6,13 @@ import android.view.View
 import android.view.ViewGroup
 import androidx.fragment.app.Fragment
 import bou.amine.apps.readerforselfossv2.android.databinding.FragmentImageBinding
-import bou.amine.apps.readerforselfossv2.android.utils.glide.bitmapWithCache
-import bou.amine.apps.readerforselfossv2.service.AppSettingsService
-import org.kodein.di.DI
-import org.kodein.di.DIAware
-import org.kodein.di.android.x.closestDI
-import org.kodein.di.instance
+import com.bumptech.glide.Glide
+import com.bumptech.glide.load.engine.DiskCacheStrategy
+import com.bumptech.glide.request.RequestOptions

-class ImageFragment :
-    Fragment(),
-    DIAware {
-    override val di: DI by closestDI()
-    private val appSettingsService: AppSettingsService by instance()
+class ImageFragment : Fragment() {
    private lateinit var imageUrl: String
+    private val glideOptions = RequestOptions.diskCacheStrategyOf(DiskCacheStrategy.ALL)
    private var _binding: FragmentImageBinding? = null
    val binding get() = _binding

@@ -37,7 +31,12 @@ class ImageFragment :
        val view = binding?.root

        binding!!.photoView.visibility = View.VISIBLE
-        requireActivity().bitmapWithCache(imageUrl, binding!!.photoView, appSettingsService)
+        Glide
+            .with(requireActivity())
+            .asBitmap()
+            .apply(glideOptions)
+            .load(imageUrl)
+            .into(binding!!.photoView)

        return view
    }
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/model/AndroidIModelUtils.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/model/AndroidIModelUtils.kt
@@ -3,21 +3,26 @@ package bou.amine.apps.readerforselfossv2.android.model
 import android.content.Context
 import android.webkit.URLUtil
 import bou.amine.apps.readerforselfossv2.android.utils.acra.sendSilentlyWithAcraWithName
-import bou.amine.apps.readerforselfossv2.android.utils.glide.preloadImage
 import bou.amine.apps.readerforselfossv2.model.SelfossModel
-import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 import bou.amine.apps.readerforselfossv2.utils.getImages
+import com.bumptech.glide.Glide
+import com.bumptech.glide.load.engine.DiskCacheStrategy
+import com.bumptech.glide.request.RequestOptions

-fun SelfossModel.Item.preloadImages(
-    context: Context,
-    appSettingsService: AppSettingsService,
-): Boolean {
+fun SelfossModel.Item.preloadImages(context: Context): Boolean {
    val imageUrls = this.getImages()

+    val glideOptions = RequestOptions.diskCacheStrategyOf(DiskCacheStrategy.ALL).timeout(10000)
+
    try {
        for (url in imageUrls) {
            if (URLUtil.isValidUrl(url)) {
-                context.preloadImage(url, appSettingsService)
+                Glide
+                    .with(context)
+                    .asBitmap()
+                    .apply(glideOptions)
+                    .load(url)
+                    .submit()
            }
        }
    } catch (e: Error) {
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/settings/SettingsActivity.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/settings/SettingsActivity.kt
@@ -26,10 +26,6 @@ import org.kodein.di.android.closestDI

 private const val TITLE_TAG = "settingsActivityTitle"

-const val MAX_ITEMS_NUMBER = 200
-
-private const val MIN_ITEMS_NUMBER = 1
-
 class SettingsActivity :
    AppCompatActivity(),
    PreferenceFragmentCompat.OnPreferenceStartFragmentCallback,
@@ -147,7 +143,7 @@ class SettingsActivity :
                        InputFilter { source, _, _, dest, _, _ ->
                            try {
                                val input: Int = (dest.toString() + source.toString()).toInt()
-                                if (input in MIN_ITEMS_NUMBER..MAX_ITEMS_NUMBER) return@InputFilter null
+                                if (input in 1..200) return@InputFilter null
                            } catch (nfe: NumberFormatException) {
                                Toast
                                    .makeText(
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/LinksUtils.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/LinksUtils.kt
@@ -72,7 +72,6 @@ fun Context.openUrlInBrowser(url: String) {
    this.mayBeStartActivity(intent)
 }

-@Suppress("detekt:SwallowedException")
 fun Context.mayBeStartActivity(intent: Intent) {
    try {
        this.startActivity(intent)
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/glide/GlideUtils.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/glide/GlideUtils.kt
@@ -2,130 +2,42 @@ package bou.amine.apps.readerforselfossv2.android.utils.glide

 import android.content.Context
 import android.graphics.Bitmap
-import android.graphics.drawable.Drawable
-import android.webkit.WebView
 import android.widget.ImageView
 import bou.amine.apps.readerforselfossv2.android.utils.CircleImageView
-import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 import com.bumptech.glide.Glide
-import com.bumptech.glide.load.engine.DiskCacheStrategy
-import com.bumptech.glide.load.model.GlideUrl
-import com.bumptech.glide.load.model.LazyHeaders
 import com.bumptech.glide.request.RequestOptions
-import com.bumptech.glide.request.target.ViewTarget
-import com.google.android.material.chip.Chip
 import java.io.ByteArrayInputStream
 import java.io.ByteArrayOutputStream
 import java.io.InputStream
-import kotlin.io.encoding.Base64
-import kotlin.io.encoding.ExperimentalEncodingApi
-
-private const val PRELOAD_IMAGE_TIMEOUT = 10000
-
-@OptIn(ExperimentalEncodingApi::class)
-fun String.toGlideUrl(appSettingsService: AppSettingsService): GlideUrl {
-    if (appSettingsService.getBasicUserName().isNotEmpty()) {
-        val authString = "${appSettingsService.getBasicUserName()}:${appSettingsService.getBasicPassword()}"
-        val authBuf = Base64.encode(authString.toByteArray(Charsets.UTF_8))
-
-        return GlideUrl(
-            this,
-            LazyHeaders
-                .Builder()
-                .addHeader("Authorization", "Basic $authBuf")
-                .build(),
-        )
-    } else {
-        return GlideUrl(
-            this,
-        )
-    }
-}
-
-fun WebView.getGlideImageForResource(
-    url: String,
-    appSettingsService: AppSettingsService,
-) = Glide
-    .with(this)
-    .asBitmap()
-    .apply(RequestOptions.diskCacheStrategyOf(DiskCacheStrategy.ALL))
-    .load(url.toGlideUrl(appSettingsService))
-    .submit()
-    .get()
-
-fun Context.preloadImage(
-    url: String,
-    appSettingsService: AppSettingsService,
-) = Glide
-    .with(this)
-    .asBitmap()
-    .apply(RequestOptions.diskCacheStrategyOf(DiskCacheStrategy.ALL).timeout(PRELOAD_IMAGE_TIMEOUT))
-    .load(url.toGlideUrl(appSettingsService))
-    .submit()
-
-fun Context.imageIntoViewTarget(
-    url: String,
-    target: ViewTarget<Chip?, Drawable?>,
-    appSettingsService: AppSettingsService,
-) = Glide
-    .with(this)
-    .load(url.toGlideUrl(appSettingsService))
-    .into(target)
-
-fun Context.bitmapWithCache(
-    url: String,
-    iv: ImageView,
-    appSettingsService: AppSettingsService,
-) = Glide
-    .with(this)
-    .asBitmap()
-    .apply(RequestOptions.diskCacheStrategyOf(DiskCacheStrategy.ALL))
-    .load(url.toGlideUrl(appSettingsService))
-    .into(iv)

 fun Context.bitmapCenterCrop(
    url: String,
    iv: ImageView,
-    appSettingsService: AppSettingsService,
 ) = Glide
    .with(this)
    .asBitmap()
-    .load(url.toGlideUrl(appSettingsService))
+    .load(url)
    .apply(RequestOptions.centerCropTransform())
    .into(iv)

-fun Context.bitmapFitCenter(
-    url: String,
-    iv: ImageView,
-    appSettingsService: AppSettingsService,
-) = Glide
-    .with(this)
-    .asBitmap()
-    .load(url.toGlideUrl(appSettingsService))
-    .apply(RequestOptions.fitCenterTransform())
-    .into(iv)
-
 fun Context.circularDrawable(
    url: String,
    view: CircleImageView,
-    appSettingsService: AppSettingsService,
 ) {
    view.textView.text = ""

    Glide
        .with(this)
-        .load(url.toGlideUrl(appSettingsService))
+        .load(url)
        .into(view.imageView)
 }

-private const val BITMAP_INPUT_STREAM_COMPRESSION_QUALITY = 80
-
 fun getBitmapInputStream(
    bitmap: Bitmap,
    compressFormat: Bitmap.CompressFormat,
 ): InputStream {
    val byteArrayOutputStream = ByteArrayOutputStream()
-    bitmap.compress(compressFormat, BITMAP_INPUT_STREAM_COMPRESSION_QUALITY, byteArrayOutputStream)
+    bitmap.compress(compressFormat, 80, byteArrayOutputStream)
    val bitmapData: ByteArray = byteArrayOutputStream.toByteArray()
    return ByteArrayInputStream(bitmapData)
 }
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/network/NetworkUtils.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/network/NetworkUtils.kt
@@ -3,6 +3,7 @@ package bou.amine.apps.readerforselfossv2.android.utils.network
 import android.content.Context
 import android.net.ConnectivityManager
 import android.net.NetworkCapabilities
+import android.os.Build
 import com.google.android.material.snackbar.Snackbar

 lateinit var s: Snackbar
@@ -10,13 +11,19 @@ lateinit var s: Snackbar
 fun isNetworkAccessible(context: Context): Boolean {
    val connectivityManager = context.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager

-    val networkCapabilities = connectivityManager.getNetworkCapabilities(connectivityManager.activeNetwork) ?: return false
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
+        val network = connectivityManager.activeNetwork ?: return false
+        val networkCapabilities = connectivityManager.getNetworkCapabilities(network) ?: return false

-    return when {
-        networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_BLUETOOTH) -> true
-        networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_CELLULAR) -> true
-        networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_ETHERNET) -> true
-        networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_WIFI) -> true
-        else -> false
+        return when {
+            networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_BLUETOOTH) -> true
+            networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_CELLULAR) -> true
+            networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_ETHERNET) -> true
+            networkCapabilities.hasTransport(NetworkCapabilities.TRANSPORT_WIFI) -> true
+            else -> false
+        }
+    } else {
+        val network = connectivityManager.activeNetworkInfo ?: return false
+        return network.isConnectedOrConnecting
    }
 }
--- a/androidApp/src/test/kotlin/bou/amine/apps/readerforselfossv2/tests/repository/RepositoryTest.kt
+++ b/androidApp/src/test/kotlin/bou/amine/apps/readerforselfossv2/tests/repository/RepositoryTest.kt
@@ -1,5 +1,3 @@
-@file:Suppress("detekt:LargeClass")
-
 package bou.amine.apps.readerforselfossv2.tests.repository

 import bou.amine.apps.readerforselfossv2.dao.ReaderForSelfossDB
@@ -44,9 +42,9 @@ private const val FEED_URL = "https://test.com/feed"

 private const val TAGS = "Test, New"

-private const val NUMBER_ARTICLES = 100
-private const val NUMBER_UNREAD = 50
-private const val NUMBER_STARRED = 20
+private val NUMBER_ARTICLES = 100
+private val NUMBER_UNREAD = 50
+private val NUMBER_STARRED = 20

 class RepositoryTest {
    private val db = mockk<ReaderForSelfossDB>(relaxed = true)
--- a/detekt.yml
+++ b/detekt.yml
@@ -1,786 +0,0 @@
-build:
-  maxIssues: 0
-  excludeCorrectable: false
-  weights:
-  # complexity: 2
-  # LongParameterList: 1
-  # style: 1
-  # comments: 1
-
-config:
-  validation: true
-  warningsAsErrors: false
-  checkExhaustiveness: false
-  # when writing own rules with new properties, exclude the property path e.g.: 'my_rule_set,.*>.*>[my_property]'
-  excludes: ''
-
-processors:
-  active: true
-  exclude:
-    - 'DetektProgressListener'
-  # - 'KtFileCountProcessor'
-  # - 'PackageCountProcessor'
-  # - 'ClassCountProcessor'
-  # - 'FunctionCountProcessor'
-  # - 'PropertyCountProcessor'
-  # - 'ProjectComplexityProcessor'
-  # - 'ProjectCognitiveComplexityProcessor'
-  # - 'ProjectLLOCProcessor'
-  # - 'ProjectCLOCProcessor'
-  # - 'ProjectLOCProcessor'
-  # - 'ProjectSLOCProcessor'
-  # - 'LicenseHeaderLoaderExtension'
-
-console-reports:
-  active: true
-  exclude:
-    - 'ProjectStatisticsReport'
-    - 'ComplexityReport'
-    - 'NotificationReport'
-    - 'FindingsReport'
-    - 'FileBasedFindingsReport'
-  #  - 'LiteFindingsReport'
-
-output-reports:
-  active: true
-  exclude:
-  # - 'TxtOutputReport'
-  # - 'XmlOutputReport'
-  # - 'HtmlOutputReport'
-  # - 'MdOutputReport'
-  # - 'SarifOutputReport'
-
-comments:
-  active: true
-  AbsentOrWrongFileLicense:
-    active: false
-    licenseTemplateFile: 'license.template'
-    licenseTemplateIsRegex: false
-  CommentOverPrivateFunction:
-    active: false
-  CommentOverPrivateProperty:
-    active: false
-  DeprecatedBlockTag:
-    active: false
-  EndOfSentenceFormat:
-    active: false
-    endOfSentenceFormat: '([.?!][ \t\n\r\f<])|([.?!:]$)'
-  KDocReferencesNonPublicProperty:
-    active: false
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-  OutdatedDocumentation:
-    active: false
-    matchTypeParameters: true
-    matchDeclarationsOrder: true
-    allowParamOnConstructorProperties: false
-  UndocumentedPublicClass:
-    active: false
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    searchInNestedClass: true
-    searchInInnerClass: true
-    searchInInnerObject: true
-    searchInInnerInterface: true
-    searchInProtectedClass: false
-  UndocumentedPublicFunction:
-    active: false
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    searchProtectedFunction: false
-  UndocumentedPublicProperty:
-    active: false
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    searchProtectedProperty: false
-
-complexity:
-  active: true
-  CognitiveComplexMethod:
-    active: false
-    threshold: 15
-  ComplexCondition:
-    active: true
-    threshold: 4
-  ComplexInterface:
-    active: false
-    threshold: 10
-    includeStaticDeclarations: false
-    includePrivateDeclarations: false
-    ignoreOverloaded: false
-  CyclomaticComplexMethod:
-    active: true
-    threshold: 15
-    ignoreSingleWhenExpression: false
-    ignoreSimpleWhenEntries: false
-    ignoreNestingFunctions: false
-    nestingFunctions:
-      - 'also'
-      - 'apply'
-      - 'forEach'
-      - 'isNotNull'
-      - 'ifNull'
-      - 'let'
-      - 'run'
-      - 'use'
-      - 'with'
-  LabeledExpression:
-    active: false
-    ignoredLabels: [ ]
-  LargeClass:
-    active: true
-    threshold: 600
-  LongMethod:
-    active: true
-    threshold: 60
-  LongParameterList:
-    active: true
-    functionThreshold: 6
-    constructorThreshold: 7
-    ignoreDefaultParameters: false
-    ignoreDataClasses: true
-    ignoreAnnotatedParameter: [ ]
-  MethodOverloading:
-    active: false
-    threshold: 6
-  NamedArguments:
-    active: false
-    threshold: 3
-    ignoreArgumentsMatchingNames: false
-  NestedBlockDepth:
-    active: true
-    threshold: 4
-  NestedScopeFunctions:
-    active: false
-    threshold: 1
-    functions:
-      - 'kotlin.apply'
-      - 'kotlin.run'
-      - 'kotlin.with'
-      - 'kotlin.let'
-      - 'kotlin.also'
-  ReplaceSafeCallChainWithRun:
-    active: false
-  StringLiteralDuplication:
-    active: false
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    threshold: 3
-    ignoreAnnotation: true
-    excludeStringsWithLessThan5Characters: true
-    ignoreStringsRegex: '$^'
-  TooManyFunctions:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**', '**/android/*Activity.kt', '**/fragments/*Fragment.kt' ]
-    thresholdInFiles: 11
-    thresholdInClasses: 11
-    thresholdInInterfaces: 11
-    thresholdInObjects: 11
-    thresholdInEnums: 11
-    ignoreDeprecated: false
-    ignorePrivate: false
-    ignoreOverridden: false
-    ignoreAnnotatedFunctions: [ ]
-
-coroutines:
-  active: true
-  GlobalCoroutineUsage:
-    active: false
-  InjectDispatcher:
-    active: true
-    dispatcherNames:
-      - 'IO'
-      - 'Default'
-      - 'Unconfined'
-  RedundantSuspendModifier:
-    active: true
-  SleepInsteadOfDelay:
-    active: true
-  SuspendFunSwallowedCancellation:
-    active: false
-  SuspendFunWithCoroutineScopeReceiver:
-    active: false
-  SuspendFunWithFlowReturnType:
-    active: true
-
-empty-blocks:
-  active: true
-  EmptyCatchBlock:
-    active: true
-    allowedExceptionNameRegex: '_|(ignore|expected).*'
-  EmptyClassBlock:
-    active: true
-  EmptyDefaultConstructor:
-    active: true
-  EmptyDoWhileBlock:
-    active: true
-  EmptyElseBlock:
-    active: true
-  EmptyFinallyBlock:
-    active: true
-  EmptyForBlock:
-    active: true
-  EmptyFunctionBlock:
-    active: true
-    ignoreOverridden: false
-  EmptyIfBlock:
-    active: true
-  EmptyInitBlock:
-    active: true
-  EmptyKtFile:
-    active: true
-  EmptySecondaryConstructor:
-    active: true
-  EmptyTryBlock:
-    active: true
-  EmptyWhenBlock:
-    active: true
-  EmptyWhileBlock:
-    active: true
-
-exceptions:
-  active: true
-  ExceptionRaisedInUnexpectedLocation:
-    active: true
-    methodNames:
-      - 'equals'
-      - 'finalize'
-      - 'hashCode'
-      - 'toString'
-  InstanceOfCheckForException:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-  NotImplementedDeclaration:
-    active: false
-  ObjectExtendsThrowable:
-    active: false
-  PrintStackTrace:
-    active: true
-  RethrowCaughtException:
-    active: true
-  ReturnFromFinally:
-    active: true
-    ignoreLabeled: false
-  SwallowedException:
-    active: true
-    ignoredExceptionTypes:
-      - 'InterruptedException'
-      - 'MalformedURLException'
-      - 'NumberFormatException'
-      - 'ParseException'
-    allowedExceptionNameRegex: '_|(ignore|expected).*'
-  ThrowingExceptionFromFinally:
-    active: true
-  ThrowingExceptionInMain:
-    active: false
-  ThrowingExceptionsWithoutMessageOrCause:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    exceptions:
-      - 'ArrayIndexOutOfBoundsException'
-      - 'Exception'
-      - 'IllegalArgumentException'
-      - 'IllegalMonitorStateException'
-      - 'IllegalStateException'
-      - 'IndexOutOfBoundsException'
-      - 'NullPointerException'
-      - 'RuntimeException'
-      - 'Throwable'
-  ThrowingNewInstanceOfSameException:
-    active: true
-  TooGenericExceptionCaught:
-    active: false
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    exceptionNames:
-      - 'ArrayIndexOutOfBoundsException'
-      - 'Error'
-      - 'Exception'
-      - 'IllegalMonitorStateException'
-      - 'IndexOutOfBoundsException'
-      - 'NullPointerException'
-      - 'RuntimeException'
-      - 'Throwable'
-    allowedExceptionNameRegex: '_|(ignore|expected).*'
-  TooGenericExceptionThrown:
-    active: true
-    exceptionNames:
-      - 'Error'
-      - 'Exception'
-      - 'RuntimeException'
-      - 'Throwable'
-
-naming:
-  active: true
-  BooleanPropertyNaming:
-    active: false
-    allowedPattern: '^(is|has|are)'
-  ClassNaming:
-    active: true
-    classPattern: '[A-Z][a-zA-Z0-9]*'
-  ConstructorParameterNaming:
-    active: true
-    parameterPattern: '[a-z][A-Za-z0-9]*'
-    privateParameterPattern: '[a-z][A-Za-z0-9]*'
-    excludeClassPattern: '$^'
-  EnumNaming:
-    active: true
-    enumEntryPattern: '[A-Z][_a-zA-Z0-9]*'
-  ForbiddenClassName:
-    active: false
-    forbiddenName: [ ]
-  FunctionMaxLength:
-    active: false
-    maximumFunctionNameLength: 30
-  FunctionMinLength:
-    active: false
-    minimumFunctionNameLength: 3
-  FunctionNaming:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    functionPattern: '[a-z][a-zA-Z0-9]*'
-    excludeClassPattern: '$^'
-  FunctionParameterNaming:
-    active: true
-    parameterPattern: '[a-z][A-Za-z0-9]*'
-    excludeClassPattern: '$^'
-  InvalidPackageDeclaration:
-    active: true
-    rootPackage: ''
-    requireRootInDeclaration: false
-  LambdaParameterNaming:
-    active: false
-    parameterPattern: '[a-z][A-Za-z0-9]*|_'
-  MatchingDeclarationName:
-    active: false # done in ktlint
-    mustBeFirst: true
-  MemberNameEqualsClassName:
-    active: true
-    ignoreOverridden: true
-  NoNameShadowing:
-    active: true
-  NonBooleanPropertyPrefixedWithIs:
-    active: false
-  ObjectPropertyNaming:
-    active: true
-    constantPattern: '[A-Za-z][_A-Za-z0-9]*'
-    propertyPattern: '[A-Za-z][_A-Za-z0-9]*'
-    privatePropertyPattern: '(_)?[A-Za-z][_A-Za-z0-9]*'
-  PackageNaming:
-    active: true
-    packagePattern: '[a-z]+(\.[a-z][A-Za-z0-9]*)*'
-  TopLevelPropertyNaming:
-    active: true
-    constantPattern: '[A-Z][_A-Z0-9]*'
-    propertyPattern: '[A-Za-z][_A-Za-z0-9]*'
-    privatePropertyPattern: '_?[A-Za-z][_A-Za-z0-9]*'
-  VariableMaxLength:
-    active: false
-    maximumVariableNameLength: 64
-  VariableMinLength:
-    active: false
-    minimumVariableNameLength: 1
-  VariableNaming:
-    active: true
-    variablePattern: '[a-z][A-Za-z0-9]*'
-    privateVariablePattern: '(_)?[a-z][A-Za-z0-9]*'
-    excludeClassPattern: '$^'
-
-performance:
-  active: true
-  ArrayPrimitive:
-    active: true
-  CouldBeSequence:
-    active: false
-    threshold: 3
-  ForEachOnRange:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-  SpreadOperator:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-  UnnecessaryPartOfBinaryExpression:
-    active: false
-  UnnecessaryTemporaryInstantiation:
-    active: true
-
-potential-bugs:
-  active: true
-  AvoidReferentialEquality:
-    active: true
-    forbiddenTypePatterns:
-      - 'kotlin.String'
-  CastNullableToNonNullableType:
-    active: false
-  CastToNullableType:
-    active: false
-  Deprecation:
-    active: false
-  DontDowncastCollectionTypes:
-    active: false
-  DoubleMutabilityForCollection:
-    active: true
-    mutableTypes:
-      - 'kotlin.collections.MutableList'
-      - 'kotlin.collections.MutableMap'
-      - 'kotlin.collections.MutableSet'
-      - 'java.util.ArrayList'
-      - 'java.util.LinkedHashSet'
-      - 'java.util.HashSet'
-      - 'java.util.LinkedHashMap'
-      - 'java.util.HashMap'
-  ElseCaseInsteadOfExhaustiveWhen:
-    active: false
-    ignoredSubjectTypes: [ ]
-  EqualsAlwaysReturnsTrueOrFalse:
-    active: true
-  EqualsWithHashCodeExist:
-    active: true
-  ExitOutsideMain:
-    active: false
-  ExplicitGarbageCollectionCall:
-    active: true
-  HasPlatformType:
-    active: true
-  IgnoredReturnValue:
-    active: true
-    restrictToConfig: true
-    returnValueAnnotations:
-      - 'CheckResult'
-      - '*.CheckResult'
-      - 'CheckReturnValue'
-      - '*.CheckReturnValue'
-    ignoreReturnValueAnnotations:
-      - 'CanIgnoreReturnValue'
-      - '*.CanIgnoreReturnValue'
-    returnValueTypes:
-      - 'kotlin.sequences.Sequence'
-      - 'kotlinx.coroutines.flow.*Flow'
-      - 'java.util.stream.*Stream'
-    ignoreFunctionCall: [ ]
-  ImplicitDefaultLocale:
-    active: true
-  ImplicitUnitReturnType:
-    active: false
-    allowExplicitReturnType: true
-  InvalidRange:
-    active: true
-  IteratorHasNextCallsNextMethod:
-    active: true
-  IteratorNotThrowingNoSuchElementException:
-    active: true
-  LateinitUsage:
-    active: false
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-    ignoreOnClassesPattern: ''
-  MapGetWithNotNullAssertionOperator:
-    active: true
-  MissingPackageDeclaration:
-    active: false
-    excludes: [ '**/*.kts' ]
-  NullCheckOnMutableProperty:
-    active: false
-  NullableToStringCall:
-    active: false
-  PropertyUsedBeforeDeclaration:
-    active: false
-  UnconditionalJumpStatementInLoop:
-    active: false
-  UnnecessaryNotNullCheck:
-    active: false
-  UnnecessaryNotNullOperator:
-    active: true
-  UnnecessarySafeCall:
-    active: true
-  UnreachableCatchBlock:
-    active: true
-  UnreachableCode:
-    active: true
-  UnsafeCallOnNullableType:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
-  UnsafeCast:
-    active: true
-  UnusedUnaryOperator:
-    active: true
-  UselessPostfixExpression:
-    active: true
-  WrongEqualsTypeParameter:
-    active: true
-
-style:
-  active: true
-  AlsoCouldBeApply:
-    active: false
-  BracesOnIfStatements:
-    active: false
-    singleLine: 'never'
-    multiLine: 'always'
-  BracesOnWhenStatements:
-    active: false
-    singleLine: 'necessary'
-    multiLine: 'consistent'
-  CanBeNonNullable:
-    active: false
-  CascadingCallWrapping:
-    active: false
-    includeElvis: true
-  ClassOrdering:
-    active: false
-  CollapsibleIfStatements:
-    active: false
-  DataClassContainsFunctions:
-    active: false
-    conversionFunctionPrefix:
-      - 'to'
-    allowOperators: false
-  DataClassShouldBeImmutable:
-    active: false
-  DestructuringDeclarationWithTooManyEntries:
-    active: true
-    maxDestructuringEntries: 3
-  DoubleNegativeLambda:
-    active: false
-    negativeFunctions:
-      - reason: 'Use `takeIf` instead.'
-        value: 'takeUnless'
-      - reason: 'Use `all` instead.'
-        value: 'none'
-    negativeFunctionNameParts:
-      - 'not'
-      - 'non'
-  EqualsNullCall:
-    active: true
-  EqualsOnSignatureLine:
-    active: false
-  ExplicitCollectionElementAccessMethod:
-    active: false
-  ExplicitItLambdaParameter:
-    active: true
-  ExpressionBodySyntax:
-    active: false
-    includeLineWrapping: false
-  ForbiddenAnnotation:
-    active: false
-    annotations:
-      - reason: 'it is a java annotation. Use `Suppress` instead.'
-        value: 'java.lang.SuppressWarnings'
-      - reason: 'it is a java annotation. Use `kotlin.Deprecated` instead.'
-        value: 'java.lang.Deprecated'
-      - reason: 'it is a java annotation. Use `kotlin.annotation.MustBeDocumented` instead.'
-        value: 'java.lang.annotation.Documented'
-      - reason: 'it is a java annotation. Use `kotlin.annotation.Target` instead.'
-        value: 'java.lang.annotation.Target'
-      - reason: 'it is a java annotation. Use `kotlin.annotation.Retention` instead.'
-        value: 'java.lang.annotation.Retention'
-      - reason: 'it is a java annotation. Use `kotlin.annotation.Repeatable` instead.'
-        value: 'java.lang.annotation.Repeatable'
-      - reason: 'Kotlin does not support @Inherited annotation, see https://youtrack.jetbrains.com/issue/KT-22265'
-        value: 'java.lang.annotation.Inherited'
-  ForbiddenComment:
-    active: true
-    comments:
-      - reason: 'Forbidden FIXME todo marker in comment, please fix the problem.'
-        value: 'FIXME:'
-      - reason: 'Forbidden STOPSHIP todo marker in comment, please address the problem before shipping the code.'
-        value: 'STOPSHIP:'
-      - reason: 'Forbidden TODO todo marker in comment, please do the changes.'
-        value: 'TODO:'
-    allowedPatterns: ''
-  ForbiddenImport:
-    active: false
-    imports: [ ]
-    forbiddenPatterns: ''
-  ForbiddenMethodCall:
-    active: false
-    methods:
-      - reason: 'print does not allow you to configure the output stream. Use a logger instead.'
-        value: 'kotlin.io.print'
-      - reason: 'println does not allow you to configure the output stream. Use a logger instead.'
-        value: 'kotlin.io.println'
-  ForbiddenSuppress:
-    active: false
-    rules: [ ]
-  ForbiddenVoid:
-    active: true
-    ignoreOverridden: false
-    ignoreUsageInGenerics: false
-  FunctionOnlyReturningConstant:
-    active: true
-    ignoreOverridableFunction: true
-    ignoreActualFunction: true
-    excludedFunctions: [ ]
-  LoopWithTooManyJumpStatements:
-    active: true
-    maxJumpCount: 1
-  MagicNumber:
-    active: true
-    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**', '**/*.kts' ]
-    ignoreNumbers:
-      - '-1'
-      - '0'
-      - '1'
-      - '2'
-    ignoreHashCodeFunction: true
-    ignorePropertyDeclaration: false
-    ignoreLocalVariableDeclaration: false
-    ignoreConstantDeclaration: true
-    ignoreCompanionObjectPropertyDeclaration: true
-    ignoreAnnotation: false
-    ignoreNamedArgument: true
-    ignoreEnums: false
-    ignoreRanges: false
-    ignoreExtensionFunctions: true
-  MandatoryBracesLoops:
-    active: false
-  MaxChainedCallsOnSameLine:
-    active: false
-    maxChainedCalls: 5
-  MaxLineLength:
-    active: false # done in ktlint
-    maxLineLength: 140 # default is 120. 140 to match ktlint
-    excludePackageStatements: true
-    excludeImportStatements: true
-    excludeCommentStatements: false
-    excludeRawStrings: true
-  MayBeConst:
-    active: true
-  ModifierOrder:
-    active: true
-  MultilineLambdaItParameter:
-    active: false
-  MultilineRawStringIndentation:
-    active: false
-    indentSize: 4
-    trimmingMethods:
-      - 'trimIndent'
-      - 'trimMargin'
-  NestedClassesVisibility:
-    active: true
-  NewLineAtEndOfFile:
-    active: false # done in ktlint
-  NoTabs:
-    active: false
-  NullableBooleanCheck:
-    active: false
-  ObjectLiteralToLambda:
-    active: true
-  OptionalAbstractKeyword:
-    active: true
-  OptionalUnit:
-    active: false
-  PreferToOverPairSyntax:
-    active: false
-  ProtectedMemberInFinalClass:
-    active: true
-  RedundantExplicitType:
-    active: false
-  RedundantHigherOrderMapUsage:
-    active: true
-  RedundantVisibilityModifierRule:
-    active: false
-  ReturnCount:
-    active: true
-    max: 2
-    excludedFunctions:
-      - 'equals'
-    excludeLabeled: false
-    excludeReturnFromLambda: true
-    excludeGuardClauses: false
-  SafeCast:
-    active: true
-  SerialVersionUIDInSerializableClass:
-    active: true
-  SpacingBetweenPackageAndImports:
-    active: false
-  StringShouldBeRawString:
-    active: false
-    maxEscapedCharacterCount: 2
-    ignoredCharacters: [ ]
-  ThrowsCount:
-    active: true
-    max: 2
-    excludeGuardClauses: false
-  TrailingWhitespace:
-    active: false
-  TrimMultilineRawString:
-    active: false
-    trimmingMethods:
-      - 'trimIndent'
-      - 'trimMargin'
-  UnderscoresInNumericLiterals:
-    active: false
-    acceptableLength: 4
-    allowNonStandardGrouping: false
-  UnnecessaryAbstractClass:
-    active: true
-  UnnecessaryAnnotationUseSiteTarget:
-    active: false
-  UnnecessaryApply:
-    active: true
-  UnnecessaryBackticks:
-    active: false
-  UnnecessaryBracesAroundTrailingLambda:
-    active: false
-  UnnecessaryFilter:
-    active: true
-  UnnecessaryInheritance:
-    active: true
-  UnnecessaryInnerClass:
-    active: false
-  UnnecessaryLet:
-    active: false
-  UnnecessaryParentheses:
-    active: false
-    allowForUnclearPrecedence: false
-  UntilInsteadOfRangeTo:
-    active: false
-  UnusedImports:
-    active: false
-  UnusedParameter:
-    active: true
-    allowedNames: 'ignored|expected'
-  UnusedPrivateClass:
-    active: true
-  UnusedPrivateMember:
-    active: true
-    allowedNames: ''
-  UnusedPrivateProperty:
-    active: true
-    allowedNames: '_|ignored|expected|serialVersionUID'
-    excludes: [ '**/build.gradle.kts' ]
-  UseAnyOrNoneInsteadOfFind:
-    active: true
-  UseArrayLiteralsInAnnotations:
-    active: true
-  UseCheckNotNull:
-    active: true
-  UseCheckOrError:
-    active: true
-  UseDataClass:
-    active: false
-    allowVars: false
-  UseEmptyCounterpart:
-    active: false
-  UseIfEmptyOrIfBlank:
-    active: false
-  UseIfInsteadOfWhen:
-    active: false
-    ignoreWhenContainingVariableDeclaration: false
-  UseIsNullOrEmpty:
-    active: true
-  UseLet:
-    active: false
-  UseOrEmpty:
-    active: true
-  UseRequire:
-    active: true
-  UseRequireNotNull:
-    active: true
-  UseSumOfInsteadOfFlatMapSize:
-    active: false
-  UselessCallOnNotNull:
-    active: true
-  UtilityClassWithPublicConstructor:
-    active: true
-  VarCouldBeVal:
-    active: true
-    ignoreLateinitVar: false
-  WildcardImport:
-    active: true
-    excludeImports:
-      - 'java.util.*'
--- a/fastlane/metadata/android/en-US/changelogs/v125010111.txt
+++ b/fastlane/metadata/android/en-US/changelogs/v125010111.txt
@@ -1,4 +0,0 @@
-**v125010111**
-
- Debug trying to fix context issues. (#174)
- Changelog for v125010031
--- a/shared/src/androidMain/kotlin/bou/amine/apps/readerforselfossv2/rest/NetworkSSL.kt
+++ b/shared/src/androidMain/kotlin/bou/amine/apps/readerforselfossv2/rest/NetworkSSL.kt
@@ -9,14 +9,12 @@ class NaiveTrustManager : X509TrustManager {
        chain: Array<out X509Certificate>?,
        authType: String?,
    ) {
-        // Nothing
    }

    override fun checkServerTrusted(
        chain: Array<out X509Certificate>?,
        authType: String?,
    ) {
-        // Nothing
    }

    override fun getAcceptedIssuers(): Array<out X509Certificate> = arrayOf()
--- a/shared/src/androidMain/kotlin/bou/amine/apps/readerforselfossv2/utils/DateUtils.kt
+++ b/shared/src/androidMain/kotlin/bou/amine/apps/readerforselfossv2/utils/DateUtils.kt
@@ -3,7 +3,6 @@ package bou.amine.apps.readerforselfossv2.utils
 import android.text.format.DateUtils
 import kotlinx.datetime.Clock

-@Suppress("detekt:UtilityClassWithPublicConstructor")
 actual class DateUtils {
    actual companion object {
        actual fun parseRelativeDate(dateString: String): String {
--- a/shared/src/androidMain/kotlin/bou/amine/apps/readerforselfossv2/utils/ModelConverters.kt
+++ b/shared/src/androidMain/kotlin/bou/amine/apps/readerforselfossv2/utils/ModelConverters.kt
@@ -12,14 +12,16 @@ actual fun SelfossModel.Item.getIcon(baseUrl: String): String = constructUrl(bas

 actual fun SelfossModel.Item.getThumbnail(baseUrl: String): String = constructUrl(baseUrl, "thumbnails", thumbnail)

-val IMAGE_EXTENSION_REGEXP = """\.(jpg|jpeg|png|webp)""".toRegex()
-
 actual fun SelfossModel.Item.getImages(): ArrayList<String> {
    val allImages = ArrayList<String>()

    for (image in Jsoup.parse(content).getElementsByTag("img")) {
        val url = image.attr("src")
-        if (IMAGE_EXTENSION_REGEXP.containsMatchIn(url.lowercase(Locale.US))) {
+        if (url.lowercase(Locale.US).contains(".jpg") ||
+            url.lowercase(Locale.US).contains(".jpeg") ||
+            url.lowercase(Locale.US).contains(".png") ||
+            url.lowercase(Locale.US).contains(".webp")
+        ) {
            allImages.add(url)
        }
    }
--- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/model/MercuryModel.kt
+++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/model/MercuryModel.kt
@@ -1,16 +1,13 @@
-@file:Suppress("detekt:LongParameterList")
-
 package bou.amine.apps.readerforselfossv2.model

 import kotlinx.serialization.Serializable

 class MercuryModel {
-    @Suppress("detekt:ConstructorParameterNaming")
    @Serializable
    class ParsedContent(
        val title: String? = null,
        val content: String? = null,
-        val lead_image_url: String? = null,
+        val lead_image_url: String? = null, // NOSONAR
        val url: String? = null,
        val error: Boolean? = null,
        val message: String? = null,
--- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/model/SelfossModel.kt
+++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/model/SelfossModel.kt
@@ -1,5 +1,3 @@
-@file:Suppress("detekt:LongParameterList")
-
 package bou.amine.apps.readerforselfossv2.model

 import bou.amine.apps.readerforselfossv2.utils.DateUtils
@@ -20,10 +18,6 @@ import kotlinx.serialization.json.booleanOrNull
 import kotlinx.serialization.json.int
 import kotlinx.serialization.json.jsonPrimitive

-class ModelException(
-    message: String,
-) : Throwable(message)
-
 class SelfossModel {
    @Serializable
    data class Tag(
@@ -147,7 +141,7 @@ class SelfossModel {
            }

            if (stringUrl.isEmptyOrNullOrNullString()) {
-                throw ModelException("Link $link was translated to $stringUrl, but was empty. Handle this.")
+                throw Exception("Link $link was translated to $stringUrl, but was empty. Handle this.")
            }

            return stringUrl
@@ -176,7 +170,7 @@ class SelfossModel {
        }
    }

-    // this seems to be super slow.
+    // TODO: this seems to be super slow.
    object TagsListSerializer : KSerializer<List<String>> {
        override fun deserialize(decoder: Decoder): List<String> =
            when (val json = ((decoder as JsonDecoder).decodeJsonElement())) {
--- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/Repository.kt
+++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/Repository.kt
@@ -1,5 +1,3 @@
-@file:Suppress("detekt:TooManyFunctions")
-
 package bou.amine.apps.readerforselfossv2.repository

 import bou.amine.apps.readerforselfossv2.dao.ACTION
@@ -25,8 +23,6 @@ import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.flow.asStateFlow
 import kotlinx.coroutines.launch

-private const val MAX_ITEMS_NUMBER = 200
-
 class Repository(
    private val api: SelfossApi,
    private val appSettingsService: AppSettingsService,
@@ -131,7 +127,7 @@ class Repository(
                    null,
                    null,
                    null,
-                    MAX_ITEMS_NUMBER,
+                    200,
                )
            return if (items.success && items.data != null) {
                items.data
@@ -143,7 +139,6 @@ class Repository(
        }
    }

-    @Suppress("detekt:ForbiddenComment")
    suspend fun reloadBadges(): Boolean {
        var success = false
        if (isNetworkAvailable()) {
@@ -564,7 +559,6 @@ class Repository(
            item.id.toString(),
        )

-    @Suppress("detekt:SwallowedException")
    suspend fun tryToCacheItemsAndGetNewOnes(): List<SelfossModel.Item> {
        try {
            val newItems = getMaxItemsForBackground(ItemType.UNREAD)
--- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/rest/RestUtils.kt
+++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/rest/RestUtils.kt
@@ -33,7 +33,6 @@ suspend fun maybeResponse(r: HttpResponse?): SuccessResponse =
        SuccessResponse(false)
    }

-@Suppress("detekt:SwallowedException")
 suspend inline fun <reified T> bodyOrFailure(r: HttpResponse?): StatusAndData<T> {
    try {
        return if (r != null && r.status.isSuccess()) {
--- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/rest/SelfossApi.kt
+++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/rest/SelfossApi.kt
@@ -1,5 +1,3 @@
-@file:Suppress("detekt:TooManyFunctions", "detekt:LongParameterList", "detekt:LargeClass")
-
 package bou.amine.apps.readerforselfossv2.rest

 import bou.amine.apps.readerforselfossv2.model.SelfossModel
@@ -37,8 +35,6 @@ import kotlinx.serialization.json.Json

 expect fun setupInsecureHttpEngine(config: CIOEngineConfig)

-private const val VERSION_WHERE_POST_LOGIN_SHOULD_WORK = 5
-
 class SelfossApi(
    private val appSettingsService: AppSettingsService,
 ) {
@@ -180,7 +176,7 @@ class SelfossApi(
            },
        )

-    private fun shouldHaveNewLogout() = appSettingsService.getApiVersion() >= VERSION_WHERE_POST_LOGIN_SHOULD_WORK // We are missing 4.1.0
+    private fun shouldHaveNewLogout() = appSettingsService.getApiVersion() >= 5 // We are missing 4.1.0

    suspend fun logout(): SuccessResponse =
        if (shouldHaveNewLogout()) {
--- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/service/ACRASettings.kt
+++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/service/ACRASettings.kt
@@ -1,5 +1,3 @@
-@file:Suppress("detekt:TooManyFunctions")
-
 package bou.amine.apps.readerforselfossv2.service

 import com.russhwolf.settings.Settings
--- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/service/AppSettingsService.kt
+++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/service/AppSettingsService.kt
@@ -1,19 +1,7 @@
-@file:Suppress("detekt:TooManyFunctions")
-
 package bou.amine.apps.readerforselfossv2.service

 import com.russhwolf.settings.Settings

-private const val DEFAULT_FONT_SIZE = 16
-
-private const val DEFAULT_REFRESH_MINUTES = 360L
-
-private const val MIN_REFRESH_MINUTES = 15L
-
-private const val DEFAULT_API_TIMEOUT = 60L
-
-private const val DEFAULT_ITEMS_NUMBER = 20
-
 class AppSettingsService(
    acraSenderServiceProcess: Boolean = false,
 ) {
@@ -48,7 +36,7 @@ class AppSettingsService(
    private var notifyNewItems: Boolean? = null
    private var itemsNumber: Int? = null
    private var apiTimeout: Long? = null
-    private var refreshMinutes: Long = DEFAULT_REFRESH_MINUTES
+    private var refreshMinutes: Long = 360
    private var markOnScroll: Boolean? = null
    private var activeAlignment: Int? = null

@@ -153,14 +141,13 @@ class AppSettingsService(
        return itemsNumber!!
    }

-    @Suppress("detekt:SwallowedException")
    private fun refreshItemsNumber() {
        itemsNumber =
            try {
-                settings.getString(API_ITEMS_NUMBER, DEFAULT_ITEMS_NUMBER.toString()).toInt()
+                settings.getString(API_ITEMS_NUMBER, "20").toInt()
            } catch (e: Exception) {
                settings.remove(API_ITEMS_NUMBER)
-                DEFAULT_ITEMS_NUMBER
+                20
            }
    }

@@ -171,24 +158,22 @@ class AppSettingsService(
        return apiTimeout!!
    }

-    @Suppress("detekt:MagicNumber")
    private fun secToMs(n: Long) = n * 1000

-    @Suppress("detekt:SwallowedException")
    private fun refreshApiTimeout() {
        apiTimeout =
            secToMs(
                try {
-                    val settingsTimeout = settings.getString(API_TIMEOUT, DEFAULT_API_TIMEOUT.toString())
+                    val settingsTimeout = settings.getString(API_TIMEOUT, "60")
                    if (settingsTimeout.toLong() > 0) {
                        settingsTimeout.toLong()
                    } else {
                        settings.remove(API_TIMEOUT)
-                        DEFAULT_API_TIMEOUT
+                        60
                    }
                } catch (e: Exception) {
                    settings.remove(API_TIMEOUT)
-                    DEFAULT_API_TIMEOUT
+                    60
                },
            )
    }
@@ -302,14 +287,14 @@ class AppSettingsService(
    }

    private fun refreshRefreshMinutes() {
-        refreshMinutes = settings.getString(PERIODIC_REFRESH_MINUTES, DEFAULT_REFRESH_MINUTES.toString()).toLong()
-        if (refreshMinutes <= MIN_REFRESH_MINUTES) {
-            refreshMinutes = MIN_REFRESH_MINUTES
+        refreshMinutes = settings.getString(PERIODIC_REFRESH_MINUTES, "360").toLong()
+        if (refreshMinutes <= 15) {
+            refreshMinutes = 15
        }
    }

    fun getRefreshMinutes(): Long {
-        if (refreshMinutes != DEFAULT_REFRESH_MINUTES) {
+        if (refreshMinutes != 360L) {
            refreshRefreshMinutes()
        }
        return refreshMinutes
@@ -383,7 +368,7 @@ class AppSettingsService(
        if (fontSize != null) {
            refreshFontSize()
        }
-        return fontSize ?: DEFAULT_FONT_SIZE
+        return fontSize ?: 16
    }

    private fun refreshStaticBarEnabled() {
--- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/utils/DateUtils.kt
+++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/utils/DateUtils.kt
@@ -4,12 +4,6 @@ import kotlinx.datetime.LocalDateTime
 import kotlinx.datetime.TimeZone
 import kotlinx.datetime.toInstant

-class DateParseException(
-    message: String,
-    e: Throwable? = null,
-) : Throwable(message, e)
-
-@Suppress("detekt:ThrowsCount")
 fun String.toParsedDate(): Long {
    // Possible formats are
    // yyyy-mm-dd hh:mm:ss format
@@ -27,18 +21,17 @@ fun String.toParsedDate(): Long {
                    .find(this)
                    ?.groups
                    ?.get(1)
-                    ?.value ?: throw DateParseException("Couldn't parse $this")
+                    ?.value ?: throw Exception("Couldn't parse $this")
            } else {
-                throw DateParseException("Unrecognized format for $this")
+                throw Exception("Unrecognized format for $this")
            }
        } catch (e: Exception) {
-            throw DateParseException("parseDate failed for $this", e)
+            throw Exception("parseDate failed for $this", e)
        }

    return LocalDateTime.parse(isoDateString).toInstant(TimeZone.currentSystemDefault()).toEpochMilliseconds()
 }

-@Suppress("detekt:UtilityClassWithPublicConstructor")
 expect class DateUtils() {
    companion object {
        fun parseRelativeDate(dateString: String): String
--- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/utils/EntityUtils.kt
+++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/utils/EntityUtils.kt
@@ -17,7 +17,7 @@ fun SOURCE.toView(): SelfossModel.SourceDetail =
        this.id.toInt(),
        this.title,
        null,
-        this.tags.split(","),
+        this.tags?.split(","),
        this.spout,
        this.error,
        this.icon,
@@ -74,7 +74,6 @@ fun SelfossModel.Item.toEntity(): ITEM =
        this.author,
    )

-@Suppress("detekt:MagicNumber")
 fun SelfossModel.Tag.getColorHexCode(): String =
    if (this.color.length == 4) { // #000
        val char1 = this.color.get(1)
--- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/utils/ItemType.kt
+++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/utils/ItemType.kt
@@ -1,6 +1,5 @@
 package bou.amine.apps.readerforselfossv2.utils

-@Suppress("detekt:MagicNumber")
 enum class ItemType(
    val position: Int,
    val type: String,
--- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/utils/StringUtils.kt
+++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/utils/StringUtils.kt
@@ -2,7 +2,6 @@ package bou.amine.apps.readerforselfossv2.utils

 fun String?.isEmptyOrNullOrNullString(): Boolean = this == null || this == "null" || this.isEmpty()

-@Suppress("detekt:MagicNumber")
 fun String.longHash(): Long {
    var h = 98764321261L
    val l = this.length
--- a/shared/src/commonTest/kotlin/bou/amine/apps/readerforselfossv2/repository/DatesTest.kt
+++ b/shared/src/commonTest/kotlin/bou/amine/apps/readerforselfossv2/repository/DatesTest.kt
--- a/shared/src/iosArm64Main/kotlin/bou/amine/apps/readerforselfossv2/rest/SetupInsecureHttpEngine.kt
+++ b/shared/src/iosArm64Main/kotlin/bou/amine/apps/readerforselfossv2/rest/SetupInsecureHttpEngine.kt
@@ -2,6 +2,5 @@ package bou.amine.apps.readerforselfossv2.rest

 import io.ktor.client.engine.cio.CIOEngineConfig

-@Suppress("detekt:EmptyFunctionBlock")
 actual fun setupInsecureHttpEngine(config: CIOEngineConfig) {
 }
--- a/shared/src/iosArm64Main/kotlin/bou/amine/apps/readerforselfossv2/utils/DateUtils.kt
+++ b/shared/src/iosArm64Main/kotlin/bou/amine/apps/readerforselfossv2/utils/DateUtils.kt
@@ -1,6 +1,5 @@
 package bou.amine.apps.readerforselfossv2.utils

-@Suppress("detekt:UtilityClassWithPublicConstructor")
 actual class DateUtils {
    actual companion object {
        actual fun parseRelativeDate(dateString: String): String {
--- a/shared/src/iosSimulatorArm64Main/kotlin/bou/amine/apps/readerforselfossv2/utils/DateUtils.iosSimulatorArm64.kt
+++ b/shared/src/iosSimulatorArm64Main/kotlin/bou/amine/apps/readerforselfossv2/utils/DateUtils.iosSimulatorArm64.kt
@@ -1,6 +1,5 @@
 package bou.amine.apps.readerforselfossv2.utils

-@Suppress("detekt:UtilityClassWithPublicConstructor")
 actual class DateUtils actual constructor() {
    actual companion object {
        actual fun parseRelativeDate(dateString: String): String {
--- a/shared/src/iosX64Main/kotlin/bou/amine/apps/readerforselfossv2/rest/SetupInsecureHttpEngine.kt
+++ b/shared/src/iosX64Main/kotlin/bou/amine/apps/readerforselfossv2/rest/SetupInsecureHttpEngine.kt
@@ -2,6 +2,5 @@ package bou.amine.apps.readerforselfossv2.rest

 import io.ktor.client.engine.cio.CIOEngineConfig

-@Suppress("detekt:EmptyFunctionBlock")
 actual fun setupInsecureHttpEngine(config: CIOEngineConfig) {
 }
--- a/shared/src/iosX64Main/kotlin/bou/amine/apps/readerforselfossv2/utils/DateUtils.kt
+++ b/shared/src/iosX64Main/kotlin/bou/amine/apps/readerforselfossv2/utils/DateUtils.kt
@@ -1,6 +1,5 @@
 package bou.amine.apps.readerforselfossv2.utils

-@Suppress("detekt:UtilityClassWithPublicConstructor")
 actual class DateUtils {
    actual companion object {
        actual fun parseRelativeDate(dateString: String): String {
Author	SHA1	Message	Date
Amine	4fbebf2954	chore: code style fixes for ktlint Some checks failed Check PR code / Lint (pull_request) Failing after 2m19s Details Check PR code / build (pull_request) Has been skipped Details	2025-01-11 15:23:02 +01:00
Amine	5035392aff	chore: more debug to fix a context issue.	2025-01-11 12:52:55 +01:00