[Dependency] com.github.chrisbanes:PhotoView #121
Labels
No Label
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Louvorg/ReaderForSelfoss-multiplatform#121
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
com.github.chrisbanes:PhotoView
is hosted on jitpack that was down for a few hours recently.Possible choices:
The dependency is used in the image activity to allow zooming and moving the images.
As far as I know, it should be possible to remove the dependency and implement these behavior ourselves, but it would be quite a bit of extra code to take care of.
I'd rather replace or fork the dependency; I'm unsure which one would be the better option: alternatives do exist but the ones I have found are not actively maintained, forking this should be possible but would require some initial work.
As far as I've seen the amount of code is not too vast, but it's all in Java and if we're updating it it would be nice to port it to kotlin. Moreover, I believe this library to be used by several other applications, thus it would probably be necessary to keep all the functionalities available, even if we don't use them.
As you have seen, lately I've been pretty busy and with little time to spare. I doubt I'll be able to take the responsibility to maintain the library soon, but I might do that in some time. I'll let you know after I finish #13, which I thought was finished but I actually found a few issues with the viewpager.
It would be nice to do it, but not necessary. The original version would still be available.
I'll handle the two dependencies issues.
Could you create issues for these problems ?
I mean, the code I implemented to introduce that feature has problems with the viewpager, currently it works flawlessly as far as I've seen.
Ok, I thought there were bugs that weren't reported. Thanks.