[Dependency] com.github.chrisbanes:PhotoView #121

New Issue

2022-12-30T19:25:50Z

AmineB commented

2022-12-30 19:25:50 +00:00

com.github.chrisbanes:PhotoView is hosted on jitpack that was down for a few hours recently.

Possible choices:

remove the dependency (maybe try to see if it's used)
replace the dependency ?
fork and update the dependency ?

`com.github.chrisbanes:PhotoView` is hosted on jitpack that was down for a few hours recently. Possible choices: - remove the dependency (maybe try to see if it's used) - replace the dependency ? - fork and update the dependency ?

AmineB added the Priority = Low Type = Chore labels 2022-12-30 19:25:50 +00:00

davidoskky commented

2023-01-04 10:36:02 +00:00

The dependency is used in the image activity to allow zooming and moving the images.
As far as I know, it should be possible to remove the dependency and implement these behavior ourselves, but it would be quite a bit of extra code to take care of.
I'd rather replace or fork the dependency; I'm unsure which one would be the better option: alternatives do exist but the ones I have found are not actively maintained, forking this should be possible but would require some initial work.
As far as I've seen the amount of code is not too vast, but it's all in Java and if we're updating it it would be nice to port it to kotlin. Moreover, I believe this library to be used by several other applications, thus it would probably be necessary to keep all the functionalities available, even if we don't use them.

As you have seen, lately I've been pretty busy and with little time to spare. I doubt I'll be able to take the responsibility to maintain the library soon, but I might do that in some time. I'll let you know after I finish #13, which I thought was finished but I actually found a few issues with the viewpager.

The dependency is used in the image activity to allow zooming and moving the images. As far as I know, it should be possible to remove the dependency and implement these behavior ourselves, but it would be quite a bit of extra code to take care of. I'd rather replace or fork the dependency; I'm unsure which one would be the better option: alternatives do exist but the ones I have found are not actively maintained, forking this should be possible but would require some initial work. As far as I've seen the amount of code is not too vast, but it's all in Java and if we're updating it it would be nice to port it to kotlin. Moreover, I believe this library to be used by several other applications, thus it would probably be necessary to keep all the functionalities available, even if we don't use them. As you have seen, lately I've been pretty busy and with little time to spare. I doubt I'll be able to take the responsibility to maintain the library soon, but I might do that in some time. I'll let you know after I finish #13, which I thought was finished but I actually found a few issues with the viewpager.

AmineB commented

2023-01-04 10:41:26 +00:00

thus it would probably be necessary to keep all the functionalities available, even if we don't use them.

It would be nice to do it, but not necessary. The original version would still be available.

I doubt I'll be able to take the responsibility to maintain the library soon, but I might do that in some time.

I'll handle the two dependencies issues.

but I actually found a few issues with the viewpager.

Could you create issues for these problems ?

> thus it would probably be necessary to keep all the functionalities available, even if we don't use them. It would be nice to do it, but not necessary. The original version would still be available. > I doubt I'll be able to take the responsibility to maintain the library soon, but I might do that in some time. I'll handle the two dependencies issues. > but I actually found a few issues with the viewpager. Could you create issues for these problems ?

👍 1

AmineB self-assigned this 2023-01-04 10:41:32 +00:00

davidoskky commented

2023-01-04 10:43:34 +00:00

Could you create issues for these problems ?

I mean, the code I implemented to introduce that feature has problems with the viewpager, currently it works flawlessly as far as I've seen.

> Could you create issues for these problems ? I mean, the code I implemented to introduce that feature has problems with the viewpager, currently it works flawlessly as far as I've seen.

AmineB commented

2023-01-04 10:45:05 +00:00

Ok, I thought there were bugs that weren't reported. Thanks.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#121