Close images swiping up or down #13
Labels
No Label
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Louvorg/ReaderForSelfoss-multiplatform#13
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Prerequisites
CONTRIBUTING
guide ?Description
In the article reader, tapping on a picture opens it in full screen.
To return to the article two actions are possible:
The first action is inconvenient due to the position, which is far away from the lower right which is where most people hold the phone one handed.
The second action is much more convenient, but still requires the movement of the thumb from the center of the screen to the lower right.
In landscape mode, action 1 results easier if holding the phone from the left or two handed while action 2 is more difficult.
Adding one extra action to close the image would ease the use of the application.
Swiping full screen images up or down to close them is widespread among other applications and could thus be a good candidate.
This methodology works equally well when holding the phone from the left or from the right, both in landscape and portrait mode; it can be used two handed as well.
I'll be working on this.
I have this ready and working, but it's using a library which is not updated since a while.
This is the library in question https://github.com/liuguangqiang/SwipeBack
I'm not sure using such an old library is a good idea since there may be problems with newer versions of android.
I'll be looking for an alternative library but I didn't find any at the moment.
Alternatively, I may fork this library and keep it updated; in this way we would also be able to change the behaviour in order to keep it consistent with the iOS implementation.
I would prefer if we didn't add a library just for this feature.
Can't it be done without one ? Even if there isn't any animation ?
Oh, replying by email doesn't work.
Yes, I can do it without library but without animation.
It's probably much better than including that questionable library.
@davidoskky is there any update on this ?
Hey @AmineL, I'm sorry as I've been pretty busy lately.
If I'm not mistaken this is pretty much ready, I'll take a look in the next few days and send a PR.
@davidoskky thanks for the update.
Keep me posted !