Close images swiping up or down #13

New Issue

AmineL · 2022-07-24T08:55:07Z

AmineL commented

2022-07-24 08:55:07 +00:00

Prerequisites

Are you running the latest version?
Did you check for an existing issue ?
Are you reporting to the correct repository?
Did you perform a cursory search?
Did you read the CONTRIBUTING guide ?

Description

In the article reader, tapping on a picture opens it in full screen.
To return to the article two actions are possible:

Tap the back button on the top left corner
Use the phone back button

The first action is inconvenient due to the position, which is far away from the lower right which is where most people hold the phone one handed.
The second action is much more convenient, but still requires the movement of the thumb from the center of the screen to the lower right.
In landscape mode, action 1 results easier if holding the phone from the left or two handed while action 2 is more difficult.

Adding one extra action to close the image would ease the use of the application.
Swiping full screen images up or down to close them is widespread among other applications and could thus be a good candidate.
This methodology works equally well when holding the phone from the left or from the right, both in landscape and portrait mode; it can be used two handed as well.

### Prerequisites * [x] Are you running the latest version? * [x] Did you check for an existing issue ? * [x] Are you reporting to the correct repository? * [x] Did you perform a cursory search? * [x] Did you read the `CONTRIBUTING` guide ? ### Description In the article reader, tapping on a picture opens it in full screen. To return to the article two actions are possible: 1. Tap the back button on the top left corner 2. Use the phone back button The first action is inconvenient due to the position, which is far away from the lower right which is where most people hold the phone one handed. The second action is much more convenient, but still requires the movement of the thumb from the center of the screen to the lower right. In landscape mode, action 1 results easier if holding the phone from the left or two handed while action 2 is more difficult. Adding one extra action to close the image would ease the use of the application. Swiping full screen images up or down to close them is widespread among other applications and could thus be a good candidate. This methodology works equally well when holding the phone from the left or from the right, both in landscape and portrait mode; it can be used two handed as well.

AmineL added the

labels 2022-07-24 08:55:07 +00:00

AmineL added this to the A little better milestone 2022-09-13 14:35:20 +00:00

AmineL added this to the Dev project 2022-09-13 14:35:22 +00:00

AmineL removed this from the Dev project 2022-09-13 14:44:50 +00:00

davidoskky commented

2022-10-17 12:42:35 +00:00

I'll be working on this.

👍 1

AmineL added this to the Dev project 2022-11-02 19:07:45 +00:00

davidoskky commented

2022-11-11 14:31:46 +00:00

I have this ready and working, but it's using a library which is not updated since a while.
This is the library in question https://github.com/liuguangqiang/SwipeBack

I'm not sure using such an old library is a good idea since there may be problems with newer versions of android.
I'll be looking for an alternative library but I didn't find any at the moment.
Alternatively, I may fork this library and keep it updated; in this way we would also be able to change the behaviour in order to keep it consistent with the iOS implementation.

I have this ready and working, but it's using a library which is not updated since a while. This is the library in question https://github.com/liuguangqiang/SwipeBack I'm not sure using such an old library is a good idea since there may be problems with newer versions of android. I'll be looking for an alternative library but I didn't find any at the moment. Alternatively, I may fork this library and keep it updated; in this way we would also be able to change the behaviour in order to keep it consistent with the iOS implementation.

AmineL commented

2022-11-11 19:33:43 +00:00

I would prefer if we didn't add a library just for this feature.

Can't it be done without one ? Even if there isn't any animation ?

I would prefer if we didn't add a library just for this feature. Can't it be done without one ? Even if there isn't any animation ?

davidoskky commented

2022-11-13 12:54:11 +00:00

Oh, replying by email doesn't work.
Yes, I can do it without library but without animation.
It's probably much better than including that questionable library.

Oh, replying by email doesn't work. Yes, I can do it without library but without animation. It's probably much better than including that questionable library.

AmineL modified the milestone from A little better to Version 2

2022-11-17 19:51:55 +00:00

AmineL removed this from the Dev project 2022-11-17 19:51:58 +00:00

AmineL commented

2022-12-11 19:41:01 +00:00

@davidoskky is there any update on this ?

davidoskky commented

2022-12-13 20:51:55 +00:00

Hey @AmineL, I'm sorry as I've been pretty busy lately.
If I'm not mistaken this is pretty much ready, I'll take a look in the next few days and send a PR.

Hey @AmineL, I'm sorry as I've been pretty busy lately. If I'm not mistaken this is pretty much ready, I'll take a look in the next few days and send a PR.

AmineL commented

2022-12-14 19:28:34 +00:00

@davidoskky thanks for the update.

Keep me posted !

@davidoskky thanks for the update. Keep me posted !

davidoskky referenced this issue

2023-01-04 10:36:03 +00:00

[Dependency] com.github.chrisbanes:PhotoView #121

davidoskky referenced this issue

2023-01-11 21:16:10 +00:00

Swipe down to close images #122

AmineL closed this issue