Louvorg/ReaderForSelfoss-multiplatform
Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 9 Pull Requests 1 Actions Releases 81 Wiki Activity

Show a confirmation dialog before deleting sources #185

Merged
AmineB merged 4 commits from davidoskky/ReaderForSelfoss-multiplatform:delete_sources_safe into master 2025-03-09 13:49:33 +00:00
Conversation 2 Commits 4 Files Changed 17 +104 -55
davidoskky commented 2025-03-03 17:39:53 +00:00
Contributor
Copy Link

Types of changes

  • [ x ] I have read the CONTRIBUTING document.
  • [ x ] My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • [ x ] All new and existing tests passed.
  • [ x ] This is NOT translation related.

This is implements feature #156

I added a confirmation dialogue which pops up after tapping the delete source button. The popup displays the full name of the source to be deleted and allows the user to decide not to delete the source to prevent erroneous deletions.

I moved most of the logic into the viewholder. Can be easily reverted if you prefer.

All tests pass. I tested correct behavior in emulated versions of android API 25, 34 and 35.

## Types of changes - [ x ] I have read the **CONTRIBUTING** document. - [ x ] My code follows the code style of this project. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [ x ] All new and existing tests passed. - [ x ] This is **NOT** translation related. This is implements feature #156 I added a confirmation dialogue which pops up after tapping the delete source button. The popup displays the full name of the source to be deleted and allows the user to decide not to delete the source to prevent erroneous deletions. I moved most of the logic into the viewholder. Can be easily reverted if you prefer. All tests pass. I tested correct behavior in emulated versions of android API 25, 34 and 35.
davidoskky added 2 commits 2025-03-03 17:39:54 +00:00 
A popup appears after tapping the delete source button with the name of the source.
Move binding source binding logic to the viewholder.
Some checks failed
Check PR code / Lint (pull_request) Failing after 3m38s
Details
Check PR code / build (pull_request) Has been skipped
Details
ba4b27651b
davidoskky added 1 commit 2025-03-09 11:43:00 +00:00
Fix Ktlint warnings
Some checks failed
Check PR code / Lint (pull_request) Successful in 3m6s
Details
Check PR code / build (pull_request) Failing after 8m33s
Details
43146b5aff
davidoskky commented 2025-03-09 12:06:09 +00:00
Author
Contributor
Copy Link

Do I have to add the new string to all translations string xml files?
Build appears to fail because of that, but if I correctly remember doing that created conflicts with the tranlsations service.

Do I have to add the new string to all translations string xml files? Build appears to fail because of that, but if I correctly remember doing that created conflicts with the tranlsations service.
AmineB commented 2025-03-09 12:55:56 +00:00
Owner
Copy Link

Hi, thanks for the lint fixes.
I fixed the translation issues.

Hi, thanks for the lint fixes. I fixed the translation issues.
👍 1
AmineB added 1 commit 2025-03-09 12:57:06 +00:00
chore: translations.
All checks were successful
Check PR code / Lint (pull_request) Successful in 2m29s
Details
Check PR code / build (pull_request) Successful in 9m40s
Details
cdf4ece99c
AmineB merged commit a1c0241a58 into master 2025-03-09 13:49:33 +00:00
AmineB deleted branch delete_sources_safe 2025-03-09 13:49:33 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
AmineB giteadrone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#185
No description provided.
Delete Branch "davidoskky/ReaderForSelfoss-multiplatform:delete_sources_safe"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?