Show a confirmation dialog before deleting sources #185

2025-03-03T17:39:53Z

davidoskky commented

2025-03-03 17:39:53 +00:00

Types of changes

[ x ] I have read the CONTRIBUTING document.
[ x ] My code follows the code style of this project.
I have updated the documentation accordingly.
I have added tests to cover my changes.
[ x ] All new and existing tests passed.
[ x ] This is NOT translation related.

This is implements feature #156

I added a confirmation dialogue which pops up after tapping the delete source button. The popup displays the full name of the source to be deleted and allows the user to decide not to delete the source to prevent erroneous deletions.

I moved most of the logic into the viewholder. Can be easily reverted if you prefer.

All tests pass. I tested correct behavior in emulated versions of android API 25, 34 and 35.

## Types of changes - [ x ] I have read the **CONTRIBUTING** document. - [ x ] My code follows the code style of this project. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [ x ] All new and existing tests passed. - [ x ] This is **NOT** translation related. This is implements feature #156 I added a confirmation dialogue which pops up after tapping the delete source button. The popup displays the full name of the source to be deleted and allows the user to decide not to delete the source to prevent erroneous deletions. I moved most of the logic into the viewholder. Can be easily reverted if you prefer. All tests pass. I tested correct behavior in emulated versions of android API 25, 34 and 35.

davidoskky added 2 commits 2025-03-03 17:39:54 +00:00

Add a confirmation when deleting a source 3ad2ad402f

A popup appears after tapping the delete source button with the name of the source.

Move binding source binding logic to the viewholder.

Check PR code / Lint (pull_request) Failing after 3m38s

Details

Check PR code / build (pull_request) Has been skipped

Details

ba4b27651b

davidoskky added 1 commit 2025-03-09 11:43:00 +00:00

Fix Ktlint warnings

Check PR code / Lint (pull_request) Successful in 3m6s

Details

Check PR code / build (pull_request) Failing after 8m33s

Details

43146b5aff

davidoskky commented

2025-03-09 12:06:09 +00:00

Do I have to add the new string to all translations string xml files?
Build appears to fail because of that, but if I correctly remember doing that created conflicts with the tranlsations service.

Do I have to add the new string to all translations string xml files? Build appears to fail because of that, but if I correctly remember doing that created conflicts with the tranlsations service.

AmineB commented

2025-03-09 12:55:56 +00:00

Hi, thanks for the lint fixes.
I fixed the translation issues.

Hi, thanks for the lint fixes. I fixed the translation issues.

👍 1

AmineB added 1 commit 2025-03-09 12:57:06 +00:00

chore: translations.

Check PR code / Lint (pull_request) Successful in 2m29s

Details

Check PR code / build (pull_request) Successful in 9m40s

Details

cdf4ece99c