Louvorg/ReaderForSelfoss-multiplatform
3
2 Fork 2
Code Issues 7 Pull Requests 2 Actions Releases 84 Wiki Activity

Pressing back in setting goes back to home #47

New Issue
Closed
opened 2022-08-28 22:14:50 +00:00 by davidoskky · 2 comments
davidoskky commented 2022-08-28 22:14:50 +00:00
Contributor
Copy Link
Copy Source

Steps to Reproduce

  1. Open the settings
  2. Open general settings
  3. Tap the back arrow on the upper left
  4. You're taken back to the home screen rather than the settings selection screen
### Steps to Reproduce 1. Open the settings 2. Open general settings 3. Tap the back arrow on the upper left 4. You're taken back to the home screen rather than the settings selection screen
AmineB commented 2022-08-29 13:21:03 +00:00
Owner
Copy Link
Copy Source

This was introduced when I added this and this.

I needed to know when a user was coming back from the settings activity, and needed to add this, else, the onActivityResult code was not called.

This could be tricky.

This was introduced when I added [this](https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/src/branch/master/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/HomeActivity.kt#L370) and [this](https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/src/branch/master/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/HomeActivity.kt#L950). I needed to know when a user was coming back from the settings activity, and needed to add [this](https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/src/branch/master/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/settings/SettingsActivity.kt#L220), else, the `onActivityResult` code was not called. This could be tricky.
davidoskky commented 2022-08-30 07:30:43 +00:00
Author
Contributor
Copy Link
Copy Source

Ok, I see the issue...
I'm currently busy restructuring a flat.
If I find some free time I'll take a look at that.

Ok, I see the issue... I'm currently busy restructuring a flat. If I find some free time I'll take a look at that.
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
AmineB (Amine Bouabdallaoui)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#47