Pressing back in setting goes back to home #47

New Issue

davidoskky · 2022-08-28T22:14:50Z

davidoskky commented

2022-08-28 22:14:50 +00:00

Steps to Reproduce

Open the settings
Open general settings
Tap the back arrow on the upper left
You're taken back to the home screen rather than the settings selection screen

### Steps to Reproduce 1. Open the settings 2. Open general settings 3. Tap the back arrow on the upper left 4. You're taken back to the home screen rather than the settings selection screen

AmineB commented

2022-08-29 13:21:03 +00:00

This was introduced when I added this and this.

I needed to know when a user was coming back from the settings activity, and needed to add this, else, the onActivityResult code was not called.

This could be tricky.

This was introduced when I added [this](https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/src/branch/master/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/HomeActivity.kt#L370) and [this](https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/src/branch/master/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/HomeActivity.kt#L950). I needed to know when a user was coming back from the settings activity, and needed to add [this](https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/src/branch/master/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/settings/SettingsActivity.kt#L220), else, the `onActivityResult` code was not called. This could be tricky.

davidoskky commented

2022-08-30 07:30:43 +00:00

Ok, I see the issue...
I'm currently busy restructuring a flat.
If I find some free time I'll take a look at that.

Ok, I see the issue... I'm currently busy restructuring a flat. If I find some free time I'll take a look at that.

👍 1

davidoskky referenced this issue

2022-09-06 10:30:46 +00:00

Correctly handle the back button in settings #48

AmineB closed this issue

2022-09-06 18:20:50 +00:00

Sign in to join this conversation.