Louvorg/ReaderForSelfoss-multiplatform
Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 11 Pull Requests Actions Releases 75 Wiki Activity

Correctly handle the back button in settings #48

Merged
AmineB merged 2 commits from davidoskky/ReaderForSelfoss-multiplatform:Settings_back into master 2022-09-06 18:20:39 +00:00
Conversation 1 Commits 2 Files Changed 2 +11 -20
davidoskky commented 2022-09-06 10:30:46 +00:00
Contributor
Copy Link

Types of changes

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This is NOT translation related.

This closes issue #47

## Types of changes - [x] I have read the **CONTRIBUTING** document. - [x] My code follows the code style of this project. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [x] All new and existing tests passed. - [x] This is **NOT** translation related. This closes issue #47
davidoskky added 1 commit 2022-09-06 10:30:47 +00:00
Correctly handle the back button in settings
Some checks are pending
continuous-integration/drone/pr Build is running
Details
6bd06cb458
davidoskky added 1 commit 2022-09-06 10:36:54 +00:00
Remove unused lambda
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/tag Build is passing
Details
bdc77ab8ef
AmineB reviewed 2022-09-06 11:13:58 +00:00
AmineB left a comment
Owner
Copy Link

Thanks !

I'll test this later today and merge it.

Thanks ! I'll test this later today and merge it.
AmineB merged commit 815f00e764 into master 2022-09-06 18:20:39 +00:00
davidoskky deleted branch Settings_back 2022-09-07 07:00:38 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#48
No description provided.
Delete Branch "davidoskky/ReaderForSelfoss-multiplatform:Settings_back"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?