Use POST /login
to authenticate users
#53
Labels
No Label
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Louvorg/ReaderForSelfoss-multiplatform#53
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Thanks, I will try to test it when I find time. Also, it would be nice to use POST method for login as pointed out in https://github.com/fossar/selfoss/issues/1356. It is supported since 2.18.
Originally posted by @jtojnar in https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/issues/52#issuecomment-452
Perfect; if we're also going to use cookies rather than sending the login parameters with each request then we should implement a way to check that the cookie did not expire and in case request a new one automatically.
Because the
/api/about
insn't available in the 2.18 version, there is no way to reliably check wich version to use.I'll wait on the matomo api version results.
Isn't POST/login supported in 2.18 as well?
As said in my previous comment,
/api/about
insn't available in the 2.18 version, so I can't check if I can use the new login in 2.18You mean to say that it's impossible to determine wether the selfoss instance is running a version prior to 2.18? That could in fact be a problem. Is there any way to determine if someone is still using such old versions of Selfoss?
Not really. In the 2.18 release, the
/api/about
method isn't available. It's introduced in a commit between 2.18 and 2.19.Using the version as a condition would make us "miss" some users that are in 2.18, and could use the POST login.
That is true, but is there another way to test if POST is supported?
Maybe in Selfoss 2.17 you receive a particular reply which you could use to pinpoint the version as older than 2.18.
Otherwise, if that's not possible, I believe it's better to use GET for 2.18 and POST for 2.19 rather than GET for both.