Use POST /login to authenticate users #53

New Issue

AmineL · 2022-09-13T08:01:43Z

AmineL commented

2022-09-13 08:01:43 +00:00

Thanks, I will try to test it when I find time. Also, it would be nice to use POST method for login as pointed out in https://github.com/fossar/selfoss/issues/1356. It is supported since 2.18.

Originally posted by @jtojnar in https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/issues/52#issuecomment-452

Thanks, I will try to test it when I find time. Also, it would be nice to use POST method for login as pointed out in https://github.com/fossar/selfoss/issues/1356. It is [supported since 2.18](https://github.com/fossar/selfoss/commit/bfda0740fa7f3e9ae04bd26b54ef815ab46e896b). _Originally posted by @jtojnar in https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/issues/52#issuecomment-452_

AmineL added the

Type = Enhancement

label 2022-09-13 08:02:03 +00:00

AmineL added this to the A little better milestone 2022-09-13 08:02:07 +00:00

AmineL added this to the Dev project 2022-09-13 08:02:12 +00:00

AmineL self-assigned this 2022-09-13 08:02:16 +00:00

davidoskky commented

2022-09-13 08:32:28 +00:00

Perfect; if we're also going to use cookies rather than sending the login parameters with each request then we should implement a way to check that the cookie did not expire and in case request a new one automatically.

AmineL removed this from the Dev project 2022-09-13 14:41:41 +00:00

davidoskky referenced this issue

2022-10-02 10:47:10 +00:00

Implement Selfoss API 5.0.0 #71

davidoskky referenced this issue

2022-10-03 06:46:24 +00:00

Simplify sources and tags handling #70

AmineL referenced this issue

2022-10-04 18:49:31 +00:00

Simplify sources and tags handling #70

AmineL added this to the Dev project 2022-11-02 19:07:29 +00:00

AmineL commented

2022-11-17 19:50:43 +00:00

Because the /api/about insn't available in the 2.18 version, there is no way to reliably check wich version to use.

I'll wait on the matomo api version results.

Because the `/api/about` insn't available in the 2.18 version, there is no way to reliably check wich version to use. I'll wait on the matomo api version results.

AmineL removed this from the A little better milestone 2022-11-17 19:50:50 +00:00

AmineL added the

Priority = Some day

label 2022-11-17 19:50:55 +00:00

AmineL removed this from the Dev project 2022-11-17 19:50:58 +00:00

davidoskky commented

2022-11-18 09:24:50 +00:00

Isn't POST/login supported in 2.18 as well?

AmineL commented

2022-11-18 19:22:03 +00:00

As said in my previous comment, /api/about insn't available in the 2.18 version, so I can't check if I can use the new login in 2.18

As said in my previous comment, `/api/about` insn't available in the 2.18 version, so I can't check if I can use the new login in 2.18

davidoskky commented

2022-11-18 20:07:28 +00:00

You mean to say that it's impossible to determine wether the selfoss instance is running a version prior to 2.18? That could in fact be a problem. Is there any way to determine if someone is still using such old versions of Selfoss?

AmineL commented

2022-11-18 20:48:16 +00:00

Not really. In the 2.18 release, the /api/about method isn't available. It's introduced in a commit between 2.18 and 2.19.

Using the version as a condition would make us "miss" some users that are in 2.18, and could use the POST login.

Not really. In the 2.18 release, the `/api/about` method isn't available. It's introduced in a commit between 2.18 and 2.19. Using the version as a condition would make us "miss" some users that are in 2.18, and could use the POST login.

davidoskky commented

2022-11-19 15:08:13 +00:00

That is true, but is there another way to test if POST is supported?
Maybe in Selfoss 2.17 you receive a particular reply which you could use to pinpoint the version as older than 2.18.

Otherwise, if that's not possible, I believe it's better to use GET for 2.18 and POST for 2.19 rather than GET for both.

That is true, but is there another way to test if POST is supported? Maybe in Selfoss 2.17 you receive a particular reply which you could use to pinpoint the version as older than 2.18. Otherwise, if that's not possible, I believe it's better to use GET for 2.18 and POST for 2.19 rather than GET for both.

AmineL referenced a pull request that will close this issue

2022-11-29 20:40:16 +00:00

Cookies login and logout. #103

AmineL added this to the Dev project 2022-11-29 20:43:08 +00:00

AmineL closed this issue

2022-11-29 20:45:24 +00:00

Sign in to join this conversation.