Louvorg/ReaderForSelfoss-multiplatform
Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 11 Pull Requests Actions Releases 75 Wiki Activity

Cookies login and logout. #103

Merged
AmineB merged 1 commits from login into master 2022-11-30 10:04:15 +00:00
Conversation 2 Commits 1 Files Changed 6 +149 -66
AmineB commented 2022-11-29 20:40:16 +00:00
Owner
Copy Link

Closes #53.

Closes #53.
AmineB added 1 commit 2022-11-29 20:40:21 +00:00
Cookies login and logout.
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
956c4341c7
davidoskky commented 2022-11-30 09:07:57 +00:00
Contributor
Copy Link

Nice
Missing api version 4.1.0 shouldn't be a problem since that was only present in nighly builds of Selfoss and I don't think we should provide support for all of those.
In fact, we could just support version 2.18 and previous and api versions above 6.0.

This afternoon I'll test creating sources in version 2.18 and see if everything works correctly over there.

Nice Missing api version 4.1.0 shouldn't be a problem since that was only present in nighly builds of Selfoss and I don't think we should provide support for all of those. In fact, we could just support version 2.18 and previous and api versions above 6.0. This afternoon I'll test creating sources in version 2.18 and see if everything works correctly over there.
AmineB commented 2022-11-30 10:04:08 +00:00
Author
Owner
Copy Link

I don't think we should provide support for all of those.
In fact, we could just support version 2.18 and previous and api versions above 6.0.

Not supporting versions between two others is pretty weird.

We will support all the versions, since the api versionning in pretty new (the /api/about method being introduced in a commit between 2.18 and 2.19 playing a big role in this)

> I don't think we should provide support for all of those. In fact, we could just support version 2.18 and previous and api versions above 6.0. Not supporting versions between two others is pretty weird. We will support all the versions, since the api versionning in pretty new (the /api/about method being introduced in a commit between 2.18 and 2.19 playing a big role in this)
AmineB merged commit f09f731d30 into master 2022-11-30 10:04:15 +00:00
AmineB deleted branch login 2022-11-30 10:04:19 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#103
No description provided.
Delete Branch "login"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?