Louvorg/ReaderForSelfoss-multiplatform
Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 10 Pull Requests Actions Releases 74 Wiki Activity

Prevent crash when logging in #81

Merged
AmineB merged 3 commits from davidoskky/ReaderForSelfoss-multiplatform:login_crash into master 2022-10-22 19:54:01 +00:00
Conversation 1 Commits 3 Files Changed 3 +64 -74
davidoskky commented 2022-10-17 17:38:21 +00:00
Contributor
Copy Link

Types of changes

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This is NOT translation related.

While running on some emulators I have seen that it sometimes crashes on login because it tries to make api calls on localhost.
Preventing those calls if not already logged in solves the problem.

I also moved the definition of dateUtils within the login function so that it gets updated after logging in.

## Types of changes - [x] I have read the **CONTRIBUTING** document. - [x] My code follows the code style of this project. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [x] All new and existing tests passed. - [x] This is **NOT** translation related. While running on some emulators I have seen that it sometimes crashes on login because it tries to make api calls on localhost. Preventing those calls if not already logged in solves the problem. I also moved the definition of dateUtils within the login function so that it gets updated after logging in.
davidoskky added 1 commit 2022-10-17 17:38:22 +00:00
Prevent crash when logging in
Some checks reported errors
continuous-integration/drone/pr Build was killed
Details
c25e8889a4
AmineB requested changes 2022-10-17 17:44:44 +00:00
shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt Outdated
@ -47,3 +46,1 @@
updateApiVersion()
dateUtils = DateUtils(appSettingsService)
reloadBadges()
if (appSettingsService.getBaseUrl() != "") {
AmineB commented 2022-10-17 17:44:17 +00:00
Owner
Copy Link

getBaseUrl should never return an empty string.

There is a verification done before even logging-in (and saving the settings), so this should never happen.

`getBaseUrl` should never return an empty string. There is a verification done before even logging-in (and saving the settings), so this should never happen.
davidoskky commented 2022-10-17 18:26:33 +00:00
Author
Contributor
Copy Link

The repository is initialized before logging in, at that point appSettingsService returns an empty string

The repository is initialized before logging in, at that point appSettingsService returns an empty string
AmineB commented 2022-10-17 18:56:14 +00:00
Owner
Copy Link

Ok, so this is a workaround.

The issue is that the runBlocking block is called even when the user is'nt updated. This should be fixed.

Ok, so this is a workaround. The issue is that the `runBlocking` block is called even when the user is'nt updated. This should be fixed.
davidoskky commented 2022-10-18 11:14:38 +00:00
Author
Contributor
Copy Link

I could remove this from the init method and make a new public method which is called by the login activity after it checks that the user is correctly set.

I could remove this from the init method and make a new public method which is called by the login activity after it checks that the user is correctly set.
AmineB commented 2022-10-18 12:06:55 +00:00
Owner
Copy Link

that could be better, yes !

that could be better, yes !
AmineB marked this conversation as resolved
shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt Outdated
@ -408,6 +409,7 @@ class Repository(private val api: SelfossApi, private val appSettingsService: Ap
appSettingsService.updateApiVersion(fetchedVersion.data.getApiMajorVersion())
}
}
dateUtils = DateUtils(appSettingsService)
AmineB commented 2022-10-17 17:44:34 +00:00
Owner
Copy Link

why was this added ?

why was this added ?
davidoskky commented 2022-10-17 18:27:16 +00:00
Author
Contributor
Copy Link

If the repository is initialized before the login, this is required to initialize the dateUtils after logging in

If the repository is initialized before the login, this is required to initialize the dateUtils after logging in
AmineB marked this conversation as resolved
davidoskky added 2 commits 2022-10-21 20:56:45 +00:00
Adjust tests to changes in the repository
All checks were successful
continuous-integration/drone/pr Build is passing
Details
667e9c1a5d
davidoskky requested review from AmineB 2022-10-21 20:57:36 +00:00
AmineB merged commit 510fcbe47e into master 2022-10-22 19:54:01 +00:00
davidoskky deleted branch login_crash 2022-10-23 01:57:39 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
AmineB
Labels
Clear labels
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#81
No description provided.
Delete Branch "davidoskky/ReaderForSelfoss-multiplatform:login_crash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?